| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-07-30 | |||
| 16:25:57 | sean-k-mooney | but im not sure we shoudl change master of this | |
| 16:26:23 | priteau | The idea was to backport this to all branches one by one so future unmaintained branches would already have the fix | |
| 16:26:41 | sean-k-mooney | elodilles: yep im just conficlted about adjusting any maintained branch becuse of unmaintianed | |
| 16:26:41 | priteau | At some point stable/2024.1 will be unmaintained/2024.1 | |
| 16:26:50 | elodilles | sean-k-mooney: i'd rather change this on master so that we(/i o:)) don't have to fix it everytime a new unmaintained branch is created o:) | |
| 16:27:07 | sean-k-mooney | elodilles: or you turn off that job on umaintainted | |
| 16:27:26 | elodilles | sean-k-mooney: if we use it on stable then i rather keep it on unmaintained | |
| 16:27:29 | sean-k-mooney | in this specific case we proably can but | |
| 16:27:41 | sean-k-mooney | but as a general rule i dont think we shoudl do that | |
| 16:29:41 | opendevreview | Balazs Gibizer proposed openstack/nova master: [manila]Use client token when talking to manila https://review.opendev.org/c/openstack/nova/+/925277 | |
| 16:29:42 | fwiesel | sean-k-mooney: Sorry, I was AFK. There is https://review.opendev.org/c/openstack/nova/+/910627 (on the list) and then there is bug (https://bugs.launchpad.net/nova/+bug/2058225) | |
| 16:30:07 | elodilles | sean-k-mooney: if this would be something complex change i'd vote for the same (don't waste time on master+stable branches), but this is a rather simple fix | |
| 16:30:09 | fwiesel | Hopefully, if we have addressed those then we should be good to go. | |
| 16:30:44 | sean-k-mooney | elodilles: well the reason im bringin it is is by definition we shoudl not be speinding time maintianing the unmainted branches espcially on the ci front | |
| 16:31:01 | sean-k-mooney | in this case i think your right its simple enough to do this | |
| 16:31:32 | sean-k-mooney | but i would not like to see use chanign job defitions on master and backportign them to fix a unmaintinaed job | |
| 16:31:50 | elodilles | ACK, understood | |
| 16:32:10 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/924103/1 is a good find by the way | |
| 16:33:09 | elodilles | yepp, i was surprised that we have a (non-working) check for that already :) | |
| 16:33:10 | sean-k-mooney | we proably should have a bug for thsoe but im going to ignore that since its just a ci issue not a code one | |
| 16:33:49 | sean-k-mooney | elodilles: i guess its not often that a cherry-pick merges without a merge for some reason | |
| 16:34:03 | sean-k-mooney | although i do wonder if this is perhaps version specific behavior | |
| 16:34:28 | elodilles | for bot proposed patches it is quite often | |
| 16:35:00 | elodilles | hence i updated the commit message in the past with [stable-only] | |
| 16:35:22 | elodilles | after this fix, that won't be necessary anymore \o/ | |
| 16:36:21 | sean-k-mooney | both changes look correct to me so +2 | |
| 16:36:27 | elodilles | thanks o/ | |
| 16:36:32 | sean-k-mooney | although maybe we shoudl try cherry-picking before we mrege them | |
| 16:36:36 | sean-k-mooney | to make sure | |
| 16:36:59 | elodilles | i'll do the cherry picks now | |
| 16:37:36 | sean-k-mooney | i assume you have tried them on stable and unmainted locally and they worked | |
| 16:37:49 | sean-k-mooney | so ci shoudl be similar but it does not hurt to precheck | |
| 16:38:27 | sean-k-mooney | fwiesel: what i was really getting at is, its great that you ahve ci working | |
| 16:38:27 | opendevreview | Elod Illes proposed openstack/nova stable/2024.1: [tools] Ignore bot generated patches https://review.opendev.org/c/openstack/nova/+/925278 | |
| 16:38:28 | opendevreview | Elod Illes proposed openstack/nova stable/2024.1: [tools] Backport validator: handle unmaintained https://review.opendev.org/c/openstack/nova/+/925279 | |
| 16:38:43 | sean-k-mooney | fwiesel: but if there is still no code review happeing of your fixes | |
| 16:39:00 | sean-k-mooney | then its still effectivly unmaintaiend since the issues are not being adressed | |
| 16:39:19 | elodilles | sean-k-mooney: yepp, i've did a quick test | |
| 16:40:09 | opendevreview | Elod Illes proposed openstack/nova stable/2023.2: [tools] Ignore bot generated patches https://review.opendev.org/c/openstack/nova/+/925280 | |
| 16:40:10 | opendevreview | Elod Illes proposed openstack/nova stable/2023.2: [tools] Backport validator: handle unmaintained https://review.opendev.org/c/openstack/nova/+/925281 | |
| 16:40:59 | opendevreview | Elod Illes proposed openstack/nova stable/2023.1: [tools] Ignore bot generated patches https://review.opendev.org/c/openstack/nova/+/925282 | |
| 16:41:00 | opendevreview | Elod Illes proposed openstack/nova stable/2023.1: [tools] Backport validator: handle unmaintained https://review.opendev.org/c/openstack/nova/+/925283 | |
| 16:43:39 | sean-k-mooney | fwiesel: the logs seam to have rotated on http://openstack-ci-logs.global.cloud.sap/openstack-nova-910627-l7ppx/index.html which should be the most recent run for https://review.opendev.org/c/openstack/nova/+/910627 | |
| 16:43:54 | sean-k-mooney | fwiesel: is there a way to recheck your ci and run it again | |
| 16:44:09 | sean-k-mooney | ah sap-openstack-ci recheck | |
| 16:50:55 | fwiesel | sean-k-mooney: sure, I can trigger it again | |
| 16:52:34 | frickler | fwiesel: not directly nova, but while you're around: did you see my comment on cirros #112? we're pretty close to making a new release | |
| 16:55:14 | fwiesel | frickler: I didn't see it, but I'll add a comment. | |
| 16:55:58 | sean-k-mooney | frickler: oh really cool | |
| 16:56:09 | sean-k-mooney | frickler: can you ensure that has the latest avaiable kernel included | |
| 16:56:45 | sean-k-mooney | ideally form ubuntu 24.04 or the upstream lts branch | |
| 16:57:07 | sean-k-mooney | if its still on a 22.04 based kernel that ok but ideally it would be updated to the latest hwe kernel | |
| 17:09:46 | frickler | sean-k-mooney: my plan was to do 0.6.3 with the latest 22.04 kernel, then try to bump both buildroot and 24.04 kernel for 0.7.0 (cf. https://github.com/cirros-dev/cirros/pull/117) | |
| 17:10:40 | sean-k-mooney | cool | |
| 17:10:47 | sean-k-mooney | that sounds good | |
| 18:15:29 | opendevreview | Merged openstack/nova stable/2024.1: Refactor vf profile for PCI device https://review.opendev.org/c/openstack/nova/+/925181 | |
| 18:15:35 | opendevreview | Merged openstack/nova master: [tools] Ignore bot generated patches https://review.opendev.org/c/openstack/nova/+/924103 | |
| 18:15:42 | opendevreview | Merged openstack/nova master: [tools] Backport validator: handle unmaintained https://review.opendev.org/c/openstack/nova/+/924104 | |
| 20:32:46 | opendevreview | Masahito Muroi proposed openstack/nova master: Change instance_system_metadata value to Text type https://review.opendev.org/c/openstack/nova/+/925163 | |
| #openstack-nova - 2024-07-31 | |||
| 07:13:11 | opendevreview | Balazs Gibizer proposed openstack/nova master: [manila]Use client token when talking to manila https://review.opendev.org/c/openstack/nova/+/925277 | |
| 07:52:00 | opendevreview | Fabian Wiesel proposed openstack/nova master: Vmware: Remove uuid parameter from get_vmdk_info call https://review.opendev.org/c/openstack/nova/+/910627 | |
| 11:32:32 | opendevreview | Adam Oswick proposed openstack/nova master: Refactor _get_pci_passthrough_devices function https://review.opendev.org/c/openstack/nova/+/925382 | |
| 12:59:16 | jlejeune | sean-k-mooney: bauzas: hello, I found why the test_snapshot_running is now failing: https://bugs.launchpad.net/nova/+bug/2075178/comments/1 | |
| 13:00:02 | sean-k-mooney | jlejeune: yes we discussed that change in behavior with dansmith and it was noted in the commit message | |
| 13:00:37 | sean-k-mooney | jlejeune: https://github.com/openstack/nova/commit/d5a631ba7791b37e49213707e4ea650a56d2ed9e | |
| 13:01:08 | sean-k-mooney | """Note that this includes seemingly-unrelated test changes because we | |
| 13:01:10 | sean-k-mooney | were actually skipping the snapshot_running test for libvirt, which | |
| 13:01:12 | sean-k-mooney | has been a bug for years. In that test case, when we went to look | |
| 13:01:14 | sean-k-mooney | for image_meta.disk_format, that attribute was not set on the o.vo | |
| 13:01:16 | sean-k-mooney | object, which raised a NotImplementedError. That error is also checked | |
| 13:01:18 | sean-k-mooney | by the test to skip the test for drivers that do not support snapshot, | |
| 13:01:20 | sean-k-mooney | which meant that for libvirt, we haven't been running that case | |
| 13:01:22 | sean-k-mooney | beyond the point at which we create snapshot metadata and trip that | |
| 13:01:24 | sean-k-mooney | exception.""" | |
| 13:02:07 | sean-k-mooney | dan added some stubs https://github.com/openstack/nova/commit/d5a631ba7791b37e49213707e4ea650a56d2ed9e#diff-4104495b69c5ecf83423c1b9aafa2a8b55e2f8ebbd4cc36a5299206a004263d2R835 | |
| 13:02:16 | sean-k-mooney | buy i guess is missign one | |
| 13:02:27 | jlejeune | y es I saw them | |
| 13:04:55 | jlejeune | I will add new ones, but I have also to mock file_open() utils function, is it ok for you if I mock it at the test level ? | |
| 13:07:59 | sean-k-mooney | you shoudl not need to mock file_open | |
| 13:08:24 | sean-k-mooney | you idealy you woudl mock hihger then that as mocking file open may breakt things | |
| 13:09:16 | sean-k-mooney | we basically want to mock the file inspector methods i think | |
| 13:19:12 | sean-k-mooney | oh its nova.virt.libvirt.utils.file_open | |
| 13:19:30 | sean-k-mooney | not open() | |
| 13:19:42 | sean-k-mooney | ya we might want to add that to the global poion at some point | |
| 13:23:48 | jlejeune | :) | |
| 13:47:09 | elinux | can someone comment on this please https://bugs.launchpad.net/nova/+bug/2075150 | |
| 13:56:25 | elinux | anyone online yet ? | |
| 13:57:38 | opendevreview | Julien Le Jeune proposed openstack/nova master: Fix test_snapshot_running https://review.opendev.org/c/openstack/nova/+/925208 | |
| 14:07:08 | opendevreview | Julien Le Jeune proposed openstack/nova stable/2023.2: Refactor vf profile for PCI device https://review.opendev.org/c/openstack/nova/+/905135 | |
| 14:24:33 | jlejeune | elodilles: hello, I've updated the review by cherry-picking the right commit from 2024.1 branch if you want to have a look: https://review.opendev.org/c/openstack/nova/+/905135 | |
| 14:25:45 | opendevreview | Adam Oswick proposed openstack/nova master: Refactor _get_pci_passthrough_devices function https://review.opendev.org/c/openstack/nova/+/925382 | |
| 14:30:34 | opendevreview | Julien Le Jeune proposed openstack/nova master: Fix test_snapshot_running https://review.opendev.org/c/openstack/nova/+/925208 | |
| 14:35:52 | elodilles | jlejeune: looks good, thanks! +2+W'd | |
| 16:49:12 | opendevreview | Merged openstack/nova stable/2024.1: [tools] Ignore bot generated patches https://review.opendev.org/c/openstack/nova/+/925278 | |
| 16:49:18 | opendevreview | Merged openstack/nova stable/2024.1: [tools] Backport validator: handle unmaintained https://review.opendev.org/c/openstack/nova/+/925279 | |
| 18:03:37 | opendevreview | Merged openstack/nova stable/2023.2: Refactor vf profile for PCI device https://review.opendev.org/c/openstack/nova/+/905135 | |
| 21:42:06 | opendevreview | Merged openstack/nova stable/2024.1: cpu: Only check governor type on online cores https://review.opendev.org/c/openstack/nova/+/924514 | |
| #openstack-nova - 2024-08-01 | |||
| 07:04:25 | opendevreview | Julien Le Jeune proposed openstack/nova stable/2023.1: Refactor vf profile for PCI device https://review.opendev.org/c/openstack/nova/+/905137 | |
| 08:41:11 | opendevreview | Merged openstack/nova stable/2023.2: [tools] Ignore bot generated patches https://review.opendev.org/c/openstack/nova/+/925280 | |
| 08:41:17 | opendevreview | Merged openstack/nova stable/2023.2: [tools] Backport validator: handle unmaintained https://review.opendev.org/c/openstack/nova/+/925281 | |