| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-07-29 | |||
| 14:38:47 | bauzas | is this https://review.opendev.org/c/openstack/nova/+/925037 ? | |
| 14:38:49 | sean-k-mooney | bauzas: they might just need to stop the instnace | |
| 14:39:01 | sean-k-mooney | yep | |
| 14:39:13 | sean-k-mooney | that patch will work but it does not have enouch test coverage | |
| 14:39:30 | sean-k-mooney | and as i said the bug is reallly here https://github.com/openstack/nova/blob/7a7427691e0bd4818bb7a2c5f5371e0244addbbb/nova/virt/libvirt/guest.py#L419 | |
| 14:40:03 | bauzas | the real problem is that we didn't had any functest for that | |
| 14:40:06 | sean-k-mooney | that if assumes all devices in get_all_devices will have an alias field | |
| 14:40:19 | bauzas | because mdev support predates alias | |
| 14:40:24 | sean-k-mooney | yep | |
| 14:40:33 | sean-k-mooney | so ideally we woudl create a fucntional repoducer | |
| 14:40:35 | bauzas | but when we merged aliases series, we created a regression | |
| 14:40:48 | bauzas | yup | |
| 14:40:52 | bauzas | we need a functtest | |
| 14:41:01 | sean-k-mooney | and then fix both the underlying bug and optionall add supprot ofr alias ot mdevs even if not used today | |
| 14:41:22 | sean-k-mooney | we can fix the actual bug in 1 of 2 ways | |
| 14:41:34 | sean-k-mooney | either check if dev has an alais field before usign it | |
| 14:42:02 | sean-k-mooney | or make sure that all device will have that eihter by extending the base class or checking all child class have it | |
| 14:43:10 | sean-k-mooney | so either add it here https://github.com/openstack/nova/blob/7a7427691e0bd4818bb7a2c5f5371e0244addbbb/nova/virt/libvirt/config.py#L56 or add a hasattr check | |
| 14:46:12 | bauzas | I'm fine with the first option | |
| 14:46:42 | bauzas | the second option is better in case of *another* regression | |
| 14:46:54 | bauzas | want me to help with the reproducer ? | |
| 14:47:20 | bauzas | I just have 3.5 days to work before my PTO and I really want my mtty series to be reviewable before I leavred | |
| 15:23:57 | opendevreview | Pavlo Shchelokovskyy proposed openstack/nova master: Replace -- as 3-4 char in hostname with - https://review.opendev.org/c/openstack/nova/+/893072 | |
| 15:33:08 | opendevreview | Merged openstack/nova stable/2023.2: Remove AMI snapshot format special case https://review.opendev.org/c/openstack/nova/+/924999 | |
| 16:09:14 | opendevreview | Merged openstack/nova stable/2023.2: Fixed an error when caching multiple images in aggregate https://review.opendev.org/c/openstack/nova/+/904017 | |
| 16:20:49 | sean-k-mooney | bauzas: i rehcecked the last patch in your mtty seriese and it didnt repoduce the cinder issue but it did fail with https://paste.opendev.org/show/bexn6H6KYRrAlhNONtVn/ | |
| 16:22:49 | sean-k-mooney | there is a bug somewehre but im not sure that https://review.opendev.org/c/openstack/nova/+/918420/ is even current | |
| 16:28:30 | opendevreview | sean mooney proposed openstack/nova stable/2023.1: Fixed an error when caching multiple images in aggregate https://review.opendev.org/c/openstack/nova/+/904018 | |
| 16:39:52 | opendevreview | Merged openstack/nova stable/2023.2: Added context manager for instance lock https://review.opendev.org/c/openstack/nova/+/911394 | |
| 16:44:24 | opendevreview | Merged openstack/nova stable/2023.2: Separate OSError with ValueError https://review.opendev.org/c/openstack/nova/+/911395 | |
| 17:25:47 | sean-k-mooney | bauzas: if you have time to work on it do | |
| 17:26:21 | sean-k-mooney | perhaps just try that usecase "mdev + cinder volume in the same vm" when working on the mtty stuff | |
| 17:26:27 | sean-k-mooney | and see if you see the same issue | |
| 17:26:35 | sean-k-mooney | if you do then we can confirm the bug | |
| 17:26:39 | sean-k-mooney | and create a repoducer | |
| 17:26:46 | sean-k-mooney | in the fucntional tests | |
| 19:51:34 | opendevreview | Merged openstack/nova stable/2023.1: Fixed an error when caching multiple images in aggregate https://review.opendev.org/c/openstack/nova/+/904018 | |
| 21:08:16 | opendevreview | Pavlo Shchelokovskyy proposed openstack/nova master: Replace -- as 3-4 char in hostname with - https://review.opendev.org/c/openstack/nova/+/893072 | |
| #openstack-nova - 2024-07-30 | |||
| 06:20:04 | opendevreview | Masahito Muroi proposed openstack/nova master: Change instance_system_metadata value to Text type https://review.opendev.org/c/openstack/nova/+/925163 | |
| 09:50:21 | opendevreview | Julien Le Jeune proposed openstack/nova stable/2024.1: Refactor vf profile for PCI device https://review.opendev.org/c/openstack/nova/+/925181 | |
| 10:08:07 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix KeyError on assisted snapshot call https://review.opendev.org/c/openstack/nova/+/900783 | |
| 10:14:13 | opendevreview | Rajesh Tailor proposed openstack/nova master: Restore original AZ when unshelve fails https://review.opendev.org/c/openstack/nova/+/911108 | |
| 10:28:42 | opendevreview | Michael Still proposed openstack/nova master: libvirt: Add config option to require secure SPICE. https://review.opendev.org/c/openstack/nova/+/922544 | |
| 10:28:43 | opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | |
| 10:32:05 | opendevreview | Michael Still proposed openstack/nova master: libvirt: Add config option to require secure SPICE. https://review.opendev.org/c/openstack/nova/+/922544 | |
| 10:32:06 | opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | |
| 10:33:57 | opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | |
| 10:33:57 | opendevreview | Michael Still proposed openstack/nova master: libvirt: Add config option to require secure SPICE. https://review.opendev.org/c/openstack/nova/+/922544 | |
| 10:34:15 | mikal | Sorry about that, I have no idea how that hook ended up in my rebase. | |
| 10:35:07 | mikal | sean-k-mooney: I've dropped the concurrency patch, and the first two patches in the series should be good to review now. I'll do the sound and usb device extra specs next but that's not done yet. | |
| 11:54:22 | opendevreview | Merged openstack/nova stable/2023.1: Remove AMI snapshot format special case https://review.opendev.org/c/openstack/nova/+/925000 | |
| 12:46:29 | jlejeune | sean-k-mooney: hello, since the last commit "Remove AMI snapshot format special case" has been merged, the test_snapshot_running test is now running but it depends on qemu-img binary which is not necessary installed, so it fails | |
| 12:55:02 | jlejeune | why not putting qemu-utils package in bindep.txt ? | |
| 13:08:20 | sean-k-mooney | jlejeune: because our unit test are not ment to depend on it | |
| 13:08:34 | sean-k-mooney | jlejeune: its an optiona depency | |
| 13:08:52 | sean-k-mooney | and we will be removing those tests when we factor this out of nova | |
| 13:09:36 | sean-k-mooney | we could add it as a test only dep in bindep | |
| 13:09:50 | sean-k-mooney | but we dont want to require peopel to install qemu image just to run unit test in general | |
| 13:17:32 | jlejeune | agree, so in the meantime waiting for the removal of that code in oslo instead of nova, we need to skip that test if qemu-img binary is missing | |
| 13:21:18 | sean-k-mooney | yep like you did for the ohter one | |
| 13:21:30 | jlejeune | yep :) | |
| 13:21:52 | sean-k-mooney | its not a blocker just an anoyance currently | |
| 13:22:18 | sean-k-mooney | i was hopign to do a new release today/tomorrow | |
| 13:22:33 | sean-k-mooney | we could include it if the patch is ready quickly | |
| 13:22:41 | sean-k-mooney | but i dont really want to hold the release just for this | |
| 13:23:36 | jlejeune | I understand | |
| 13:24:16 | mnaser | question.. has anyone ran into this in nova CI? | |
| 13:24:18 | mnaser | `TypeError: canonicalize_version() got an unexpected keyword argument 'strip_trailing_zero'` | |
| 13:24:24 | mnaser | https://zuul.opendev.org/t/openstack/build/7e95381e525e43e6afb34c1a0381e971 | |
| 13:24:34 | mnaser | I know its unmaintained zed but in case this rings a bell and needs us to back port something in specific : | |
| 13:37:51 | dansmith | it's a new change in packageutils or something I think | |
| 13:38:06 | dansmith | I hit it elsewhere outside of openstack | |
| 13:38:36 | dansmith | part of a larger theme of issues everyone has been facing, because the python community decided they should tell us what our version numbers have to look like | |
| 13:38:51 | sean-k-mooney | that has been fixed kind fo | |
| 13:39:20 | sean-k-mooney | its caused by a new release of setuptools conflciting with the max version of packaging we allowed in 2023.1 | |
| 13:39:40 | sean-k-mooney | we resolved that on stable by bumping the max version to the same as 2023.2 | |
| 13:39:55 | sean-k-mooney | alternitivly you can clamp the max veriosn of setup tools on older release | |
| 13:42:57 | opendevreview | Rajesh Tailor proposed openstack/nova master: Rephrase the help message https://review.opendev.org/c/openstack/nova/+/925207 | |
| 13:43:04 | mnaser | hmmm | |
| 13:43:22 | mnaser | so I'd have to fix this in requirements | |
| 13:43:38 | mnaser | or cap it inside nova? | |
| 13:47:07 | sean-k-mooney | mnaser: yes you would | |
| 13:47:18 | sean-k-mooney | you cant cap settup tool in requiremnts | |
| 13:47:29 | sean-k-mooney | you could only bump the pacakging version | |
| 13:47:42 | sean-k-mooney | if you didnt want to do that you would have to clamp it in the ci job | |
| 13:50:59 | opendevreview | Julien Le Jeune proposed openstack/nova master: Fix test_snapshot_running test when qemu-img binary is missing https://review.opendev.org/c/openstack/nova/+/925208 | |
| 13:56:51 | opendevreview | Julien Le Jeune proposed openstack/nova master: Fix test_snapshot_running test when qemu-img binary is missing https://review.opendev.org/c/openstack/nova/+/925208 | |
| 13:59:32 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix typos and punctuation issues https://review.opendev.org/c/openstack/nova/+/878779 | |
| 13:59:55 | elodilles | mnaser: i'm not sure that patch is needed. i mean, the gate is fine without that patch. but if you could review these CVE related zed backports, that would be awesome o:) (6 patch :S) https://review.opendev.org/c/openstack/nova/+/925018/2 | |
| 14:05:22 | jlejeune | elodilles: hello, following your comment, I backported that commit in 2024.1: https://review.opendev.org/c/openstack/nova/+/925181 | |
| 14:16:28 | elodilles | jlejeune: thanks! looks good to me! +2'd | |
| 14:25:03 | sean-k-mooney | jlejeune: ya we have that dowsn tream too already i agree iwth backporting that | |
| 14:25:26 | jlejeune | elodilles: sean-k-mooney: thanks, I have another small fix on unit test like previous one I made last week: https://review.opendev.org/c/openstack/nova/+/925208 | |
| 14:25:36 | sean-k-mooney | i tought there were already backport of that proposed but i guess not | |
| 14:25:48 | sean-k-mooney | jlejeune: yep i reviewd thats incorrect | |
| 14:26:15 | sean-k-mooney | previosly it was fine to skip if qemu-img was not installed as the tests in question were validtating the behaivor of calling qemu image | |
| 14:26:24 | sean-k-mooney | this test is just missing a mock | |
| 14:26:28 | jlejeune | ok doing | |
| 14:43:48 | mnaser | elodilles: the thing is nova-multistore job is broken so not letting glance job pass so we can't finish landing the CVE fixes in glance :( | |
| 14:45:48 | elodilles | mnaser: ahh, i see | |