| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-07-26 | |||
| 09:43:48 | jlejeune | bauzas: sean-k-mooney: now you have merged all the patchs related to the last CVE, maybe you can review my small fix in unit tests: https://review.opendev.org/c/openstack/nova/+/924148 :) | |
| 09:43:56 | jlejeune | hello BTW :) | |
| 10:08:55 | sean-k-mooney | jlejeune: oh yes we can merge that now and start backproting it too | |
| 10:09:07 | sean-k-mooney | it would be good to include that in the same release | |
| 10:09:37 | sean-k-mooney | bauzas: ^ | |
| 11:47:02 | bauzas | sent to the gate ^ | |
| 11:57:33 | jlejeune | bauzas: sean-k-mooney: thanks | |
| 11:58:14 | sean-k-mooney | jlejeune: do you want to do the submistion of the cerry-picks once its merged? | |
| 11:58:33 | sean-k-mooney | if not ill do it | |
| 12:00:01 | jlejeune | sean-k-mooney: I will | |
| 12:00:28 | jlejeune | I have to do it over 2023.1 / 2023.2 and 2024.1 right ? | |
| 12:00:44 | sean-k-mooney | yep form newst to oldest | |
| 12:01:03 | sean-k-mooney | so master->2024.1->2023.2->2023.1 | |
| 12:01:04 | jlejeune | ok so firt on 2024.1 | |
| 12:01:09 | sean-k-mooney | yep | |
| 12:01:15 | jlejeune | got it | |
| 12:06:27 | opendevreview | Merged openstack/nova master: Fix test_vmdk_bad_descriptor_mem_limit and test_vmdk_bad_descriptor_mem_limit_stream_optimized https://review.opendev.org/c/openstack/nova/+/924148 | |
| 12:16:09 | sean-k-mooney | jlejeune: ^ :) | |
| 12:16:41 | sean-k-mooney | unit test only fixes like this get to skip all the tempest josb so they are actully really fast to merge | |
| 12:21:01 | opendevreview | Julien Le Jeune proposed openstack/nova stable/2024.1: Fix test_vmdk_bad_descriptor_mem_limit and test_vmdk_bad_descriptor_mem_limit_stream_optimized https://review.opendev.org/c/openstack/nova/+/925011 | |
| 12:22:45 | opendevreview | Julien Le Jeune proposed openstack/nova stable/2023.2: Fix test_vmdk_bad_descriptor_mem_limit and test_vmdk_bad_descriptor_mem_limit_stream_optimized https://review.opendev.org/c/openstack/nova/+/925012 | |
| 12:24:01 | opendevreview | Julien Le Jeune proposed openstack/nova stable/2023.1: Fix test_vmdk_bad_descriptor_mem_limit and test_vmdk_bad_descriptor_mem_limit_stream_optimized https://review.opendev.org/c/openstack/nova/+/925014 | |
| 12:24:12 | sean-k-mooney | jlejeune: the second cherry pick is missing the cherrypcik line form the previous one | |
| 12:24:32 | sean-k-mooney | basically you shoudl have one (cherry picked from commit ...) per branch as you go back | |
| 12:24:55 | sean-k-mooney | the sha shoudl be the full commit sha from the previous cherrypick | |
| 12:25:33 | jlejeune | hm ok, sorry it was my first time | |
| 12:25:54 | sean-k-mooney | its ok | |
| 12:26:04 | sean-k-mooney | i mentioned it because we have a ci job that checks | |
| 12:27:42 | opendevreview | Julien Le Jeune proposed openstack/nova stable/2023.2: Fix test_vmdk_bad_descriptor_mem_limit and test_vmdk_bad_descriptor_mem_limit_stream_optimized https://review.opendev.org/c/openstack/nova/+/925012 | |
| 12:29:02 | opendevreview | Julien Le Jeune proposed openstack/nova stable/2023.1: Fix test_vmdk_bad_descriptor_mem_limit and test_vmdk_bad_descriptor_mem_limit_stream_optimized https://review.opendev.org/c/openstack/nova/+/925014 | |
| 12:30:18 | sean-k-mooney | jlejeune: we will try and include those in the next release we do next week | |
| 12:31:00 | jlejeune | perfect | |
| 12:31:15 | sean-k-mooney | thanks for fixing this | |
| 12:37:06 | jlejeune | no prob :) | |
| 13:18:38 | sean-k-mooney | bauzas: as i said downstream im goign to call it a day would you mind landing https://review.opendev.org/c/openstack/nova/+/925011 and the other backprot in order | |
| 13:50:12 | opendevreview | Merged openstack/nova stable/2024.1: Fix test_vmdk_bad_descriptor_mem_limit and test_vmdk_bad_descriptor_mem_limit_stream_optimized https://review.opendev.org/c/openstack/nova/+/925011 | |
| 15:20:26 | opendevreview | Merged openstack/nova stable/2023.2: Fix test_vmdk_bad_descriptor_mem_limit and test_vmdk_bad_descriptor_mem_limit_stream_optimized https://review.opendev.org/c/openstack/nova/+/925012 | |
| 15:22:51 | opendevreview | Dan Smith proposed openstack/nova master: DNM: Test against oslo.utils https://review.opendev.org/c/openstack/nova/+/925026 | |
| 15:22:51 | opendevreview | Dan Smith proposed openstack/nova master: Use format_inspector from oslo https://review.opendev.org/c/openstack/nova/+/925025 | |
| 18:03:18 | opendevreview | Mike Lowe proposed openstack/nova master: Parse alias from domain hostdev for MDEV https://review.opendev.org/c/openstack/nova/+/925037 | |
| 18:38:11 | dansmith | melwitt: I guess sean is offline but the above DNM test of the oslo format_inspector passed for the devstack jobs | |
| 18:38:26 | dansmith | just fyi in terms of the changes necessary for that | |
| 18:40:44 | melwitt | ok cool | |
| 19:24:42 | opendevreview | Mike Lowe proposed openstack/nova master: Parse alias from domain hostdev for MDEV https://review.opendev.org/c/openstack/nova/+/925037 | |
| 22:06:42 | opendevreview | Mike Lowe proposed openstack/nova master: OParse alias from domain hostdev for MDEV https://review.opendev.org/c/openstack/nova/+/925037 | |
| #openstack-nova - 2024-07-27 | |||
| 13:01:18 | MajidKhoram_ | thanks MajidKhoram Iim loving OpenStack | |
| 13:07:45 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with stateless firmware https://review.opendev.org/c/openstack/nova/+/908890 | |
| 13:07:45 | opendevreview | Takashi Kajinami proposed openstack/nova master: Report availability of stateless firmware support https://review.opendev.org/c/openstack/nova/+/908888 | |
| 13:08:35 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with stateless firmware https://review.opendev.org/c/openstack/nova/+/908890 | |
| 13:08:35 | opendevreview | Takashi Kajinami proposed openstack/nova master: Report availability of stateless firmware support https://review.opendev.org/c/openstack/nova/+/908888 | |
| 13:11:29 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Detect vtpm support by libvirt https://review.opendev.org/c/openstack/nova/+/908508 | |
| 13:11:29 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Ensure swtpm_ioctl is available for vTPM support https://review.opendev.org/c/openstack/nova/+/908546 | |
| 13:11:30 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Report available TPM models https://review.opendev.org/c/openstack/nova/+/909183 | |
| #openstack-nova - 2024-07-28 | |||
| 12:52:15 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with stateless firmware https://review.opendev.org/c/openstack/nova/+/908890 | |
| #openstack-nova - 2024-07-29 | |||
| 07:12:17 | jlejeune | bauzas: hello, I would need a one more review on https://review.opendev.org/c/openstack/nova/+/925014 please :) | |
| 08:28:37 | opendevreview | Merged openstack/nova stable/2023.1: Fix test_vmdk_bad_descriptor_mem_limit and test_vmdk_bad_descriptor_mem_limit_stream_optimized https://review.opendev.org/c/openstack/nova/+/925014 | |
| 08:29:28 | jlejeune | thanks bauzas :) | |
| 10:07:39 | ralonsoh | hi folks! please check this list of backports: https://review.opendev.org/q/Ie731045629f0899840a4680d21793a16ade9b98e | |
| 10:07:53 | ralonsoh | this is affecting the stable branches CI in Neutron right now | |
| 10:08:07 | ralonsoh | the master patch, merged 3 days ago, solved the issue for the master branch | |
| 10:08:12 | ralonsoh | thanks in advance! | |
| 10:51:29 | sean-k-mooney | bauzas: gibi: can try an dland these backports today https://review.opendev.org/q/topic:%22remove-ami-override%22 | |
| 10:52:13 | sean-k-mooney | this will be needed by neutorn and i want to include them in the release shas for the new release for the cve which i hope to base on what is merged by EOD | |
| 10:58:57 | frickler | elodilles: ^^ maybe? or as a last resort I can undust my release-team-inherited stable-maint hat | |
| 11:01:22 | sean-k-mooney | frickler: i think elodilles is on pto so its ok to wait for others | |
| 11:01:49 | sean-k-mooney | frickler: the timeline i have in my head is prepare the branches to be tagged today by merging any pending backport we think are reasonabe | |
| 11:02:04 | sean-k-mooney | then tomorrow ill submit the release patches adn we can review them in the nova meeting | |
| 11:02:20 | sean-k-mooney | if no objections at that point then we will proceed with the actual release | |
| 11:03:24 | sean-k-mooney | frickler: if really needed i can self approve my own backport or dansmith can approve them i was just avoiding ping people before they come online | |
| 11:16:12 | gibi | sean-k-mooney: I'm +2 on the backports | |
| 11:19:55 | sean-k-mooney | gibi: thanks if you and bauzas: are both happy i can add +w as required once the preceddeing patch is merged | |
| 11:21:41 | gibi | sounds good to me | |
| 11:21:56 | sean-k-mooney | by the way i hada weirdly passive agressinve interaction with someone over the weekend. i dont know why they were getting so defensive when i asked simple questions but they abandoned there patch | |
| 11:21:58 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/925037 | |
| 11:22:49 | sean-k-mooney | apparently if we have mdevs allocated volume or possible also interface detach | |
| 11:22:54 | sean-k-mooney | can fail https://bugs.launchpad.net/nova/+bug/2074219 | |
| 11:23:43 | sean-k-mooney | bauzas: we should create a functional repoducer and or see if we can replicate this in your devstack mdev series | |
| 11:26:36 | sean-k-mooney | my guess is they work for Indiana University and just decieded that actully fixing this properly upstream was too much effrot and they are just going to carry the patch downstream | |
| 11:27:12 | sean-k-mooney | but if this is a real problem i wouls like to actully fix it for everyone properly | |
| 11:27:31 | sean-k-mooney | however we shoudl acutlly create a repoducer before doing that | |
| 11:43:31 | elodilles | sean-k-mooney: actually i'm back from today on, though i just started picking up the pace o:) | |
| 11:54:17 | sean-k-mooney | elodilles: well welcome back and dont burn yourself out. | |
| 12:00:47 | elodilles | thx, i will try no to o:) | |
| 12:21:15 | opendevreview | Rajesh Tailor proposed openstack/nova master: Add regression test case for bug 1978573 https://review.opendev.org/c/openstack/nova/+/914653 | |
| 12:21:16 | opendevreview | Rajesh Tailor proposed openstack/nova master: Restore original AZ when unshelve fails https://review.opendev.org/c/openstack/nova/+/911108 | |
| 12:26:28 | sean-k-mooney | elodilles: i dont really want to delay the release for the cve too long but if there are any backports you think we should include in the release im happy to review | |
| 12:31:33 | kashyap | sean-k-mooney: On that MDEV patch review, for a new contributor, I wouldn't use language like: "any attempt to rely on something like that would not pass code review." | |
| 12:32:12 | sean-k-mooney | kashyap: they are not really new htey have submitted patches before over a few releases and abandoned most of them | |
| 12:32:56 | sean-k-mooney | kashyap: but they were also implying that we were not following best pratices and relying on bad coding style. | |
| 12:33:12 | kashyap | I see; I've just seen that they've also contributed in the past a patch. | |
| 12:34:03 | sean-k-mooney | when i didnt recognise the name i looked to see if they were new and saw they ahd previous patches but i tought it was odd they abandoned most of them | |
| 12:34:21 | kashyap | Yeah, I saw that comment. Maybe they could've said, "_if_ we're relying on missing attributes ..." | |
| 12:35:09 | sean-k-mooney | perhaps they seams to ignore the content of my comment hosever and get very defensive | |
| 12:36:45 | sean-k-mooney | i on 2 ocations asked them to create a repoducer to demonstrate the orgainal bug and confrim there patch actully fixed it | |
| 12:36:53 | kashyap | But is parsing the alias field here wrong? I'm not 100% sure yet | |
| 12:45:15 | sean-k-mooney | the bug is that we dont check that all the objects have it before using it | |
| 12:45:18 | sean-k-mooney | and only some of them do | |
| 12:45:44 | sean-k-mooney | you can only request MDEVs via the flavor | |
| 12:46:00 | sean-k-mooney | so we dont actuly supprot detaching or attaching them to a running domain | |
| 12:46:09 | sean-k-mooney | which is why we did not add the alias field to them | |