| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-07-24 | |||
| 21:55:29 | sean-k-mooney | ill try snapshot and shelve quicklys | |
| 21:56:29 | sean-k-mooney | yep so snapshot creates a raw sanpshot | |
| 21:56:40 | melwitt | ok. yeah I was thinking about it because of that old code comment "glance forces ami disk format to be ami" I don't understand what it meant. so I wondered if a raw is uploaded and not labeled "ami" will glance somehow have a problem with it | |
| 21:57:09 | melwitt | like have a problem creating an instance from it | |
| 21:57:40 | sean-k-mooney | i think its just wrong | |
| 21:57:46 | sean-k-mooney | or at least it is today | |
| 21:58:17 | sean-k-mooney | i dont think glance has any idea what ami is | |
| 21:58:34 | sean-k-mooney | i can upload the 3 pars of the iamge as raw and it wont care | |
| 21:58:47 | melwitt | ok. mystery comment then I guess :) | |
| 21:59:51 | sean-k-mooney | so i get the same odd behavior when shelving a instance created form a glance qcow when i also have a snapshot | |
| 22:02:48 | sean-k-mooney | so it look like for soem reason the image backidn is tryign to use direct_snapshot | |
| 22:03:00 | sean-k-mooney | that fails and then we abort | |
| 22:03:02 | sean-k-mooney | https://paste.opendev.org/show/bKsmlsy1ClyGhEg1XTVp/ | |
| 22:03:57 | melwitt | it actually does that for everything, tries direct_snapshot first and then falls back on regular snapshot if not implemented | |
| 22:04:00 | sean-k-mooney | we are not on ceph so we do not expect driect_snapshot to work | |
| 22:04:12 | melwitt | it's weird, not sure why it's done that way | |
| 22:04:39 | sean-k-mooney | its because for ceph we can sometiems do it and othertiems not | |
| 22:04:51 | sean-k-mooney | depending on if glance and nova are on the same cluster i think | |
| 22:04:51 | melwitt | https://github.com/openstack/nova/blob/df39222b106326a4c28dee26b7127a61174d6b51/nova/virt/libvirt/driver.py#L3205 | |
| 22:05:14 | melwitt | ack | |
| 22:05:44 | sean-k-mooney | but the odd part is dan is not changin any of that in https://review.opendev.org/c/openstack/nova/+/924866 | |
| 22:07:01 | sean-k-mooney | it also does not make sense why this works if i dont alreayd have a snapshot and why creating a snapshot seperatly also works | |
| 22:07:08 | melwitt | huh you keep getting bad gateway from glance. are there any errors in the g-api log? | |
| 22:07:34 | sean-k-mooney | oh you think we are just logging ingocrrectly | |
| 22:07:41 | sean-k-mooney | ill check | |
| 22:08:37 | melwitt | I don't see how 502 bad gateway can be related to your test or the patch but I have seen weird things in upstream CI before | |
| 22:09:11 | sean-k-mooney | i might have hit an image size quota | |
| 22:09:18 | melwitt | ohhhh yeah that's what it is | |
| 22:09:27 | sean-k-mooney | DEBUG oslo.limit.limit [None req-635da87a-1d0b-45e9-b3d1-df7b8b2decf2 admin admin] hit limit for project: [Resource image_size_total is over limit of 1000 due to current usage 1849 and delta 0] | |
| 22:09:37 | melwitt | when you exceed quota, glance gives a 502, and it confused me so much | |
| 22:09:59 | sean-k-mooney | taht is really inccorect usage of http repsoce codes | |
| 22:10:22 | melwitt | and every time I guess I have to re figure it out to find that it's a quota limit issue | |
| 22:10:27 | melwitt | yeah, seriously | |
| 22:11:31 | sean-k-mooney | i have horizon im just setting them to -1 for now | |
| 22:12:24 | sean-k-mooney | lol of course the image qutas are not there | |
| 22:14:52 | melwitt | to do it manually it's openstack --os-cloud devstack-system-admin registered limit set --default-limit $limit --resource-name $name $registered_limit_id | |
| 22:15:34 | melwitt | to get the list openstack --os-cloud devstack registered limit list | |
| 22:15:40 | sean-k-mooney | isnt that for unified limits? | |
| 22:15:50 | melwitt | yeah, glance uses unified limits for its quotas | |
| 22:15:50 | sean-k-mooney | i guess glance uses that already | |
| 22:16:39 | melwitt | so I think -1 won't work as unlimited, but you can try if you want | |
| 22:16:51 | sean-k-mooney | it wont any more no | |
| 22:16:59 | sean-k-mooney | why is the default 1000 | |
| 22:17:01 | sean-k-mooney | which is 1G | |
| 22:17:19 | melwitt | qcow2 favoritism | |
| 22:17:28 | melwitt | (I don't actually know) | |
| 22:17:45 | sean-k-mooney | that only work for like cirros, alpine or tinycore | |
| 22:18:02 | melwitt | yeah there's that too | |
| 22:18:02 | sean-k-mooney | like most cloud images are under a gig but barely | |
| 22:20:57 | melwitt | you don't actually shouldn't pass --resource-name because it's by id and --resource-name is if you want to update the name. I made a mistake in the nova docs | |
| 22:21:11 | melwitt | *you actually shouldn't | |
| 22:21:43 | sean-k-mooney | ya i got a dup-licet key error | |
| 22:21:51 | sean-k-mooney | Conflict occurred attempting to store registered_limit - Duplicate entry. (HTTP 409) (Request-ID: req-f0f478fe-f682-4081-8837-bc89a09e79f2) | |
| 22:22:06 | sean-k-mooney | but i have updated it | |
| 22:22:13 | melwitt | yeah, sorry. I need to fix the doc I'm referencing | |
| 22:23:00 | sean-k-mooney | no worries i would have given up all ready | |
| 22:23:12 | sean-k-mooney | but i want ot see if this works | |
| 22:23:28 | sean-k-mooney | if it does then we have another bug to fix but dans patch looks good otherwise | |
| 22:27:12 | sean-k-mooney | ok its workign for me locally | |
| 22:27:53 | melwitt | ok nice | |
| 22:27:59 | sean-k-mooney | i know the ship has kidn of sailed on -1 but i really se that as a downgrade with unifried limts... | |
| 22:28:38 | sean-k-mooney | i need a new way to write max_int with brevity and style | |
| 22:28:47 | melwitt | yeah, it's weird bc the keystone docs say specifically that -1 means unlimited but oslo.limit does something else | |
| 22:29:01 | melwitt | and style 😂 | |
| 22:29:01 | sean-k-mooney | liek --im-an-admin-do-what-i-say akek --sudo | |
| 22:29:36 | sean-k-mooney | *aka | |
| 22:29:58 | melwitt | ceph has at least one funny CLI option like that | |
| 22:30:02 | sean-k-mooney | ofcouse i could personaly do with --do-what-i-ment-not-what-typed option too | |
| 22:30:15 | sean-k-mooney | the one for when your deleting things | |
| 22:30:26 | sean-k-mooney | ya i always liked that | |
| 22:30:28 | melwitt | yeah. I love that | |
| 22:31:03 | sean-k-mooney | i feell like if we added that to reset-state i would feel alttile better about that existing | |
| 22:31:54 | melwitt | same | |
| 22:31:59 | sean-k-mooney | ok im geting tired so im goign to go get some rest and ill take a look at dansmith's patch again in the morning | |
| 22:32:30 | melwitt | ok, seeya o/ | |
| 22:59:08 | opendevreview | melanie witt proposed openstack/nova master: docs: Correct unified limits CLI commands https://review.opendev.org/c/openstack/nova/+/924888 | |
| 23:38:50 | opendevreview | Merged openstack/nova master: [CI] Replace deprecated regex https://review.opendev.org/c/openstack/nova/+/922212 | |
| #openstack-nova - 2024-07-25 | |||
| 07:34:12 | opendevreview | Alexander Hild proposed openstack/nova master: feat: "vm uuid" in baseBoard asset tag https://review.opendev.org/c/openstack/nova/+/924907 | |
| 10:30:46 | opendevreview | Alexander Hild proposed openstack/nova master: feat: Include "vm uuid" in baseBoard asset tag in libvirt domain xml https://review.opendev.org/c/openstack/nova/+/924916 | |
| 11:35:43 | sean-k-mooney | gibi: bauzas: can one of ye hit https://review.opendev.org/c/openstack/nova/+/924733 | |
| 11:36:27 | gibi | looking | |
| 11:38:47 | gibi | +A | |
| 11:39:49 | sean-k-mooney | gibi: thanks | |
| 11:40:12 | sean-k-mooney | gibi: i left some other comments on https://review.opendev.org/c/openstack/nova/+/924866 by the way in case you want to weigh in there | |
| 11:40:41 | sean-k-mooney | im +2 on it but want to get dans opion before proceeding | |
| 11:41:21 | andreykurilin | If not, can this case be considered as a bug? And the last question - if it is a bug, does it require a microversion bump or not, as the 'removeSecurityGroup' API already defines a 400 error code? | |
| 11:41:21 | andreykurilin | Hi folks! I have a custom Neutron plugin that restricts adding&removing specific security groups from ports. It works excellently with Nova's `addSecurityGroup` server action, i.e., Nova propagates an original error from Neutron to the end-user. But 'removeSecurityGroup' behaves differently - it raises 500 if something goes wrong on the Neutron side. Is the behavior difference between similar server actions intentional or not? | |
| 11:44:08 | gibi | sean-k-mooney: ack. My limited understanding of the related code tells me that our defaults probably OK and if we start reconfiure things we will hit edge cases. So lets wait for Dan but I think we can land this as is and chalk up one more thing to care about when we rewrite the image code in nova. | |
| 11:44:53 | sean-k-mooney | yep thats where im at too | |
| 11:46:11 | sean-k-mooney | im going for an "eyes fully open appoch" just to be transparent and say hay this edge case exist but it existed before so not a regression | |
| 11:47:07 | sean-k-mooney | it does double down on the fact we need better tempest coverage of the formats we intend to supprot in the nova ci however | |
| 11:47:14 | sean-k-mooney | even if those are just in a perodic job | |
| 11:47:37 | sean-k-mooney | or one that only runs on cahgnes to the image code | |
| 11:55:59 | gibi | I agree. We only caught our regression becuase we were lucky to have a job with ami images | |
| 12:02:55 | sean-k-mooney | andreykurilin: we do not provide any supprot in nova for third party enturon exteions | |
| 12:03:58 | sean-k-mooney | andreykurilin: so unless this is in tree in neutron its by defientioan not a nova bug | |
| 12:04:43 | sean-k-mooney | if there is an aooved neutron api exteion for this beaviro then nova can be enhanced to supprot that when its enabeld | |
| 12:04:49 | opendevreview | Balazs Gibizer proposed openstack/nova master: DNM: test downstream cross repo testing https://review.opendev.org/c/openstack/nova/+/924823 | |
| 12:06:21 | sean-k-mooney | the behaivor being differnet is likely not intentional but im not sure if we shoudl fix it | |
| 12:07:01 | sean-k-mooney | if we were to fix this a micorversoin would not be approiate | |