| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-07-08 | |||
| 11:43:58 | sean-k-mooney | ack im just adressing the other nits ill have new version up in the next 30 mins or so | |
| 12:03:42 | opendevreview | sean mooney proposed openstack/nova master: Add iso file format inspector https://review.opendev.org/c/openstack/nova/+/923533 | |
| 12:03:42 | opendevreview | sean mooney proposed openstack/nova master: Reproduce iso regression with deep format inspection https://review.opendev.org/c/openstack/nova/+/923507 | |
| 12:04:23 | sean-k-mooney | gibi: dansmith: ^ when your about those are functiontally the saem just with the nits addressed | |
| 12:04:49 | sean-k-mooney | im going to stack with those now and confirm if this correctly sovles the rebuild regression | |
| 12:05:34 | sean-k-mooney | i.e. boot form qcow usin a KNOPPIX or similar rescue iso to repair a vm | |
| 12:06:04 | sean-k-mooney | s/usin/then using/ | |
| 12:10:25 | gibi | sean-k-mooney: those two patches looks good to me. | |
| 12:11:07 | sean-k-mooney | hopefully that resolves the timeouts but we will see. the fact that it was only timing out in the coverage job ment it was borderline before | |
| 12:11:50 | sean-k-mooney | espicaly give the spread between tox py11 at 11 mins to py312 at 22 | |
| 12:13:19 | sean-k-mooney | where that job runs obviouly has a non trivial impact on the job time | |
| 12:24:14 | sean-k-mooney | gibi: ill comment on the patch but i was able t boot form an cirros qcow and then rescue with an alpine iso | |
| 12:24:24 | sean-k-mooney | unrescue reverted back to cirros as expected | |
| 12:41:11 | gibi | sounds good | |
| 12:41:25 | andrewbonney | Hi. Any reviews on https://review.opendev.org/c/openstack/nova/+/919961 would be appreciated when people have time. Thanks | |
| 13:08:33 | opendevreview | Robert Hoffmann proposed openstack/nova master: Fix: clean up volume attachments https://review.opendev.org/c/openstack/nova/+/923646 | |
| 13:37:14 | spatel | Any idea on nova_libvirt error : qemuDomainObjBeginJobInternal:968 : Timed out during operation: cannot acquire state change lock (held by monitor=init-instance-00000d99) | |
| 14:43:57 | elodilles | sean-k-mooney dansmith : should we wait for any other patch to merge, or is it OK if I generate now stable release patches for nova? (so that we release the fixes for bug/2059809) | |
| 14:44:23 | dansmith | elodilles: I think fungi would say yes, release | |
| 14:44:44 | elodilles | ACK, then I'm preparing the patch | |
| 14:44:48 | fungi | yeah, the sooner the better | |
| 14:45:38 | dansmith | elodilles, fungi: bauzas is out this week, will we need an ack? | |
| 14:46:41 | fungi | the release team is able to override/bypass that requirement, if they're willing to | |
| 14:46:52 | dansmith | cool | |
| 14:58:09 | elodilles | dansmith: https://review.opendev.org/c/openstack/releases/+/923656 | |
| 14:58:39 | elodilles | Uggla auniyal : ping, as you are also release liaisons ^^^ o:) | |
| 15:00:04 | elodilles | release jobs (validation and list-changes) logs should be available in ~10-20 mins | |
| 15:00:36 | dansmith | elodilles: hmm, are those the right hashes for each release? | |
| 15:00:50 | dansmith | seems like A and C are reversed, unless I'm missing something | |
| 15:01:11 | dansmith | wait, maybe not | |
| 15:01:33 | dansmith | okay yeah, mis-copy-paste I think, nevermind | |
| 16:14:10 | mnaser | hi nova friends. https://review.opendev.org/c/openstack/nova/+/923298/2 -- can someone look at this unmaintained/zed stack, it looks good to me so far and would be nice to get going into the gate | |
| 16:14:15 | mnaser | (CVE stuff) | |
| 16:16:54 | dansmith | mnaser: note that nova-core doesn't even have +2 on that branch because it's unmaintained | |
| 16:18:23 | dansmith | looks like it has the only tweak we made after the first push, so I'd assume that if it works for you it's good | |
| 16:20:12 | mnaser | yeah I got that in | |
| 16:20:23 | mnaser | well, elodilles did :) | |
| 16:25:14 | JayF | mnaser: feel free to add me as reviewer for any security backports in unmaintained/ that need additional review. | |
| 16:25:33 | JayF | mnaser: I have the one patch you've indicated opened in my window, will have a look | |
| 16:30:56 | JayF | Speaking of; mnaser has an important fix for the Ironic driver which will need to land in master + go back to Caracal, and is probably bad enough that I'd hope we could get it in a caracal point release: https://review.opendev.org/c/openstack/nova/+/923530 -- basically Ironic+Nova integrated environments with complex networking configurations will not have their metadata generated properly | |
| 16:33:08 | dansmith | JayF: +2d | |
| 16:33:30 | dansmith | looks simple enough, maybe gmann or melwitt could hit it for you | |
| 16:33:31 | JayF | dansmith: thank you very much \o/ (for this and for fixing the security issues over the last weeks) | |
| 16:36:21 | melwitt | +Wd | |
| 16:37:26 | JayF | awesome, I'll get a backport in once it lands | |
| 16:38:18 | JayF | I do have an item on my todo to follow up and make sure all those tests use iter([obj1,obj2]) to catch this kinda issue | |
| 17:19:47 | dansmith | sean-k-mooney: so the coverage job is still failing on your test_iso9660 | |
| 17:19:52 | dansmith | I don't really know why though | |
| 17:21:28 | dansmith | because it reads 10M 17 bytes at a time maybe? does it need to be that big? | |
| 17:23:13 | sean-k-mooney | didnt i fixt that already https://review.opendev.org/c/openstack/nova/+/923533/8/nova/tests/unit/image/test_format_inspector.py#211 | |
| 17:23:54 | sean-k-mooney | dansmith: https://review.opendev.org/c/openstack/nova/+/923507/3 still need a +w by the way | |
| 17:24:02 | sean-k-mooney | that why its not currently in the ci | |
| 17:24:28 | dansmith | oh yeah, I was looking at the wrong report | |
| 17:24:34 | dansmith | that's why duh | |
| 17:24:48 | dansmith | cool | |
| 17:24:57 | sean-k-mooney | but ya the 32KB system area makes it time out with 7 or 512 bytye blocks | |
| 17:25:02 | dansmith | I just changed to 128k locally and it works fine at that size, so no real need for it to be larger I think | |
| 17:25:10 | sean-k-mooney | btu the 64k and 1mb block size do it in a single read | |
| 17:25:41 | dansmith | but as long as it passes now all good, it's only temporary anyway | |
| 17:25:42 | sean-k-mooney | well its reading 34KB total so the 64K read size is enough | |
| 17:27:07 | dansmith | in the gate now | |
| 17:27:16 | dansmith | totes forgot about that repro patch below :D | |
| 17:27:18 | sean-k-mooney | we could perhaps replace the 7 bytes with 7k later to have an unaligend read test be a little fater but ya for now it should be fine | |
| 17:29:50 | sean-k-mooney | ok those are going to take a while to go though the gate so ill likely take this time to cook dinner and ill check back after | |
| 17:30:23 | dansmith | ++ | |
| 18:30:01 | dansmith | hmm, might have a requirements conflict: gabbi 3.0.0 depends on jsonpath-rw-ext>=1.0.0 | |
| 18:30:05 | dansmith | just failed in gate | |
| 18:34:31 | dansmith | okay might've just been the requirements change that was in front of it | |
| 18:34:48 | dansmith | that failed (with multiple issues) and the nova restart passed that point I think | |
| 18:40:50 | frickler | that sounds like pypi is having some issues | |
| 18:41:20 | dansmith | maybe | |
| 18:43:03 | clarkb | those sorts of failures can occur when we get served old indexes from pypi | |
| 18:48:11 | dansmith | okay the requirements patch wasn't changing either of those packages, and one other job on it failed in a different way (but the nova one failed the same way the nova patch behind it did) | |
| 18:56:43 | opendevreview | Merged openstack/nova master: Reproduce iso regression with deep format inspection https://review.opendev.org/c/openstack/nova/+/923507 | |
| 20:29:09 | opendevreview | Merged openstack/nova master: Add iso file format inspector https://review.opendev.org/c/openstack/nova/+/923533 | |
| 20:32:54 | sean-k-mooney | sweet ^ ill start backporting those | |
| 20:45:39 | dansmith | \o/ | |
| #openstack-nova - 2024-07-09 | |||
| 00:18:54 | opendevreview | Merged openstack/nova master: Fix port group network metadata generation https://review.opendev.org/c/openstack/nova/+/923530 | |
| 00:26:12 | opendevreview | Mohammed Naser proposed openstack/nova stable/2024.1: Fix port group network metadata generation https://review.opendev.org/c/openstack/nova/+/923689 | |
| 03:27:25 | opendevreview | melanie witt proposed openstack/nova master: Support rescue with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/873675 | |
| 03:27:25 | opendevreview | melanie witt proposed openstack/nova master: Support encrypted backing files for qcow2 https://review.opendev.org/c/openstack/nova/+/907961 | |
| 03:27:26 | opendevreview | melanie witt proposed openstack/nova master: Support cross cell resize with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/909595 | |
| 03:27:26 | opendevreview | melanie witt proposed openstack/nova master: Support snapshot with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870937 | |
| 03:27:27 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for rbd with LUKS https://review.opendev.org/c/openstack/nova/+/889912 | |
| 03:27:27 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for raw with LUKS https://review.opendev.org/c/openstack/nova/+/884313 | |
| 04:08:14 | opendevreview | Merged openstack/nova stable/2024.1: add functional repoducer for bug 2065927 https://review.opendev.org/c/openstack/nova/+/922950 | |
| 05:41:33 | opendevreview | Merged openstack/nova stable/2024.1: retry write_sys call on device busy https://review.opendev.org/c/openstack/nova/+/922984 | |
| 06:05:02 | opendevreview | melanie witt proposed openstack/nova master: Consolidate vTPM and ephemeral encryption secret creation https://review.opendev.org/c/openstack/nova/+/912094 | |
| 06:05:03 | opendevreview | melanie witt proposed openstack/nova master: Follow up for encryption secret create consolidation https://review.opendev.org/c/openstack/nova/+/921586 | |
| 06:05:03 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Add optional 'description' kwarg to create_secret() https://review.opendev.org/c/openstack/nova/+/919986 | |
| 06:05:04 | opendevreview | melanie witt proposed openstack/nova master: Add EncryptDetails object for ephemeral encryption https://review.opendev.org/c/openstack/nova/+/921344 | |
| 06:05:04 | opendevreview | melanie witt proposed openstack/nova master: Remove use of (hw:|hw_)ephemeral_encryption_format https://review.opendev.org/c/openstack/nova/+/921343 | |
| 06:05:05 | opendevreview | melanie witt proposed openstack/nova master: Support create with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870932 | |
| 06:05:05 | opendevreview | melanie witt proposed openstack/nova master: Add database migration to ALTER encryption_options https://review.opendev.org/c/openstack/nova/+/921587 | |
| 06:05:06 | opendevreview | melanie witt proposed openstack/nova master: Clean up unused ephemeral encryption libvirt secrets https://review.opendev.org/c/openstack/nova/+/919990 | |
| 06:05:06 | opendevreview | melanie witt proposed openstack/nova master: Validate key manager create access in API https://review.opendev.org/c/openstack/nova/+/919989 | |
| 06:05:08 | opendevreview | melanie witt proposed openstack/nova master: Support (resize|cold migration) with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870933 | |
| 06:05:08 | opendevreview | melanie witt proposed openstack/nova master: libvirt: "Auto heal" ephemeral encryption secrets on guest launch https://review.opendev.org/c/openstack/nova/+/919991 | |
| 06:05:10 | opendevreview | melanie witt proposed openstack/nova master: Support rebuild with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870939 | |
| 06:05:10 | opendevreview | melanie witt proposed openstack/nova master: Support live migration with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/905512 | |