| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-05-30 | |||
| 08:27:52 | mikal | I spent a lot of time arguing against forks in my youth. | |
| 08:28:05 | sean-k-mooney[m] | what you really need to aovid is getting on the hook with this in production for protracted periods of time without upstreaming | |
| 08:28:37 | mikal | Yeah agreed, that would suck. | |
| 08:28:51 | sean-k-mooney[m] | well normally i would either rjust submit the patches to gerrit or host them in a gitbub branch | |
| 08:28:57 | sean-k-mooney[m] | preferbally the former | |
| 08:29:35 | sean-k-mooney[m] | since that makes them aviable for review and eaislly downloadable in a working git tree | |
| 08:29:43 | mikal | I'd be happy to do that. I had kind of assumed people would find that annoying until the spec is approved. That said, a lot of the nova patches are fairly vanilla -- add a sound card, add some USB passthrough devices, enforce network encryption, etc etc. | |
| 08:30:18 | mikal | I also haven't really chased down any of the other openstack projects because there's not a lot of point until nova agrees to land the key bit. | |
| 08:31:31 | sean-k-mooney[m] | so it depend on if you follow the letter of the law or are pratical. our docs say you should not start writign the code until the specc is merged but practically speaking most people at least do a poc. and as long as your are not rebasing them alot and using lots of ci resouce there is noharm in pushing them | |
| 08:32:06 | mikal | Yeah, those patches haven't changed in a couple of months so there wouldn't be a lot of CI load. | |
| 08:32:11 | mikal | I'll add pushing them to my todo list. | |
| 08:33:27 | sean-k-mooney[m] | by the way kolla only builds debian images now as far as im aware so you probaly dont need the rpm supprot anymore in your kolla series | |
| 08:34:07 | sean-k-mooney[m] | not that that saves much since its only 4 lines or so but just tought i would mention it | |
| 08:36:15 | mikal | Oh interesting. I only build debian images anyways because RHEL dropped SPICE support which is kind of awkward for me right now. | |
| 08:39:18 | sean-k-mooney[m] | ya… redhat strop all development of spice and removed supprot for it in our version of qemu when the only person that work on spice on our virt/qemu team left | |
| 08:39:40 | sean-k-mooney[m] | they may of left because of the decsion to drop spice im not sure | |
| 08:39:58 | sean-k-mooney[m] | but in rhel 9 it got compiled out | |
| 08:40:41 | sean-k-mooney[m] | i dont know of any plans to every change that going forward | |
| 08:40:59 | sean-k-mooney[m] | if kerbside takes off who knows | |
| 08:41:49 | sean-k-mooney[m] | mikal: kolla still support installing on other distos they just use the debian image for that now | |
| 08:42:36 | sean-k-mooney[m] | i used to use ubuntu-source as my build target for kolla in the past, i never had issues with that on ubuntu or centos | |
| 08:43:04 | sean-k-mooney[m] | anyway im going to go grab a coffeee and move from my ipad to my desk o/ | |
| 08:47:15 | mikal | No worries, thanks for the chat. | |
| 08:51:40 | sean-k-mooney | gibi: bauzas: when ye have time can ye re reivew my ci fix for the emulation job https://review.opendev.org/c/openstack/nova/+/918464 | |
| 08:51:48 | bauzas | ack | |
| 09:32:24 | opendevreview | Marlin Cremers proposed openstack/nova master: feat: set rotation rate on disks based on rotation rate from volume https://review.opendev.org/c/openstack/nova/+/920818 | |
| 09:34:16 | opendevreview | Marlin Cremers proposed openstack/nova master: libvirt: set rotation rate on disks based on rotation rate from volume https://review.opendev.org/c/openstack/nova/+/920818 | |
| 09:43:09 | opendevreview | Marlin Cremers proposed openstack/nova master: libvirt: set rotation rate on disks based on rotation rate from volume https://review.opendev.org/c/openstack/nova/+/920818 | |
| 09:49:53 | marlinc | Hello there, I'm trying to contribute a small change to introduce support for the libvirtd rotation_rate flag for volumes. Now I'm wondering if I have to also create a spec alongside a blueprint for this | |
| 09:50:40 | marlinc | And I'm also wondering if I should also do this for cinder as it uses a new field in the connection_info from cinder | |
| 09:50:55 | marlinc | I have already written a small blueprint for this https://blueprints.launchpad.net/nova/+spec/rotation-rate | |
| 09:55:14 | opendevreview | Marlin Cremers proposed openstack/nova master: libvirt: set rotation rate on disks based on rotation rate from volume https://review.opendev.org/c/openstack/nova/+/920818 | |
| 12:26:34 | sean-k-mooney | marlinc feature by default are tracked as bluepirnt, we only require specs if there is an upgrade impact which this may or may not have when it comes to live migraton | |
| 12:27:03 | sean-k-mooney | we suppoirt compute nodes of up to n-2 or speciicly the previous slurp release | |
| 12:27:12 | sean-k-mooney | in thei case that n-1 | |
| 12:27:29 | sean-k-mooney | so we need to supprot live migrating form master to the previous relese | |
| 12:28:58 | sean-k-mooney | marlinc i see your irc client disconnected but ill capture it here in teh logs. what we woudl need to confirm is is there a live migration impact. i think yes. then we need to determin how to adress that. | |
| 12:29:50 | sean-k-mooney | the case that i am concerned about breaking is live migratine form n to n-1 and then back to n | |
| 12:30:40 | sean-k-mooney | if that work then the only other thing we should need to conifm is when was rotation_rate added and is it supported in our min libvirt version | |
| 12:31:05 | sean-k-mooney | those are the two main upgrade concerns since this is a dirver only change | |
| 12:31:34 | sean-k-mooney | "rotation_rate" attribute value since 7.3.0 | |
| 12:32:18 | sean-k-mooney | our min supported libvirt is 7.0.0 | |
| 12:32:25 | sean-k-mooney | so the patch also need to accomidate for that. | |
| 12:32:50 | sean-k-mooney | nova will not allow you to live migrate to an older libvirt | |
| 12:33:06 | sean-k-mooney | so you just need that check on the source node (the upgraded node) | |
| 12:33:20 | sean-k-mooney | ill metion thsi in the reveiw | |
| 15:11:53 | opendevreview | Arnaud Morin proposed openstack/nova master: libvirt: Log exception if failure checking block job https://review.opendev.org/c/openstack/nova/+/907720 | |
| 15:30:16 | opendevreview | Arnaud Morin proposed openstack/nova master: libvirt: Add retry on device job operation timeout https://review.opendev.org/c/openstack/nova/+/907730 | |
| #openstack-nova - 2024-05-31 | |||
| 10:44:11 | opendevreview | Merged openstack/nova master: add functional repoducer for bug 2065927 https://review.opendev.org/c/openstack/nova/+/920119 | |
| 13:58:51 | opendevreview | Marlin Cremers proposed openstack/nova master: libvirt: set rotation rate on disks based on rotation rate from volume https://review.opendev.org/c/openstack/nova/+/920818 | |
| #openstack-nova - 2024-06-03 | |||
| 08:06:37 | opendevreview | Zhang Hua proposed openstack/nova master: BlockDeviceMapping object has no attribute copy https://review.opendev.org/c/openstack/nova/+/920374 | |
| 08:53:33 | opendevreview | Maxime Lubin proposed openstack/nova master: libvirt: add power management xml handling https://review.opendev.org/c/openstack/nova/+/920993 | |
| 08:53:34 | opendevreview | Maxime Lubin proposed openstack/nova master: libvirt driver: configure power management behavior from flavor metadata https://review.opendev.org/c/openstack/nova/+/920994 | |
| 12:14:07 | andrewbonney | Hi. Unless there's a specific review session which could cover it, any further reviews of https://review.opendev.org/c/openstack/nova/+/919961 would be appreciated. Thanks | |
| 12:52:20 | opendevreview | Merged openstack/nova stable/2023.1: Fix nova-manage image_property show unexpected keyword https://review.opendev.org/c/openstack/nova/+/914766 | |
| 14:26:49 | opendevreview | ribaudr proposed openstack/nova master: Amend ShareMappingStatus due to asynchronous call https://review.opendev.org/c/openstack/nova/+/908864 | |
| 14:26:50 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | |
| 14:26:50 | opendevreview | ribaudr proposed openstack/nova master: Amend DB model add a unique constraint. https://review.opendev.org/c/openstack/nova/+/912518 | |
| 14:26:51 | opendevreview | ribaudr proposed openstack/nova master: Mounting the shares as part of the initialization process https://review.opendev.org/c/openstack/nova/+/880075 | |
| 14:26:51 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part) https://review.opendev.org/c/openstack/nova/+/833090 | |
| 14:26:52 | opendevreview | ribaudr proposed openstack/nova master: Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | |
| 14:26:52 | opendevreview | ribaudr proposed openstack/nova master: Deletion of associated share mappings on instance deletion https://review.opendev.org/c/openstack/nova/+/881472 | |
| 14:26:53 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to reboot method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/854823 | |
| 14:26:54 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to resume method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/860284 | |
| 14:26:54 | opendevreview | ribaudr proposed openstack/nova master: Support rebooting an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/854824 | |
| 14:26:56 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to rescue/unrescue shares https://review.opendev.org/c/openstack/nova/+/860286 | |
| 14:26:56 | opendevreview | ribaudr proposed openstack/nova master: Support resuming an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/860285 | |
| 14:26:58 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/860288 | |
| 14:26:58 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (driver part) https://review.opendev.org/c/openstack/nova/+/860287 | |
| 14:27:00 | opendevreview | ribaudr proposed openstack/nova master: Check shares support (compute manager) https://review.opendev.org/c/openstack/nova/+/885751 | |
| 14:27:00 | opendevreview | ribaudr proposed openstack/nova master: Allow to mount manila share using Cephfs protocol https://review.opendev.org/c/openstack/nova/+/883862 | |
| 14:27:02 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/885753 | |
| 14:27:02 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (API) https://review.opendev.org/c/openstack/nova/+/836830 | |
| 14:27:04 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028 | |
| 14:27:04 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | |
| 14:27:06 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach_error notification https://review.opendev.org/c/openstack/nova/+/860282 | |
| 14:27:06 | opendevreview | ribaudr proposed openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029 | |
| 14:27:08 | opendevreview | ribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working. https://review.opendev.org/c/openstack/nova/+/852086 | |
| 14:27:08 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach_error notification https://review.opendev.org/c/openstack/nova/+/860283 | |
| 14:27:10 | opendevreview | ribaudr proposed openstack/nova master: Docs about Manila shares API usage https://review.opendev.org/c/openstack/nova/+/871642 | |
| 14:27:10 | opendevreview | ribaudr proposed openstack/nova master: Add virt/libvirt error test cases https://review.opendev.org/c/openstack/nova/+/852087 | |
| 15:13:00 | zigo | https://paste.opendev.org/show/bOc8BpuH8DTiMSmtiQ5n/ <--- Anyone knows why eventlet monkey patching is broken for me? | |
| 15:17:54 | zigo | That's with Python 3.11 and Caracal, with eventlet 3.35.1 ... | |
| 15:27:59 | zigo | Looks like the issue is my backport to bookworm, somehow... | |
| #openstack-nova - 2024-06-04 | |||
| 12:42:57 | zigo | I'm still getting the issue that Caracal doesn't like cpu_models = EPYC-Milan (nova-compute exists with "Unacceptable CPU info: CPU doesn't have compatibility"), even tough "virsh capabilities" shows that my host's CPU really is EPYC-Milan. Is the _check_cpu_compatibility somehow broken?!? | |
| 12:43:03 | zigo | How can I check what it does? | |
| 14:12:46 | dansmith | bauzas: do you want to +W this or should I? https://review.opendev.org/c/openstack/nova-specs/+/907654 | |
| 14:13:13 | bauzas | dansmith: do this | |
| 14:13:39 | dansmith | bauzas: ? | |
| 14:16:54 | sean-k-mooney | bauzas: does that mean you will or that dan should | |
| 14:17:16 | sean-k-mooney | cause i was going to ask dansmith why he did not +w but then i saw this converstaion | |
| 14:17:59 | dansmith | I thought bauzas said several times he wanted to review that, so I held off the +W but I also didn't realize you had +2d yet | |
| 14:18:18 | dansmith | I was actually going to it to see the status and saw you had +2d | |
| 14:18:34 | sean-k-mooney | ack | |
| 14:18:43 | dansmith | but if bauzas isn't going to in short order, we should just send it I think | |
| 14:18:47 | dansmith | we're running out of time | |
| 14:19:23 | sean-k-mooney | i just the email update for your +2 and was wondering but was waiting for our downstream converation to come to an end before changing topic | |
| 14:20:39 | sean-k-mooney | anyway im cool leaving it to either of you to +w i was wondering if my +2 had been lost or not | |
| 14:23:45 | bauzas | ok, ok, I can try to give it a shot | |
| 14:28:01 | dansmith | bauzas: can you clarify what you're saying? _are_ you going to review that? | |