Earlier  
Posted Nick Remark
#openstack-nova - 2024-04-30
16:27:58 bauzas anything else on the stable side ?
16:27:59 elodilles sean-k-mooney: we had some patches, but i don't know whether that is among them :X
16:28:14 elodilles bauzas: np, nothing else from me
16:28:21 sean-k-mooney ack so that will cause grenade to fail then since the base barnch wont exist
16:28:40 sean-k-mooney but its also a simple enough change once all the branch movign is done
16:28:57 elodilles ++
16:28:59 bauzas I think grenade has some homework anytime we delete a branch
16:29:15 bauzas but let's move on
16:29:21 bauzas #topic vmwareapi 3rd-party CI efforts Highlights
16:29:37 bauzas fwiesel: wanting to say something ?
16:29:47 fwiesel Not really.
16:30:02 fwiesel https://review.opendev.org/c/openstack/nova/+/909474 has been reviewed, so that's great. Thanks to everyone.
16:30:11 fwiesel Any questions?
16:30:27 sean-k-mooney am i saw the chagnes that dan asked for
16:30:29 bauzas cool, I'll see if I can look at it
16:30:38 sean-k-mooney i have not had time to re review but ill try and get to it today
16:30:38 bauzas but dan and sean already did their work
16:30:42 sean-k-mooney after the meeting
16:30:45 fwiesel Thanks
16:30:47 bauzas cool so
16:30:51 fwiesel #info Nothing to report.
16:30:54 bauzas cool
16:30:56 bauzas last topic then
16:30:59 bauzas let's be short
16:31:01 sean-k-mooney asuming that merges can you add the next one to the list for review
16:31:03 bauzas #topic Open discussion
16:31:10 bauzas I have one thing to raise
16:31:13 gibi I have one too
16:31:22 fwiesel sean-k-mooney: Of course, I'll add that one
16:31:31 bauzas (bauzas) I won't be able to run the next nova meeting
16:31:52 opendevreview Takashi Kajinami proposed openstack/nova master: Remove old excludes https://review.opendev.org/c/openstack/nova/+/917594
16:32:00 bauzas (I'll take a few days off starting Wed, but I'll need to travel on Tues by 5pm my time)
16:32:14 bauzas so, who can run the meeting in my absence ?
16:32:19 dansmith or just cancel?
16:32:25 bauzas if nobody volunteers, I can cancel
16:32:28 bauzas yeah that
16:32:44 gibi I can run it if needed
16:33:09 bauzas thanks gibi
16:33:17 gibi no problemo
16:33:18 bauzas #action gibi to run next nova meeting
16:33:24 bauzas gibi: shoot your own point
16:33:31 gibi just a heads up
16:34:15 gibi we started a small standup with Uggla_ about his manial series 30 mins twice a week. So far it is Uggla_ and me but eventually we need a second code for the series
16:34:26 bauzas count me on it
16:34:27 gibi and such core could benefit joining to these meetings
16:34:49 gibi bauzas: thanks, I will make sure you will have the invite
16:34:50 bauzas I already reviewed the series so I'd be happy to continue to shepherd it
16:35:10 bauzas gibi: cool, timezones will then match hopefully :)
16:35:16 bauzas (it was a joke)
16:35:20 gibi it will :)
16:35:28 gibi that is all
16:35:31 bauzas cool
16:35:36 bauzas and then that's all for me too
16:35:40 bauzas thanks all
16:35:42 opendevreview Takashi Kajinami proposed openstack/python-novaclient master: Remove old excludes https://review.opendev.org/c/openstack/python-novaclient/+/917685
16:35:44 bauzas was a productive meeting
16:35:48 bauzas see you :)
16:35:52 opendevmeet Log: https://meetings.opendev.org/meetings/nova/2024/nova.2024-04-30-16.00.log.html
16:35:52 opendevmeet Minutes (text): https://meetings.opendev.org/meetings/nova/2024/nova.2024-04-30-16.00.txt
16:35:52 opendevmeet Minutes: https://meetings.opendev.org/meetings/nova/2024/nova.2024-04-30-16.00.html
16:35:52 opendevmeet Meeting ended Tue Apr 30 16:35:52 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
16:35:52 bauzas #endmeeting
16:35:54 Uggla_ bauzas, I will send you the invites
16:36:00 bauzas np
16:36:17 elodilles thanks o/
16:36:38 tkajinam thank you :-D
16:36:39 sean-k-mooney just a note f you want ot send a message to the list to invite other to join if they want to dont send the ical
16:36:59 sean-k-mooney if you send the ical to the list is will effectivly invite the list :)
16:37:27 gibi I think this will not go to the list :)
16:37:39 gibi we want t keep it focused
16:37:43 opendevreview Takashi Kajinami proposed openstack/os-resource-classes master: Remove old excludes https://review.opendev.org/c/openstack/os-resource-classes/+/917614
16:37:44 fwiesel thanks
16:37:58 sean-k-mooney which is fine. i likely wont join those meeting but if you want me to attend as a one off for a specific patch or topic ping
16:39:20 gibi sure, thanks
16:40:40 gibi btw if we already discussing this series I'm wondering if we are OK to have a sqlite specific db migration codepath https://review.opendev.org/c/openstack/nova/+/912518/1/nova/db/main/migrations/versions/d60bddf7a903_add_constraint_instance_share_avoid_.py
16:40:56 dansmith wow, really?
16:41:05 gibi our migraton testing fail without it
16:41:32 gibi so we either skip testing this migration or have an sqlite specific path
16:41:33 dansmith and it's a table drop/recreate? that seems incredibly unfortunate to me
16:41:42 gibi it is for sqlite
16:42:03 dansmith what is the actual problem?
16:42:21 sean-k-mooney we should not need that
16:42:21 gibi sqlite does not support altering constarint on a table without recreate
16:42:31 sean-k-mooney although i know ironic does some sqlite specific tweaks
16:42:50 dansmith the create_table includes mysql-specific stuff too
16:42:51 sean-k-mooney gibi: as in adding a foringkey
16:43:45 dansmith is this because we merged the migration before the implementation and then decided that we needed something different?
16:43:47 sean-k-mooney so this is the share mapping table
16:43:51 sean-k-mooney which does not exist right
16:44:03 sean-k-mooney so why do we need this drop table and recreate
16:44:10 sean-k-mooney did that merge last cycle?
16:44:16 gibi dansmith: we needed an exta constraint to prevent creating two sharemapping with the same share id and instance id
16:44:28 gibi sean-k-mooney: we merged the db code
16:44:37 dansmith ugh, that's very unfortunate
16:44:41 sean-k-mooney ... ok this partly why i didint want to do that
16:44:46 dansmith yeah seriously
16:45:13 dansmith but, if it's not used currently, can we just drop and recreate it for all backends? should be very non-impactful for an empty mysql table I think
16:45:34 sean-k-mooney ya i think i prefer ^
16:45:35 gibi dansmith: correct, the api code is not landed, so the table is empty
16:46:01 dansmith yeah, I'd prefer that, but.. also prefer not landing db code before implementation is ready for exactly this reason :(

Earlier   Later