| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-04-23 | |||
| 16:32:39 | sean-k-mooney | but as you said we can review that on the patches | |
| 16:33:08 | bauzas | there are different threads, right? | |
| 16:33:40 | sean-k-mooney | you will have to rephase that question, im not following. | |
| 16:33:41 | dansmith | what does "parallel instead of concurrent" mean? | |
| 16:33:44 | bauzas | like, for the services workers, it's not a problem, we would create all the threads when starting the service | |
| 16:34:07 | sean-k-mooney | your repheing to how we have a worker count for the schduler | |
| 16:34:20 | bauzas | dansmith: I mean that we would thread instead of greenthreading | |
| 16:35:00 | sean-k-mooney | ok yes we woudl be using pthreads/OS threads instead fo userland/green threads | |
| 16:35:02 | dansmith | bauzas: okay so you mean async instead of one of parallel or concurrent I think, but okay | |
| 16:35:18 | sean-k-mooney | in pything the gil means they are still concurrent not turely parallel | |
| 16:35:37 | sean-k-mooney | *in python | |
| 16:35:39 | bauzas | sure | |
| 16:35:51 | bauzas | we still have the GIL so they're not really paralled | |
| 16:35:59 | bauzas | but they're threads | |
| 16:36:05 | sean-k-mooney | yes | |
| 16:36:05 | dansmith | they're still parallel, IMHO | |
| 16:36:07 | fwiesel | Depends on the context... c-extensions may release the lock and run really in parallel | |
| 16:36:15 | dansmith | right | |
| 16:36:33 | bauzas | anyway, let me reexplain it | |
| 16:36:34 | dansmith | they're parallel but with a ton of shared/locked data structures :) | |
| 16:36:35 | sean-k-mooney | ya and there are other case wehre the gil is droped too | |
| 16:36:36 | fwiesel | Would help with the parsing of the huge xml documents we sometimes get in the vmwareapi | |
| 16:36:47 | dansmith | let's just move on, I think we know what we agreed | |
| 16:36:54 | sean-k-mooney | sure | |
| 16:37:09 | bauzas | we will use 'python threads" instead of "other concurrent/green threading way" | |
| 16:37:37 | sean-k-mooney | yes throught the api of a futureist executor in most cases | |
| 16:37:41 | bauzas | so, anything else to say? | |
| 16:37:53 | sean-k-mooney | nope | |
| 16:37:56 | bauzas | cool | |
| 16:37:59 | bauzas | thanks all | |
| 16:38:16 | opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2024/nova.2024-04-23-16.00.log.html | |
| 16:38:16 | opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2024/nova.2024-04-23-16.00.txt | |
| 16:38:16 | opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2024/nova.2024-04-23-16.00.html | |
| 16:38:16 | opendevmeet | Meeting ended Tue Apr 23 16:38:16 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 16:38:16 | bauzas | #endmeeting | |
| 16:38:27 | fwiesel | Thanks and bye | |
| 16:38:42 | gibi | o/ | |
| 16:38:42 | elodilles | thanks o/ | |
| 16:39:13 | elodilles | bauzas: the zed release patch: https://review.opendev.org/c/openstack/releases/+/916813 | |
| 16:41:27 | elodilles | btw, it's probably useful to release now then form newer stable branches as well. i'll create stable release patches for those | |
| 16:59:40 | elodilles | here they are: 2023.1 - https://review.opendev.org/916815 ; 2023.2 - https://review.opendev.org/916816 | |
| 17:00:10 | elodilles | i think we don't need a stable/2024.1 release yet | |
| 17:01:27 | elodilles | (this would be the content on caracal in the moment: https://paste.opendev.org/show/bq3vt56UP5WVQ9baFLUZ/ ) | |
| #openstack-nova - 2024-04-24 | |||
| 14:17:47 | artom | dansmith, sean-k-mooney, I think https://review.opendev.org/c/openstack/nova/+/915139/3 (the cpu_shared_set live migration fix) is at a point where it should be an easy-ish +2/+A - can we get that going? I've got a couple of whitebox changed that need it, which will allow us to cross a few tests off our list | |
| 14:18:21 | sean-k-mooney | ah ya i didnt get to reveiw that last week | |
| 14:18:40 | sean-k-mooney | i have 12 mins before my next meeting so ill take a look | |
| 14:21:37 | artom | Cheers :) | |
| 14:36:48 | simondodsley | is there a known prgramatic method to get the unique ID of a hypervisor? I know it is in the Nova DB but not sure which construct I can use to get that out through a python call | |
| 14:41:26 | sean-k-mooney | do you mean the compute node UUID | |
| 14:41:40 | sean-k-mooney | that is aviable to admins via the hypervior api | |
| 14:46:43 | dansmith | Uggla_: mind if I just quickly fix the truthiness nits in https://review.opendev.org/c/openstack/nova/+/915139/3/nova/virt/libvirt/migration.py and then I'll +2? | |
| 14:51:59 | dansmith | and also the commit message nit | |
| 14:52:07 | dansmith | (which is not really a nit, IMHO) | |
| 14:53:06 | artom | dansmith, mind if I proxy for him and just tell you to do it? ;) | |
| 14:53:14 | artom | (With appreciation for your review time) | |
| 14:56:44 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: scheduler: AggregateMultitenancyIsolation to support unlimited tenant https://review.opendev.org/c/openstack/nova/+/896512 | |
| 14:59:27 | opendevreview | Dan Smith proposed openstack/nova master: Fix: migration configuration with cpu_shared_set (object part) https://review.opendev.org/c/openstack/nova/+/903706 | |
| 14:59:28 | opendevreview | Dan Smith proposed openstack/nova master: Test live migration between hosts with differnet cpu_shared_sets https://review.opendev.org/c/openstack/nova/+/913744 | |
| 14:59:28 | opendevreview | Dan Smith proposed openstack/nova master: Fix: migration configuration with cpu_shared_set (libvirt part) https://review.opendev.org/c/openstack/nova/+/915139 | |
| 15:31:16 | dansmith | tkajinam: did you want to opine on this before I flesh it out? https://review.opendev.org/c/openstack/nova/+/915911/1 | |
| 15:32:10 | opendevreview | Max proposed openstack/nova master: feat: nova-manage db instace events cleanup https://review.opendev.org/c/openstack/nova/+/916927 | |
| 15:34:44 | tkajinam | dansmith, I'll check the series of these patches and will leave any comments (or +1 if no) | |
| 19:58:58 | opendevreview | Merged openstack/nova master: Fix: migration configuration with cpu_shared_set (object part) https://review.opendev.org/c/openstack/nova/+/903706 | |
| 20:37:39 | opendevreview | Merged openstack/nova master: Fix: migration configuration with cpu_shared_set (libvirt part) https://review.opendev.org/c/openstack/nova/+/915139 | |
| 21:07:42 | simondodsley | sean-k-mooney: sorry for the delay in responding. I need to get the compute UUID from within a cinder driver. Do you know where/how I could do that? | |
| #openstack-nova - 2024-04-25 | |||
| 09:10:45 | songwenping | sean-k-mooney: hi, is there concurrency case in tempest? | |
| 10:20:30 | sean-k-mooney | songwenping: can you be more specific? tempest can run with multiple test in parallel | |
| 10:22:31 | sean-k-mooney | simondodsley: im not entirly sure why the cinder driver woudl need the compute node uuid. we dont use that as a value we exchange between services. we use the CONF.host value which is typically the hostname but can be the fqdn | |
| 10:23:34 | sean-k-mooney | anyway to fid it you can use https://docs.openstack.org/api-ref/compute/#list-hypervisors | |
| 10:24:12 | sean-k-mooney | so /os-hypervisors?hypervisor_hostname_pattern=<host value goes here> | |
| 10:24:52 | sean-k-mooney | use microveriosn 2.53 or higher to get teh id filed as a uuid | |
| 10:25:21 | sean-k-mooney | <2.53 the id filed is a cell speific int so you should avoid that | |
| 10:27:37 | auniyal | sean-k-mooney, how to set min_microversion in temepst, this https://paste.opendev.org/show/bJLSDBLxBgj2hzBcJEiq/ in tempest.conf | |
| 10:28:01 | auniyal | but I am getting SKIPPED: The microversion range[2.11 - latest] of this test is out of the configuration range[None - None]. | |
| 10:28:29 | auniyal | I was refering this - https://docs.openstack.org/tempest/latest/sampleconf.html | |
| 10:49:30 | sean-k-mooney | auniyal: you set it in teh test class | |
| 10:49:52 | sean-k-mooney | you may also be able to do it seperately but most tests seam to do it at the class level | |
| 10:49:59 | auniyal | yeah, in test class min_microversion = '2.11' | |
| 10:50:40 | sean-k-mooney | you shoudl not need to chnage the tempest.conf | |
| 10:51:19 | auniyal | I am getting SKIPPED: The microversion range[2.11 - latest] of this test is out of the configuration range[None - None] | |
| 10:51:37 | sean-k-mooney | sure but devstack will produce a valid tempst conf for you | |
| 10:51:53 | sean-k-mooney | and you should never realy need to change the values for the micorverion range in general | |
| 10:52:10 | auniyal | ack, so change rearding microverion in tempest conf | |
| 10:52:14 | auniyal | *no change | |
| 10:52:48 | sean-k-mooney | what you have in the pastbin shoudl work | |
| 10:52:55 | auniyal | sean-k-mooney, how can I fix skipping test then | |
| 10:52:58 | sean-k-mooney | but my guess is that is nto the actul issue | |
| 10:53:01 | sean-k-mooney | can you should be the test | |
| 10:53:25 | auniyal | https://paste.opendev.org/show/bZgalcGsTREjXm08RT34/ | |
| 10:54:19 | sean-k-mooney | https://github.com/openstack/tempest/blob/1c3fc43c9dae274a19683b003f78b5f50edbc062/doc/source/microversion_testing.rst that is the docs on adding microversion test by the way | |
| 10:55:21 | sean-k-mooney | it looks like you might be missing the resocue_setup funciton un less you are gettign that form the ineritied test | |
| 10:56:46 | sean-k-mooney | its not provided directly by the parent class https://opendev.org/openstack/whitebox-tempest-plugin/src/branch/master/whitebox_tempest_plugin/api/compute/base.py#L38 | |
| 10:56:55 | sean-k-mooney | so we need to check BaseV2ComputeAdminTest | |
| 10:57:41 | sean-k-mooney | ok it should get it form here https://github.com/openstack/tempest/blob/1c3fc43c9dae274a19683b003f78b5f50edbc062/tempest/api/compute/base.py#L123 | |
| 10:58:28 | auniyal | CONF.compute.min_microversion - so None | |
| 10:58:29 | sean-k-mooney | from what i can see you have done it correctly | |
| 10:59:03 | sean-k-mooney | auniyal: its proably best to ask about this isn the QA channel by the way | |
| 10:59:15 | auniyal | sean-k-mooney, ack | |
| 10:59:21 | sean-k-mooney | that is where we gernerally discuss tempest/whitebox thigns | |
| 10:59:23 | auniyal | thanks for looking | |