| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-03-26 | |||
| 16:07:53 | elodilles | and final rc week is this week | |
| 16:07:57 | bauzas | I've started a new etherpad | |
| 16:08:02 | bauzas | #link https://etherpad.opendev.org/p/nova-dalmatian-status | |
| 16:08:34 | bauzas | #topic vPTG Planning | |
| 16:08:40 | bauzas | #info The vPTG will be held on Apr 8-12 | |
| 16:08:44 | bauzas | #info Nova sessions between Tues-Fri 1pm-5pm UTC | |
| 16:08:48 | bauzas | #link https://etherpad.opendev.org/p/nova-dalmatian-ptg add your own PTG topics in that etherpad | |
| 16:08:52 | bauzas | #info Don't forget to register yourselves on http://ptg2023.openinfra.dev/ | |
| 16:08:59 | bauzas | that's it | |
| 16:09:03 | bauzas | #topic Review priorities | |
| 16:09:09 | bauzas | like I said, | |
| 16:09:18 | bauzas | #link https://etherpad.opendev.org/p/nova-dalmatian-status | |
| 16:09:23 | bauzas | #topic Stable Branches | |
| 16:09:25 | bauzas | elodilles: your turn | |
| 16:09:52 | elodilles | to be short: | |
| 16:10:03 | elodilles | #info stable/202*.* branches' gates seem to be OK, but nova-ceph-multistore is constantly failing (?) on stable/zed | |
| 16:10:10 | elodilles | #info stable branch status / gate failures tracking etherpad: https://etherpad.opendev.org/p/nova-stable-branch-ci | |
| 16:10:14 | elodilles | EOM | |
| 16:10:23 | bauzas | thanks | |
| 16:10:29 | bauzas | #topic vmwareapi 3rd-party CI efforts Highlights | |
| 16:10:35 | bauzas | fwiesel seems off | |
| 16:10:38 | grandchild | fwiesel is out this week. there's not much to report. he's waiting on reviews on changes. presumably https://review.opendev.org/c/openstack/nova/+/909474 and https://review.opendev.org/c/openstack/nova/+/910627. that is all. | |
| 16:10:39 | bauzas | copying his notes | |
| 16:10:49 | bauzas | cool thanks grandchild | |
| 16:11:01 | bauzas | #topic Open discussion | |
| 16:11:08 | bauzas | (bauzas) Could https://blueprints.launchpad.net/nova/+spec/aggregatemultitenancyisolation-to-support-unlimited-tenant be a specless blueprint ? | |
| 16:11:15 | bauzas | honestly, I'd like so | |
| 16:11:28 | bauzas | this is a quick small change limited to a filter | |
| 16:11:47 | bauzas | and sahid awaits us to approve his patch for too long | |
| 16:12:23 | bauzas | so, controversial opinions ? | |
| 16:12:31 | bauzas | if not, I'll approve it | |
| 16:12:57 | sean-k-mooney | we discussed all the controverial stuff last cycle | |
| 16:13:06 | sean-k-mooney | so im fine with it being specless this cycle | |
| 16:13:10 | bauzas | cool | |
| 16:13:24 | bauzas | #agreed https://blueprints.launchpad.net/nova/+spec/aggregatemultitenancyisolation-to-support-unlimited-tenant accepted as a specless blueprint | |
| 16:13:29 | bauzas | I'll do the paperwork | |
| 16:13:42 | bauzas | anything else for open discussion ? | |
| 16:14:32 | bauzas | looks not | |
| 16:14:34 | bauzas | thanks all | |
| 16:14:38 | opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2024/nova.2024-03-26-16.00.log.html | |
| 16:14:38 | opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2024/nova.2024-03-26-16.00.txt | |
| 16:14:38 | opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2024/nova.2024-03-26-16.00.html | |
| 16:14:38 | opendevmeet | Meeting ended Tue Mar 26 16:14:38 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 16:14:38 | bauzas | #endmeeting | |
| 16:15:36 | elodilles | thanks bauzas o/ | |
| 16:16:52 | sean-k-mooney | bauzas: for the vmware reviwe we proably should try and do a realtime review of those or somethign | |
| 16:17:15 | sean-k-mooney | i have not had time to fully load the context and then look a the ci results to know if the patch fixes what it say it fixes | |
| 16:17:24 | sean-k-mooney | but it woudl be good to adress some of those issues | |
| 19:03:53 | melwitt | sean-k-mooney: care to revisit this nova-manage image_property fix? they updated it to address the property value printing https://review.opendev.org/c/openstack/nova/+/880557 | |
| 19:23:06 | sean-k-mooney | i can take a look i need to recall the context | |
| 19:23:38 | sean-k-mooney | oh i see | |
| 19:26:26 | sean-k-mooney | melwitt: wasnt the command orgianly nova-manage property show <vm_uuid> hw_vif_multiqueue_enabled | |
| 19:26:34 | sean-k-mooney | will we break anyoen if we fix this | |
| 19:26:47 | sean-k-mooney | and make it nova-manage image_property show <vm_uuid> hw_vif_multiqueue_enabled | |
| 19:28:43 | sean-k-mooney | i guess the intent was for this to be namespaced under an image_property subparser https://review.opendev.org/c/openstack/nova/+/880557/2/nova/cmd/manage.py#3360 | |
| 19:28:45 | melwitt | sean-k-mooney: looking ... yeah, you're right, sorry 😑 | |
| 19:28:58 | melwitt | let me update my comment and vote | |
| 19:29:32 | sean-k-mooney | well my really question is can we create a repoducer test of some kind to validate the old/new behavior | |
| 19:29:57 | sean-k-mooney | i might be able to check this on my home cloud quickly | |
| 19:30:11 | melwitt | it would take some doing bc we don't currently test the CLI in that manner that exercises these decorators | |
| 19:31:04 | melwitt | I tried briefly a long time ago when I first reviewed this and didn't come up with a good way (and i don't remember what I tried now) | |
| 19:31:57 | sean-k-mooney | so i tought someone submited a docs fix related to this recently | |
| 19:32:39 | melwitt | sean-k-mooney: ok so this isn't changing the subcommand, just the name of the arg. so I don't think it would break anyone? | |
| 19:33:10 | sean-k-mooney | if its just the name of the arg in python then no | |
| 19:33:20 | sean-k-mooney | so really i need to try and test this locally to review it | |
| 19:33:27 | sean-k-mooney | which menas i need a devstack | |
| 19:33:52 | melwitt | I had meant to do dest=image_property and call the arg just "property" because I was trying to avoid nova-manage image_property image_property from an aesthetic perspective | |
| 19:34:45 | sean-k-mooney | ya | |
| 19:34:50 | sean-k-mooney | it should be a postional arg | |
| 19:35:02 | sean-k-mooney | to the show command after the vm uuid | |
| 19:35:16 | melwitt | sean-k-mooney: sorry, I didn't mean for this to be involved. I think you would only need to install nova-manage and not a whole devstack bc the bug happens before anything is done, it's a parsing problem essentially | |
| 19:35:50 | sean-k-mooney | well i have a local copy of nova i can check it out in a venv with tox and see i guess | |
| 19:36:37 | melwitt | it is a positional arg. it's just the name of the arg doesn't match the keyword arg that goes with it. and if it isn't going to match you have to use "dest=whatever" but I messed up and didn't do that | |
| 19:38:12 | sean-k-mooney | i tought etavar='<image_property>', was ment to be the name of the variable | |
| 19:38:22 | sean-k-mooney | but i have not looked at the argpars docs in a while | |
| 19:38:37 | melwitt | I might have spaced and thought so too but it isn't, that's just for what it shows in the usage or help | |
| 19:39:17 | melwitt | dest= is what names the variable and if you omit dest= it will use the name of the positional arg | |
| 19:39:31 | melwitt | and property != image_property | |
| 19:40:39 | melwitt | so it either needs to be @args(property, dest=image_property, ...) or @args(image_property, ...) I think | |
| 19:42:59 | sean-k-mooney | ok so i can confim without hte patch i get the error and with it it fixes it and i get an sql error | |
| 19:43:13 | sean-k-mooney | but that just becasue i dont have a nova.conf with any real data for it to use | |
| 19:43:26 | melwitt | right | |
| 19:48:22 | sean-k-mooney | ok its on its way | |
| 19:49:00 | melwitt | thanks, sorry for the confusion | |
| 19:49:46 | sean-k-mooney | its ok | |
| 19:50:03 | sean-k-mooney | so this is something we should proably add test coverage for in the functional tests at some point | |
| 19:50:20 | sean-k-mooney | i.e. invoke nova manage in such a way that we test hte paring logic | |
| 19:50:34 | sean-k-mooney | i think that is doable but its not reasonable to ask for that in this case | |
| 19:50:50 | sean-k-mooney | failing that we coudl test this in the tempest jobs at some point | |
| 19:50:56 | melwitt | yeah.. I couldn't come up with a way other than process exec or something like that, but I could just be missing something obvious | |
| 19:51:31 | sean-k-mooney | process exec woudl work in a tempest type jobs that is kind fo what the openstck client devstack job does | |
| 19:51:48 | sean-k-mooney | but i think we can import the nova manage parser and just give it a string | |
| 19:52:38 | melwitt | agree it's ok in tempest, but for func tests, I would have thought to avoid that. but I dunno | |
| 19:53:00 | sean-k-mooney | like this is the nova manage main function | |
| 19:53:24 | sean-k-mooney | we call config.parse_args(sys.argv) to pars the cli opt | |
| 19:53:39 | sean-k-mooney | we cab just pass an arry of stings to that | |
| 19:54:06 | sean-k-mooney | like we can mock sys.arg an then call main | |
| 19:54:11 | melwitt | ok, I guess I was just being dumb then 😛 what you're saying makes sense | |
| 19:54:12 | sean-k-mooney | form a functional test | |
| 19:54:39 | sean-k-mooney | the tricky part woudl be jsut makeing sure we have the dbfixture extra in place to make it work | |