| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-03-08 | |||
| 17:36:08 | dansmith | with just user tools | |
| 17:36:15 | dansmith | or without downloading, unkeying and re-uploading the image | |
| 17:36:52 | melwitt | no, the default is check the flavor and image and if either one says encryption=true, the disks get encrypted | |
| 17:37:38 | melwitt | if one says encryption=true and the other says encryption=false, that is invalid and the api should reject it | |
| 17:38:16 | dansmith | sure, but as a user, the flavor is the tool I'm given to control what the target environment looks like.. it's definitely confusing and grey with some stuff in both places for sure | |
| 17:38:44 | dansmith | I'm just saying, I expected to be able to break out of the loop without having to download and unkey the image myself | |
| 17:38:51 | melwitt | I am expecting to add the microversion for the snapshot api stuff btw, I put it in the spec reproposal. so there will be that | |
| 17:39:35 | dansmith | yep, that will help for sure, but means I have to snapshot to get through | |
| 17:39:39 | dansmith | so, I was just thinking: | |
| 17:39:50 | dansmith | wait, let me pull up the image meta patch | |
| 17:40:10 | melwitt | yeah, I guess .. I'm not sure how nova would know what to do if flavor and image can request it and image requests it. how could it know you want unencrypted | |
| 17:41:18 | dansmith | okay, so I wasn't thinking about that true/false flag since it's not actually added by this series, but does that mean if I snapshot to encrypted image, | |
| 17:41:58 | dansmith | leave the secret_uuid in place, but set hw_empheral_encryption=False, then I can boot from that image and get a non-encrypted root disk (backed by the encrypted image) ? | |
| 17:42:06 | melwitt | ah, yeah. it was much earlier on in the series. I think it was even before I started working on it | |
| 17:42:10 | dansmith | I was thinking you were just keying off the presence of the secret | |
| 17:44:15 | melwitt | yeah I was thinking that. but I'm not sure if it will handle it correctly. well, actually I think it will complain because of what we talked about earlier, if hw_ephemeral_encryption_secret_uuid is present then we require hw_ephemeral_encryption_format. and I think I also added that it require hw_ephemeral_encryption too in that case. so I may need to change that to make it take the encrypted image => unencrypted disks | |
| 17:45:58 | dansmith | this is sort of my complaint about using hw_ for all this oo, | |
| 17:46:13 | dansmith | because the secret uuid is not anything to do with hw, or the resulting vm, it's purely an attribute of the image | |
| 17:46:18 | dansmith | as is kinda luks as well | |
| 17:47:10 | dansmith | but it seems to me that we should use the boolean flag to control whether or not you actually get an encrypted disk on your instance (which I think is why it was added originally) and the others to say "if so, this is how" and they also apply to the image in terms of "here is how you should interpret the data inside here" | |
| 17:47:12 | melwitt | yeah. I have thought similar that the secret uuid in the image property can/should be able to stand alone | |
| 17:47:26 | dansmith | tbh, glance should have been extended with a luks disk_format instead of what's going on here, but... | |
| 17:47:34 | dansmith | yeah | |
| 17:52:07 | dansmith | yeah, setting that =false doesn't change anything.. still works, boots, but is encrypted | |
| 17:52:44 | melwitt | ok, good to know. I can change it to make it do the thing in that case | |
| 17:53:07 | dansmith | okay cool I think that'd be good so I (as a user) has an out | |
| 17:53:52 | dansmith | I can see an operator not wanting to allow you to exfiltrate an image that way, but there are a hundred other ways to do it and I think that if we rely on the image property there that they can use the image property permissions to block changes to it | |
| 17:56:05 | melwitt | ack | |
| 20:20:48 | JayF | bauzas: if you want to give a bullet point to the ironic driver in cycle highlights, I'm happy to draft a thing for you. Just let me know. If you want to do it, I'd highlight the SDK migration in addition to sharding :) | |
| 22:03:19 | artom | Whoever thought that making the compute_rpcapi.rollback_live_migration_at_destination() a conditional *from the source* deserves... bad things. | |
| 22:05:25 | artom | Although apparently it's safe to add conditions, since vpmem and mdevs has been added | |
| 23:05:59 | opendevreview | Artom Lifshitz proposed openstack/nova master: Add cpuset_reserved helper to instance NUMA topology https://review.opendev.org/c/openstack/nova/+/910020 | |
| 23:06:00 | opendevreview | Artom Lifshitz proposed openstack/nova master: Power on cores for isolated emulator threads https://review.opendev.org/c/openstack/nova/+/909795 | |
| 23:06:00 | opendevreview | Artom Lifshitz proposed openstack/nova master: Reproducer for not powering on isolated emulator threads cores https://review.opendev.org/c/openstack/nova/+/910021 | |
| 23:06:01 | opendevreview | Artom Lifshitz proposed openstack/nova master: pwr mgmt: handle live migrations correctly https://review.opendev.org/c/openstack/nova/+/909806 | |
| 23:06:01 | opendevreview | Artom Lifshitz proposed openstack/nova master: Reproducer test for live migration with power management https://review.opendev.org/c/openstack/nova/+/910022 | |
| 23:06:02 | opendevreview | Artom Lifshitz proposed openstack/nova master: pwr mgmt: make API into a per-driver object https://review.opendev.org/c/openstack/nova/+/912320 | |
| #openstack-nova - 2024-03-09 | |||
| 01:40:00 | opendevreview | Artom Lifshitz proposed openstack/nova master: Add cpuset_reserved helper to instance NUMA topology https://review.opendev.org/c/openstack/nova/+/910020 | |
| 01:40:01 | opendevreview | Artom Lifshitz proposed openstack/nova master: Power on cores for isolated emulator threads https://review.opendev.org/c/openstack/nova/+/909795 | |
| 01:40:01 | opendevreview | Artom Lifshitz proposed openstack/nova master: Reproducer for not powering on isolated emulator threads cores https://review.opendev.org/c/openstack/nova/+/910021 | |
| 01:40:02 | opendevreview | Artom Lifshitz proposed openstack/nova master: Reproducer test for live migration with power management https://review.opendev.org/c/openstack/nova/+/910022 | |
| 01:40:02 | opendevreview | Artom Lifshitz proposed openstack/nova master: pwr mgmt: make API into a per-driver object https://review.opendev.org/c/openstack/nova/+/912320 | |
| 01:40:03 | opendevreview | Artom Lifshitz proposed openstack/nova master: pwr mgmt: handle live migrations correctly https://review.opendev.org/c/openstack/nova/+/909806 | |
| 03:37:28 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Create persistent mdevs https://review.opendev.org/c/openstack/nova/+/910041 | |
| 05:27:03 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Create persistent mdevs https://review.opendev.org/c/openstack/nova/+/910041 | |
| 09:34:08 | opendevreview | Vasyl Saienko proposed openstack/nova master: Fix calling nova-manage image_property get|set https://review.opendev.org/c/openstack/nova/+/912329 | |
| 09:34:29 | opendevreview | Vasyl Saienko proposed openstack/nova master: Fix calling nova-manage image_property get|set https://review.opendev.org/c/openstack/nova/+/912329 | |
| 10:05:56 | opendevreview | Vasyl Saienko proposed openstack/nova master: Fix calling nova-manage image_property show https://review.opendev.org/c/openstack/nova/+/912329 | |
| 11:30:04 | opendevreview | Pavlo Shchelokovskyy proposed openstack/nova master: Fix nova-manage image_property show unexpected keyword https://review.opendev.org/c/openstack/nova/+/880557 | |
| #openstack-nova - 2024-03-11 | |||
| 12:07:57 | artom_ | sean-k-mooney, bauzas, gibi, I updated my stack to fix libvirt CPU power management: https://review.opendev.org/c/openstack/nova/+/909806 | |
| 12:08:28 | artom_ | Uggla will also need to update his patch at https://review.opendev.org/c/openstack/nova/+/877773, as it's also necessary | |
| 12:57:20 | gibi | artom_: nice patches. I have one question about test coverage in the last one | |
| 13:39:01 | Uggla | artom_, I'll do that ASAP. | |
| 14:20:47 | opendevreview | Merged openstack/nova master: Reproducers for bug 1869804 https://review.opendev.org/c/openstack/nova/+/877772 | |
| 15:53:04 | opendevreview | Merged openstack/nova master: Add cpuset_reserved helper to instance NUMA topology https://review.opendev.org/c/openstack/nova/+/910020 | |
| 15:53:12 | opendevreview | Merged openstack/nova master: Reproducer for not powering on isolated emulator threads cores https://review.opendev.org/c/openstack/nova/+/910021 | |
| 16:55:05 | opendevreview | Gaudenz Steinlin proposed openstack/nova master: Fix attaching port with different port security https://review.opendev.org/c/openstack/nova/+/912478 | |
| 18:24:37 | opendevreview | Artom Lifshitz proposed openstack/nova master: pwr mgmt: handle live migrations correctly https://review.opendev.org/c/openstack/nova/+/909806 | |
| 18:24:37 | opendevreview | Artom Lifshitz proposed openstack/nova master: Reproducer test for live migration with power management https://review.opendev.org/c/openstack/nova/+/910022 | |
| #openstack-nova - 2024-03-12 | |||
| 02:51:46 | opendevreview | Youngjun Yoo proposed openstack/nova master: refectory: simplifying if condition expressions https://review.opendev.org/c/openstack/nova/+/912502 | |
| 06:10:48 | opendevreview | Amit Uniyal proposed openstack/nova stable/2023.2: Disconnecting volume from the compute host https://review.opendev.org/c/openstack/nova/+/911396 | |
| 08:34:27 | opendevreview | Amit Uniyal proposed openstack/nova stable/2023.1: Added context manager for instance lock https://review.opendev.org/c/openstack/nova/+/912511 | |
| 08:34:28 | opendevreview | Amit Uniyal proposed openstack/nova stable/2023.1: Separate OSError with ValueError https://review.opendev.org/c/openstack/nova/+/912512 | |
| 08:34:29 | opendevreview | Amit Uniyal proposed openstack/nova stable/2023.1: Disconnecting volume from the compute host https://review.opendev.org/c/openstack/nova/+/912513 | |
| 10:08:48 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | |
| 10:08:48 | opendevreview | ribaudr proposed openstack/nova master: Amend ShareMappingStatus due to asynchronous call https://review.opendev.org/c/openstack/nova/+/908864 | |
| 10:08:49 | opendevreview | ribaudr proposed openstack/nova master: Mounting the shares as part of the initialization process https://review.opendev.org/c/openstack/nova/+/880075 | |
| 10:08:49 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part) https://review.opendev.org/c/openstack/nova/+/833090 | |
| 10:08:50 | opendevreview | ribaudr proposed openstack/nova master: Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | |
| 10:08:50 | opendevreview | ribaudr proposed openstack/nova master: Deletion of associated share mappings on instance deletion https://review.opendev.org/c/openstack/nova/+/881472 | |
| 10:08:51 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to reboot method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/854823 | |
| 10:08:52 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to resume method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/860284 | |
| 10:08:52 | opendevreview | ribaudr proposed openstack/nova master: Support rebooting an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/854824 | |
| 10:08:54 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to rescue/unrescue shares https://review.opendev.org/c/openstack/nova/+/860286 | |
| 10:08:54 | opendevreview | ribaudr proposed openstack/nova master: Support resuming an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/860285 | |
| 10:08:56 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/860288 | |
| 10:08:56 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (driver part) https://review.opendev.org/c/openstack/nova/+/860287 | |
| 10:08:58 | opendevreview | ribaudr proposed openstack/nova master: Check shares support (compute manager) https://review.opendev.org/c/openstack/nova/+/885751 | |
| 10:08:58 | opendevreview | ribaudr proposed openstack/nova master: Allow to mount manila share using Cephfs protocol https://review.opendev.org/c/openstack/nova/+/883862 | |
| 10:09:00 | opendevreview | ribaudr proposed openstack/nova master: Check shares support (only API exception) https://review.opendev.org/c/openstack/nova/+/885752 | |
| 10:09:00 | opendevreview | ribaudr proposed openstack/nova master: Add share lock/unlock and restrict visibility https://review.opendev.org/c/openstack/nova/+/890340 | |
| 10:09:02 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/885753 | |
| 10:09:02 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (API) https://review.opendev.org/c/openstack/nova/+/836830 | |
| 10:09:04 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028 | |
| 10:09:04 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | |
| 10:09:06 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach_error notification https://review.opendev.org/c/openstack/nova/+/860282 | |
| 10:09:06 | opendevreview | ribaudr proposed openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029 | |
| 10:09:08 | opendevreview | ribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working. https://review.opendev.org/c/openstack/nova/+/852086 | |
| 10:09:08 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach_error notification https://review.opendev.org/c/openstack/nova/+/860283 | |
| 10:09:10 | opendevreview | ribaudr proposed openstack/nova master: Docs about Manila shares API usage https://review.opendev.org/c/openstack/nova/+/871642 | |
| 10:09:10 | opendevreview | ribaudr proposed openstack/nova master: Add virt/libvirt error test cases https://review.opendev.org/c/openstack/nova/+/852087 | |
| 10:09:12 | opendevreview | ribaudr proposed openstack/nova master: Amend DB model add a unique constraint. https://review.opendev.org/c/openstack/nova/+/912518 | |
| 13:58:12 | opendevreview | ribaudr proposed openstack/nova master: Fix: Live migrating to a host with cpu_shared_set configured will now update the VM's configuration accordingly. https://review.opendev.org/c/openstack/nova/+/903706 | |
| 13:58:12 | opendevreview | ribaudr proposed openstack/nova master: Fix [backport]: Live migrating to a host with cpu_shared_set configured will now update the VM's configuration accordingly. https://review.opendev.org/c/openstack/nova/+/877773 | |
| 15:34:39 | fwiesel | Hi, regarding the bug report (https://bugs.launchpad.net/nova/+bug/2055700) (ServerActionsV293TestJSON.test_rebuild_volume_backed_server). I think, I do now why I get the exception. What I don't know is, how that is ever suppose to work with other hypervisors. | |
| 15:36:21 | fwiesel | ComputeManager._rebuild_default_impl is calling driver.destroy on the instance, and *then* calls a volume detach. That raises an InstanceNotFound in the vmwareapi driver, and I don't know how it should not. | |
| 15:37:04 | fwiesel | Here is the destroy: https://opendev.org/openstack/nova/src/branch/master/nova/compute/manager.py#L3695-L3701 | |
| 15:37:35 | fwiesel | Then the call to _rebuild_volume_backed_instance (https://opendev.org/openstack/nova/src/branch/master/nova/compute/manager.py#L3714-L3715) | |
| 15:38:12 | fwiesel | Which in turn calls _detach_root_volume (https://opendev.org/openstack/nova/src/branch/master/nova/compute/manager.py#L3591) | |
| 15:38:55 | fwiesel | And that unsurprisingly calls driver.detach_volume (https://opendev.org/openstack/nova/src/branch/master/nova/compute/manager.py#L3556-L3557) | |