| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-02-29 | |||
| 11:35:09 | sean-k-mooney | just remove all the other sections | |
| 11:35:43 | sean-k-mooney | stephenfin: we normally do bump them | |
| 11:36:00 | sean-k-mooney | and you need compat code to remove the new values when backleveling | |
| 11:36:03 | stephenfin | yeah that's my thinking. It's pretty unusual not to | |
| 11:36:25 | stephenfin | as I said in the review, if there's a good reason not then it should be noted in the commit message | |
| 11:36:27 | sean-k-mooney | if we look at the video model | |
| 11:36:37 | sean-k-mooney | that is proably the closest example to the compat code | |
| 11:37:26 | sean-k-mooney | https://github.com/openstack/nova/commit/35a591d33d8b1a6c30bf40ddc48a07715fd87339 | |
| 11:37:30 | sean-k-mooney | Uggla: ^ | |
| 11:38:39 | sean-k-mooney | adding new enum fields to the VideoModel enum required an object bump for the image metadata object and backleveling code | |
| 11:38:45 | sean-k-mooney | so you woudl need that for attaching too | |
| 11:42:54 | opendevreview | Steven Blatzheim proposed openstack/nova master: Fix nova-metadata-api for ovn dhcp native networks https://review.opendev.org/c/openstack/nova/+/910466 | |
| 11:43:27 | sean-k-mooney | stblatzheim: did you forget a git add ^ | |
| 11:43:27 | stblatzheim | sean-k-mooney: Thank you, I just uploaded the release file | |
| 11:44:00 | opendevreview | Steven Blatzheim proposed openstack/nova master: Fix nova-metadata-api for ovn dhcp native networks https://review.opendev.org/c/openstack/nova/+/910466 | |
| 11:44:16 | sean-k-mooney | :) | |
| 11:44:18 | stblatzheim | Sorry, my fault :D | |
| 11:45:42 | sean-k-mooney | stephenfin: while your here ^ nice quick review for you if you have time | |
| 11:54:10 | sean-k-mooney | bauzas: are you around | |
| 11:54:41 | bauzas | yup | |
| 11:54:56 | sean-k-mooney | can we chat about the ironic shards work | |
| 11:55:18 | sean-k-mooney | basically im wondering are you ok to proceed with it | |
| 11:56:04 | sean-k-mooney | also the mdev presitance https://review.opendev.org/c/openstack/nova/+/910041 im not sure i have time to review that today | |
| 11:56:11 | opendevreview | Merged openstack/nova master: libvirt: Configure and teardown ephemeral encryption secrets https://review.opendev.org/c/openstack/nova/+/826754 | |
| 11:56:40 | sean-k-mooney | so i assume the mdev persistnace will go to D since mel has a -w on it | |
| 11:57:25 | bauzas | sure | |
| 12:05:37 | stephenfin | sean-k-mooney: your opinion is requested on https://review.opendev.org/c/openstack/nova/+/833090/43/nova/compute/api.py | |
| 12:06:22 | sean-k-mooney | bauzas: is that sure your goign t | |
| 12:06:40 | sean-k-mooney | to review them or... | |
| 12:08:19 | bauzas | ok, I need to go to lunch but I'll look at it | |
| 12:09:04 | sean-k-mooney | stephenfin: ya i chatted to gibi about it a little. he pointed out that the attachment is actully done in the api | |
| 12:09:47 | opendevreview | Steven Blatzheim proposed openstack/nova master: Fix nova-metadata-api for ovn dhcp native networks https://review.opendev.org/c/openstack/nova/+/910466 | |
| 12:09:53 | sean-k-mooney | stephenfin: he was ok with using attachment to future proof the name | |
| 12:10:12 | sean-k-mooney | but right now its acutly doing the manilla export | |
| 12:13:22 | opendevreview | Steven Blatzheim proposed openstack/nova master: Fix nova-metadata-api for ovn dhcp native networks https://review.opendev.org/c/openstack/nova/+/910466 | |
| 12:20:33 | opendevreview | Stephen Finucane proposed openstack/nova master: docs: Further clarifications to the SG doc https://review.opendev.org/c/openstack/nova/+/903675 | |
| 12:21:19 | stephenfin | melwitt: Respun that small SG docs patch again ^ Sorry for the delay: I missed your response. Would appreciate a (re-)review when you can 🙏 | |
| 12:24:09 | sean-k-mooney | stephenfin: i am +2 on it i think the changes are a nice improvement | |
| 12:24:19 | stephenfin | ty | |
| 12:24:23 | sean-k-mooney | espically the metadata one | |
| 12:25:13 | sean-k-mooney | i actully think that might depend on the driver tha tis used on teh neutron side | |
| 12:25:18 | sean-k-mooney | but its good to have a note | |
| 12:25:42 | sean-k-mooney | neutorn has some default ruels that are alwasy applike like allowing arp and dhcp i belive | |
| 12:26:10 | sean-k-mooney | but i also think ml2/ovs and ml2/ovn differ on what is always allwoed | |
| 12:30:41 | sean-k-mooney | stephenfin: this is what i was thinking of https://github.com/openstack/neutron/blob/12ed429e7b41c7f1ce0901fdc4215216a80b9374/neutron/plugins/ml2/drivers/openvswitch/agent/openflow/native/br_int.py#L68-L69 | |
| 12:31:03 | sean-k-mooney | so if the subnet has dhcp it opens dhcp automatically | |
| 12:31:27 | sean-k-mooney | but it doe s not do that for metadata | |
| 12:32:11 | sean-k-mooney | whihc is why we need the note you added for metadata but not for dhcp | |
| 12:33:50 | stblatzheim | In ovn context there needs to be a SG for DHCP and metadata if i remember well. We scame across this behavior when we built a new cloud with ovn. | |
| 12:36:20 | stblatzheim | I think there was also a difference between geneve networks and native_vlan networks. | |
| 13:32:20 | Uggla | sean-k-mooney, stephenfin ok I'have seen your comments. I'll update the version. | |
| 13:33:29 | Uggla | sean-k-mooney, stephenfin, thx for explanation | |
| 13:57:37 | opendevreview | Fabian Wiesel proposed openstack/nova master: Vmware: Remove uuid parameter from get_vmdk_info call https://review.opendev.org/c/openstack/nova/+/910627 | |
| 14:10:15 | opendevreview | Fabian Wiesel proposed openstack/nova master: Vmware: Remove uuid parameter from get_vmdk_info call https://review.opendev.org/c/openstack/nova/+/910627 | |
| 14:20:40 | opendevreview | Takashi Kajinami proposed openstack/nova master: SEV: Add TODO note about iommu setting done in recent QEMU https://review.opendev.org/c/openstack/nova/+/909635 | |
| 14:27:09 | opendevreview | Merged openstack/nova master: Added context manager for instance lock https://review.opendev.org/c/openstack/nova/+/873648 | |
| 14:27:16 | opendevreview | Merged openstack/nova master: Separate OSError with ValueError https://review.opendev.org/c/openstack/nova/+/908825 | |
| 15:54:10 | opendevreview | Merged openstack/nova master: HyperV: Remove extra specs of HyperV driver https://review.opendev.org/c/openstack/nova/+/906992 | |
| 16:14:40 | opendevreview | melanie witt proposed openstack/nova master: Support create with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870932 | |
| 16:16:19 | opendevreview | melanie witt proposed openstack/nova master: Support live migration with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/905512 | |
| 16:16:19 | opendevreview | melanie witt proposed openstack/nova master: Support (resize|cold migration) with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870933 | |
| 16:16:20 | opendevreview | melanie witt proposed openstack/nova master: Support rescue with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/873675 | |
| 16:16:20 | opendevreview | melanie witt proposed openstack/nova master: Support rebuild with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870939 | |
| 16:16:21 | opendevreview | melanie witt proposed openstack/nova master: Support snapshot with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870937 | |
| 16:16:21 | opendevreview | melanie witt proposed openstack/nova master: Add encryption support to qemu-img rebase https://review.opendev.org/c/openstack/nova/+/870936 | |
| 16:16:22 | opendevreview | melanie witt proposed openstack/nova master: Support encrypted backing files for qcow2 https://review.opendev.org/c/openstack/nova/+/907961 | |
| 16:16:22 | opendevreview | melanie witt proposed openstack/nova master: Add backing_encryption_secret_uuid to BlockDeviceMapping https://review.opendev.org/c/openstack/nova/+/907960 | |
| 16:16:23 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for raw with LUKS https://review.opendev.org/c/openstack/nova/+/884313 | |
| 16:16:23 | opendevreview | melanie witt proposed openstack/nova master: Support cross cell resize with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/909595 | |
| 16:16:25 | opendevreview | melanie witt proposed openstack/nova master: Report ephemeral disk encryption in the metadata API https://review.opendev.org/c/openstack/nova/+/909945 | |
| 16:16:25 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for rbd with LUKS https://review.opendev.org/c/openstack/nova/+/889912 | |
| 16:16:27 | opendevreview | melanie witt proposed openstack/nova master: Documentation for ephemeral encryption https://review.opendev.org/c/openstack/nova/+/910034 | |
| 16:16:27 | opendevreview | melanie witt proposed openstack/nova master: Deprecate legacy ephemeral storage encryption using dm-crypt https://review.opendev.org/c/openstack/nova/+/909947 | |
| 17:03:23 | opendevreview | Merged openstack/nova master: docs: Further clarifications to the SG doc https://review.opendev.org/c/openstack/nova/+/903675 | |
| 17:05:43 | melwitt | dansmith, sean-k-mooney: just to be clear, the patch where stuff starts actually happening is the "support create" patch, so if the intention is not to put that out there without the rest of the series, it shouldn't be merged this cycle | |
| 17:06:03 | dansmith | melwitt: yeah that's what I was intending to say | |
| 17:06:20 | melwitt | ack | |
| 17:14:35 | sean-k-mooney | ack works for me | |
| 17:53:49 | bauzas | that blueprint needs a core swing for being accepted, gave my blessing already https://review.opendev.org/c/openstack/nova/+/904568 | |
| 18:46:24 | opendevreview | Merged openstack/nova master: Limit nodes by ironic shard key https://review.opendev.org/c/openstack/nova/+/903915 | |
| 18:46:34 | opendevreview | Merged openstack/nova master: Add nova-manage ironic-compute-node-move https://review.opendev.org/c/openstack/nova/+/903916 | |
| 18:48:28 | opendevreview | Merged openstack/nova master: Make compute node rebalance safer https://review.opendev.org/c/openstack/nova/+/903917 | |
| 19:07:01 | gmann | bauzas: sean-k-mooney: as you were reviewing the TC 2024.2 testing runtime, I pushed the new version for possibility of adding ubuntu 24.02 testing after release, please review and add your feedback/vote https://review.opendev.org/c/openstack/governance/+/908862 | |
| 19:14:06 | sean-k-mooney | ack py3.12 is what im most interested in but moving to 24.04 when its relatead woudl be nice too | |
| 19:14:17 | sean-k-mooney | even if its only for tox py3.12 jobs initally | |
| 19:15:35 | sean-k-mooney | gmann: my only real request woudl be to add py3.12 as best effort too | |
| 19:16:14 | sean-k-mooney | for nova i would like to add a tox job or perhaps a periodic-weekly tempest job | |
| 19:16:36 | JayF | I think it's misleading to say best effort for python 3.12 | |
| 19:16:47 | sean-k-mooney | well i wanted to say required | |
| 19:16:51 | JayF | when we know there are projects that won't work with python 3.12, or at least, will lose some features | |
| 19:16:52 | sean-k-mooney | but other pushed back | |
| 19:16:56 | JayF | (oslo_service.sslutils) | |
| 19:17:02 | JayF | I assume you read my comment about that? | |
| 19:17:10 | gmann | sean-k-mooney: my main concern is we do not know how much it is failing and before adding it as nv or so it is confusing to say this as 'bets effort' | |
| 19:17:18 | sean-k-mooney | how are canonical dealing with that in ubuntu 24.04 | |
| 19:17:42 | sean-k-mooney | like they are releaseign caracal on 3.12 on ubuntu 24.04 | |
| 19:17:55 | JayF | sean-k-mooney: I have no idea whatsoever. I just know this eventlet stuff was swept under the rug repeatedly and we idnd't take real action to address it | |
| 19:18:00 | sean-k-mooney | so either those feature are not imporant to them or they hae worked around it | |
| 19:18:13 | dansmith | JayF: I really don't understand the sslutils thing so I must be missing something.. they moved to wrapping the context instead of the socket, right? there's some other issue? | |
| 19:18:14 | gmann | adding 24.04 is a good signal to know how much it fail | |