| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-01-11 | |||
| 20:35:27 | JayF | sean-k-mooney: that I think is going to be an attractive pattern that may lead to more pain than it's worth, based on my understanding many of the eventlet bugs in python3.11/3.12 which are just ... unfixable by design are mostly at the edges of stdlib interacting with monkey patched bits of code | |
| 20:35:39 | JayF | OK good, hopefully that means you'll avoid the sharpest edges | |
| 20:35:41 | sean-k-mooney | so in my case it depens on what direcotry the console cript is defiend in | |
| 20:35:50 | sean-k-mooney | if its under nova.cmd its monky patched | |
| 20:35:56 | sean-k-mooney | if its under nova.bin its not | |
| 20:36:13 | JayF | but there's never a case, as conjectured above, where say, queue would be std lib but threading would be eventlet? | |
| 20:36:33 | sean-k-mooney | not unless i screwed up | |
| 20:36:51 | sean-k-mooney | so the nova api in my serise can be patch or unpatched | |
| 20:36:59 | sean-k-mooney | if run via the wsgi script its unpatched | |
| 20:37:11 | JayF | okay cool, in that case my hypothesis is invalid and unlikely to be happening | |
| 20:37:11 | sean-k-mooney | if run via nova.cmd.nova-api it is | |
| 20:37:20 | JayF | and I'd suggest potentially even enforcing that if possible | |
| 20:37:25 | sean-k-mooney | but within any binary its one of the otehr | |
| 20:38:07 | JayF | Do you mind a quick topic change? | |
| 20:38:21 | sean-k-mooney | sure but i need to leave in a few | |
| 20:38:25 | sean-k-mooney | whats on your mind | |
| 20:38:27 | JayF | Just curious for ironic-guest-metadata, would you mind doing the piece of that work of splitting out the libvirt code to the common compute driver? | |
| 20:38:44 | JayF | I'd prefer not operate in a portion of the nova codebase outside of the ironic driver codepath, just based on familiarity | |
| 20:39:00 | JayF | but I can if you are too busy helping save the world from eventlet (a project which I too am invested in) | |
| 20:39:18 | sean-k-mooney | hum i might be able to ill have to see if i have time but should nbot be terrible complex | |
| 20:39:42 | sean-k-mooney | ask me again next week and ill see if i can help | |
| 20:40:16 | sean-k-mooney | i need to make some progress on the healtcheck stuff but im hoping to spend most of the next 4-5 weeks until codefreeze mainaly on upstream nova stuff | |
| 20:41:19 | sean-k-mooney | JayF: the eventlet stuff is just somethign im looking at in my personal time | |
| 20:41:58 | sean-k-mooney | so im not goign to be spending that much time looking at it untill we have some more detailed disucssions in the next ptg | |
| 20:42:34 | sean-k-mooney | i know others have concerse over if moving to asyncio or realtreading is really the right move | |
| 20:48:20 | JayF | Honestly, I joke sometimes that I'm a sysadmin who pretends to be a developer, but what that means in reality is for stuff like "should we use asyncio or $other?" type discussions, I tend to let folks with stronger opinions and foundational knowledge battle it out :) | |
| 20:48:40 | JayF | my concern is that we use something well maintained, with reasonable patterns that anyone who works on openstack for the next decade will be able to follow | |
| 20:49:39 | JayF | so like, I have zero opinions about how we move; I have lots of opinions that moving is important, and doing it well is important (and as I've mentioned elsewhere, I've gotten a part time developer assigned to OpenStack upstream at GR-OSS, he is onboarding now and will be pointed at eventlet migrations for underresourced openstack projects once we have a migration path set) | |
| 22:22:54 | opendevreview | melanie witt proposed openstack/nova master: DNM test ephemeral encryption + resize: qcow2, raw, rbd https://review.opendev.org/c/openstack/nova/+/862416 | |
| 23:04:10 | opendevreview | melanie witt proposed openstack/nova master: DNM test ephemeral encryption + resize: qcow2, raw, rbd https://review.opendev.org/c/openstack/nova/+/862416 | |
| #openstack-nova - 2024-01-12 | |||
| 03:28:51 | melwitt | sean-k-mooney: a heads up that live migration and cold migrate are broken ... I'm working on it | |
| 04:39:44 | opendevreview | sean mooney proposed openstack/nova master: [WIP] factor out driver instance metadata https://review.opendev.org/c/openstack/nova/+/905406 | |
| 04:46:42 | opendevreview | Amit Uniyal proposed openstack/nova master: Refactor vf profile for PCI device https://review.opendev.org/c/openstack/nova/+/905134 | |
| 04:54:09 | opendevreview | sean mooney proposed openstack/nova master: [WIP] factor out driver instance metadata https://review.opendev.org/c/openstack/nova/+/905406 | |
| 08:48:13 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup setup.py https://review.opendev.org/c/openstack/nova/+/905419 | |
| 09:32:46 | opendevreview | Takashi Kajinami proposed openstack/nova master: Remove deprecated [workarounds] enable_numa_live_migration https://review.opendev.org/c/openstack/nova/+/905426 | |
| 09:34:30 | opendevreview | Takashi Kajinami proposed openstack/nova master: Remove deprecated [workarounds] enable_numa_live_migration https://review.opendev.org/c/openstack/nova/+/905426 | |
| 10:46:48 | opendevreview | Sylvain Bauza proposed openstack/nova-specs master: add the blueprint link to the specs https://review.opendev.org/c/openstack/nova-specs/+/905342 | |
| 11:21:32 | sean-k-mooney | JayF: https://review.opendev.org/c/openstack/nova/+/905406 need more unit tests and i shoudl add a follow up to the libvirt dirver to start including the flavor/image properties in the libvirt xml but it should be enouch for you to start working on the ironic part | |
| 12:41:16 | opendevreview | Amit Uniyal proposed openstack/nova stable/2023.2: Refactor vf profile for PCI device https://review.opendev.org/c/openstack/nova/+/905135 | |
| 12:42:45 | opendevreview | Amit Uniyal proposed openstack/nova stable/2023.1: Refactor vf profile for PCI device https://review.opendev.org/c/openstack/nova/+/905137 | |
| 12:43:51 | opendevreview | Amit Uniyal proposed openstack/nova stable/zed: Refactor vf profile for PCI device https://review.opendev.org/c/openstack/nova/+/905138 | |
| 14:06:33 | opendevreview | Amit Uniyal proposed openstack/nova stable/yoga: Refactor vf profile for PCI device https://review.opendev.org/c/openstack/nova/+/905440 | |
| 14:16:42 | opendevreview | Amit Uniyal proposed openstack/nova stable/yoga: Refactor vf profile for PCI device https://review.opendev.org/c/openstack/nova/+/905440 | |
| 14:43:59 | opendevreview | Takashi Kajinami proposed openstack/nova master: Remove deprecated [workarounds] enable_numa_live_migration https://review.opendev.org/c/openstack/nova/+/905426 | |
| 22:44:31 | opendevreview | melanie witt proposed openstack/nova master: WIP Suppport migration with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/905512 | |
| 22:44:31 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for rbd with LUKS https://review.opendev.org/c/openstack/nova/+/889912 | |
| #openstack-nova - 2024-01-13 | |||
| 05:26:44 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Configure and teardown ephemeral encryption secrets https://review.opendev.org/c/openstack/nova/+/826754 | |
| 05:26:45 | opendevreview | melanie witt proposed openstack/nova master: Add encryption support to convert_image https://review.opendev.org/c/openstack/nova/+/870934 | |
| 05:26:45 | opendevreview | melanie witt proposed openstack/nova master: imagebackend: Add support to libvirt_info for LUKS based encryption https://review.opendev.org/c/openstack/nova/+/826755 | |
| 05:26:46 | opendevreview | melanie witt proposed openstack/nova master: Support resize with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870933 | |
| 05:26:46 | opendevreview | melanie witt proposed openstack/nova master: Support create with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870932 | |
| 05:26:47 | opendevreview | melanie witt proposed openstack/nova master: Add encryption support to qemu-img rebase https://review.opendev.org/c/openstack/nova/+/870936 | |
| 05:26:47 | opendevreview | melanie witt proposed openstack/nova master: Add hw_ephemeral_encryption_secret_uuid image property https://review.opendev.org/c/openstack/nova/+/870935 | |
| 05:26:48 | opendevreview | melanie witt proposed openstack/nova master: Support snapshot with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870937 | |
| 05:26:49 | opendevreview | melanie witt proposed openstack/nova master: Support rescue with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/873675 | |
| 05:26:49 | opendevreview | melanie witt proposed openstack/nova master: Support rebuild and unshelve with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/870939 | |
| 05:26:51 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for qcow2 with LUKS https://review.opendev.org/c/openstack/nova/+/772273 | |
| 05:26:51 | opendevreview | melanie witt proposed openstack/nova master: Reject (resize|rebuild) API requests with conflicting encryption https://review.opendev.org/c/openstack/nova/+/904240 | |
| 05:26:53 | opendevreview | melanie witt proposed openstack/nova master: WIP Suppport migration with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/905512 | |
| 05:26:53 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for raw with LUKS https://review.opendev.org/c/openstack/nova/+/884313 | |
| 05:26:55 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for rbd with LUKS https://review.opendev.org/c/openstack/nova/+/889912 | |
| 07:16:57 | opendevreview | Jie Song proposed openstack/nova master: hardware: Fix image_meta.id within get_mem_encryption_constraint https://review.opendev.org/c/openstack/nova/+/904197 | |
| 09:24:36 | opendevreview | Amit Uniyal proposed openstack/nova stable/yoga: Refactor vf profile for PCI device https://review.opendev.org/c/openstack/nova/+/905440 | |
| 10:19:53 | opendevreview | melanie witt proposed openstack/nova master: WIP libvirt: make |
|
| 10:19:53 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for rbd with LUKS https://review.opendev.org/c/openstack/nova/+/889912 | |
| 13:30:19 | opendevreview | Jie Song proposed openstack/nova master: hardware: Fix image_meta.id within get_mem_encryption_constraint https://review.opendev.org/c/openstack/nova/+/904197 | |
| 14:56:03 | opendevreview | Amit Uniyal proposed openstack/nova master: WIP: create bfv snapshot test https://review.opendev.org/c/openstack/nova/+/905517 | |
| 14:56:03 | opendevreview | Amit Uniyal proposed openstack/nova master: Fixes bug 2048184 https://review.opendev.org/c/openstack/nova/+/904817 | |
| 21:16:20 | opendevreview | melanie witt proposed openstack/nova master: DNM test ephemeral encryption + resize: qcow2, raw, rbd https://review.opendev.org/c/openstack/nova/+/862416 | |
| #openstack-nova - 2024-01-14 | |||
| 15:55:59 | opendevreview | Pavlo Shchelokovskyy proposed openstack/nova master: Optionally delete mdev on instance cleanup https://review.opendev.org/c/openstack/nova/+/899407 | |
| 15:57:58 | opendevreview | Pavlo Shchelokovskyy proposed openstack/nova master: Optionally delete mdev on instance cleanup https://review.opendev.org/c/openstack/nova/+/899407 | |
| #openstack-nova - 2024-01-15 | |||
| 07:46:29 | gibi | let me know if there are urgent+important things I should be aware of | |
| 08:17:28 | elodilles | gibi: welcome back o/ maybe a nice clean cherry pick for an easy start? :D o:) https://review.opendev.org/c/openstack/nova/+/904371 | |
| 08:24:10 | gibi | elodilles: thanks. Easy win indeed. Done | |
| 08:24:42 | elodilles | \o/ | |
| 08:24:48 | elodilles | thanks, too | |
| 08:28:48 | gibi | ping me when the next round of backport from that is up | |
| 08:31:16 | elodilles | sure thing :) | |
| 08:58:12 | opendevreview | Merged openstack/nova stable/2023.2: Reproduce bug #2025480 in a functional test https://review.opendev.org/c/openstack/nova/+/904370 | |
| 09:43:57 | bauzas | gibi: want some paperwork change ? sure https://review.opendev.org/c/openstack/nova-specs/+/905342 :p | |
| 09:45:27 | gibi | bauzas: sure. done. | |
| 09:45:33 | bauzas | <3 | |
| 09:58:15 | opendevreview | Merged openstack/nova-specs master: add the blueprint link to the specs https://review.opendev.org/c/openstack/nova-specs/+/905342 | |
| 10:24:07 | opendevreview | Merged openstack/nova stable/2023.2: Do not untrack resources of a server being unshelved https://review.opendev.org/c/openstack/nova/+/904371 | |
| 10:45:44 | gibi | gate seems to be healthy on stable | |
| 10:48:31 | elodilles | gibi: yepp, it looks good \o/ and the 2023.2 version of the backport has merged ;) | |
| 10:49:59 | elodilles | so I've +2'd the patch on 2023.1 | |
| 11:07:01 | gibi | elodilles: lets see how the 2023.1 gate performs :) | |
| 11:09:00 | bauzas | fwiw, back in 2024 finding why we race for https://42ba7385992f85feadcc-7de3ea29d2988c6d3fb53b5f30580c1f.ssl.cf2.rackcdn.com/904177/5/check/nova-tox-functional-py38/b878af0/testr_results.html | |
| 11:09:25 | bauzas | 3 weeks after testing, I don't remember why | |
| 11:26:20 | sean-k-mooney[m] | bauzas: is it because you added the test before https://review.opendev.org/c/openstack/nova/+/904209/4 | |
| 11:30:21 | sean-k-mooney[m] | i also looks like whatever fixture your using to providie the mdevs likely is not taking effect | |
| 12:32:59 | opendevreview | Amit Uniyal proposed openstack/nova master: enforce remote console shutdown https://review.opendev.org/c/openstack/nova/+/901824 | |
| 12:36:42 | opendevreview | Amit Uniyal proposed openstack/nova master: enforce remote console shutdown https://review.opendev.org/c/openstack/nova/+/901824 | |
| 12:46:03 | opendevreview | Merged openstack/nova stable/2023.1: Reproduce bug #2025480 in a functional test https://review.opendev.org/c/openstack/nova/+/904372 | |
| 13:01:33 | opendevreview | Amit Uniyal proposed openstack/nova master: Allow swap resize from non-zero to zero https://review.opendev.org/c/openstack/nova/+/857339 | |
| 13:01:34 | opendevreview | Amit Uniyal proposed openstack/nova master: WIP: temp commit for tests https://review.opendev.org/c/openstack/nova/+/905597 | |
| 13:25:35 | bauzas | sean-k-mooney: nope, sorry but you're wrong, the test works correctly | |
| 13:26:23 | bauzas | I'm running stestr with --until-failure from 2 hours for all functional tests with mdevs, np for the moment | |