| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-01-10 | |||
| 14:04:36 | bauzas | sean-k-mooney: fwiw, even if I agree with the usecase (listing the pinned AZ), I -1d https://review.opendev.org/c/openstack/nova-specs/+/904368 because of the difference between 'I requested a AZ' and 'my instance is pinned' | |
| 14:06:13 | bauzas | ratailor: ^ see my comment above ^ | |
| 14:25:38 | sean-k-mooney | bauzas: responed | |
| 14:25:49 | sean-k-mooney | your not wrong altough i dont entirly agree with all your coments | |
| 14:26:23 | sean-k-mooney | i would not be opposed to the spec if your comment were adressed however | |
| 14:26:54 | sean-k-mooney | you and i are readign requested to have 2 diffent meanings | |
| 14:27:15 | sean-k-mooney | for me an az is requested if the az filed in the request_spec is populated for any reason | |
| 14:27:26 | sean-k-mooney | for you its requested only if it was in the http post | |
| 14:27:43 | sean-k-mooney | thats disconnect between my reading and your reading of the spec | |
| 14:28:33 | noonedeadpunk | I'd actually vote for taking AZ from request_spec regardless of how it's appeared there | |
| 14:28:36 | sean-k-mooney | im ok with using your interperation and updating the spec to reflect that but form the persptice of the schduelr its requested if there is a value in the request spec | |
| 14:28:54 | bauzas | sean-k-mooney: I provided an alternative name for the API field | |
| 14:29:02 | noonedeadpunk | As actually I assume that what matters at the end... | |
| 14:29:05 | bauzas | 'attached_availability_zone' | |
| 14:29:17 | sean-k-mooney | i dont like attached | |
| 14:29:34 | sean-k-mooney | you also sugggested pinned_availablity_zone | |
| 14:29:39 | bauzas | we already have 'cross_az_attach' option, hence my name | |
| 14:29:52 | sean-k-mooney | attach in that context is refering to the volume not the az | |
| 14:30:02 | bauzas | possibly yeah | |
| 14:30:24 | sean-k-mooney | so pinned_aviableity_zone or required_avilablity_zone are all fine | |
| 14:30:31 | bauzas | the fact is that I want my user to understand that the instance is only using this AZ without looking at the api docs | |
| 14:30:50 | sean-k-mooney | noonedeadpunk: form an operator perspective what would you find more intuitive | |
| 14:30:51 | bauzas | I'm not fine with 'requested_az' for the reason I explained | |
| 14:31:17 | sean-k-mooney | right but i actully think that is the most correct form for the reasons i explaied :) | |
| 14:31:27 | bauzas | the fact that neither the operator nor the user could request this instance to be pinned while the instance would still be pinned | |
| 14:31:31 | sean-k-mooney | but i dont really care too much what the field name is | |
| 14:31:47 | sean-k-mooney | bauzas: right but its part of the requst_spec | |
| 14:31:58 | sean-k-mooney | there for the az was requested | |
| 14:32:04 | sean-k-mooney | it does not makter who requeteded it | |
| 14:32:12 | bauzas | sean-k-mooney: well, some enduser doesn't know the internals | |
| 14:32:28 | sean-k-mooney | yep which is why im interested in noonedeadpunk input | |
| 14:32:35 | sean-k-mooney | im fine with using a diffent name | |
| 14:32:51 | bauzas | noonedeadpunk: tell me a better name and I +2 your own spec :p | |
| 14:32:53 | bauzas | (jk) | |
| 14:32:55 | sean-k-mooney | so if you think somethign else is better that is ok with me althoug lets avoid attach | |
| 14:33:14 | sean-k-mooney | bauzas: this is now noonedeadpunk spec | |
| 14:33:19 | sean-k-mooney | theres is the other one | |
| 14:33:22 | bauzas | sean-k-mooney: I'm quite conservative on AZs given it's an enduser param | |
| 14:33:45 | bauzas | and most OVH endusers (for example) don't know a single bit of the nova internals | |
| 14:34:07 | sean-k-mooney | well even those that do disagree on how az should be used | |
| 14:34:10 | bauzas | sean-k-mooney: yeah I know, we're speaking of ratailor's spec | |
| 14:34:18 | sean-k-mooney | i for one have no issue with explcitly requesting the nova az | |
| 14:34:31 | sean-k-mooney | i know why you dont like that | |
| 14:34:39 | sean-k-mooney | but to me that is perfectly valid | |
| 14:34:58 | sean-k-mooney | and i know of cloud that have configured default_schedule_zone=nova | |
| 14:35:15 | sean-k-mooney | thats a tangent | |
| 14:35:22 | bauzas | that's a terrible thing | |
| 14:35:32 | bauzas | and we documented that | |
| 14:35:47 | sean-k-mooney | bauzas: right but horizon default to nova and i belive it always puts it in the request | |
| 14:35:54 | bauzas | NOOOOOOOOOOOOOOOOOOOOOOOOOOO | |
| 14:36:13 | bauzas | are you joking ? | |
| 14:36:17 | sean-k-mooney | i know that horizon use to alwasy require an az in the drop down | |
| 14:36:31 | sean-k-mooney | and if nova was the only one in the list you had no other choice | |
| 14:36:34 | bauzas | that's an horizon bug then | |
| 14:36:42 | sean-k-mooney | one that has been there forever | |
| 14:36:44 | noonedeadpunk | ooopps | |
| 14:36:58 | bauzas | https://docs.openstack.org/nova/latest/admin/availability-zones.html | |
| 14:37:00 | sean-k-mooney | like litrally since i started workin on openstack 10 years ago | |
| 14:37:09 | bauzas | I wrote that in solid red | |
| 14:37:29 | sean-k-mooney | bauzas: ya i know. im just saying that what you expect and how thing are used in the wild dont actully agreee | |
| 14:37:33 | ratailor | sean-k-mooney, bauzas I took that name, because its easy to differentiate for endusers, who don't know anything about nova internals. | |
| 14:37:49 | bauzas | ratailor: read my comments | |
| 14:38:04 | ratailor | bauzas, ack. | |
| 14:38:29 | bauzas | endusers would wonder why their instance has a returned param saying 'requested_az' : "bar" without them asking for it | |
| 14:39:16 | bauzas | sean-k-mooney: sure, I understand people doing wild things are usual, but for those we also say "unsupported" | |
| 14:39:44 | noonedeadpunk | I then have a question towards default_availability_zone that you already discussed some time ago with damiandabrowski. As like in some usecases I see close to no other option rather then define default_availability_zone, for instance when cross_az_attach = False | |
| 14:40:13 | bauzas | ? | |
| 14:40:13 | bauzas | noonedeadpunk: default_schedule_zone you mean . | |
| 14:40:35 | bauzas | https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.default_schedule_zone | |
| 14:40:47 | bauzas | ". The instance(s) will be bound to this availability zone " | |
| 14:41:00 | bauzas | ahah, third alternative name ! "bound_availability_zone" | |
| 14:41:24 | noonedeadpunk | yeah, sorry, default_schedule_zone | |
| 14:41:50 | bauzas | noonedeadpunk: what's your question with this option ? | |
| 14:42:57 | noonedeadpunk | So, when you have multiple AZs, and isolated storage in each AZ (so volumes can't migrate cross-AZ), and user does not provide AZ explicitly - VM will try to move between AZs, since it's not ending up in request_specs | |
| 14:43:03 | noonedeadpunk | unless default_schedule_zone is defined | |
| 14:46:07 | noonedeadpunk | nah, disregard, I already found answer to my "question" :) | |
| 14:46:59 | bauzas | noonedeadpunk: yeah, it depends on cross_az_attach value | |
| 14:47:05 | bauzas | if True, indeed | |
| 14:47:41 | bauzas | if False, nope, we'll automatically change the value of reqspec.az to the volume's az name | |
| 14:47:52 | bauzas | so it will be "pinned" or "bound" | |
| 14:48:11 | bauzas | even if the user "requested" something elsze | |
| 14:48:29 | bauzas | hence my concern on the ratailor's API parameter name | |
| 14:48:58 | bauzas | noonedeadpunk: how much your users know about Nova internals and the fact we have a DB table named "request_specs" ? | |
| 14:49:21 | noonedeadpunk | bauzas: I think it's true only _if_ volume was created first | |
| 14:49:31 | bauzas | the fact is that I don't like ourselves naming a new parameter "requested" if something else but the user changed it | |
| 14:49:39 | noonedeadpunk | bauzas: they don't give a sh*** about it :D | |
| 14:49:46 | bauzas | that's my point | |
| 14:50:29 | noonedeadpunk | Because if volume is being created together with server - reqspec.az is not populated then | |
| 14:50:32 | bauzas | noonedeadpunk: yeah, if you bfv your instance by asking nova to create a volume, then nova asks cinder for a new volume without passing the AZ | |
| 14:50:38 | ykarel | thx sean-k-mooney for your response yesterday re. https://bugs.launchpad.net/nova/+bug/2045785 | |
| 14:51:05 | ykarel | do you have link for the other tempest unfixed issue that you mentioned or link it into the bug ^ | |
| 14:51:14 | bauzas | noonedeadpunk: because (IIRC) we create the volume *before* we schedule | |
| 14:51:22 | ykarel | i will check later if it's same or some other issue | |
| 14:52:15 | noonedeadpunk | bauzas: but shouldn't then it be veeery close to usage of already existing volume? | |
| 14:52:27 | noonedeadpunk | Ie, you should be already be able to check AZ of that volume? | |
| 14:52:52 | bauzas | honestly, I need to remember the details | |
| 14:52:59 | bauzas | I also wrote a functional test for it | |
| 14:53:05 | noonedeadpunk | Yeah, no worries | |
| 14:53:06 | bauzas | so we could test | |
| 14:53:41 | bauzas | noonedeadpunk: you haven't responded to our question about your preference for naming the new parameter that ratailor would provide | |