| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-12-19 | |||
| 17:34:13 | dtantsur | yeah, this ^^^ | |
| 17:34:23 | opendevreview | Sylvain Bauza proposed openstack/nova-specs master: Proposes mdev live-migration support in libvirt https://review.opendev.org/c/openstack/nova-specs/+/900636 | |
| 17:34:41 | bauzas | sean-k-mooney: gibi: updated based on sean-k-mooney's nice improvments | |
| 17:34:49 | JayF | Either way, it's clear the arrows of the "latest" version of the API is that this information is best looked up and kept in nova, if it's not a first class API object in Nova that's guaranteed to be there and/or Ironic is not going to cache the flavor like nova does | |
| 17:35:07 | JayF | this was going to be an easy win; it's not; so punt it and keep the metadata that is the easy wins IMO | |
| 17:35:29 | JayF | our API already has enough places with weird corners, this sounds like an easy place to avoid making another one | |
| 17:35:30 | sean-k-mooney | so looks like it was changed in pike https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id43 so there should be a spec | |
| 17:36:54 | sean-k-mooney | https://specs.openstack.org/openstack/nova-specs/specs/pike/implemented/instance-flavor-api.html#proposed-change it jsut says it could be stale but i kind of think that was a mistake | |
| 17:37:22 | sean-k-mooney | JayF: ack i tought the falvor was the main motavator for this | |
| 17:37:34 | dtantsur | hold on. if a user can specify the uuid, cannot they specify a uuid of an already deleted flavor? | |
| 17:38:02 | JayF | sean-k-mooney: user_id/project_id is the primary motivator, to enable that next-step feature outlined in the blueprint (automatic_lessee) | |
| 17:38:27 | sean-k-mooney | first flavor are admin only. and yes looking at the api they can recreate a flavor wit hteh same id and name | |
| 17:38:46 | sean-k-mooney | JayF: oh ok | |
| 17:38:59 | sean-k-mooney | then sure feel free to exclude flavor or any other filed not useful to you | |
| 17:40:10 | sean-k-mooney | JayF: back to my docs comment we ahve refnece docs that detail some of the internal works of nova https://github.com/openstack/nova/tree/d28a55959e50b472e181809b919e11a896f989e3/doc/source/reference | |
| 17:40:16 | opendevreview | Merged openstack/nova stable/wallaby: db: Resolve additional SAWarning warnings https://review.opendev.org/c/openstack/nova/+/874069 | |
| 17:40:34 | JayF | sean-k-mooney: so you're saying "Ironic <> Nova API interactions" would be a good document for there, potentially | |
| 17:40:41 | JayF | sean-k-mooney: including a section on metadata passed over | |
| 17:40:47 | sean-k-mooney | JayF: they refence section is inteded for developers so i was suggesting adding a instance metadata doc ther that just says this si what ironic uses | |
| 17:41:00 | JayF | sean-k-mooney: even if that's not what you're saying, it's what I'm saying now, because it's a good idea and might make the ironic driver generally less scary | |
| 17:41:20 | sean-k-mooney | yep | |
| 17:41:49 | sean-k-mooney | so im fine fi the details change as part of the impleation as long as we documetn /test the expecte behavior so we know why | |
| 17:41:58 | sean-k-mooney | normally i woudl refer to the spec for those detail of intent | |
| 17:55:59 | opendevreview | Merged openstack/nova stable/2023.1: Allow live migrate paused instance when post copy is enabled https://review.opendev.org/c/openstack/nova/+/903840 | |
| 18:39:54 | sean-k-mooney | bauzas: +2 on https://review.opendev.org/c/openstack/nova-specs/+/900636 gibi if you agree can you +2w | |
| 22:57:07 | opendevreview | Jay Faulkner proposed openstack/nova master: Limit nodes by ironic shard key https://review.opendev.org/c/openstack/nova/+/903915 | |
| 22:57:07 | opendevreview | Jay Faulkner proposed openstack/nova master: [ironic] Partition & use cache for list_instance* https://review.opendev.org/c/openstack/nova/+/900831 | |
| 22:57:08 | opendevreview | Jay Faulkner proposed openstack/nova master: Make compute node rebalance safter https://review.opendev.org/c/openstack/nova/+/903917 | |
| 22:57:08 | opendevreview | Jay Faulkner proposed openstack/nova master: Add nova-manage ironic-compute-node-move https://review.opendev.org/c/openstack/nova/+/903916 | |
| #openstack-nova - 2023-12-20 | |||
| 00:54:10 | opendevreview | Merged openstack/nova-specs master: Enforce console session timeout https://review.opendev.org/c/openstack/nova-specs/+/898553 | |
| 01:45:25 | opendevreview | melanie witt proposed openstack/nova master: WIP Support rescue with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/873675 | |
| 01:45:25 | opendevreview | melanie witt proposed openstack/nova master: Support rebuild and unshelve with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/870939 | |
| 01:45:26 | opendevreview | melanie witt proposed openstack/nova master: WIP libvirt: Introduce support for raw with LUKS https://review.opendev.org/c/openstack/nova/+/884313 | |
| 01:45:26 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for qcow2 with LUKS https://review.opendev.org/c/openstack/nova/+/772273 | |
| 01:45:27 | opendevreview | melanie witt proposed openstack/nova master: WIP libvirt: Introduce support for rbd with LUKS https://review.opendev.org/c/openstack/nova/+/889912 | |
| 01:51:48 | sean-k-mooney[m] | melwitt: im going to sleep now but can you do a full rebase of the ephmeral encyption serise so we can start reviewing and merging the firest couple of patches? i would suggest putting them on top of stephenfin ‘s mypy patch to avoid the merge conflict | |
| 01:52:27 | melwitt | sean-k-mooney[m]: ok, sure | |
| 01:52:35 | sean-k-mooney[m] | https://review.opendev.org/c/openstack/nova/+/884312 need a recheck anyway so might as well just do a rebase of the serise and get fresh results for the seriese | |
| 01:53:12 | melwitt | ++ | |
| 03:42:12 | opendevreview | Artom Lifshitz proposed openstack/nova master: weights debug log: stop using tuples as dict keys https://review.opendev.org/c/openstack/nova/+/904060 | |
| 03:47:47 | opendevreview | Merged openstack/nova master: Remove deprecated [api] use_forwarded_for https://review.opendev.org/c/openstack/nova/+/903339 | |
| 03:47:59 | opendevreview | Merged openstack/nova master: Imported Translations from Zanata https://review.opendev.org/c/openstack/nova/+/903427 | |
| 03:50:38 | opendevreview | Merged openstack/nova master: Reproducer test of bug #1999674 https://review.opendev.org/c/openstack/nova/+/867807 | |
| 05:29:08 | opendevreview | Merged openstack/nova master: docs: fix 404 for ironic docs https://review.opendev.org/c/openstack/nova/+/887643 | |
| 05:43:13 | opendevreview | Merged openstack/nova master: Adds a repoducer for post_live_migration_at_destination failures https://review.opendev.org/c/openstack/nova/+/868088 | |
| 06:23:03 | opendevreview | Artom Lifshitz proposed openstack/nova master: weights debug log: stop using tuples as dict keys https://review.opendev.org/c/openstack/nova/+/904060 | |
| 07:41:33 | opendevreview | liwenjian proposed openstack/nova stable/2023.2: Fixed an error when caching multiple images in aggregate https://review.opendev.org/c/openstack/nova/+/904017 | |
| 07:42:08 | opendevreview | liwenjian proposed openstack/nova stable/2023.1: Fixed an error when caching multiple images in aggregate https://review.opendev.org/c/openstack/nova/+/904018 | |
| 07:44:26 | opendevreview | liwenjian proposed openstack/nova stable/zed: Fixed an error when caching multiple images in aggregate https://review.opendev.org/c/openstack/nova/+/904019 | |
| 07:44:47 | opendevreview | liwenjian proposed openstack/nova stable/yoga: Fixed an error when caching multiple images in aggregate https://review.opendev.org/c/openstack/nova/+/904020 | |
| 07:45:09 | opendevreview | liwenjian proposed openstack/nova stable/xena: Fixed an error when caching multiple images in aggregate https://review.opendev.org/c/openstack/nova/+/904081 | |
| 07:45:36 | opendevreview | liwenjian proposed openstack/nova stable/wallaby: Fixed an error when caching multiple images in aggregate https://review.opendev.org/c/openstack/nova/+/904082 | |
| 07:46:25 | opendevreview | liwenjian proposed openstack/nova stable/victoria: Fixed an error when caching multiple images in aggregate https://review.opendev.org/c/openstack/nova/+/904083 | |
| 07:49:44 | opendevreview | liwenjian proposed openstack/nova stable/victoria: Fixed an error when caching multiple images in aggregate https://review.opendev.org/c/openstack/nova/+/904083 | |
| 07:57:05 | opendevreview | liwenjian proposed openstack/nova stable/ussuri: Fixed an error when caching multiple images in aggregate https://review.opendev.org/c/openstack/nova/+/904084 | |
| 07:59:51 | opendevreview | melanie witt proposed openstack/nova master: block_device: Add encryption attributes to swap disks https://review.opendev.org/c/openstack/nova/+/884312 | |
| 07:59:52 | opendevreview | melanie witt proposed openstack/nova master: imagebackend: Add support to libvirt_info for LUKS based encryption https://review.opendev.org/c/openstack/nova/+/826755 | |
| 07:59:52 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Configure and teardown ephemeral encryption secrets https://review.opendev.org/c/openstack/nova/+/826754 | |
| 07:59:53 | opendevreview | melanie witt proposed openstack/nova master: Support create with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870932 | |
| 07:59:53 | opendevreview | melanie witt proposed openstack/nova master: Add encryption support to convert_image https://review.opendev.org/c/openstack/nova/+/870934 | |
| 07:59:54 | opendevreview | melanie witt proposed openstack/nova master: Add hw_ephemeral_encryption_secret_uuid image property https://review.opendev.org/c/openstack/nova/+/870935 | |
| 07:59:54 | opendevreview | melanie witt proposed openstack/nova master: Support resize with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870933 | |
| 07:59:55 | opendevreview | melanie witt proposed openstack/nova master: Add encryption support to qemu-img rebase https://review.opendev.org/c/openstack/nova/+/870936 | |
| 07:59:56 | opendevreview | melanie witt proposed openstack/nova master: Support rebuild and unshelve with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/870939 | |
| 07:59:56 | opendevreview | melanie witt proposed openstack/nova master: Support snapshot with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870937 | |
| 07:59:58 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for qcow2 with LUKS https://review.opendev.org/c/openstack/nova/+/772273 | |
| 07:59:58 | opendevreview | melanie witt proposed openstack/nova master: Support rescue with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/873675 | |
| 08:00:00 | opendevreview | melanie witt proposed openstack/nova master: WIP libvirt: Introduce support for rbd with LUKS https://review.opendev.org/c/openstack/nova/+/889912 | |
| 08:00:00 | opendevreview | melanie witt proposed openstack/nova master: WIP libvirt: Introduce support for raw with LUKS https://review.opendev.org/c/openstack/nova/+/884313 | |
| 08:01:59 | opendevreview | melanie witt proposed openstack/nova master: DNM test ephemeral encryption + resize: qcow2, raw, rbd https://review.opendev.org/c/openstack/nova/+/862416 | |
| 09:04:52 | opendevreview | Merged openstack/nova master: Call Neutron immediately upon _post_live_migration() start https://review.opendev.org/c/openstack/nova/+/883682 | |
| 10:24:09 | opendevreview | Balazs Gibizer proposed openstack/nova stable/zed: Allow live migrate paused instance when post copy is enabled https://review.opendev.org/c/openstack/nova/+/904085 | |
| 10:37:18 | opendevreview | Merged openstack/nova-specs master: Proposes mdev live-migration support in libvirt https://review.opendev.org/c/openstack/nova-specs/+/900636 | |
| 10:49:57 | bauzas | gibi: thanks for the spec review but actually about how to check the destination compute, I was wrong | |
| 10:50:27 | bauzas | gibi: I just checked and we recreate the migrate-data object in the source by using the latest version | |
| 10:50:41 | bauzas | so target_mdevs field should be here | |
| 10:51:07 | bauzas | so I'll create another field for just telling whether we support | |
| 10:51:25 | bauzas | like https://github.com/openstack/nova/blob/master/nova/objects/migrate_data.py#L270 | |
| 10:54:33 | gibi | addign a field there is OK to me. I guess we don't persist those | |
| 11:08:24 | bauzas | nope indeed | |
| 11:09:10 | bauzas | I'll start to upload the mdev-liv-mig series hopefully today EOB | |
| 11:39:20 | damiandabrowski | Hey! I looked into my issue with VMs that are moved to the other AZs during resize/migrate. | |
| 11:39:28 | damiandabrowski | sean-k-mooney: bauzas Thanks for showing me code responsible for preventing this behavior: https://github.com/openstack/nova/blob/d28a55959e50b472e181809b919e11a896f989e3/nova/compute/api.py#L1205 | |
| 11:39:37 | damiandabrowski | The problem is: this method is executed only when instance is created and due to the _get_volumes_for_bdms behavior, it sets proper request specs only when instance is booted from pre-existing volume. | |
| 11:39:43 | damiandabrowski | But if user creates a VM using CLI and --boot-from-volume argument, the VM does not have AZ assigned in requests specs even though its root volume is associated with a specific AZ. | |
| 11:39:49 | damiandabrowski | Should it be considered as a bug? | |
| 12:34:56 | sean-k-mooney[m] | im not sure it could be fixed as a bug | |
| 12:35:50 | sean-k-mooney[m] | i would have expeced boot from volume form image and boot form prexising volume to have the same behavior | |
| 12:36:24 | sean-k-mooney[m] | i.e. both a boot form voluem but in one instance nova is creating the volume and in the other we are using a user provided volume | |
| 12:37:06 | sean-k-mooney[m] | it is expected that we execute this only once at instance creation | |
| 12:42:04 | sean-k-mooney[m] | i assume the ax is not the default az “nova” | |
| 12:42:05 | sean-k-mooney[m] | https://github.com/openstack/nova/blob/d28a55959e50b472e181809b919e11a896f989e3/nova/compute/api.py#L1333 | |
| 12:44:29 | sean-k-mooney[m] | this code https://github.com/openstack/nova/blob/d28a55959e50b472e181809b919e11a896f989e3/nova/compute/api.py#L1399-L1406 will only work with precreated volumes | |
| 12:45:04 | sean-k-mooney[m] | but i tought there was code later to update the request spec if its bfv form image | |
| 12:47:16 | sean-k-mooney[m] | we would have to do that in the conductor after we have created the volume unless that happens on the computer. fi it does then its too late to update the request spec | |
| 12:49:36 | damiandabrowski | yeah exactly, _get_volumes_for_bdms considers only precreated volumes | |
| 12:50:06 | damiandabrowski | and since bfv from image is problematic on my dev environment and bfv from existing volume works fine, we most likely don't have anything that would update request specs later on :/ | |
| 12:50:19 | damiandabrowski | i can file a bug report today if you don't have anything against it | |
| 12:53:55 | sean-k-mooney[m] | so i think this might be a non bakcportable feature not a bug | |
| 12:54:00 | sean-k-mooney[m] | https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L1646 | |