| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-11-20 | |||
| 15:01:37 | sean-k-mooney | the problem with the filter approch is placmenet may not return hosts that could fit the vm depening on the alocation candate limit | |
| 15:01:57 | sean-k-mooney | i belvie the default limit is 1000 allocation candiates but we may have more then one allcoation candiate per host | |
| 15:02:40 | sean-k-mooney | so even if you have less then 1000 host some hosts that dont have any tennated assocated with them can be filtered out before we hit the schduler filters | |
| 15:03:11 | sean-k-mooney | this is made worse where you limit the reustls. cern limit placment ot less then 20 allcoation candiates | |
| 15:03:54 | sean-k-mooney | in such a case it very likely that all 20 hosts would be exclude by the filter even if you have many hosts with capsity | |
| 15:04:02 | sean-k-mooney | that woudl other wise be valid | |
| 15:05:20 | sahid | this limittation is valable for all scheduler filters, right? | |
| 15:06:53 | sean-k-mooney | yes which is why filters taht filter host based on critia that placement has not considerd in terms of resouce constraits can be problmatic if the placemetn limit is low | |
| 15:07:58 | sean-k-mooney | supporting the usecase you want to enabel is not particalarly striat forward in placment | |
| 15:09:15 | sean-k-mooney | its doable but somewhat complex. basically we would have to create a special aggreated that initally contaiend all comptues. then we would have to remove hots form that if they are later added to a tenent sepcific aggreated. | |
| 15:09:47 | sean-k-mooney | that is non tivial to ensure is correct as new hosts are added and or as aggreates are updated. | |
| 15:09:54 | sean-k-mooney | which is why we orginally didnt to it. | |
| 15:10:57 | sean-k-mooney | there is perhasp another way to do it but its also not ideal | |
| 15:11:40 | sean-k-mooney | with the placment approch we add all host assocated with a tenant aggreate to a placment aggreate. we could do two placment queries and merge the result | |
| 15:12:26 | sean-k-mooney | well me might actully be able to do it in one request | |
| 15:13:17 | bauzas | sean-k-mooney: you can remove your +2 lock; I just +2d https://review.opendev.org/c/openstack/nova/+/901188 :) | |
| 15:13:50 | sean-k-mooney | btu basically we would need to get the list of all host aggates/placment aggreet related to tenatn affinity and ask for all host not in any of those placment aggreates + the one in the tenant specific aggreates | |
| 15:13:53 | sean-k-mooney | for that tenat | |
| 15:14:26 | sean-k-mooney | bauzas: do we know why the funtional tests failed | |
| 15:14:35 | sean-k-mooney | i can but im going to check that first | |
| 15:15:26 | sean-k-mooney | bauzas: nova.tests.functional.libvirt.test_power_manage.PowerManagementTests.test_hardstop_compute_service_if_wrong_opt | |
| 15:15:30 | sean-k-mooney | need to be updated | |
| 15:15:37 | sean-k-mooney | @gibi ^ | |
| 15:15:42 | sean-k-mooney | gibi: ^ | |
| 15:16:04 | bauzas | because we're changing the behaviour, voila :) | |
| 15:16:49 | sean-k-mooney | so once that is fixed then ya ill add +2 | |
| 15:16:51 | bauzas | sean-k-mooney: I just -1d because I wanted a relnote https://review.opendev.org/c/openstack/nova/+/901188 | |
| 15:17:05 | sean-k-mooney | sure | |
| 15:17:21 | sean-k-mooney | gibi: feel free to ping us when that is updated | |
| 15:24:18 | sahid | sean-k-mooney: from operator point of view we are far from placement, we currently run ussuri, and to be at that point of taking benefit of the change added in placement these will take time | |
| 15:25:37 | opendevreview | Merged openstack/nova master: Enforce correct choice for [DEFAULT] enabled_ssl_apis https://review.opendev.org/c/openstack/nova/+/889787 | |
| 15:26:11 | sahid | i have discussed that with bauzas and he told me that there is no evidence today to deprecate or even remove scheduler filter | |
| 15:27:17 | sahid | and I think bauzas you told me that this has been discussed during meeting, no? | |
| 15:40:22 | sahid | if you don't want the change I think we will just keep this improvement for us :-) | |
| 17:29:40 | opendevreview | melanie witt proposed openstack/nova master: Support resize with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870933 | |
| 19:13:51 | opendevreview | Merged openstack/nova master: docs: Add documentation on server groups https://review.opendev.org/c/openstack/nova/+/899979 | |
| #openstack-nova - 2023-11-21 | |||
| 00:46:03 | opendevreview | melanie witt proposed openstack/nova master: Add hw_ephemeral_encryption_secret_uuid image property https://review.opendev.org/c/openstack/nova/+/870935 | |
| 03:47:16 | opendevreview | melanie witt proposed openstack/nova master: Add encryption support to qemu-img rebase https://review.opendev.org/c/openstack/nova/+/870936 | |
| 10:45:41 | opendevreview | Merged openstack/nova stable/2023.1: add a regression test for all compute RPCAPI 6.x pinnings for rebuild https://review.opendev.org/c/openstack/nova/+/900306 | |
| 12:16:44 | opendevreview | Merged openstack/nova stable/2023.1: Fix rebuild compute RPC API exception for rolling-upgrades https://review.opendev.org/c/openstack/nova/+/900336 | |
| 12:16:50 | opendevreview | Merged openstack/nova stable/2023.1: hyperv: Mark driver as experimental https://review.opendev.org/c/openstack/nova/+/899159 | |
| 13:47:42 | opendevreview | Tobias Urdin proposed openstack/nova stable/yoga: libvirt: remove default cputune shares value https://review.opendev.org/c/openstack/nova/+/898554 | |
| 14:19:56 | bauzas | sean-k-mooney: thanks for have explained my change https://review.opendev.org/c/openstack/nova/+/899625 you understood it | |
| 14:20:18 | bauzas | sean-k-mooney: I'll provide a functest by the change too (if I can) before removing the WIP | |
| 14:20:38 | bauzas | so I hope people will better understand the change | |
| 14:21:09 | sean-k-mooney | so i descirbed what the algoritim shoudl do i didnt have time to fully read the code and determinif your change actully implemnted that | |
| 14:22:06 | tobias-urdin | perhaps possible to get https://review.opendev.org/c/openstack/nova/+/898554 in before yoga release (that is the last release before eol?) https://review.opendev.org/c/openstack/releases/+/899605 | |
| 14:27:08 | bauzas | sean-k-mooney: oh no, we haven't said to have a specific change for SRIOV | |
| 14:27:24 | bauzas | sean-k-mooney: we just said to limit the number of RPs by the limit | |
| 14:28:05 | bauzas | this is a simple change that doesn't need to change the behaviour so we can backport it | |
| 14:28:11 | bauzas | and we don't need to reshape | |
| 14:28:36 | sean-k-mooney | right i described 2 viable algortiims one that requries a reshape and one that does not | |
| 14:28:54 | sean-k-mooney | both only ever advertise the number of vgpus that can be created | |
| 14:29:01 | sean-k-mooney | assuming max_isntances is defiend | |
| 14:29:16 | sean-k-mooney | and wont require removal at runtime | |
| 14:29:24 | bauzas | my change can also work with non-SRIOV GPUs | |
| 14:29:41 | bauzas | that's the fact | |
| 14:30:03 | bauzas | https://review.opendev.org/c/openstack/nova/+/899625/6/nova/tests/unit/virt/libvirt/test_driver.py#26367 is a unittest explaining what we would pass | |
| 14:30:59 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (db) https://review.opendev.org/c/openstack/nova/+/831193 | |
| 14:30:59 | opendevreview | ribaudr proposed openstack/nova master: Allow config to support virtiofs (driver) https://review.opendev.org/c/openstack/nova/+/886522 | |
| 14:31:00 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | |
| 14:31:00 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (objects) https://review.opendev.org/c/openstack/nova/+/839401 | |
| 14:31:01 | opendevreview | ribaudr proposed openstack/nova master: Mounting the shares as part of the initialization process https://review.opendev.org/c/openstack/nova/+/880075 | |
| 14:31:01 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part) https://review.opendev.org/c/openstack/nova/+/833090 | |
| 14:31:02 | opendevreview | ribaudr proposed openstack/nova master: Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | |
| 14:31:02 | opendevreview | ribaudr proposed openstack/nova master: Deletion of associated share mappings on instance deletion https://review.opendev.org/c/openstack/nova/+/881472 | |
| 14:31:03 | opendevreview | ribaudr proposed openstack/nova master: Support rebooting an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/854824 | |
| 14:31:03 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to reboot method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/854823 | |
| 14:31:05 | opendevreview | ribaudr proposed openstack/nova master: Support resuming an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/860285 | |
| 14:31:05 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to resume method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/860284 | |
| 14:31:07 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (driver part) https://review.opendev.org/c/openstack/nova/+/860287 | |
| 14:31:07 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to rescue/unrescue shares https://review.opendev.org/c/openstack/nova/+/860286 | |
| 14:31:09 | opendevreview | ribaudr proposed openstack/nova master: Allow to mount manila share using Cephfs protocol https://review.opendev.org/c/openstack/nova/+/883862 | |
| 14:31:09 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/860288 | |
| 14:31:11 | opendevreview | ribaudr proposed openstack/nova master: Add share lock/unlock and restrict visibility https://review.opendev.org/c/openstack/nova/+/890340 | |
| 14:31:11 | opendevreview | ribaudr proposed openstack/nova master: Check shares support (compute manager) https://review.opendev.org/c/openstack/nova/+/885751 | |
| 14:31:13 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (API) https://review.opendev.org/c/openstack/nova/+/836830 | |
| 14:31:13 | opendevreview | ribaudr proposed openstack/nova master: Check shares support (only API exception) https://review.opendev.org/c/openstack/nova/+/885752 | |
| 14:31:15 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/885753 | |
| 14:31:15 | opendevreview | ribaudr proposed openstack/nova master: Check shares support (API) https://review.opendev.org/c/openstack/nova/+/850499 | |
| 14:31:17 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028 | |
| 14:31:17 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | |
| 14:31:19 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach_error notification https://review.opendev.org/c/openstack/nova/+/860282 | |
| 14:31:19 | opendevreview | ribaudr proposed openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029 | |
| 14:31:21 | opendevreview | ribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working. https://review.opendev.org/c/openstack/nova/+/852086 | |
| 14:31:21 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach_error notification https://review.opendev.org/c/openstack/nova/+/860283 | |
| 14:31:23 | opendevreview | ribaudr proposed openstack/nova master: Docs about Manila shares API usage https://review.opendev.org/c/openstack/nova/+/871642 | |
| 14:31:23 | opendevreview | ribaudr proposed openstack/nova master: Add virt/libvirt error test cases https://review.opendev.org/c/openstack/nova/+/852087 | |
| 14:36:57 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow enabling cpu_power_management with 0 dedicated CPUs https://review.opendev.org/c/openstack/nova/+/901188 | |
| 15:08:23 | bauzas | reminder : nova meeting in 52 mins here | |
| 16:00:17 | opendevmeet | The meeting name has been set to 'nova' | |
| 16:00:17 | opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | |
| 16:00:17 | opendevmeet | Meeting started Tue Nov 21 16:00:17 2023 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | |
| 16:00:17 | bauzas | #startmeeting nova | |
| 16:00:30 | bauzas | hey folks | |
| 16:00:34 | bauzas | aloha | |
| 16:00:42 | bauzas | #link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | |
| 16:01:01 | Uggla_ | o/ | |
| 16:01:13 | grandchild | hi | |
| 16:01:27 | bauzas | awaiting a few more people | |