| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-11-15 | |||
| 15:33:33 | sean-k-mooney | but we can always ask the virt folks if this exists elsewhere in the python lib | |
| 15:33:45 | bauzas | but I don't see anything in https://libvirt.org/html/libvirt-libvirt-nodedev.html | |
| 15:34:03 | bauzas | we have a cap flag but not an alias one | |
| 15:35:18 | bauzas | https://libvirt.org/html/libvirt-libvirt-nodedev.html#virConnectListAllNodeDevices doesn't know a single bit about aliases | |
| 15:41:18 | bauzas | actually, I'm wrong, nodedev is only for host devices, here we're talking of guest devices hence the domain API | |
| 15:52:16 | opendevreview | Merged openstack/nova stable/2023.2: add a regression test for all compute RPCAPI 6.x pinnings for rebuild https://review.opendev.org/c/openstack/nova/+/900309 | |
| 15:53:04 | bauzas | one down, two to go | |
| 17:27:55 | opendevreview | Jay Faulkner proposed openstack/nova master: WIP: [ironic] Partition & use cache for list_instance* https://review.opendev.org/c/openstack/nova/+/900831 | |
| 17:36:33 | bauzas | stephenfin: or other lords of mypy: could someone tell me how to tell f..k to mypy here https://review.opendev.org/c/openstack/nova/+/899625/4/nova/virt/libvirt/driver.py#7975 ? | |
| 17:36:50 | bauzas | mypy isn't able to infer that the variable will never be None in that case | |
| 17:38:03 | JayF | Does it need to be a Tuple[str, Optional[Any]]? | |
| 17:39:02 | melwitt | bauzas: I think it's just that you need to use a % there instead of a comma? | |
| 17:39:05 | JayF | Any implies none per https://mypy.readthedocs.io/en/stable/kinds_of_types.html#the-any-type | |
| 17:39:20 | bauzas | melwitt: not in LOG() | |
| 17:39:58 | melwitt | but you're assembling the message separately before calling LOG.blah(..., ..., ...) | |
| 17:40:11 | bauzas | JayF: I guess I'll need to annotate the first call | |
| 17:40:36 | JayF | I think melwitt is right | |
| 17:40:37 | melwitt | you could do LOG.warning("mdev type default already set to %s", self.pgpu_type_default) | |
| 17:40:41 | dansmith | sean-k-mooney: yep, that was the problem with the falling-back log message, so that top patch should be good :) | |
| 17:40:55 | bauzas | I can try | |
| 17:40:56 | melwitt | but if you're making the string beforehand the comma won't work. LOG is the thing that handles the comma | |
| 17:41:23 | stephenfin | yeah, what melwitt said. That would have introduced a bug | |
| 17:42:10 | bauzas | ok | |
| 17:42:25 | bauzas | respinning pep8 locally to see whether that fixes my problem | |
| 17:43:43 | bauzas | uh, actually that's a separate tox target | |
| 17:46:29 | stephenfin | iirc we run all linters as part of the pep8 env. mordred had an idea of renaming pep8 to linters across projects years ago but backed off the idea | |
| 17:46:37 | stephenfin | too much work, too little ROI | |
| 17:46:52 | JayF | Ah, so that's why it's inconsistent everywhere now :-| | |
| 17:47:02 | stephenfin | afraid so | |
| 17:47:47 | stephenfin | bauzas: btw, https://review.opendev.org/c/openstack/nova/+/899979 is waiting for your doc eyes when you get a chance. There are references to AZs in there that melwitt thought you might have opinions on | |
| 17:49:01 | bauzas | stephenfin: ack, a bit overloaded as of now, but I'll look at it tomorrow morning | |
| 17:49:10 | stephenfin | nw, thanks (y) | |
| 18:12:21 | admin1 | > i accidentally mapped an IP to a wrong node .. i deleted it from inventory and compute service .. and gave the correct node to the IP .. but when i provision it, it still comes up wiht the old hostname .. which nova/placement table holds this record so that i can map the uuid to the correct hostname | |
| 19:27:33 | opendevreview | Jay Faulkner proposed openstack/nova master: WIP: [ironic] Partition & use cache for list_instance* https://review.opendev.org/c/openstack/nova/+/900831 | |
| 19:58:16 | mgariepy | hmm any pointer on : Migration pre-check error: Unacceptable CPU info: CPU doesn't have compatibility ? | |
| 19:58:29 | mgariepy | same server model cpu memory and all | |
| 19:58:40 | mgariepy | with 2023.1 release. | |
| 20:10:50 | opendevreview | Merged openstack/nova stable/2023.2: Fix rebuild compute RPC API exception for rolling-upgrades https://review.opendev.org/c/openstack/nova/+/900338 | |
| 20:17:07 | mgariepy | hmm like this one : https://bugs.launchpad.net/nova/+bug/2039803 | |
| 20:38:45 | opendevreview | melanie witt proposed openstack/nova master: Support create with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870932 | |
| 21:26:30 | opendevreview | Jay Faulkner proposed openstack/nova master: [ironic] Partition & use cache for list_instance* https://review.opendev.org/c/openstack/nova/+/900831 | |
| #openstack-nova - 2023-11-16 | |||
| 01:01:34 | songwenping | hi, team. nova-conductor services block at starting after the control nodes' network reset(stop and start for 5min), what's the reason and any guys got this? | |
| 08:31:14 | gibi | mgariepy: you might hit by https://bugs.launchpad.net/nova/+bug/2039803 | |
| 09:43:38 | opendevreview | Elod Illes proposed openstack/nova stable/2023.1: add a regression test for all compute RPCAPI 6.x pinnings for rebuild https://review.opendev.org/c/openstack/nova/+/900306 | |
| 09:43:39 | opendevreview | Elod Illes proposed openstack/nova stable/2023.1: Fix rebuild compute RPC API exception for rolling-upgrades https://review.opendev.org/c/openstack/nova/+/900336 | |
| 09:43:40 | opendevreview | Elod Illes proposed openstack/nova stable/2023.1: Adding server actions tests to grenade-multinode https://review.opendev.org/c/openstack/nova/+/900337 | |
| 09:53:33 | bauzas | elodilles: thanks for taking care of the RPC backports | |
| 10:18:14 | elodilles | np :) | |
| 10:19:10 | bauzas | elodilles: as a reminder, we'll need to modify the main change when backporting to Zed since one of the two modifications are related to a new RPC version that was added in Antelope | |
| 10:19:58 | elodilles | bauzas: i had only a quick look at the zed version, but yes, i saw that there should be a conflict | |
| 10:20:44 | elodilles | though as i saw probably it's trivial to resolve (famous last words? :)) | |
| 10:35:36 | bauzas | elodilles: probably, I can take a look when I have time | |
| 11:23:40 | opendevreview | Mark Goddard proposed openstack/nova master: Fix PCI passthrough race on reschedule (refresh) https://review.opendev.org/c/openstack/nova/+/710848 | |
| 11:23:40 | opendevreview | Mark Goddard proposed openstack/nova master: Functional test test_boot_reschedule_with_proper_pci_device_count https://review.opendev.org/c/openstack/nova/+/760354 | |
| 12:03:04 | dvo-plv | sean-k-mooney, I write to you regarding your comment https://review.opendev.org/c/openstack/nova/+/876075/27/nova/api/validation/extra_specs/hw.py#540 | |
| 12:03:27 | dvo-plv | I found this doc https://review.opendev.org/c/openstack/glance/+/882133/3/doc/source/admin/useful-image-properties.rst | |
| 12:04:10 | dvo-plv | but i can not find glance metadada and flavor extra spec which I have to extend | |
| 12:04:17 | sean-k-mooney | ah right you have done this already | |
| 12:04:38 | sean-k-mooney | dvo-plv: you have already done it in https://review.opendev.org/c/openstack/glance/+/882133/3/etc/metadefs/compute-libvirt.json | |
| 12:04:48 | sean-k-mooney | that patch has everything you need to do in glance | |
| 12:05:23 | sean-k-mooney | dvo-plv: all that is missing is the nova doc update to document the extra spec | |
| 12:05:32 | dvo-plv | okay, I will test gibi's comments and update nova patch | |
| 12:05:42 | sean-k-mooney | that is done in the user/flavor.rst doc | |
| 12:06:07 | dvo-plv | soory, i did not get | |
| 12:06:52 | sean-k-mooney | your current nova patch does not update doc/source/user/flavor.rst | |
| 12:07:11 | sean-k-mooney | * doc/source/user/flavors.rst | |
| 12:07:35 | sean-k-mooney | we list all the extra specs there https://github.com/openstack/nova/blob/master/doc/source/user/flavors.rst#extra-specs | |
| 12:07:54 | sean-k-mooney | so you shoudl just add the packed format there in your patch too | |
| 12:08:09 | sean-k-mooney | just as you did in the glance useful-imageproperties.rst | |
| 12:15:30 | dvo-plv | okay, I based on the vif_multiqueue_enabled and it does not present in this doc, so I thought it has other purposes | |
| 12:17:34 | sean-k-mooney | when vif_multiqueue_enabled was first intoduced it was only an image property | |
| 12:17:51 | sean-k-mooney | we added it as a flavor extra spec in a sperate patch a few release later | |
| 12:18:01 | dvo-plv | got it | |
| 12:18:33 | sean-k-mooney | although it looks like we also forgot to update the doc when we added it | |
| 12:18:39 | sean-k-mooney | so we shoudl proably fix that at some point | |
| 12:19:08 | sean-k-mooney | dvo-plv: sorry i think i link the wrong doc | |
| 12:27:12 | sean-k-mooney | dvo-plv: you shoudl update https://docs.openstack.org/nova/latest/configuration/extra-specs.html instead | |
| 12:27:34 | sean-k-mooney | which is here https://github.com/openstack/nova/blob/e5e5e00579212cf0b3a58cf7248f7e9483c17461/doc/source/configuration/extra-specs.rst | |
| 12:29:08 | sean-k-mooney | this doc is auto generated so you shoudl not need to modify it | |
| 12:29:18 | sean-k-mooney | let me confirm on the docs preview job | |
| 12:30:45 | sean-k-mooney | dvo-plv: https://5e2e8f3aeccddec75327-8da05f86af8a44d2353be3e602197c08.ssl.cf1.rackcdn.com/876075/27/check/openstack-tox-docs/8e3d058/docs/configuration/extra-specs.html#hw:virtio_packed_ring | |
| 12:31:01 | sean-k-mooney | dvo-plv: so nova doc genreate is workign fine for your chage | |
| 12:31:32 | dvo-plv | I also found this doc, it has in the web version https://docs.openstack.org/nova/latest/configuration/extra-specs.html, but it does not has so much info in the github https://github.com/openstack/nova/blob/master/doc/source/configuration/extra-specs.rst | |
| 12:32:02 | dvo-plv | So i thought that it generate dynamicly | |
| 12:32:03 | sean-k-mooney | we use sphinx directives to auto generate the contnet of the doc | |
| 12:33:21 | sean-k-mooney | .. extra-specs:: hw | |
| 12:33:37 | sean-k-mooney | is automatically generating all the hw: extra specs including the one your adding | |
| 12:34:36 | sean-k-mooney | we have a sphix extention that does this https://github.com/openstack/nova/blob/e5e5e00579212cf0b3a58cf7248f7e9483c17461/doc/ext/extra_specs.py | |
| 12:35:04 | sean-k-mooney | dvo-plv: it uses the info form the extra spec validators to generate the content | |
| 12:35:17 | sean-k-mooney | so as long as we provide a vlaidator the doc is always up to date | |
| 12:40:42 | dvo-plv | so, with docs all good | |
| 12:40:51 | dvo-plv | i do not update anything else | |
| 12:40:58 | dvo-plv | only fix gibi's comments | |
| 12:41:28 | sean-k-mooney | correct the docs shoudl all be fine | |
| 12:41:36 | sean-k-mooney | but gibis comments in the review are valid | |
| 12:41:45 | sean-k-mooney | sepcialy = false handeling | |
| 12:41:52 | dvo-plv | good that we clarify that, thanks | |
| 13:37:48 | mgariepy | gibi, yes thanks i found it and applied the workarounds stuff. | |
| 13:55:46 | SvenKieske | hi there, can anybody update me on the status of this spec? https://specs.openstack.org/openstack/nova-specs/specs/wallaby/approved/nova-support-webvnc-with-password-authentication.html | |
| 13:56:06 | sean-k-mooney | SvenKieske: it was rejected | |