| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-11-14 | |||
| 16:30:35 | dvo-plv | Sorry, I forgot to fill agenda with this | |
| 16:30:43 | sean-k-mooney | i have two related things we we can talk about after ^ | |
| 16:31:40 | sean-k-mooney | dvo-plv: if dansmith and bauzas feel stronly that the tait is not required and want to use a min compute service check instead i can relent on that | |
| 16:32:00 | sean-k-mooney | but you will need to modify the spec to say that the feature will only work when its fully upgraded | |
| 16:32:20 | sean-k-mooney | bauzas: dansmith ^ is that still your prefernce | |
| 16:32:39 | dansmith | I have never been super opinionated about it.. I'm pretty meh all around | |
| 16:32:50 | dvo-plv | i beleive that we alreadt agreed with trait usage | |
| 16:32:51 | dansmith | I still feel like a trait is just too much work for such a thing | |
| 16:33:13 | dvo-plv | I added upgrade impact https://review.opendev.org/c/openstack/nova-specs/+/895924/8/specs/2024.1/approved/virtio_packedring_configuration_support.rst#126 | |
| 16:33:33 | sean-k-mooney | dvo-plv: is this what you wanted to discuss by the way | |
| 16:33:43 | sean-k-mooney | i want to make sure we have a path to unblocking you | |
| 16:34:27 | dvo-plv | yes, I also want a path to unblock this feature and i thought that nova core already agreed with that | |
| 16:34:41 | dvo-plv | so I've updated spec and nova code | |
| 16:34:46 | sean-k-mooney | im fine with the trait i assuemd that was the only open | |
| 16:34:54 | sean-k-mooney | i can re review the new version of the spec | |
| 16:35:02 | bauzas | I think I said loudly a couple of times that I eventually give up | |
| 16:35:18 | bauzas | so, I let other cores accept using traits | |
| 16:36:04 | bauzas | my only concern is that I just want to make sure nobody would use that trait in a flavor so we could eventually remove it if we want, but given I won't review the spec, I leave others to say what they want | |
| 16:36:47 | dvo-plv | I suggest to add thi item somewhere regarding trait usage | |
| 16:37:09 | dvo-plv | but it does not required as far as it will assigned automatically | |
| 16:37:45 | dvo-plv | https://review.opendev.org/c/openstack/nova/+/876075/27/nova/scheduler/request_filter.py#275 here for instance | |
| 16:38:08 | dvo-plv | https://review.opendev.org/c/openstack/nova/+/876075/27/nova/virt/libvirt/driver.py#12429 here for node | |
| 16:40:33 | sean-k-mooney | so can i suggest we take a look at this (the spec and the implematnion) tomorrow n the implemation review day | |
| 16:40:37 | sean-k-mooney | for those that are interested | |
| 16:40:58 | bauzas | I am not but that's a good idea | |
| 16:41:24 | bauzas | anyway, can we end the meeting now ? | |
| 16:41:34 | sean-k-mooney | i would like to add 2 thigns quickly | |
| 16:41:42 | sean-k-mooney | https://blueprints.launchpad.net/nova/+spec/remove-hyperv-driver and https://blueprints.launchpad.net/nova/+spec/remove-vmware-support | |
| 16:42:00 | sean-k-mooney | are we ok to appove those or would you like use to expeand the description with more details | |
| 16:42:35 | bauzas | I think gmann wrote specs | |
| 16:42:45 | sean-k-mooney | yes which they abandoned | |
| 16:42:51 | bauzas | okay | |
| 16:42:55 | sean-k-mooney | because multiple of us said it was not requried | |
| 16:42:58 | bauzas | so we need to review both blueprints in a meeting | |
| 16:43:04 | bauzas | yeah, including me | |
| 16:43:11 | dvo-plv | Thank you | |
| 16:43:17 | sean-k-mooney | so i just want to decied on a path forward for the paper work | |
| 16:43:21 | bauzas | but I don't wanna force someone to not write a spec if he/she really wants to :) | |
| 16:43:22 | sean-k-mooney | if we want to review them next week we can | |
| 16:43:37 | sean-k-mooney | but i would like to merge the first patches for the removal sooner rather then later | |
| 16:43:38 | bauzas | sure | |
| 16:43:44 | bauzas | and sure | |
| 16:43:58 | sean-k-mooney | bauzas: i was orgianlly hoping ot merge the vmware removal patch tomorrow in the implemation day | |
| 16:44:02 | sean-k-mooney | but it can wait | |
| 16:44:12 | bauzas | then, we can approve those today | |
| 16:44:15 | bauzas | folks, | |
| 16:44:32 | bauzas | anyone having concerns with https://blueprints.launchpad.net/nova/+spec/remove-hyperv-driver as a specless BP for one ? | |
| 16:46:26 | sean-k-mooney | im fine with that. for the vmware one i do have more patches ill need to write to complete the removal but the inital patch https://review.opendev.org/c/openstack/nova/+/897017 is the entirty of the driver removal. i need to remove the console and objects in follow up patches | |
| 16:46:38 | bauzas | okay, so | |
| 16:46:52 | bauzas | #agreed https://blueprints.launchpad.net/nova/+spec/remove-hyperv-driver to be accepted as a specless bp | |
| 16:46:57 | bauzas | next one | |
| 16:47:22 | bauzas | anyone having concerns with https://blueprints.launchpad.net/nova/+spec/remove-vmware-support as a specless BP ? | |
| 16:47:59 | bauzas | sean-k-mooney: the fact that you have left things to implement is just some implementation nit | |
| 16:48:03 | bauzas | we can still approve the bp | |
| 16:48:09 | sean-k-mooney | yep | |
| 16:48:14 | bauzas | like we did with nova-net | |
| 16:48:21 | sean-k-mooney | just wanted to clarify that since we expanded the scope at the ptg | |
| 16:48:23 | bauzas | anyone having concerns again ? | |
| 16:48:33 | bauzas | okay so | |
| 16:48:50 | bauzas | #agreed https://blueprints.launchpad.net/nova/+spec/remove-vmware-support to be accepted as a specless BP | |
| 16:48:54 | bauzas | there we go | |
| 16:49:11 | bauzas | sean-k-mooney: I'll just set the LP fields right after the meeting | |
| 16:49:15 | sean-k-mooney | thanks | |
| 16:49:18 | sean-k-mooney | thats all from me | |
| 16:49:23 | bauzas | and we can start to review your patches tomorrow | |
| 16:49:26 | bauzas | cool | |
| 16:49:35 | bauzas | so, let me call it a wrap | |
| 16:49:42 | bauzas | thanks all | |
| 16:49:45 | opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2023/nova.2023-11-14-16.00.log.html | |
| 16:49:45 | opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2023/nova.2023-11-14-16.00.txt | |
| 16:49:45 | opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2023/nova.2023-11-14-16.00.html | |
| 16:49:45 | opendevmeet | Meeting ended Tue Nov 14 16:49:45 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 16:49:45 | bauzas | #endmeeting | |
| 16:50:56 | dvo-plv | sean-k-mooney, How we can attend tomorrow review. Does it meeting or what ? | |
| 16:51:21 | sean-k-mooney | no its just that tommrrow we are goign to make time to reveiw via gerrit | |
| 16:51:27 | sean-k-mooney | we will be disucssing things here | |
| 16:51:32 | sean-k-mooney | on irc too as needed | |
| 16:52:00 | bauzas | sean-k-mooney: paperwork stamps dully noted. | |
| 16:52:15 | dvo-plv | I see ,okay. Feel free to ping me, thank you | |
| 16:52:22 | bauzas | (on both BPs) | |
| 16:52:30 | elodilles | bauzas: minor clarification: pyhton-novaclient and osc-placement had no relevant changes i think, that's why we only have os-vif Caracal-1 proposed. nova and placement are services, so they don't need Caracal-1 release, hence release patches are not generated for them. (though we could release .0b1 releases, but that is unnecessary as we discussed) | |
| 16:52:47 | bauzas | ack | |
| 17:03:25 | gmann | bauzas: yeah, abandon the hyperV removal spec. i proposed it before our PTG discussion. | |
| 17:39:17 | bauzas | dansmith: can't find the procedural blueprint for https://blueprints.launchpad.net/nova/+spec/libvirt-dev-alias | |
| 17:39:24 | bauzas | fancy creating it ? | |
| 17:39:53 | bauzas | https://specs.openstack.org/openstack/nova-specs/specs/2024.1/approved/libvirt-dev-alias.html links to it | |
| 17:40:31 | dansmith | oh I probably never created it yeah | |
| 17:41:13 | dansmith | bauzas: done | |
| 17:41:40 | bauzas | cool | |
| 17:43:34 | bauzas | okay, https://blueprints.launchpad.net/nova/2024.1 reflects what we have | |
| 17:43:54 | bauzas | (except john's BP which isn't approved yet) | |
| 17:44:21 | bauzas | folks, etherpad just created https://etherpad.opendev.org/p/nova-caracal-status | |
| 17:44:33 | bauzas | I'll curate the list of blueprints to find the relevant gerrit series | |
| 17:44:45 | bauzas | but you should be able to look at it tomorrow | |
| 17:46:27 | sean-k-mooney | cool thanks bauzas | |
| 18:01:21 | opendevreview | Sylvain Bauza proposed openstack/nova master: WIP: libvirt: Cap with max_instances GPU types https://review.opendev.org/c/openstack/nova/+/899625 | |
| 18:01:41 | bauzas | dansmith: sean-k-mooney: squashed my SRIOV patches into a single one | |
| 18:02:04 | bauzas | like dansmith said to me ;) | |
| 18:02:35 | bauzas | operators would then provide the max instances and then restarting nova-compute so the virt driver would delete the ResourceProviders | |
| 18:03:54 | sean-k-mooney | bauzas: i looked at those previosuly but i dont think i found where dansmith said that | |