| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-11-08 | |||
| 15:16:19 | bauzas | like I said, there are other cores but me for the spec | |
| 15:16:29 | dansmith | all traits *are* consumable, so that's just the end of it :) | |
| 15:17:14 | bauzas | this just implies that we won't never remove a trait from a compute once we provide it | |
| 15:17:22 | bauzas | but OK | |
| 15:17:32 | sean-k-mooney | bauzas: we have never done it before | |
| 15:17:38 | sean-k-mooney | and i assuemd that was going to be the case yes | |
| 15:17:55 | sean-k-mooney | i mean unless | |
| 15:17:58 | sean-k-mooney | we remove a feature | |
| 15:18:19 | sean-k-mooney | if we remove the ablit to do somethign removing the trait is reflecting reality | |
| 15:18:47 | bauzas | sure, I wasn't talking about removing a feature | |
| 15:19:04 | dansmith | I too don't think there's any way to remove a trait other than not supporting a thing it represents | |
| 15:19:05 | bauzas | but rather rebuilding the feature by doing other scheduler way | |
| 15:19:22 | dansmith | which is also why traits are massively more expensive than bumping an internal integer | |
| 15:19:35 | bauzas | ^ that is my concern | |
| 15:19:59 | dansmith | well, that was my argument in the beginning | |
| 15:20:00 | sean-k-mooney | if we decied because we have done the min libvirt version we dont need the triat thats fine | |
| 15:20:01 | bauzas | so, again, if we are not able to draw a line (which I can understand), then I won't accept the spec | |
| 15:20:19 | sean-k-mooney | but i dont really like bumping a min compute version for a driver only change | |
| 15:20:21 | bauzas | and I'll just wait for another core to accept it | |
| 15:20:25 | sean-k-mooney | but if that is preferabel fine | |
| 15:20:42 | sean-k-mooney | we are just scoping out supproting this until the cloud is fully upgraded | |
| 15:20:44 | bauzas | we already have a min compute version that works | |
| 15:21:04 | dansmith | sean-k-mooney: https://github.com/openstack/nova/blob/master/nova/objects/service.py#L136 | |
| 15:21:11 | sean-k-mooney | right but normally i would not expect a compute service bump for a change that only affect a virt driver | |
| 15:21:19 | bauzas | https://github.com/openstack/nova/blob/master/nova/objects/service.py#L264 | |
| 15:21:48 | sean-k-mooney | dansmith file backed memroy required toher chagnes | |
| 15:22:06 | dansmith | this feels kinda similar: https://github.com/openstack/nova/blob/master/nova/objects/service.py#L220 | |
| 15:24:20 | sean-k-mooney | dansmith: im more ok with documenting "do a compute service bump for dirver only changes" then docuementing anything about not suing traits | |
| 15:25:24 | dansmith | I definitely understand the "this is purely a driver thing so not service version eligible" but I think that this is (a) the primary virt driver, (b) in tree, (c) has hard version requirements built into the driver | |
| 15:25:43 | bauzas | guys, I originally wanted to discuss about https://bugs.launchpad.net/nova/+bug/2041519 status and we sidetracked on the trait thing where I'm done and not much interested. Fancy moving to that ? | |
| 15:25:44 | dansmith | and also maybe (d) most of the other live migration and neutron things we bump the service version for are really just for libvirt features/changes | |
| 15:25:46 | dansmith | so I dunno | |
| 15:25:57 | dansmith | I think the relative cost makes it worth it | |
| 15:26:08 | dansmith | bauzas: yes please ;P | |
| 15:26:12 | dansmith | bauzas: gmeet or here/ | |
| 15:26:28 | bauzas | gmeet, will be faster if you don't mind getting yet another meeting | |
| 15:26:37 | dansmith | I'd rather do less typing | |
| 15:26:45 | dansmith | here it's 7:26 and I'm already sick of typing | |
| 15:26:47 | bauzas | already had 2 hours of meeting already | |
| 15:26:51 | bauzas | okay, so | |
| 15:27:07 | bauzas | https://meet.google.com/mdo-owzo-zka | |
| 15:27:27 | bauzas | people wanting to discuss on https://bugs.launchpad.net/nova/+bug/2041519 are free to come here ^ | |
| 15:28:27 | dvo-plv | FYI, I've updated packed ring spec file https://review.opendev.org/c/openstack/nova-specs/+/895924 | |
| 15:31:50 | dansmith | sean-k-mooney: ? | |
| 15:32:49 | dansmith | ah nevermind, you're busy sorry | |
| 15:37:16 | sean-k-mooney | ya sorry on two calls currently | |
| 15:41:27 | bauzas | sean-k-mooney: nevermind, dansmith found me a solution that should work :) | |
| 15:41:51 | bauzas | I just need to make sure we can verify the resource providers by init_host :) | |
| 17:43:27 | bauzas | dang, since we call check_on_dest before check_on_source in the live migration worflow, I don't have any way to hard guess the mdev type the instance was set against | |
| 20:17:01 | opendevreview | Erik Olof Gunnar Andersson proposed openstack/nova master: Fix coverage issues with eventlet https://review.opendev.org/c/openstack/nova/+/900116 | |
| #openstack-nova - 2023-11-09 | |||
| 15:01:12 | opendevreview | Takashi Kajinami proposed openstack/nova master: Fix unit tests broken by olso.utils https://review.opendev.org/c/openstack/nova/+/900532 | |
| 15:05:39 | opendevreview | Takashi Kajinami proposed openstack/nova master: Fix unit tests broken by olso.utils https://review.opendev.org/c/openstack/nova/+/900532 | |
| 15:18:03 | opendevreview | Erik Olof Gunnar Andersson proposed openstack/nova master: Fix coverage issues with eventlet https://review.opendev.org/c/openstack/nova/+/900116 | |
| 15:28:54 | eandersson | Now with a more reasonable commit message. | |
| 15:37:14 | opendevreview | Takashi Kajinami proposed openstack/nova master: Fix unit tests broken by olso.utils https://review.opendev.org/c/openstack/nova/+/900532 | |
| 15:41:57 | opendevreview | Takashi Kajinami proposed openstack/nova master: Fix unit tests broken by olso.utils https://review.opendev.org/c/openstack/nova/+/900532 | |
| 15:43:43 | tkajinam | Hi ! It'd be nice if someone from the core review the above patch to bump oslo.utils to fix sqlalchemy-2.x jobs | |
| 15:48:54 | opendevreview | Takashi Kajinami proposed openstack/nova master: Make sqlalchemy-2x job voting again https://review.opendev.org/c/openstack/nova/+/900538 | |
| 15:49:10 | opendevreview | Takashi Kajinami proposed openstack/nova master: Make sqlalchemy-2x job voting again https://review.opendev.org/c/openstack/nova/+/900538 | |
| 16:38:20 | opendevreview | Samuel Kunkel proposed openstack/nova master: fix: amd-sev handle missing img properties https://review.opendev.org/c/openstack/nova/+/874264 | |
| 19:24:17 | dansmith | melwitt: maybe you can hit this for tkajinam: https://review.opendev.org/c/openstack/nova/+/900532 | |
| #openstack-nova - 2023-11-10 | |||
| 02:30:18 | opendevreview | Nobuhiro MIKI proposed openstack/nova-specs master: Re-propose "Add maxphysaddr support for Libvirt" for 2024.1 Caracal https://review.opendev.org/c/openstack/nova-specs/+/895135 | |
| 02:55:22 | opendevreview | Merged openstack/nova master: Fix unit tests broken by olso.utils https://review.opendev.org/c/openstack/nova/+/900532 | |
| 11:36:08 | dvo-plv | Hello, All | |
| 11:36:38 | dvo-plv | Maybe you will have a chance for review today ? https://review.opendev.org/c/openstack/nova-specs/+/895924 | |
| 15:35:28 | opendevreview | Vasyl Saienko proposed openstack/nova master: libvirt: Make Enligtened VMCS optional https://review.opendev.org/c/openstack/nova/+/900629 | |
| 15:49:36 | opendevreview | Vasyl Saienko proposed openstack/nova master: libvirt: Make Enligtened VMCS optional https://review.opendev.org/c/openstack/nova/+/900629 | |
| 16:27:32 | opendevreview | Sylvain Bauza proposed openstack/nova-specs master: Proposes mdev live-migration support in libvirt https://review.opendev.org/c/openstack/nova-specs/+/900636 | |
| 16:42:18 | opendevreview | Takashi Natsume proposed openstack/nova master: Update contributor guide for 2024.1 Caracal https://review.opendev.org/c/openstack/nova/+/896305 | |
| 17:45:58 | opendevreview | sean mooney proposed openstack/nova master: remove eventlet.tpool from rbd_utils https://review.opendev.org/c/openstack/nova/+/900682 | |
| 17:45:58 | opendevreview | sean mooney proposed openstack/nova master: removew use of eventlet.queue.LightQueue https://review.opendev.org/c/openstack/nova/+/900681 | |
| 19:26:40 | opendevreview | Merged openstack/nova master: doc: clarify that pre-commit is optional https://review.opendev.org/c/openstack/nova/+/897057 | |
| 19:59:41 | opendevreview | Vasyl Saienko proposed openstack/nova master: libvirt: Make Enligtened VMCS optional https://review.opendev.org/c/openstack/nova/+/900629 | |
| 20:12:32 | opendevreview | Erik Olof Gunnar Andersson proposed openstack/nova master: Fix coverage issues with eventlet https://review.opendev.org/c/openstack/nova/+/900116 | |
| 20:15:32 | mgariepy | is there issue with placement allocation ? depsite having a Memory_MB allocation_ratio of 1.0 i got used:737280 out of a total of 515555 | |
| 20:35:39 | mgariepy | pretty much the same issue as : https://bugzilla.redhat.com/show_bug.cgi?id=1846844 | |
| #openstack-nova - 2023-11-12 | |||
| 09:28:16 | opendevreview | Balazs Gibizer proposed openstack/nova master: DNM: test hostname based migration URL https://review.opendev.org/c/openstack/nova/+/900275 | |
| 09:28:16 | opendevreview | Balazs Gibizer proposed openstack/nova master: [libvirt]Add migration_inbound_addr https://review.opendev.org/c/openstack/nova/+/900203 | |
| #openstack-nova - 2023-11-13 | |||
| 10:35:48 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix KeyError on assisted snapshot call https://review.opendev.org/c/openstack/nova/+/900783 | |
| 11:46:38 | opendevreview | Danylo Vodopianov proposed openstack/nova master: Packed virtqueue support was added. https://review.opendev.org/c/openstack/nova/+/876075 | |
| 12:01:11 | jkulik | Hi folks, we just stumbled over https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/5ASRKETLJQAZM2KJ2EDIJZB6XMDWAL4P/ which has removing vmware from Nova and other projects as the topic. We're still actively using VMware inside SAP through OpenStack. Is there any way we can reverse the decision to completely remove the vmwareapi infrastructure from Nova? | |
| 12:12:32 | stephenfin | jkulik: I would suggest bringing this up on the Nova weekly meeting and likely openstack-discuss. The details and link to the agenda for the former can be found here https://meetings.opendev.org/#Nova_Team_Meeting | |
| 12:15:23 | stephenfin | jkulik: the tl;dr: is that we have had no CI for any of this code for many years now, which means we have no ability to test it and ensure that it works/isn't broken by other changes | |
| 12:17:41 | opendevreview | Samuel Kunkel proposed openstack/nova master: fix: amd-sev handle missing img properties https://review.opendev.org/c/openstack/nova/+/874264 | |
| 12:17:57 | stephenfin | jkulik: I would also suggest you need to bring this up internally rather quickly. I can't speak for anyone else but _my guess_ would be that the only way this decision would be reversed would be via a long-term commitment from some third party to maintain testing infrastructure for these components (the VMWare-related drivers in Nova, Cinder, Neutron etc.; oslo-vmware, ...) | |
| 12:20:10 | stephenfin | jkulik: We previously got such a commitment from VMWare folks (about 2-3 years ago, iirc) but it wasn't followed up on, so there will likely be some hesitation at taking any commitment at face value without seeing e.g. a CI being established | |
| 12:20:28 | stephenfin | Hopefully that helps provide a bit of colour to the situation | |
| 12:23:19 | jkulik | thank you. indeed I remember the deprecation attempt 2-3 years ago when we got VMware to bring back some CI. we were not aware that it's broken again. | |
| 12:34:27 | sean-k-mooney | jkulik: the ci hase been absent for 2+ years | |
| 12:39:19 | jkulik | iirc this was the time when we talked to VMware and they brougt back a CI https://review.opendev.org/c/openstack/nova/+/712101 - 2020-03 ... so there should have been some CI ~3 years ago again. https://review.opendev.org/c/openstack/nova/+/806391 in 2021-09 still contains a message from a "VMware NSX CI". I'm just wondering when it went away. | |
| 12:47:47 | sean-k-mooney | jkulik: presumably related to the pandmeic that ci went way again in 2021 and never returned | |
| 12:47:52 | jkulik | 2022-02 I found a message `ext-nova-zuul: NOT_REGISTERED` for that CI. sounds like a good hint when it went away. in 2021 it still seemed to work. Even in 2022-01-27 there's still a message for a Cinder review-request | |
| 12:48:51 | jkulik | yeah, VMware doesn't have too much going for OpenStack. is there a way for a third-party, non-VMware user to get notified if the CI goes away? | |
| 12:49:27 | sean-k-mooney | there isnt, and evenupstream developer will only know if they noticed its not reporting | |
| 12:49:44 | sean-k-mooney | jkulik: they did not tell us they were nolonger maintianing it or removing it | |
| 12:49:51 | sean-k-mooney | it jus t disappeared silently | |
| 12:50:03 | sean-k-mooney | again | |
| 12:50:18 | jkulik | they did not tell us either ... that's why I would have liked to get notified somehow to tell them to fix it | |
| 12:50:42 | sean-k-mooney | at this point i thik its beyond that | |
| 12:51:05 | sean-k-mooney | they have demonstarted that they will not maintain the ci or lib requried to supprot vmware | |