| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-10-26 | |||
| 09:05:19 | opendevreview | Sylvain Bauza proposed openstack/nova master: Fix rebuild compute RPC API exception for rolling-upgrades https://review.opendev.org/c/openstack/nova/+/899235 | |
| 09:09:56 | kashyap | bauzas: Minor comment: line wrapping is broken in your commit message here: https://review.opendev.org/c/openstack/nova/+/899234 | |
| 09:10:10 | kashyap | Where single words (e.g. "to") are on a whole line | |
| 09:11:00 | bauzas | ah yeah | |
| 09:12:08 | bauzas | that's because the line number is less than 79 | |
| 09:12:48 | bauzas | I'll then cut on L72 | |
| 09:13:03 | kashyap | Thanks; and sorry for the nit-pick. It just makes it reading hard :) | |
| 09:15:08 | opendevreview | Sylvain Bauza proposed openstack/nova master: add a regression test for all compute RPCAPI 6.x pinnings for rebuild https://review.opendev.org/c/openstack/nova/+/899234 | |
| 09:15:08 | opendevreview | Sylvain Bauza proposed openstack/nova master: DNM(yet): Adding server actions tests to grenade-multinode https://review.opendev.org/c/openstack/nova/+/899375 | |
| 09:15:09 | opendevreview | Sylvain Bauza proposed openstack/nova master: Fix rebuild compute RPC API exception for rolling-upgrades https://review.opendev.org/c/openstack/nova/+/899235 | |
| 09:15:12 | bauzas | np, | |
| 09:15:16 | kashyap | Looks good now! | |
| 09:15:19 | bauzas | just reuploaded them | |
| 09:15:57 | bauzas | I'm paginating with VSCodium for a 80-line | |
| 09:16:10 | kashyap | I see; I'm still "stuck in vim" | |
| 09:16:18 | bauzas | but for the commit, then I need to make sure about the length of 72 chars | |
| 09:17:04 | bauzas | tbh I said yesterday loudly that I appreciate correctly written commit messages, so I need to do this for me :) | |
| 09:17:40 | bauzas | tbc, that's not really because I prefer commit messages over code, but we can simply fix a code while a commit message can't be simply be modified | |
| 09:17:57 | bauzas | (once it's merged) | |
| 09:18:13 | bauzas | anyway, let's see what grenade is telling to us :) | |
| 09:19:47 | kashyap | bauzas: Yeah, I highly good commit messages that explain the _why_ in good detail. Not just the "what" (the code tells that anyway!) | |
| 09:20:08 | kashyap | bauzas: DanPB's epic guide on commit messages is still the best I've ever seen: https://wiki.openstack.org/wiki/GitCommitMessages | |
| 09:20:28 | kashyap | See the section on "Examples of bad practise" and "Examples of good practise" | |
| 09:27:01 | elodilles | gmann: no, i did not realize that yet, though now that you have mentioned i remember seeing a fix for this. yes, here it is: https://review.opendev.org/c/openstack/openstacksdk/+/899154 | |
| 09:36:48 | opendevreview | Pierre Libeau proposed openstack/nova master: Fix request_specs not updated after failed rebuild https://review.opendev.org/c/openstack/nova/+/899379 | |
| 09:51:10 | opendevreview | Takashi Kajinami proposed openstack/nova master: Detect maximum number of SEV(-ES) guests automatically https://review.opendev.org/c/openstack/nova/+/899381 | |
| 09:53:41 | dvo-plv | Hello, All maybe someone will have a chance to review reproposed spec file ? https://review.opendev.org/c/openstack/nova-specs/+/895924 | |
| 09:59:47 | gokhani | thanks for your reply sean-k-mooney, I also saw preallocate_images config in nova. Does it provide thick provisioning ? | |
| 10:00:21 | kashyap | dvo-plv: From a quick look, the core change reads good to me, to gain better performance from using the more efficient virtq structure | |
| 10:00:46 | kashyap | dvo-plv: Also this week is the PTG, so folks might be busy w/ many other things | |
| 10:03:18 | dvo-plv | oh, I see, sorry for dіstraction | |
| 10:03:18 | dvo-plv | oh, I see, sorry for dÑ–straction | |
| 10:04:48 | kashyap | No-no; it's fine. Just keeping you posted in case if you don't hear much this week | |
| 10:05:22 | kashyap | dvo-plv: I gave my ACK there, FWIW | |
| 11:26:15 | dvo-plv | thanks | |
| 12:05:02 | opendevreview | Amit Uniyal proposed openstack/nova-specs master: WIP: Enforce console session timeout https://review.opendev.org/c/openstack/nova-specs/+/898553 | |
| 12:14:45 | opendevreview | Sylvain Bauza proposed openstack/nova master: add a regression test for all compute RPCAPI 6.x pinnings for rebuild https://review.opendev.org/c/openstack/nova/+/899234 | |
| 12:14:46 | opendevreview | Sylvain Bauza proposed openstack/nova master: DNM(yet): Adding server actions tests to grenade-multinode https://review.opendev.org/c/openstack/nova/+/899375 | |
| 12:14:46 | opendevreview | Sylvain Bauza proposed openstack/nova master: Fix rebuild compute RPC API exception for rolling-upgrades https://review.opendev.org/c/openstack/nova/+/899235 | |
| 12:15:37 | opendevreview | Sylvain Bauza proposed openstack/nova master: Adding server actions tests to grenade-multinode https://review.opendev.org/c/openstack/nova/+/899375 | |
| 12:29:42 | opendevreview | Sylvain Bauza proposed openstack/nova master: DNM : Test a new compute RPC version with an error https://review.opendev.org/c/openstack/nova/+/899392 | |
| 12:51:04 | opendevreview | Amit Uniyal proposed openstack/nova-specs master: WIP: Enforce console session timeout https://review.opendev.org/c/openstack/nova-specs/+/898553 | |
| 12:57:46 | auniyal | ack frickler | |
| 12:57:58 | bauzas | stephenfin: johnthetubaguy: folks, you haven't replied yet. Are you available in 3 mins for discussing about your topics ? | |
| 13:02:43 | bauzas | like I said in the PTG website, avengers assemble ! | |
| 13:06:09 | gmann | frickler: thanks | |
| 13:12:56 | gmann | elodilles: ack. thanks did the recheck now | |
| 13:15:03 | elodilles | ++ | |
| 13:44:47 | opendevreview | Takashi Kajinami proposed openstack/nova master: Detect maximum number of SEV(-ES) guests automatically https://review.opendev.org/c/openstack/nova/+/899381 | |
| 14:41:54 | gmann | sean-k-mooney: on service role, i captured some note in nova etherpad about what we discussed on Monday, please check/correct if I missed anything in your idea there https://etherpad.opendev.org/p/nova-caracal-ptg#L594 | |
| 15:08:33 | opendevreview | Merged openstack/nova stable/2023.2: Revert "Add upgrade check for compute-object-ids linkage" https://review.opendev.org/c/openstack/nova/+/898953 | |
| 15:12:54 | opendevreview | Pavlo Shchelokovskyy proposed openstack/nova master: Use configuration for single enabled mdev type https://review.opendev.org/c/openstack/nova/+/899406 | |
| 15:17:23 | opendevreview | Pavlo Shchelokovskyy proposed openstack/nova master: Optionally delete mdevs on instance cleanup https://review.opendev.org/c/openstack/nova/+/899407 | |
| 15:39:27 | whoami-rajat | bauzas, hey, is there a suitable time when nova team will be available to meet tomorrow to discuss the leftover topics? | |
| 15:42:47 | whoami-rajat | leftover as in from yesterday's cross project session | |
| 15:45:32 | bauzas | whoami-rajat: how much time do you think we need for the left topics ? | |
| 15:46:04 | whoami-rajat | bauzas, i would say 40-45 mins but sometimes the discussion stretches so 1 hour to be on safer side | |
| 15:49:00 | bauzas | whoami-rajat: ok, we can try 1500UTC | |
| 15:53:21 | whoami-rajat | bauzas, great, we will see you then! | |
| 16:33:21 | bauzas | I hope I haven't killed the zoom session | |
| 16:47:36 | opendevreview | Dan Smith proposed openstack/nova master: Support glance's new location API https://review.opendev.org/c/openstack/nova/+/891036 | |
| 16:47:37 | opendevreview | Dan Smith proposed openstack/nova master: DNM: Test glance new location api https://review.opendev.org/c/openstack/nova/+/891207 | |
| 16:58:42 | opendevreview | Merged openstack/nova stable/2023.1: Decorate only Flavor.get_* methods that execute queries https://review.opendev.org/c/openstack/nova/+/891749 | |
| 17:03:13 | dansmith | bauzas: need a "done for the day" on the ptg status? | |
| 17:03:29 | dansmith | I just jumped over because I have a slot and thought unified limits would be being discussed ;) | |
| 17:28:16 | sean-k-mooney | dansmith: we did disucss it but finished early | |
| 17:28:35 | dansmith | sean-k-mooney: I realize that I'm just saying the ptg page looks like it's still ongoing | |
| 17:28:37 | sean-k-mooney | dansmith: i ended the session but didnt update the bot | |
| 17:28:51 | sean-k-mooney | what the irc channel for that again | |
| 17:29:06 | clarkb | sean-k-mooney: #openinfra-events | |
| 17:29:48 | sean-k-mooney | thansk am what the command :) | |
| 17:30:54 | sean-k-mooney | ah found https://opendev.org/openstack/ptgbot/src/branch/master/README.rst | |
| 17:31:09 | opendevreview | Merged openstack/placement master: db: Wrap raw SQL query in sqlalchemy.text https://review.opendev.org/c/openstack/placement/+/896650 | |
| 17:32:36 | sean-k-mooney | ok should be good now | |
| 17:33:33 | sean-k-mooney | i guess i can set it to done for today instead of nothing | |
| 17:35:34 | opendevreview | Merged openstack/placement master: Add job to test with SQLAlchemy master (2.x) https://review.opendev.org/c/openstack/placement/+/886229 | |
| 18:20:13 | tonyb | sean-k-mooney: So your name came up in relation to vPTG and iCal support. In that you had opinions about it but not what they were/are. | |
| 18:20:30 | tonyb | sean-k-mooney: is that accurate? If so care to expand? | |
| 18:21:34 | sean-k-mooney | tonyb: ish i wrote/hacked a tool to produce ical files form the old spreadsheet that was used | |
| 18:21:53 | tonyb | Ah okay. | |
| 18:22:07 | sean-k-mooney | i wanted icals for all the sessions | |
| 18:22:25 | sean-k-mooney | https://github.com/SeanMooney/ptg-cal | |
| 18:22:26 | tonyb | try https://ptg.opendev.org/ptg.ics | |
| 18:22:50 | tonyb | you can also replace ptg with a track name to get just that track | |
| 18:23:01 | sean-k-mooney | this was a few years ago by the way | |
| 18:23:07 | sean-k-mooney | but i dint want a single ical | |
| 18:23:09 | tonyb | eg https://ptg.opendev.org/nova.ics | |
| 18:23:09 | sean-k-mooney | that is nice | |
| 18:23:14 | sean-k-mooney | but i wanted one per track too | |
| 18:23:24 | sean-k-mooney | ya so that is what i impelmente din the repo | |
| 18:24:16 | tonyb | Okay. Well it's in production now. Feel free to poke at it and ping me with features/bugs | |
| 18:25:15 | tonyb | I don't have anything like: https://github.com/SeanMooney/ptg-cal/blob/master/ptg_cal/main.py#L115 for example | |
| 18:26:42 | sean-k-mooney | tonyb: some of that code was becasue i was takign a ill defiend ethersheet | |
| 18:26:52 | sean-k-mooney | where each sell was a hour/half hour | |
| 18:27:01 | sean-k-mooney | and i had to calulate how long the essions were | |
| 18:27:48 | sean-k-mooney | so merge_adjacent_sessions was taking nova 13:00-14:00 and nova 14:00-15:00 and producing nova 13:00-15:00 | |
| 18:28:29 | tonyb | Fair. PTGBot has a similar issue. and right now youd get 4 1hr sessions for nova rather than 1 4hr session | |
| 18:28:43 | sean-k-mooney | tonyb: ^ so if you have a better data souce you wont need it | |
| 18:28:54 | sean-k-mooney | honestly that not that much of a big deal | |
| 18:29:26 | sean-k-mooney | tonyb: basically i orgainly worte this so i coudl build my own local calander in my email client for the session | |