| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-10-24 | |||
| 12:23:24 | sean-k-mooney | we added both in the lat 2 years | |
| 12:23:30 | noonedeadpunk | I think most usecase is in fact some rescue.... | |
| 12:23:46 | noonedeadpunk | and yes, that kinda covers my usecase fully | |
| 12:24:25 | noonedeadpunk | sean-k-mooney: is it possible to reset delete on termination flag for the root drive? | |
| 12:24:27 | sean-k-mooney | noonedeadpunk: part of the reason we didnt do this was we decied lets just make the instance action that dont work with bfv work first | |
| 12:24:50 | sean-k-mooney | noonedeadpunk: that im not sure i think you might eb able to do it via cinder | |
| 12:25:07 | sean-k-mooney | but that woudl also be reasonable to support IMO if we dont supprot that already | |
| 12:25:33 | sean-k-mooney | you shoudl always be able to say "hay dont delete this" after the fact i think | |
| 12:25:39 | noonedeadpunk | yeah | |
| 12:26:00 | noonedeadpunk | as this what strikes my mind when I think why I would need to detach the root volume... | |
| 12:26:10 | noonedeadpunk | Just to save it from being deleted | |
| 12:26:18 | noonedeadpunk | (with the VM) | |
| 12:26:36 | noonedeadpunk | and then rescue works nicely indeed | |
| 12:26:44 | sean-k-mooney | ya and you should be able to do the same for ports. the port case is defenitly on our todo list | |
| 12:28:44 | noonedeadpunk | but then indeed I don't know why would you need to detach it | |
| 12:29:17 | noonedeadpunk | Just out of convenience... Like first thing someone would try to do rather using rescue... | |
| 12:29:46 | noonedeadpunk | so I think you;re right here and it's smth that ppl were just historically missing due to not working rescue | |
| 12:30:26 | noonedeadpunk | and that is kinda inertion of thinking | |
| 12:32:27 | sean-k-mooney | ya so thats why im wondering about the usecase | |
| 12:32:43 | sean-k-mooney | if there is a usecase we cant supprot then im happy to hear that and see what we can do to supprot it | |
| 12:33:11 | sean-k-mooney | but if its already covered by rescue or updating the delete on terminate flag | |
| 12:33:24 | sean-k-mooney | then i woudl perfer to use that approch then add root detach | |
| 12:33:38 | sean-k-mooney | so we will see later i guess | |
| 13:00:35 | bauzas | we gonna use Zoom eventually https://www.openstack.org/ptg/rooms/diablo | |
| 13:05:19 | bauzas | sean-k-mooney: are you arriving to the PTg ? | |
| 14:28:53 | opendevreview | Pavlo Shchelokovskyy proposed openstack/nova master: Deprecate use_cow_images and 'default' images_type https://review.opendev.org/c/openstack/nova/+/898229 | |
| 14:28:53 | opendevreview | Pavlo Shchelokovskyy proposed openstack/nova master: Fix image conversion check in finish_migration https://review.opendev.org/c/openstack/nova/+/897842 | |
| 15:19:31 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: libvirt: Avoid getCapabilities() to calculate host CPU definition https://review.opendev.org/c/openstack/nova/+/899185 | |
| 15:25:46 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: libvirt: Avoid getCapabilities() to calculate host CPU definition https://review.opendev.org/c/openstack/nova/+/899185 | |
| 16:18:20 | simondodsley | sean-k-mooney: sorry - i can't stay any longer on the PTG today - i have other commitments i have to deal with. I would love some update on the spec I put in the etherpad though | |
| 16:21:30 | opendevreview | Merged openstack/nova stable/2023.2: Install lxml before we need it in post-run https://review.opendev.org/c/openstack/nova/+/899142 | |
| 16:43:14 | opendevreview | Pavlo Shchelokovskyy proposed openstack/placement master: Use new db session when retrying https://review.opendev.org/c/openstack/placement/+/898807 | |
| 16:45:37 | opendevreview | Pavlo Shchelokovskyy proposed openstack/placement master: Use new db session when retrying https://review.opendev.org/c/openstack/placement/+/898807 | |
| 18:13:19 | bauzas | not fun: we had the exact same issue with rolling upgrade in Victoria>Wallaby on rebuild https://review.opendev.org/c/openstack/nova/+/761458/ | |
| 18:13:28 | bauzas | so we really need a grenade test on it | |
| 18:13:37 | bauzas | and perhaps some hacking check, I dunno | |
| 18:14:42 | bauzas | I'll write the fixes tomorrow morning | |
| 18:15:23 | bauzas | and yeah, we don't test rebuild https://github.com/openstack/nova/blob/master/.zuul.yaml#L560 | |
| 21:49:08 | opendevreview | Pavlo Shchelokovskyy proposed openstack/nova master: Deprecate use_cow_images and 'default' images_type https://review.opendev.org/c/openstack/nova/+/898229 | |
| 21:49:08 | opendevreview | Pavlo Shchelokovskyy proposed openstack/nova master: Fix image conversion check in finish_migration https://review.opendev.org/c/openstack/nova/+/897842 | |
| 23:01:00 | opendevreview | melanie witt proposed openstack/nova stable/zed: Remove use of removeprefix https://review.opendev.org/c/openstack/nova/+/899148 | |
| 23:54:50 | opendevreview | Merged openstack/nova master: fix sphinx-lint issues in releasenotes https://review.opendev.org/c/openstack/nova/+/897087 | |
| 23:54:58 | opendevreview | Merged openstack/nova master: fix sphinx-lint issues in api guide https://review.opendev.org/c/openstack/nova/+/897088 | |
| #openstack-nova - 2023-10-25 | |||
| 01:41:10 | melwitt | bauzas: I did a little bit of belated bug triage on my turn in the bug triage roster, sorry I didn't get around to it earlier 😟 | |
| 01:41:10 | melwitt | bauzas: I did a little bit of belated bug triage on my turn in the bug triage roster, sorry I didn't get around to it earlier 😟 | |
| 06:02:35 | auniyal | its frequent - https://zuul.openstack.org/builds?job_name=openstacksdk-functional-devstack+&project=openstack%2Fnova&branch=stable%2F2023.1&skip=0 | |
| 06:02:35 | auniyal | openstacksdk-functional-devstack is failing for branch: stable/2023.1, because there is a conflict in openstacksdk version, | |
| 06:06:09 | opendevreview | Amit Uniyal proposed openstack/nova stable/2023.2: Translate VF network capabilities to port binding https://review.opendev.org/c/openstack/nova/+/899225 | |
| 07:04:03 | gibi | melwitt bauzas: I felt bad after the yesterday sessions so I also did some bug triage :) | |
| 07:12:31 | kashyap | gibi: Morning. I started a crude version of it here, to get the ball rolling: https://review.opendev.org/c/openstack/nova/+/899185 | |
| 07:13:57 | kashyap | gibi: By publicly admitting that, you're implicitly making me feel guilty for not doing enough upstream bug triage | |
| 07:20:33 | bauzas | gibi: melwitt: sending all e-hugs to both of you <3 | |
| 07:28:52 | frickler | auniyal: see https://review.opendev.org/q/topic:gate-fix-unpin-osdk , seems we need that for all stable branches now (except 2023.2) | |
| 08:05:14 | opendevreview | Amit Uniyal proposed openstack/nova stable/2023.1: Translate VF network capabilities to port binding https://review.opendev.org/c/openstack/nova/+/898945 | |
| 08:05:50 | opendevreview | Amit Uniyal proposed openstack/nova stable/zed: Translate VF network capabilities to port binding https://review.opendev.org/c/openstack/nova/+/899229 | |
| 09:04:26 | opendevreview | Sylvain Bauza proposed openstack/nova master: Fix rebuild compute RPC API exception for rolling-upgrades https://review.opendev.org/c/openstack/nova/+/899235 | |
| 09:04:26 | opendevreview | Sylvain Bauza proposed openstack/nova master: add a regression test for all compute RPCAPI 6.x pinnings for rebuild https://review.opendev.org/c/openstack/nova/+/899234 | |
| 09:04:41 | bauzas | noonedeadpunk: ^ | |
| 09:05:21 | bauzas | I'll look at how grenade can verify rebuild instances | |
| 09:07:41 | noonedeadpunk | bauzas: thanks for working on that! | |
| 09:08:07 | bauzas | once it's approved, I'll backport those down to Zed | |
| 09:16:15 | bauzas | interesting, I only find 2 tempest tests that verify rebuild | |
| 09:16:45 | bauzas | https://github.com/openstack/tempest/blob/d1742bad94e94ebabe875ed24415d1ff510a5ae7/tempest/api/compute/servers/test_server_actions.py#L395-L473 | |
| 09:40:31 | gibi | kashyap: thanks for the patch please keep me reminded about it if I don't show up reviewing it. This week and next week is pretty hectic | |
| 09:40:55 | gibi | bauzas: maybe we need to do more public shaming of people to get them to triage bugs :D | |
| 09:41:16 | kashyap | gibi: Right, it'll be the week after. The patch doesn't deserve your review yet, but I'll need some help as I want to be careful not to introduce any other subtle issues | |
| 09:42:17 | gibi | kashyap: I think you can create a local reproduction for it with a multi node devstack if you set the cpu_mode to host model (and maybe tweek the devstack VMs so libvirt reports different cpu for capabilities and domcapabiltities) | |
| 09:42:51 | gibi | or you can try the same in an upstream CI patch | |
| 09:43:15 | gibi | in the CI we set cpu_mode=custom so you can try to change that to host-model | |
| 09:43:26 | kashyap | gibi: The DevStack VMs (level-1 guests) should be CentOS9 stream, yeah? | |
| 09:43:41 | gibi | kashyap: in my case the lvl1 was centos stream 9 | |
| 09:43:56 | gibi | but I think for the repro it is enough the have different cap and domcap reported | |
| 09:44:00 | gibi | + host-model | |
| 09:44:08 | kashyap | Yeah | |
| 09:44:15 | kashyap | gibi: For an upstream CI test, which job do you suggest to change? | |
| 09:45:23 | gibi | we have a live migration job | |
| 09:45:57 | gibi | (ahh my other devstack based on ubuntu lvl1 reports the same for cap and domcap so lvl1 OS matters) | |
| 09:46:36 | gibi | kashyap: this is our live migration job https://github.com/openstack/nova/blob/master/.zuul.yaml#L102 | |
| 09:46:37 | kashyap | Ah, good that you checked | |
| 09:47:09 | kashyap | (On Ubuntu setup) | |
| 09:47:17 | gibi | you can try to add | |
| 09:47:18 | gibi | $NOVA_CPU_CONF: | |
| 09:47:18 | gibi | post-config: | |
| 09:47:18 | gibi | devstack_local_conf: | |
| 09:47:32 | gibi | to that job | |
| 09:47:36 | gibi | to pass nova config | |
| 09:47:55 | gibi | similarly to https://github.com/openstack/nova/blob/master/.zuul.yaml#L400C1-L402C26 | |
| 09:51:19 | kashyap | gibi: Ah, thank you! Handy example | |
| 09:56:49 | bauzas | gibi: about the upstream tempest jobs, wdyt if I add https://github.com/openstack/tempest/blob/d1742bad94e94ebabe875ed24415d1ff510a5ae7/tempest/api/compute/servers/test_server_actions.py#L395-L473 to the grenade-multinode job ? | |
| 09:57:12 | bauzas | I don't see any other tempest test for rebuild apart from the volume one | |
| 09:57:45 | bauzas | in https://github.com/openstack/nova/blob/master/.zuul.yaml#L560 we only check the smoke tests and the live-migration ones | |
| 09:58:06 | bauzas | which is not a long list https://0fd77280b0334417b6ee-1d67ec5eb204f28641a7073258861323.ssl.cf5.rackcdn.com/877410/7/check/nova-grenade-multinode/4e93584/testr_results.html | |
| 09:58:41 | gibi | bauzas: yeah it make sense to add a rebuild test to grenade | |
| 09:58:52 | bauzas | oh wait, I'm wrong | |
| 09:58:54 | bauzas | https://github.com/openstack/tempest/blob/d1742bad94e94ebabe875ed24415d1ff510a5ae7/tempest/api/compute/servers/test_server_actions.py#L263 | |
| 09:59:21 | bauzas | oh no, we just test test_reboot_server_hard[id-2cb1baf6-ac8d-4429-bf0d-ba8a0ba53e32,smoke] | |
| 09:59:59 | bauzas | so, two possibilities : either we make rebuild_server a smoke test in tempest, or we change grenade | |
| 10:00:18 | gibi | there are simpler rebuild servers like https://github.com/openstack/tempest/blob/d1742bad94e94ebabe875ed24415d1ff510a5ae7/tempest/api/compute/servers/test_servers_microversions.py#L40 | |
| 10:01:11 | bauzas | test_rebuild_server seems enough simple to me https://github.com/openstack/tempest/blob/d1742bad94e94ebabe875ed24415d1ff510a5ae7/tempest/api/compute/servers/test_server_actions.py#L262-L278 | |
| 10:01:32 | bauzas | and it doesn't depend on microversion check | |