| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-09-22 | |||
| 12:29:07 | bauzas | I'm personnally against such things because I think it negates the stance of writing, but this is a personal opinion and absolutely not arguable | |
| 12:29:22 | sean-k-mooney | and ansible... but it has renifoced that feelting that auto liniting is good | |
| 12:29:58 | sean-k-mooney | and auto formating is both good for the reviewer and author | |
| 12:30:31 | bauzas | I can't wait for a ChatGPT bot on Visual Code | |
| 12:30:43 | bauzas | VS Code* | |
| 12:30:52 | stephenfin | https://marketplace.visualstudio.com/items?itemName=GitHub.copilotvs | |
| 12:30:55 | sean-k-mooney | hehe i already use code poilte ot help writhe my comments | |
| 12:31:04 | sean-k-mooney | its why they have had less typos lately | |
| 12:31:27 | bauzas | and yeah, I heard about GH CoPilot | |
| 12:32:00 | sean-k-mooney | it daydreams a bit so unless you know the code base i would not recomend it to new commers | |
| 12:33:24 | sean-k-mooney | i have mostly been using it of go/ansible but i find i have to check its work and rewite it but its often close to what i would write | |
| 12:33:26 | bauzas | that's the problem with those AI tools | |
| 12:33:36 | bauzas | 95% of the job is perfectly done | |
| 12:33:48 | bauzas | and then the rest is errorprone | |
| 12:33:59 | sean-k-mooney | yep and that last 5% is where being a software engineer comes in | |
| 12:34:25 | bauzas | I'm not sure my productivity will raise because of a bot writing my code | |
| 12:34:26 | sean-k-mooney | using your expirnce ot understand its probmpts and correct them | |
| 12:35:21 | bauzas | most of the time it takes for me to write a feature is : 1/ identify the gaps, 2/ come with a proposal, 3/ let the community agree on the proposal, 4/ write that | |
| 12:35:33 | bauzas | the 4/ isn't exactly hard to do | |
| 12:36:41 | sean-k-mooney | sure and most of the process of adding a feature into nova is code review | |
| 12:36:53 | sean-k-mooney | not wirting the code in the first place | |
| 12:37:41 | bauzas | honestly, I feel the entry barrier on Nova isn't because we're not having black style and autoformatters | |
| 12:38:19 | bauzas | but rather because it's a very large distributed software contributed by many in different times | |
| 12:38:34 | bauzas | and I don't think autoformatters will lower this barrier | |
| 12:38:51 | sean-k-mooney | sure but that misses the point | |
| 12:39:45 | bauzas | which is that people can autotab their brackets ? | |
| 12:40:04 | sean-k-mooney | no | |
| 12:40:05 | stephenfin | it's a quality of life improvement | |
| 12:40:09 | sean-k-mooney | yep | |
| 12:40:42 | stephenfin | being a surgeon is hard: working in a clean operating theatre makes it slightly easier | |
| 12:41:01 | bauzas | I see myself more like a butcher :D | |
| 12:41:15 | bauzas | anyway, I stink and I need to get a shower | |
| 12:41:17 | stephenfin | then black is a sharp knife | |
| 12:41:20 | stephenfin | ;) | |
| 12:41:38 | stephenfin | or rather an automatic knife sharpener | |
| 12:41:55 | sean-k-mooney | i was going to play the frech card and say its a Charcuterie | |
| 12:42:01 | bauzas | stephenfin: if we continue the analogy, people can get hurt by a sharp knife if they don't know how to use it :) | |
| 12:42:29 | sean-k-mooney | which is another reason my analogy is better :) | |
| 12:43:08 | sean-k-mooney | be a charcutier not a butcher of our lovely codebase :) | |
| 12:55:40 | sean-k-mooney | stephenfin: since your about can you look at https://review.opendev.org/c/openstack/nova/+/895655 | |
| 12:56:17 | sean-k-mooney | once thats merged i can propsoe the revert adn ping it to rodolfo and co so we can renable it once neutron says the test is fixed for ovn | |
| 12:56:32 | stephenfin | ack, done | |
| 12:56:56 | sean-k-mooney | that test is one of the thing that cased the hackign patch to fail | |
| 12:57:12 | sean-k-mooney | the other failure was volume detach related | |
| 13:05:01 | bauzas | fwiw, starting to look at the rest of sql14 series | |
| 13:09:04 | opendevreview | Felix Huettner proposed openstack/nova master: ignore errors when deleting volume attachments https://review.opendev.org/c/openstack/nova/+/896235 | |
| 13:18:05 | bauzas | okay, this is Friday, I'm not a better and decent position to start a debate https://luminousmen.com/post/my-unpopular-opinion-about-black-code-formatter | |
| 13:18:30 | bauzas | now* | |
| 13:18:57 | sean-k-mooney | for what its worht a number of opentack proejct have arelady adopted black | |
| 13:19:09 | bauzas | that doesn't make the point valid :) | |
| 13:19:12 | sean-k-mooney | we already have autopep8 which was a compomise | |
| 13:19:58 | bauzas | yup, and which doesn't force your code to change, right? | |
| 13:20:14 | bauzas | just because a ending bracket has to be on a separate line | |
| 13:20:17 | sean-k-mooney | it only fixes code if it not pep8 complient | |
| 13:20:33 | sean-k-mooney | and it undersands the things we disable in tox.ini | |
| 13:20:57 | bauzas | black is *very* noisy in terms of code change since it can't adapt to the existing code style | |
| 13:21:11 | sean-k-mooney | i.e. it reads https://github.com/openstack/nova/blob/master/tox.ini#L307 | |
| 13:21:21 | bauzas | and it forces us to do the way blacks thinks being the best | |
| 13:22:16 | sean-k-mooney | i think that is better then use disagreeing on what is the best style | |
| 13:22:30 | bauzas | btw. this twitter post which is replied by Guido is absolutly gold | |
| 13:23:16 | sean-k-mooney | bauzas: by the way i actully dont really care what the tool is provide we have one that does it | |
| 13:23:23 | bauzas | it shows the mindset of many developers : in order to follow *best* practices of coding, it says "install X and Y" | |
| 13:23:37 | bauzas | my head explodes when I read this | |
| 13:23:54 | bauzas | I thought for 2 decades that coding best practices were about code patterns and reusability | |
| 13:24:21 | sean-k-mooney | partly but we are not talking about best praticies | |
| 13:24:36 | sean-k-mooney | if you think we are then again your are missing the point | |
| 13:24:40 | bauzas | sean-k-mooney: read my link above, you'll see this tweet :) | |
| 13:24:47 | sean-k-mooney | i have seen those before | |
| 13:28:24 | bauzas | ouch https://black.readthedocs.io/en/stable/guides/introducing_black_to_your_project.html#avoiding-ruining-git-blame | |
| 13:47:39 | bauzas | sean-k-mooney: just in order to move on black and because I want to exactly understand the implications, do you know how the other projects manage the git blame mangling thing ? | |
| 13:48:24 | sean-k-mooney | i belvie you can annotate the commit to be ignored for blame | |
| 13:48:47 | sean-k-mooney | and it will then not be seein in github or locally by default | |
| 13:49:17 | sean-k-mooney | bauzas: which stephen did there https://review.opendev.org/c/openstack/nova/+/896231 | |
| 13:49:26 | bauzas | yeah, that's what black is saying on their docs | |
| 13:49:55 | bauzas | okay, then that's planned, gtk | |
| 13:56:32 | sean-k-mooney | yep its definetly a nice ux improvment ot have that | |
| 13:57:24 | sean-k-mooney | althoguh i woudl also take blame working in github at all on the libvirt driver... | |
| 17:34:41 | opendevreview | Merged openstack/nova master: Fix pep8 errors with new hacking https://review.opendev.org/c/openstack/nova/+/874517 | |
| #openstack-nova - 2023-09-23 | |||
| 08:21:53 | opendevreview | Takashi Natsume proposed openstack/nova master: Update contributor guide for 2024.1 Caracal https://review.opendev.org/c/openstack/nova/+/896305 | |
| 19:08:41 | opendevreview | Elod Illes proposed openstack/nova stable/2023.2: [stable-only] Update .gitreview for stable/2023.2 https://review.opendev.org/c/openstack/nova/+/896019 | |
| 19:09:53 | opendevreview | Elod Illes proposed openstack/nova stable/2023.2: [stable-only] Update TOX_CONSTRAINTS_FILE for stable/2023.2 https://review.opendev.org/c/openstack/nova/+/896020 | |
| 19:59:25 | opendevreview | Merged openstack/nova stable/2023.2: [stable-only] Update .gitreview for stable/2023.2 https://review.opendev.org/c/openstack/nova/+/896019 | |
| 20:02:03 | frickler | why is nova-tox-validate-backport non-voting in check, but voting in gate? seems inconsistent | |
| 20:06:13 | opendevreview | Merged openstack/nova stable/2023.2: [stable-only] Update TOX_CONSTRAINTS_FILE for stable/2023.2 https://review.opendev.org/c/openstack/nova/+/896020 | |
| #openstack-nova - 2023-09-24 | |||
| 14:56:33 | mo | Hello :) Nova newbie here, sorry to interrupt but I'm a bit lost trying to understand Nova's code, can you refer me to a good place to start? I've already read the developer docs (https://docs.openstack.org/nova/ocata). thanks ! | |
| #openstack-nova - 2023-09-25 | |||
| 04:35:11 | opendevreview | Yonghyun Kim proposed openstack/nova master: Fixed 500 response error for concurrent API requests. https://review.opendev.org/c/openstack/nova/+/896320 | |
| 06:07:36 | elodilles | frickler: mainly to avoid unnecessary rechecks | |
| 09:09:59 | lajoskatona | bauzas: Hi, quick question regarding libvirt/os support matrix: https://wiki.openstack.org/wiki/LibvirtDistroSupportMatrix | |
| 09:10:47 | lajoskatona | bauzas: is there any hanging or abandoned patch to update this doc for 2023.1 and .2? I can't find it... :-( | |
| 09:17:42 | frickler | lajoskatona: that's a wiki page, were you intending to refer to something in nova docs? wiki pages don't get updated by patches and this one looks pretty abandoned | |
| 09:19:10 | frickler | elodilles: I'm not convinced that trading reducing rechecks for increasing gate failures is the right direction, ymmv | |
| 09:20:29 | lajoskatona | frickler: sorry, there's a doc page also: https://docs.openstack.org/nova/latest/reference/libvirt-distro-support-matrix.html | |
| 09:21:01 | lajoskatona | frickler: it's one release fresher with xena included | |
| 09:21:41 | frickler | lajoskatona: that still looks pretty outdated, that's sad indeed | |
| 09:22:59 | bauzas | lajoskatona: yes, please use the above HTML | |
| 09:24:01 | frickler | bauzas: the question is why this isn't updated for Zed and beyond | |
| 09:24:21 | bauzas | I can ask kashyap to add the new versions for Zed and more | |
| 09:24:27 | lajoskatona | frickler, bauzas: exactly | |
| 09:25:03 | lajoskatona | bauzas: thanks that would be nice, it is quite hard to check the reno pages for related entries | |
| 09:25:51 | elodilles | frickler: well, in case of proper (not stable-only) patches we only +W patches that have merged versions in N+1 branch, so then the gate won't fail, but we spare some unnecessary rechecks. so that is quite rare where we accidentally accept patches that is failing on gate with this validation | |