| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-09-22 | |||
| 11:55:53 | stephenfin | That's what I was talking about. We just disable E501 because it's not worth the hassle of manually fixing the dozen or so exceptions | |
| 11:56:22 | stephenfin | It also avoids questions from contributors less familiar with the tooling. We can just tell them "run this and you'll get no style-related questions" | |
| 11:56:36 | sean-k-mooney | ya if other are ok with that then i would be infavor of the general useablity improvement | |
| 11:56:43 | stephenfin | (as opposed to "run this and then manually fix things if you still get errors") | |
| 11:56:47 | sean-k-mooney | although the eiarlier patches i htink should be done regradless | |
| 11:56:54 | sean-k-mooney | so ill start reveiwign those | |
| 11:56:56 | stephenfin | yup | |
| 11:57:13 | stephenfin | I put those at the front since they should be non-controversial | |
| 12:04:04 | frickler | while you're doing linting stuff, please also check https://review.opendev.org/c/openstack/nova/+/874517 , it seems to keep failing on unrelated issues | |
| 12:04:56 | sean-k-mooney | some of that might get adresses by these patches as well but sure | |
| 12:05:25 | sean-k-mooney | ya the bump to the new autopep8 fixes many of the hacking issues | |
| 12:05:48 | stephenfin | oh yeah, there's quite a bit of overlap there. The only thing mine are missing is the switch from printf style formatting (%) to use of string.format. I wonder why I didn't have to worry about that? | |
| 12:06:11 | sean-k-mooney | its not a pep8 requriement | |
| 12:06:24 | sean-k-mooney | and i would honestly prefer to go to fstring if we were updating them | |
| 12:06:38 | frickler | o.k., if that's no longer needed, just updating https://review.opendev.org/c/openstack/hacking/+/874516 would also be fine to me | |
| 12:06:54 | frickler | and once that's done we can do the next flake8 bump in hacking ;) | |
| 12:07:00 | bauzas | stephenfin: sorry was outside sweating | |
| 12:07:19 | bauzas | stephenfin: sure, if we want to merge your series, I prefer to do this on the starting Caracal :) | |
| 12:11:17 | sean-k-mooney | frickler: so stephen's partches are largely generated form tools | |
| 12:11:27 | stephenfin | bauzas: tbf, we say that every cycle and then we forget to look at it until the end of the cycle (see all discussions on the outstanding sqlalchemy 2.x work from last week) 0:) | |
| 12:11:44 | bauzas | stephenfin: that's why this is fresh in my mind | |
| 12:11:47 | stephenfin | the changes (except for the black one) are minimal and we've cut the branch, can we review now and if we need to fast revert, we can | |
| 12:11:49 | sean-k-mooney | so we will just proceed with the hacking fix patch and then regeenrate the ones that are still needed form there pre-commit series | |
| 12:12:39 | stephenfin | it'd likely be a win for you too: if we operated this way, I'd have stopped annoying you about sqlalchemy 2.x ~6 months ago XD | |
| 12:12:49 | stephenfin | sean-k-mooney: wfm | |
| 12:13:10 | sean-k-mooney | RC1 and stable/2023.2 have been done now | |
| 12:13:27 | sean-k-mooney | so i think now is a perfect time to do linting updates to be honest | |
| 12:16:07 | bauzas | can we try to not mix linter changes *and* SQLA things at the same time ? | |
| 12:16:27 | sean-k-mooney | they are two diffent serise | |
| 12:16:31 | bauzas | I know | |
| 12:16:44 | bauzas | but you know my backportability concerns about any linting change | |
| 12:17:27 | sean-k-mooney | yep and you knwo i disagree with that stance. that said the early one should have no impact | |
| 12:17:30 | bauzas | those need to be reasonabily needing a reason, because it makes any other backports a pain | |
| 12:17:54 | bauzas | we suffered a lot with functional tests refactoring, but this was kinda understansable | |
| 12:18:11 | bauzas | since it was improving tests reusability | |
| 12:18:16 | stephenfin | bauzas: out of curiosity, could you point to a recent case where a backport was impeded because of one of these linting change? | |
| 12:18:20 | sean-k-mooney | honetsly not automating this makes it harder for use to maintain nova | |
| 12:19:02 | sean-k-mooney | and it makes it harder for new peopel to continbue. with the reduced upstream comunity i think it would be in our intereste to embrance this automation where we can | |
| 12:19:08 | bauzas | stephenfin: I don't have any examples of the linting changes in mind, but be sure we faced some problems for other bits | |
| 12:19:25 | bauzas | sean-k-mooney: I understand that point for refactoring things | |
| 12:19:37 | bauzas | sean-k-mooney: but for linting, I seriously argue | |
| 12:20:06 | sean-k-mooney | yep and ill happy argue back | |
| 12:20:17 | bauzas | code style modifications being even less convincing to me | |
| 12:20:59 | sean-k-mooney | honestly i have spend enough time this cycle on sytle issues in code review | |
| 12:21:17 | sean-k-mooney | that if this is the only thing we got done in caracal i woudl consider it a success | |
| 12:21:45 | bauzas | I know it's Friday, but is this a reason to argue now ? | |
| 12:22:38 | sean-k-mooney | i mean its friday what else would we do | |
| 12:22:45 | stephenfin | :) | |
| 12:22:48 | sean-k-mooney | go home early and realx | |
| 12:24:07 | bauzas | I already sweated and now I have endorphins | |
| 12:24:24 | bauzas | not sure my stress level should jump, not good for my heart | |
| 12:24:27 | sean-k-mooney | if the wether stays ok i might go for a bike ride later | |
| 12:24:49 | sean-k-mooney | althogh its a bit humid out so we will see | |
| 12:24:53 | bauzas | seriously, I'm half-kidding, but feel free to put code styling and autoformatters on the PTG agenda | |
| 12:25:05 | opendevreview | Merged openstack/nova master: db: Replace use of backref https://review.opendev.org/c/openstack/nova/+/860829 | |
| 12:25:12 | bauzas | not sure my opinion will evolve but I'm still open to discuss about it | |
| 12:25:36 | bauzas | I just don't think the benefits overcome the pain | |
| 12:26:01 | sean-k-mooney | honestly the pain of not having them makes me somethimes condier if i wnat to keep manintianing nova | |
| 12:26:11 | bauzas | and about exceprts of code changes that pulled extra complexity into backports, I can do some homework and find some series | |
| 12:26:32 | sean-k-mooney | bauzas: i would happly backport the autofromating if that woudl make you feel beeter | |
| 12:26:36 | bauzas | not out of my head at first sight unfortunately, but there are experiences for sure | |
| 12:26:49 | bauzas | sean-k-mooney: down to Train ? :) | |
| 12:26:53 | sean-k-mooney | sure | |
| 12:27:03 | sean-k-mooney | the patches would be generated by the tool | |
| 12:27:15 | sean-k-mooney | we woudl jsut have to review it once and its done for ever | |
| 12:27:40 | sean-k-mooney | if that is your main objection its sovleabel. but im also oke with fixing this when backporting | |
| 12:28:27 | bauzas | that's indeed my main objection, beyond just a feeling | |
| 12:28:52 | sean-k-mooney | as you know i have been working in both go and python lately | |
| 12:29:07 | bauzas | I'm personnally against such things because I think it negates the stance of writing, but this is a personal opinion and absolutely not arguable | |
| 12:29:22 | sean-k-mooney | and ansible... but it has renifoced that feelting that auto liniting is good | |
| 12:29:58 | sean-k-mooney | and auto formating is both good for the reviewer and author | |
| 12:30:31 | bauzas | I can't wait for a ChatGPT bot on Visual Code | |
| 12:30:43 | bauzas | VS Code* | |
| 12:30:52 | stephenfin | https://marketplace.visualstudio.com/items?itemName=GitHub.copilotvs | |
| 12:30:55 | sean-k-mooney | hehe i already use code poilte ot help writhe my comments | |
| 12:31:04 | sean-k-mooney | its why they have had less typos lately | |
| 12:31:27 | bauzas | and yeah, I heard about GH CoPilot | |
| 12:32:00 | sean-k-mooney | it daydreams a bit so unless you know the code base i would not recomend it to new commers | |
| 12:33:24 | sean-k-mooney | i have mostly been using it of go/ansible but i find i have to check its work and rewite it but its often close to what i would write | |
| 12:33:26 | bauzas | that's the problem with those AI tools | |
| 12:33:36 | bauzas | 95% of the job is perfectly done | |
| 12:33:48 | bauzas | and then the rest is errorprone | |
| 12:33:59 | sean-k-mooney | yep and that last 5% is where being a software engineer comes in | |
| 12:34:25 | bauzas | I'm not sure my productivity will raise because of a bot writing my code | |
| 12:34:26 | sean-k-mooney | using your expirnce ot understand its probmpts and correct them | |
| 12:35:21 | bauzas | most of the time it takes for me to write a feature is : 1/ identify the gaps, 2/ come with a proposal, 3/ let the community agree on the proposal, 4/ write that | |
| 12:35:33 | bauzas | the 4/ isn't exactly hard to do | |
| 12:36:41 | sean-k-mooney | sure and most of the process of adding a feature into nova is code review | |
| 12:36:53 | sean-k-mooney | not wirting the code in the first place | |
| 12:37:41 | bauzas | honestly, I feel the entry barrier on Nova isn't because we're not having black style and autoformatters | |
| 12:38:19 | bauzas | but rather because it's a very large distributed software contributed by many in different times | |
| 12:38:34 | bauzas | and I don't think autoformatters will lower this barrier | |
| 12:38:51 | sean-k-mooney | sure but that misses the point | |
| 12:39:45 | bauzas | which is that people can autotab their brackets ? | |
| 12:40:04 | sean-k-mooney | no | |
| 12:40:05 | stephenfin | it's a quality of life improvement | |
| 12:40:09 | sean-k-mooney | yep | |
| 12:40:42 | stephenfin | being a surgeon is hard: working in a clean operating theatre makes it slightly easier | |
| 12:41:01 | bauzas | I see myself more like a butcher :D | |
| 12:41:15 | bauzas | anyway, I stink and I need to get a shower | |