Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2023-09-20
13:09:12 sahid sean-k-mooney: oh that is interesting
13:10:08 sean-k-mooney in general its still good to not trun it off but its there to wrokaround the fact that neutron can currpt the network info cache if ti returns partial results
13:10:43 sahid yes i think we will try to be consersavatif on keep it
13:10:44 sean-k-mooney cisco aci or other core plugins that use external databases
13:10:53 sean-k-mooney were partically prone to makeing port list falky
13:11:07 sahid i see
13:11:34 sean-k-mooney what neutorn backend are ye using
13:12:39 sean-k-mooney we have considerd defaullting this to off in our downstream instller going forwrad but we havent actully done that yet
13:14:48 sean-k-mooney it might we worth consdierign defaulting it to off upstream or exteneding the default timeout upstream
13:54:23 sahid sean-k-mooney: we are using ovs
14:03:28 sean-k-mooney ml2/ovs is not one of the backend that partcalarly need the heal perodic
14:03:57 sean-k-mooney in fact its proably the one that is most tollererent to a long timeout or disableing it
14:05:40 opendevreview Danylo Vodopianov proposed openstack/nova-specs master: Re-propose using VirtIO PackedRing Configuration support for 2024.1 https://review.opendev.org/c/openstack/nova-specs/+/895924
14:06:29 sahid sean-k-mooney: thank you we will set it from 60 to 600 and then see if we can completly disable it
#openstack-nova - 2023-09-21
09:42:24 opendevreview Amit Uniyal proposed openstack/nova master: WIP:Adds device tagging functional tests https://review.opendev.org/c/openstack/nova/+/895162
10:04:52 manuvakery1 Hi .. I noticed that the Live migration is taking too long to complete and in the event show its showing the compute_check_can_live_migrate_destination is taking huge time
10:05:19 manuvakery1 "result": "Success",
10:05:19 manuvakery1 "finish_time": "2023-09-21T05:57:23.000000",
10:05:19 manuvakery1 "start_time": "2023-09-21T05:41:21.000000",
10:05:19 manuvakery1 "event": "compute_check_can_live_migrate_destination",
10:05:19 manuvakery1 {
10:05:20 manuvakery1 self.force_reraise()\n File \"/usr/lib/python3.6/site-packages/oslo_utils/excutils.py\", line 196, in force_reraise\n six.reraise(self.type_, self.value, self.tb)\n File \"/usr/lib/python3.6/site-packages/six.py\", line 693, in reraise\n raise value\n File \"/usr/lib/python3.6/site-packages/nova/compute/manager.py\", line 207, in decorated_function\n return function(self, context, *args, **kwargs)\n File
10:05:20 manuvakery1 "traceback": " File \"/usr/lib/python3.6/site-packages/nova/compute/utils.py\", line 1372, in decorated_function\n return function(self, context, *args, **kwargs)\n File \"/usr/lib/python3.6/site-packages/nova/compute/manager.py\", line 219, in decorated_function\n kwargs['instance'], e, sys.exc_info())\n File \"/usr/lib/python3.6/site-packages/oslo_utils/excutils.py\", line 220, in __exit__\n
10:05:22 manuvakery1 in _create_shared_storage_test_file\n fd, tmp_file = tempfile.mkstemp(dir=dirpath)\n File \"/usr/lib64/python3.6/tempfile.py\", line 344, in mkstemp\n return _mkstemp_inner(dir, prefix, suffix, flags, output_type)\n File \"/usr/lib64/python3.6/tempfile.py\", line 262, in _mkstemp_inner\n fd = _os.open(file, flags, 0o600)\n File \"/usr/lib/python3.6/site-packages/eventlet/green/os.py\", line 118, in open\n
10:05:22 manuvakery1 \"/usr/lib/python3.6/site-packages/nova/compute/manager.py\", line 6897, in check_can_live_migrate_destination\n block_migration, disk_over_commit)\n File \"/usr/lib/python3.6/site-packages/nova/virt/libvirt/driver.py\", line 8432, in check_can_live_migrate_destination\n filename = self._create_shared_storage_test_file(instance)\n File \"/usr/lib/python3.6/site-packages/nova/virt/libvirt/driver.py\", line 8749,
10:05:24 manuvakery1 }
10:05:24 manuvakery1 fd = __original_open__(file, flags, mode)\n"
10:05:58 manuvakery1 Any hint on this
10:36:55 opendevreview OpenStack Release Bot proposed openstack/nova stable/2023.2: Update .gitreview for stable/2023.2 https://review.opendev.org/c/openstack/nova/+/896019
10:36:59 opendevreview OpenStack Release Bot proposed openstack/nova stable/2023.2: Update TOX_CONSTRAINTS_FILE for stable/2023.2 https://review.opendev.org/c/openstack/nova/+/896020
10:37:03 opendevreview OpenStack Release Bot proposed openstack/nova master: Update master for stable/2023.2 https://review.opendev.org/c/openstack/nova/+/896021
13:08:00 opendevreview Pavlo Shchelokovskyy proposed openstack/nova master: Do not store InstanceInvalidState as instance_fault https://review.opendev.org/c/openstack/nova/+/860702
13:30:16 opendevreview Stephen Finucane proposed openstack/nova master: Implement add_consumer, remove_consumer KeyManager APIs https://review.opendev.org/c/openstack/nova/+/896100
14:12:02 bauzas just in case people don't know
14:12:06 bauzas welcome in Caracal !
17:52:30 opendevreview Merged openstack/placement stable/2023.2: Update .gitreview for stable/2023.2 https://review.opendev.org/c/openstack/placement/+/895491
17:52:32 opendevreview Merged openstack/placement stable/2023.2: Update TOX_CONSTRAINTS_FILE for stable/2023.2 https://review.opendev.org/c/openstack/placement/+/895492
#openstack-nova - 2023-09-22
03:20:53 opendevreview OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.opendev.org/c/openstack/nova/+/896175
09:07:53 bauzas fyi, folks, did the launchpad usual janitory for creating a new series and milestones on both placement and nova : https://launchpad.net/placement/2024.1 and https://launchpad.net/nova/2024.1
09:08:17 bauzas as you can see, I stopped using the release name to mock what we already have in our specs repo
09:36:05 opendevreview Merged openstack/nova master: Imported Translations from Zanata https://review.opendev.org/c/openstack/nova/+/896175
10:11:47 stephenfin bauzas: Can we merge the outstanding sqlalchemy 2.0 stuff now?
10:12:37 stephenfin actually, it's sean-k-mooney I should be asking. Sean, could you look at https://review.opendev.org/c/openstack/nova/+/860829/ again?
10:13:05 sean-k-mooney yes please
10:13:21 stephenfin though I am going to respin https://review.opendev.org/c/openstack/nova/+/886230 to address those regex warnings
10:15:19 sean-k-mooney what about https://review.opendev.org/c/openstack/nova/+/894635
10:16:11 opendevreview Stephen Finucane proposed openstack/nova master: Add job to test with SQLAlchemy master (2.x) https://review.opendev.org/c/openstack/nova/+/886230
10:16:43 stephenfin sean-k-mooney, bauzas: ^ fixed to address the RE2 warning from zuul. It's otherwise unchanged.
10:16:52 stephenfin sean-k-mooney: I'll clean that last patch up today
10:17:30 stephenfin actually, intermittent failure. That looks good to me now but I think bauzas wanted a little more proof that the relationships weren't used anywhere
10:17:49 stephenfin trying to figure out how I can prove that besides code inspection (I tried that. Too slow)
10:24:14 sean-k-mooney i didnt think it was related and likely just needed a retry
10:24:30 sean-k-mooney i was more wondifning if you still wanted to proceed with that patch
10:24:48 sean-k-mooney the first two in teh series are +2w ill review the ci patch shortly
11:00:17 opendevreview Felix Huettner proposed openstack/nova master: remove calls used for nova-network https://review.opendev.org/c/openstack/nova/+/896221
11:55:07 opendevreview Stephen Finucane proposed openstack/nova master: doc: Remove crud from conf.py file https://review.opendev.org/c/openstack/nova/+/896224
11:55:08 opendevreview Stephen Finucane proposed openstack/nova master: pre-commit: Update plugin versions https://review.opendev.org/c/openstack/nova/+/896226
11:55:08 opendevreview Stephen Finucane proposed openstack/nova master: Apply latest version of autopep8 https://review.opendev.org/c/openstack/nova/+/896225
11:55:09 opendevreview Stephen Finucane proposed openstack/nova master: pre-commit: Add mypy https://review.opendev.org/c/openstack/nova/+/896228
11:55:09 opendevreview Stephen Finucane proposed openstack/nova master: tox: Use pre-commit for pep8 target https://review.opendev.org/c/openstack/nova/+/896227
11:55:10 opendevreview Stephen Finucane proposed openstack/nova master: pre-commit: Integrate black https://review.opendev.org/c/openstack/nova/+/896230
11:55:10 opendevreview Stephen Finucane proposed openstack/nova master: Blacken codebase https://review.opendev.org/c/openstack/nova/+/896229
11:55:11 opendevreview Stephen Finucane proposed openstack/nova master: Ignore black change https://review.opendev.org/c/openstack/nova/+/896231
11:55:13 stephenfin sean-k-mooney: ^
11:55:48 sean-k-mooney :)
11:55:53 stephenfin That's what I was talking about. We just disable E501 because it's not worth the hassle of manually fixing the dozen or so exceptions
11:56:22 stephenfin It also avoids questions from contributors less familiar with the tooling. We can just tell them "run this and you'll get no style-related questions"
11:56:36 sean-k-mooney ya if other are ok with that then i would be infavor of the general useablity improvement
11:56:43 stephenfin (as opposed to "run this and then manually fix things if you still get errors")
11:56:47 sean-k-mooney although the eiarlier patches i htink should be done regradless
11:56:54 sean-k-mooney so ill start reveiwign those
11:56:56 stephenfin yup
11:57:13 stephenfin I put those at the front since they should be non-controversial
12:04:04 frickler while you're doing linting stuff, please also check https://review.opendev.org/c/openstack/nova/+/874517 , it seems to keep failing on unrelated issues
12:04:56 sean-k-mooney some of that might get adresses by these patches as well but sure
12:05:25 sean-k-mooney ya the bump to the new autopep8 fixes many of the hacking issues
12:05:48 stephenfin oh yeah, there's quite a bit of overlap there. The only thing mine are missing is the switch from printf style formatting (%) to use of string.format. I wonder why I didn't have to worry about that?
12:06:11 sean-k-mooney its not a pep8 requriement
12:06:24 sean-k-mooney and i would honestly prefer to go to fstring if we were updating them
12:06:38 frickler o.k., if that's no longer needed, just updating https://review.opendev.org/c/openstack/hacking/+/874516 would also be fine to me
12:06:54 frickler and once that's done we can do the next flake8 bump in hacking ;)
12:07:00 bauzas stephenfin: sorry was outside sweating
12:07:19 bauzas stephenfin: sure, if we want to merge your series, I prefer to do this on the starting Caracal :)
12:11:17 sean-k-mooney frickler: so stephen's partches are largely generated form tools
12:11:27 stephenfin bauzas: tbf, we say that every cycle and then we forget to look at it until the end of the cycle (see all discussions on the outstanding sqlalchemy 2.x work from last week) 0:)
12:11:44 bauzas stephenfin: that's why this is fresh in my mind
12:11:47 stephenfin the changes (except for the black one) are minimal and we've cut the branch, can we review now and if we need to fast revert, we can
12:11:49 sean-k-mooney so we will just proceed with the hacking fix patch and then regeenrate the ones that are still needed form there pre-commit series
12:12:39 stephenfin it'd likely be a win for you too: if we operated this way, I'd have stopped annoying you about sqlalchemy 2.x ~6 months ago XD
12:12:49 stephenfin sean-k-mooney: wfm
12:13:10 sean-k-mooney RC1 and stable/2023.2 have been done now
12:13:27 sean-k-mooney so i think now is a perfect time to do linting updates to be honest
12:16:07 bauzas can we try to not mix linter changes *and* SQLA things at the same time ?
12:16:27 sean-k-mooney they are two diffent serise
12:16:31 bauzas I know
12:16:44 bauzas but you know my backportability concerns about any linting change
12:17:27 sean-k-mooney yep and you knwo i disagree with that stance. that said the early one should have no impact
12:17:30 bauzas those need to be reasonabily needing a reason, because it makes any other backports a pain
12:17:54 bauzas we suffered a lot with functional tests refactoring, but this was kinda understansable
12:18:11 bauzas since it was improving tests reusability

Earlier   Later