| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-05-30 | |||
| 16:47:18 | dansmith | geguileo: okay | |
| 16:47:25 | geguileo | dansmith: if connect_volume is called, make sure that is used in all the instances that use the same cinder volume on that host | |
| 16:47:53 | dansmith | sounds like the solution is that we need to call connect_volume every time we're going to start an instance for any reason, and update the XML (rescue or otherwise) to use that value before we start | |
| 16:48:43 | geguileo | dansmith: that would be slower but safe | |
| 16:49:12 | geguileo | the optimised mechanism where we could tweak Nova to only do that when necessary could lead to unintended bugs | |
| 16:49:13 | bauzas | yeah, I was hoping some mechanism that would prevent the unnecessary roundtrip but if that's hard, then... | |
| 16:49:18 | dansmith | yeah I just don't know how we could do it safely otherwise, unless there's something that maintains an exclusive threadsafe set of host devices to make sure we never get them confused | |
| 16:50:02 | geguileo | dansmith: if the host doesn't reboot and connect_volume is not called again, then we could assume that the device is correct | |
| 16:50:13 | bauzas | geguileo: but we don't know thisq | |
| 16:50:27 | bauzas | geguileo: we only know about the service restart | |
| 16:50:40 | geguileo | bauzas: could nova query the uptime or something? | |
| 16:50:47 | dansmith | no :) | |
| 16:51:03 | geguileo | ok, then the whole connect_volume is probably the only way :'-( | |
| 16:51:08 | dansmith | let's not do anything like that for host or service uptime.. I think we just need to do the safe/slow approach | |
| 16:51:24 | bauzas | geguileo: we have other host-dependent resources like mdevs that we treat this way without requiring to know if it's a reboot | |
| 16:53:08 | geguileo | so I guess that's the solution then? | |
| 16:53:37 | dansmith | I think so.. not ideal for sure | |
| 16:53:43 | bauzas | in general, we follow some workflow which is "lookup my XML, find the specific resources attached, then query whatever needed to know whether those still exist, and if not, ask whatever else to recreate them" | |
| 16:54:08 | bauzas | (at service restart I mean) | |
| 16:54:35 | geguileo | with changes to cinder drivers we could have a proper check if it's valid, or have the connect-volume be faster (and idempotent when it can) | |
| 16:54:56 | geguileo | they would need to provide extra information to validate the device | |
| 16:55:10 | dansmith | let's do the slow/safe thing now, and if connect_volume() can be idempotent and faster in the future, then that's cool | |
| 16:55:20 | geguileo | dansmith: sounds like a plan | |
| 16:55:48 | geguileo | since that way the newer approach would probably not require additional nova changes | |
| 16:55:52 | geguileo | just os-brick and cinder | |
| 16:55:55 | dansmith | yep | |
| 16:56:59 | geguileo | ok, then I have nothing else to say on the topic | |
| 16:57:06 | dansmith | geguileo: unrelated, but since you're here.. what's cinder's plan for stable/train? | |
| 16:57:15 | dansmith | I assume no backports of this CVE back that far right? | |
| 16:57:23 | dansmith | and are you all thinking about EOLing at some point? | |
| 16:57:46 | geguileo | dansmith: definitely no backports that far | |
| 16:57:49 | dansmith | we have concerns about keeping branches open that look maintained but don't have backports of high-profile CVEs (two for us now) | |
| 16:58:08 | geguileo | I believe at some point it was discussed to stop supporting anything before Yoga | |
| 16:58:29 | dansmith | ack | |
| 16:58:36 | bauzas | anyway, we're on time | |
| 16:58:44 | bauzas | the nova meeting is ending in 1 min | |
| 16:59:07 | dansmith | thanks geguileo | |
| 16:59:16 | geguileo | thank you all | |
| 16:59:20 | bauzas | geguileo: dansmith: I guess we've arrived on a conclusion | |
| 16:59:25 | bauzas | thanks both of you | |
| 16:59:29 | bauzas | and thanks all | |
| 16:59:48 | bauzas | if nothing else, | |
| 16:59:53 | bauzas | bye | |
| 16:59:59 | opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2023/nova.2023-05-30-16.00.log.html | |
| 16:59:59 | opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2023/nova.2023-05-30-16.00.txt | |
| 16:59:59 | opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2023/nova.2023-05-30-16.00.html | |
| 16:59:59 | opendevmeet | Meeting ended Tue May 30 16:59:59 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 16:59:59 | bauzas | #endmeeting | |
| 17:00:09 | elodilles | thanks o/ | |
| 17:01:21 | stephenfin | Didn't bring it up in the meeting cos it doesn't belong there, but another round of +2s on the outstanding sqlalchemy-20 stuff would make my week and get us towards unblocking that in Bobcat. sean-k-mooney[m] has already spun through them | |
| 17:01:22 | stephenfin | All can be found here https://review.opendev.org/q/project:openstack/nova+topic:sqlalchemy-20+is:open | |
| 17:01:38 | stephenfin | Happy to answer any questions you may have on any/all of them | |
| 17:02:53 | bauzas | stephenfin: ack, no promises but I'll try to review them soon | |
| 17:03:01 | bauzas | stephenfin: bump me again next week if not | |
| 17:03:16 | stephenfin | will do, thanks bauzas | |
| 17:06:36 | opendevreview | Dan Smith proposed openstack/nova master: Add compute_id columns to instances, migrations https://review.opendev.org/c/openstack/nova/+/879499 | |
| 17:06:36 | opendevreview | Dan Smith proposed openstack/nova master: Populate ComputeNode.service_id https://review.opendev.org/c/openstack/nova/+/879904 | |
| 17:06:37 | opendevreview | Dan Smith proposed openstack/nova master: Add compute_id to Instance object https://review.opendev.org/c/openstack/nova/+/879500 | |
| 17:06:37 | opendevreview | Dan Smith proposed openstack/nova master: Add dest_compute_id to Migration object https://review.opendev.org/c/openstack/nova/+/879682 | |
| 17:06:38 | opendevreview | Dan Smith proposed openstack/nova master: Add online migration for Instance.compute_id https://review.opendev.org/c/openstack/nova/+/884752 | |
| 17:06:38 | opendevreview | Dan Smith proposed openstack/nova master: Online migrate missing Instance.compute_id fields https://review.opendev.org/c/openstack/nova/+/879905 | |
| 17:24:36 | dansmith | So, the last GPF kernel crash we had was a week ago | |
| 17:25:04 | dansmith | it was on the new cirros but it doesn't look exactly like what we saw before | |
| 17:25:27 | dansmith | but it does look related to acpi hotplug, which I assume is related to the volume attach or detach, and _is_ in one of those volume-having tests | |
| 17:26:33 | dansmith | so at this point I'd say the new cirros didn't fix it, but we'll have to wait for a few weeks of data to see if it's better or different | |
| 17:44:16 | frickler | dansmith: do you have a link to that crash handy? also we're right now publishing 0.6.2 with an updated kernel, that might help https://github.com/cirros-dev/cirros/actions/runs/5123918187 | |
| 17:45:45 | dansmith | frickler: here's the 0.6.1 one: https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_ad6/826755/16/check/nova-lvm/ad65569/job-output.txt | |
| 17:45:51 | dansmith | search for "general protection" | |
| 17:48:37 | opendevreview | Sylvain Bauza proposed openstack/nova stable/xena: Fix get_segments_id with subnets without segment_id https://review.opendev.org/c/openstack/nova/+/883725 | |
| 17:50:17 | opendevreview | Sylvain Bauza proposed openstack/nova stable/xena: Fix get_segments_id with subnets without segment_id https://review.opendev.org/c/openstack/nova/+/883725 | |
| 17:53:22 | opendevreview | Sylvain Bauza proposed openstack/nova stable/yoga: Fix get_segments_id with subnets without segment_id https://review.opendev.org/c/openstack/nova/+/883724 | |
| 17:55:05 | opendevreview | Sylvain Bauza proposed openstack/nova stable/xena: Fix get_segments_id with subnets without segment_id https://review.opendev.org/c/openstack/nova/+/883725 | |
| 18:02:54 | opendevreview | Sylvain Bauza proposed openstack/nova stable/wallaby: Fix get_segments_id with subnets without segment_id https://review.opendev.org/c/openstack/nova/+/883726 | |
| 20:57:01 | opendevreview | Merged openstack/nova master: db: Remove the legacy 'migration_version' table https://review.opendev.org/c/openstack/nova/+/872429 | |
| 21:50:10 | melwitt | jjm9ASDFGHJJKOL;;;;;'''' | |
| 21:51:33 | melwitt | geguileo: w2f | |
| 21:51:48 | melwitt | argh sorry | |
| 21:56:11 | dansmith | noice | |
| 21:59:24 | melwitt | 😆 | |
| 21:59:24 | melwitt | 😆 | |
| #openstack-nova - 2023-05-31 | |||
| 06:23:16 | LarsErikP | frickler: (reading backlog) - ok, thanks =) | |
| 07:40:01 | opendevreview | Sylvain Bauza proposed openstack/nova stable/xena: Fix segment-aware scheduling permissions error https://review.opendev.org/c/openstack/nova/+/884808 | |
| 07:44:30 | opendevreview | Sylvain Bauza proposed openstack/nova stable/xena: Fix segment-aware scheduling permissions error https://review.opendev.org/c/openstack/nova/+/884808 | |
| 07:46:55 | bauzas | elodilles: gibi: could you please give a swing to https://review.opendev.org/c/openstack/nova/+/883724 as a stable/yoga patch ? It would be nice thanks | |
| 07:47:50 | opendevreview | Sylvain Bauza proposed openstack/nova stable/xena: Fix get_segments_id with subnets without segment_id https://review.opendev.org/c/openstack/nova/+/883725 | |
| 07:48:51 | gibi | bauzas: I guess you mean the stable/zed first) | |
| 07:48:52 | gibi | :) | |
| 07:49:26 | bauzas | gibi: indeed | |
| 07:49:30 | bauzas | + yoga | |
| 07:50:01 | bauzas | I'm trying to backport https://review.opendev.org/c/openstack/nova/+/883725 down to wallaby but I also need to create some backport for https://review.opendev.org/c/openstack/nova/+/884808 down to Wallaby too | |
| 07:51:59 | gibi | bauzas: it seems that unit test errors in https://review.opendev.org/c/openstack/nova/+/883726 are relevant | |
| 07:52:24 | bauzas | gibi: indeed, I'm working atm on this | |
| 07:52:35 | bauzas | we need a dependent backport | |
| 07:53:17 | bauzas | https://review.opendev.org/c/openstack/nova/+/705792 hits me hard | |
| 07:53:40 | bauzas | that's why I sometimes hate to just modify a lot of methods :( | |
| 08:17:09 | opendevreview | Sylvain Bauza proposed openstack/nova stable/xena: Fix segment-aware scheduling permissions error https://review.opendev.org/c/openstack/nova/+/884808 | |
| 08:17:10 | opendevreview | Sylvain Bauza proposed openstack/nova stable/xena: Fix get_segments_id with subnets without segment_id https://review.opendev.org/c/openstack/nova/+/883725 | |
| 08:26:00 | opendevreview | Sylvain Bauza proposed openstack/nova stable/wallaby: Fix get_segments_id with subnets without segment_id https://review.opendev.org/c/openstack/nova/+/883726 | |
| 08:26:01 | opendevreview | Sylvain Bauza proposed openstack/nova stable/wallaby: Fix segment-aware scheduling permissions error https://review.opendev.org/c/openstack/nova/+/884830 | |
| 08:43:36 | bauzas | gibi: thanks for the stable reviews, could you also please look at https://review.opendev.org/c/openstack/nova/+/884808 ? | |