| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-05-17 | |||
| 10:38:21 | sean-k-mooney | just to get used to that process | |
| 10:38:49 | stephenfin | sean-k-mooney: https://github.com/openstack/openstacksdk/blob/master/openstack/compute/v2/server.py#L695-L707 ? | |
| 10:38:50 | sean-k-mooney | maybe on firday as a hack and hussel thing | |
| 10:39:12 | sean-k-mooney | hum ok so its in the sdk | |
| 10:39:18 | sean-k-mooney | so its just missing form osc | |
| 10:40:08 | sean-k-mooney | so adding a new "openstack server toplogy show" command shoudl not be hard | |
| 10:40:24 | sean-k-mooney | the show i guess is a littel reduntant | |
| 10:40:57 | sean-k-mooney | since there is only one action on that endpoint but i think its consitent with the other commands | |
| 10:41:35 | stephenfin | Yup, should be minimally complicated. I'd swear we had that also though... | |
| 10:41:37 | sean-k-mooney | if i try and write a patch for this on friday can you take a look if and give me pointers if i gest stuck | |
| 10:41:57 | sean-k-mooney | i think we missed it because its not in nova client as far as i can see | |
| 10:42:01 | sean-k-mooney | i tought we did too | |
| 10:42:14 | stephenfin | https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/server.html#server-show | |
| 10:42:27 | stephenfin | openstack server show --topology <server> | |
| 10:42:28 | sean-k-mooney | its not in server show intentionally | |
| 10:42:57 | sean-k-mooney | so that returns only the toplogy and not the rest of the server detail? | |
| 10:43:28 | sean-k-mooney | we made the point in the spec that this should not be part fo the server show api respocne for performance reasons | |
| 10:43:40 | sean-k-mooney | i guess as a client opt in it not terible | |
| 10:44:02 | stephenfin | Yeah. It's not how I'd personally do that normally since it's really a separate command but it predates my involvement in the project. Ditto for the --diagnostics argument | |
| 10:44:09 | sean-k-mooney | but that means the client is merging in a second api request into the output | |
| 10:44:20 | stephenfin | I moved 'server migrate --confirm' to 'server migration confirm' | |
| 10:45:12 | sean-k-mooney | ok if this is in the osc we have downstream for 17 i could suggest using it for verifying an instnac ehas been booted with a numa toplogy | |
| 10:45:19 | stephenfin | Yeah, it is. Client-side though | |
| 10:45:35 | sean-k-mooney | ok so if we have the supprot should i just leave it as it is | |
| 10:45:54 | stephenfin | For 17 I'd pull the Antelope version of OSC. It's so much better than the Wallaby version or whatever | |
| 10:45:58 | sean-k-mooney | i didnt find it as i was expecting it to be a seperate command sicne its a differnt api but its not without precended | |
| 10:46:00 | stephenfin | Ditto for SDK | |
| 10:46:07 | sean-k-mooney | we use server migrate for cold and live | |
| 10:46:11 | stephenfin | openstacksdk 1.0 is a big move forward | |
| 10:46:30 | sean-k-mooney | stephenfin: that has issues depeningon where you isntall it | |
| 10:46:50 | sean-k-mooney | you cant intall the pypi verisonon the undercloud becasue it use the rpm version to run tripleo | |
| 10:47:09 | sean-k-mooney | but any of our custoemr using it on there laptops shoudl defintly use it form pypi | |
| 10:47:18 | stephenfin | True | |
| 10:48:07 | sean-k-mooney | ok well thanks for confirming this is techinaly supproted | |
| 10:48:19 | sean-k-mooney | i guess ill park doing any refactorign for now | |
| 10:48:35 | sean-k-mooney | we could rename it but its proably not worth the upgrade impact | |
| 11:40:04 | dvo-plv_ | sen-k-mooney, Hello. Will you have some free time to verify new test for packed ring, which were created ? https://review.opendev.org/c/openstack/nova/+/876075 | |
| 11:48:25 | dvo-plv_ | sean-k-mooney: sorry, I've made a mistake in your nick | |
| 11:49:32 | sean-k-mooney | hehe i have done that in comments i left in the code so dont worry about it | |
| 11:50:23 | sean-k-mooney | dvo-plv_: and no i have not yet but ill try and take a look. i have a meeting at the top of the hour so im oging to go grab coffee but ill take a look at them when i get back | |
| 11:53:27 | dvo-plv_ | sure, we always should find time for coffee :) | |
| 14:09:06 | opendevreview | Carl Morris proposed openstack/nova master: Improving logging at '_numa_cells_support_network_metadata'. https://review.opendev.org/c/openstack/nova/+/860930 | |
| 14:16:44 | opendevreview | Carl Morris proposed openstack/nova master: Improving logging at '_numa_cells_support_network_metadata'. https://review.opendev.org/c/openstack/nova/+/860930 | |
| 15:04:03 | mnasiadka | Hello | |
| 15:04:23 | mnasiadka | Is there a reason https://review.opendev.org/c/openstack/nova/+/853267 backport has not been merged yet? | |
| 15:28:05 | opendevreview | melanie witt proposed openstack/nova master: Add debug logging when Instance raises OrphanedObjectError https://review.opendev.org/c/openstack/nova/+/883325 | |
| 15:40:33 | opendevreview | Mark Goddard proposed openstack/nova master: ironic: Let Ironic handle deployment cleanup actions during destroy https://review.opendev.org/c/openstack/nova/+/883411 | |
| 17:59:56 | sean-k-mooney | mnasiadka: review bandwith | |
| 18:00:09 | sean-k-mooney | i dont see any orhter reason its not merge ill take a look now | |
| 18:04:46 | sean-k-mooney | mnasiadka:they are on its way on yoga | |
| 18:05:34 | sean-k-mooney | mnasiadka: what branch do you need the fix on | |
| 23:20:36 | opendevreview | Merged openstack/nova stable/yoga: Reproducer for bug 1983753 https://review.opendev.org/c/openstack/nova/+/853266 | |
| 23:28:15 | opendevreview | Merged openstack/nova stable/yoga: Update RequestSpec.pci_request for resize https://review.opendev.org/c/openstack/nova/+/853267 | |
| 23:28:17 | opendevreview | Merged openstack/nova stable/yoga: Add reno for fixing bug 1941005 https://review.opendev.org/c/openstack/nova/+/853268 | |
| #openstack-nova - 2023-05-18 | |||
| 00:20:06 | opendevreview | melanie witt proposed openstack/nova master: Add debug logging when Instance raises OrphanedObjectError https://review.opendev.org/c/openstack/nova/+/883325 | |
| 04:24:12 | opendevreview | melanie witt proposed openstack/nova master: testing: Use the oslo.log ContextFormatter in the log fixture https://review.opendev.org/c/openstack/nova/+/883466 | |
| 04:26:46 | opendevreview | melanie witt proposed openstack/nova master: testing: Use the oslo.log ContextFormatter in the log fixture https://review.opendev.org/c/openstack/nova/+/883466 | |
| 06:25:24 | opendevreview | Amit Uniyal proposed openstack/nova master: Fixes a typo in availability-zone doc https://review.opendev.org/c/openstack/nova/+/883474 | |
| 11:40:49 | opendevreview | Mark Goddard proposed openstack/nova master: Fix PCI passthrough race on reschedule (refresh) https://review.opendev.org/c/openstack/nova/+/710848 | |
| 11:40:49 | opendevreview | Mark Goddard proposed openstack/nova master: Add functional regression test for 1860555 https://review.opendev.org/c/openstack/nova/+/760354 | |
| 12:29:21 | dvo-plv | sean-k-mooney, gibi: Hello, sorry for annoying you, but will your have a ability to review new bp changes ? :) https://review.opendev.org/q/bp/virtio | |
| 12:30:07 | sean-k-mooney | ill try and get to it this week yes | |
| 12:30:27 | sean-k-mooney | if you have added teh test coverage i asked for i think it will be in reasonably shape to proceed | |
| 12:31:02 | sean-k-mooney | just looking at it very quickly it woudl be good to add a release note | |
| 12:31:36 | sean-k-mooney | "tox -e venv reno new libvirt-virtio-packed-queues" will stub out a release note file for you | |
| 12:31:48 | sean-k-mooney | you can delete all the section excpet feature | |
| 12:32:14 | sean-k-mooney | and there just give a bifr describption of the feature | |
| 12:32:55 | sean-k-mooney | it should be trarged in a way that operator will see it an go "oh that could be useful" so it does not have to have all the deatil jut a high level short paragraph | |
| 12:33:36 | sean-k-mooney | dvo-plv: addtional documenation could be added in a follow up patch but the release note should be in the patch that addes the features | |
| 12:37:33 | opendevreview | Danylo Vodopianov proposed openstack/nova master: Packed virtqueue support was added. https://review.opendev.org/c/openstack/nova/+/876075 | |
| 12:38:26 | dvo-plv | I added test coverage and releasnote. I forgot to do git add for release note in the previous patch | |
| 12:39:32 | sean-k-mooney | :) | |
| 12:39:56 | sean-k-mooney | would you mind removing the tabs https://review.opendev.org/c/openstack/nova/+/876075/8/releasenotes/notes/packed-virtqueue-filter-43a376674cb5b345.yaml | |
| 12:40:16 | dvo-plv | sure | |
| 12:40:39 | sean-k-mooney | actully they might be spaces but either way it would be nice to remove them | |
| 12:40:55 | sean-k-mooney | i think the release note is ok | |
| 12:41:25 | sean-k-mooney | it does not really explain why you want want to enable it | |
| 12:41:32 | sean-k-mooney | or what it is however | |
| 12:42:18 | sean-k-mooney | ideally an opeartor that does not know what this feature is should be able to look at the release note and get a sense for why they might care about learnign more | |
| 12:43:32 | sean-k-mooney | i woudl add a sentence basically saying that the pack virtqueue format can improve the performance espically when combinind with hadware offloads or dpdk | |
| 12:44:00 | sean-k-mooney | ill try an review this properly later or tomorrow | |
| 12:44:54 | dvo-plv | okay, I see. Should I left sentence regarding packed filter and scheduling or this is too dive for the operator? | |
| 12:46:56 | sean-k-mooney | am no i dont think that is needed but it would be nice to add a link to the spec https://specs.openstack.org/openstack/nova-specs/specs/2023.2/approved/virtio_packedring_configuration_support.html | |
| 12:47:21 | sean-k-mooney | just add it in the "Usefull references about virtqueue:" list | |
| 12:47:39 | sean-k-mooney | maybe make that jsut "Usefull references:" | |
| 12:48:17 | sean-k-mooney | with those change the operator that reads it will have an idea of what the feature is and why they might want it and then links to learn more | |
| 12:48:24 | sean-k-mooney | so that shoudl be good. | |
| 12:51:04 | dvo-plv | okay, thanks, I will apply all advice | |
| 13:12:49 | opendevreview | Danylo Vodopianov proposed openstack/nova master: Packed virtqueue support was added. https://review.opendev.org/c/openstack/nova/+/876075 | |
| 13:23:55 | dansmith | we need another +2 on the CVE stack for wallaby please: https://review.opendev.org/c/openstack/nova/+/882869/2 | |
| 13:32:44 | sean-k-mooney | dansmith: done | |
| 13:32:59 | dansmith | sean-k-mooney: thanks | |
| 13:49:54 | dvo-plv | sean-k-mooney: When we've told about queue feature, you mentioned that in could defined via '/sys/bus/pci/devices/...' path. I found this parser in the nova/pci/utils.py | |
| 13:50:58 | dvo-plv | But you also mentined about getting queue from the libvirt xml. Could you please direct me to the module, which parse libvirt output | |
| 13:51:44 | sean-k-mooney | eiehter will work for your case since the PF will be bound to dpdk | |
| 13:51:58 | sean-k-mooney | and the representors are in user space | |
| 13:52:57 | dvo-plv | class LibvirtConfigNodeDevicePciCap ? | |
| 13:54:04 | sean-k-mooney | that is the libvir class i think yes | |
| 13:54:18 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/host.py#L1568 we list the pci devices here | |
| 13:56:10 | sean-k-mooney | this is what parses the nodedevs https://github.com/openstack/nova/blob/master/nova/virt/libvirt/config.py#L3245 | |