| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-05-15 | |||
| 09:04:13 | zigo | I really would prefer to keep that unit test if possible ... | |
| 09:04:29 | zigo | melwitt: ^ | |
| 09:58:52 | dvo-plv | bauzas: Hello. I have update nova code after os-traits release. Coud you please review packed ring support bp: https://review.opendev.org/q/bp/virtio | |
| 11:18:49 | opendevreview | Amit Uniyal proposed openstack/nova-specs master: Adds cleanup to remove dangling volumes https://review.opendev.org/c/openstack/nova-specs/+/878757 | |
| 11:30:52 | sean-k-mooney | dvo-plv: the code looks ok but your missing test coverage | |
| 11:41:10 | dvo-plv | seean-k-mooney: We would like to implement tests after code approval in the separate bp. Does it possible, or we should to create a test immediately? | |
| 11:42:12 | sean-k-mooney | dvo-plv: no | |
| 11:42:23 | sean-k-mooney | we do not merge untested code in genral | |
| 11:42:40 | sean-k-mooney | so you need to have tests either in the same commmit or a followup commit | |
| 11:43:00 | sean-k-mooney | if its in a followup we will hold the first commit until we are happy with both and then merge them togeter | |
| 11:44:33 | sean-k-mooney | for openstack we treat master as if all commits could be deployed to production. | |
| 11:44:58 | sean-k-mooney | for lareger feature we genreally gate multi commit feature by having the change that enables the feature to be used last in the serise | |
| 11:45:37 | dvo-plv | I think we will implement and update this commit with tests coverage | |
| 11:45:49 | sean-k-mooney | that works | |
| 15:31:50 | opendevreview | Merged openstack/nova stable/yoga: Use force=True for os-brick disconnect during delete https://review.opendev.org/c/openstack/nova/+/882863 | |
| 15:33:45 | opendevreview | Merged openstack/nova stable/yoga: Enable use of service user token with admin context https://review.opendev.org/c/openstack/nova/+/882864 | |
| 17:24:47 | dansmith | fungi: if we change the wallaby implementation of the cve fix in gerrit (to address the thing raised in the bug), do we have to update errata or not? | |
| 17:24:56 | dansmith | the patch was in the bug, but wallaby should be out of bounds now | |
| 17:30:53 | fungi | technically we don't need to reference it because that branch is no longer under normal maintenance | |
| 17:31:27 | fungi | though i might amend the errata list with it and just not announce that so as to keep the noise level to a minimum | |
| 17:32:17 | fungi | we have a bit of flexibility with branches no longer under normal maintenance since those fixes are merely being included as a convenience and on a best-effort basis | |
| 17:32:27 | dansmith | ack, cool | |
| 17:32:50 | dansmith | I think you said "patches for older branches are appreciated but not required" so I just didn't know how that mapped to "provided as a courtesy and then changed" | |
| 17:32:52 | dansmith | melwitt: ^ | |
| 17:33:26 | fungi | it's sort of a grey area | |
| 17:33:40 | dansmith | I'm a walking grey area | |
| 17:33:49 | fungi | we didn't provide any non-nova wallaby patches anyway | |
| 17:34:14 | fungi | everything else stopped at xena (which is also no longer under normal maintenance at this point) | |
| 17:35:31 | melwitt | fungi: I had named the patch nova-2004555-xena_and_wallaby.patch erroneously thinking xena and wallaby were identical but it's really just nova-2004555-xena.patch | |
| 17:35:43 | fungi | makes sense | |
| 17:36:21 | fungi | for the downstream notification (and advisory of course) i split them up | |
| 17:36:37 | melwitt | oh, I see | |
| 17:37:33 | fungi | lots of the patches were "this applies to branches x and y" so i made separate identical branch x and branch y patches, because we don't want consumers to have to sort through a maze of patch name to branch mappings | |
| 17:41:07 | dansmith | melwitt: you're probably going to have to fix the job config on wallaby if you actually want to merge it too | |
| 17:41:32 | melwitt | fungi: that makes sense | |
| 17:41:41 | dansmith | the recent cinder tempest plugin changes for the ceph job have broken it.. I think just disabling the ceph job on wallaby is probably best | |
| 17:41:42 | melwitt | dansmith: good point | |
| 17:42:18 | melwitt | I at least wanted the current ps to be correct if anyone pulls it manually | |
| 17:43:13 | dansmith | yeah | |
| 17:43:23 | dansmith | well, it'll help the ubuntu wallaby patches and the reporter at least | |
| 17:47:39 | opendevreview | melanie witt proposed openstack/nova stable/wallaby: Use force=True for os-brick disconnect during delete https://review.opendev.org/c/openstack/nova/+/882869 | |
| 17:47:40 | opendevreview | melanie witt proposed openstack/nova stable/wallaby: Enable use of service user token with admin context https://review.opendev.org/c/openstack/nova/+/882870 | |
| 18:08:33 | dansmith | jamespage: you might want to notice this ^ update along with the traffic on https://bugs.launchpad.net/nova/+bug/2004555 | |
| 18:08:47 | dansmith | related to the ubuntu packages for that cve | |
| 18:54:38 | fungi | jamespage: also https://review.opendev.org/c/openstack/ossa/+/883202 "Add errata 3 for OSSA-2023-003" | |
| 19:28:35 | sean-k-mooney | i tought the general guidancce was to not track the ubuntu package state in the laucnchpad bug and only use them for the upstream openstack projects | |
| 19:29:43 | sean-k-mooney | i was always toold it was conidered rude to add the disto pacakges to the bug at elast when i was at intel my perception was it caused consution with regards to is this fixed on the upstream branch or downstream branch | |
| 19:34:32 | melwitt | zigo: I looked into the victoria issue, note that I updated the wallaby patch review for something different so please pull the latest one. besides that, I think you can add something like 'mount_device': None here under connection_info https://review.opendev.org/c/openstack/nova/+/882869/2/nova/tests/unit/virt/libvirt/test_driver.py#19646 to pass the test | |
| 19:38:03 | melwitt | the victoria code expects an additional key 'mount_device' key in the block_device_mapping | |
| 19:38:19 | melwitt | *an additional key in | |
| 22:53:29 | opendevreview | Merged openstack/nova stable/xena: CI: fix backport validator for new branch naming https://review.opendev.org/c/openstack/nova/+/882967 | |
| #openstack-nova - 2023-05-16 | |||
| 02:21:01 | opendevreview | melanie witt proposed openstack/nova master: testing: Use inspect.isfunction() to check signatures https://review.opendev.org/c/openstack/nova/+/883217 | |
| 03:08:30 | opendevreview | melanie witt proposed openstack/nova master: testing: Use inspect.isfunction() to check signatures https://review.opendev.org/c/openstack/nova/+/883217 | |
| 07:29:20 | elodilles | hi nova team! Happy *** Nova Stable Branches Review Day *** to everyone! \o/ o:) | |
| 07:56:06 | bauzas | elodilles: thanks for the reminder :) | |
| 08:01:42 | jamespage | dansmith, fungi: thanks - looking now | |
| 08:45:39 | bauzas | gibi: can you give a swing on that stable review day for https://review.opendev.org/c/openstack/nova/+/882786 ? :) | |
| 09:01:31 | gibi | bauzas: done | |
| 09:02:15 | gibi | on a similar note I need stable review on https://review.opendev.org/q/topic:bug%252F1994526 | |
| 09:02:47 | bauzas | gibi: I did it for 2023.1, will look at zed | |
| 09:16:51 | elodilles | gibi: 2023.1 version is on the gate now | |
| 09:17:47 | elodilles | and if you have time for these simple gate fix backports to review: https://review.opendev.org/q/topic:validate-backport-release-id | |
| 09:17:50 | elodilles | o:) | |
| 09:19:45 | gibi | looking | |
| 09:21:22 | gibi | done :) | |
| 09:24:12 | elodilles | thx \o/ | |
| 09:27:31 | opendevreview | Amit Uniyal proposed openstack/nova-specs master: Adds cleanup to remove dangling volumes https://review.opendev.org/c/openstack/nova-specs/+/878757 | |
| 09:42:24 | auniyal_ | gibi, elodilles in case you are done with stable reviews, only these 2 stable/2023.1 patches missed: https://review.opendev.org/c/openstack/nova/+/882293 , https://review.opendev.org/c/openstack/nova/+/882913 | |
| 09:43:39 | auniyal_ | bauzas, already had +2 in one, and other one is from bauzas | |
| 09:44:12 | bauzas | np | |
| 09:50:27 | zigo | melwitt: I was able to get Nova / Victoria to build correctly with the patch. thanks for your usefull hint ! | |
| 09:59:14 | elodilles | zigo: if you could upload the victoria patch then i can review it as well ;) | |
| 10:34:05 | zigo | elodilles: It would need the os-brick patch to be merged first, no? | |
| 11:05:39 | elodilles | zigo: probably yes, but i guess then you have that too | |
| 11:09:37 | opendevreview | Merged openstack/nova stable/zed: Revert "Debug Nova APIs call failures" https://review.opendev.org/c/openstack/nova/+/882786 | |
| 11:09:43 | opendevreview | Merged openstack/nova stable/2023.1: Reproduce asym NUMA mixed CPU policy bug https://review.opendev.org/c/openstack/nova/+/882508 | |
| 11:21:26 | opendevreview | Elod Illes proposed openstack/nova stable/victoria: Cleanup old resize instances dir before resize https://review.opendev.org/c/openstack/nova/+/864730 | |
| 11:21:45 | opendevreview | Merged openstack/nova stable/2023.1: Handle zero pinned CPU in a cell with mixed policy https://review.opendev.org/c/openstack/nova/+/882509 | |
| 11:21:52 | opendevreview | Merged openstack/nova stable/wallaby: CI: fix backport validator for new branch naming https://review.opendev.org/c/openstack/nova/+/882968 | |
| 11:30:56 | zigo | elodilles: I'm currently finishing the debian/bullseye package updates, I'll see if I can do that later on. | |
| 11:32:43 | elodilles | zigo: thanks in advance! please ping me for those backports so that i can review them (both nova and os-brick) | |
| 12:05:06 | opendevreview | Merged openstack/nova stable/2023.1: Have host look for CPU controller of cgroupsv2 location. https://review.opendev.org/c/openstack/nova/+/882913 | |
| 12:12:57 | auniyal_ | nice all stable/2023.1 patches merged | |
| 12:13:12 | auniyal_ | oh 1 pending | |
| 13:36:35 | elodilles | hmmm, it seems stable/wallaby gate is broken as nova-ceph-multistore is failing: https://zuul.opendev.org/t/openstack/builds?job_name=nova-ceph-multistore&project=openstack%2Fnova&branch=stable%2Fwallaby&skip=0 | |
| 13:38:16 | elodilles | it seems cinder-tempest-plugin is too new and needs latest tempest which is not allowed (?) on wallaby | |
| 13:39:44 | elodilles | (yepp, upper constraints pins tempest===27.0.0) | |
| 14:00:15 | dansmith | elodilles: yeah I mentioned that yesterday | |
| 14:00:32 | dansmith | elodilles: I think the only reasonable solution is to drop that job from wallaby | |
| 14:00:48 | dansmith | I mean, we can certainly fix it, I'm just not sure it's worth it for something so old | |
| 14:02:03 | elodilles | dansmith: isn't that enough if we just ensure that the job should use older cinder-tempest-plugin? | |
| 14:03:22 | dansmith | elodilles: probably, but the fixes to c-t-p were for stability and it just seems like it better fits the "best effort" approach to drop jobs that need that level of work | |
| 14:04:31 | dansmith | I guess devstack-plugin-ceph is branched so that will be okay (there was a tangled web of changes amongst all three) | |
| 14:05:56 | elodilles | dansmith: i can accept to drop the job, just thought to better fix it if possible | |
| 14:06:06 | dansmith | elodilles: your call | |
| 14:06:13 | elodilles | :) | |
| 14:06:50 | elodilles | sure, i'm looking it now and will propose a job dropping patch if i don't find an easy solution :D | |
| 14:11:21 | opendevreview | Danylo Vodopianov proposed openstack/nova master: Packed virtqueue support was added. https://review.opendev.org/c/openstack/nova/+/876075 | |
| 14:12:54 | bauzas | elodilles: dansmith: I'll create a release for 2023.1 and Zed tonight then | |
| 14:13:16 | elodilles | bauzas: ack, thanks in advance! | |