| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-04-25 | |||
| 16:36:53 | bauzas | (bauzas) Can https://blueprints.launchpad.net/nova/+spec/cold-migrate-to-host-policy be specless ? | |
| 16:37:05 | bauzas | tl;dr: we discussed this at the PTG | |
| 16:37:29 | sean-k-mooney | assuming there is no change in the default policy then yes i think so | |
| 16:37:32 | bauzas | operators want a better granularity and maybe change the cold-migrate action to be admin_or_owner | |
| 16:37:46 | bauzas | but, here, we're just adding a new policy which is admin-only | |
| 16:37:55 | bauzas | so no API change, and no policy changes | |
| 16:38:11 | bauzas | it will just go check a separate policy if host is set | |
| 16:38:32 | bauzas | (literally a one-liner patch besides the policy file) | |
| 16:38:55 | sean-k-mooney | so basicaly there will be two poicies now for cold migration one for migratoin with a host adn one without but admin only by default | |
| 16:38:55 | bauzas | any objections to have it specless ? | |
| 16:39:01 | sean-k-mooney | and then operators can choose | |
| 16:39:18 | sean-k-mooney | +1 | |
| 16:39:37 | bauzas | correct, like we have for os_compute_api:servers:create:forced_host | |
| 16:40:10 | bauzas | except I won't change the defaut rule for os_compute_api:os-migrate-server:migrate | |
| 16:40:34 | bauzas | both being admin-only | |
| 16:40:34 | bauzas | there will be os_compute_api:os-migrate-server:migrate and os_compute_api:os-migrate-server:migrate:host | |
| 16:40:48 | bauzas | (and operators can decide to open os_compute_api:os-migrate-server:migrate to endusers) | |
| 16:41:10 | bauzas | so I reiterate, any objection to have it specless ? | |
| 16:41:40 | bauzas | looks not | |
| 16:41:49 | bauzas | if so, | |
| 16:42:08 | sean-k-mooney | as long ast there is at least a blueprint im happy. i dislike changing policy without any tracker to works for me | |
| 16:42:17 | bauzas | #agreed https://blueprints.launchpad.net/nova/+spec/cold-migrate-to-host-policy accepted as a specless feature for Bobcat | |
| 16:42:31 | bauzas | sean-k-mooney: there is a blueprint, and there will be a relnote | |
| 16:42:45 | bauzas | and there will be functional tests covering this | |
| 16:42:53 | sean-k-mooney | yep all good. | |
| 16:43:15 | bauzas | I don't think we need a tempest change, do you think it's a nice to have ? | |
| 16:43:29 | sean-k-mooney | i dont think tempst shoudl test non default policy | |
| 16:43:41 | bauzas | yeah, that was my question | |
| 16:43:48 | bauzas | I'm not a QA expert | |
| 16:43:55 | bauzas | tempest is branchless | |
| 16:44:05 | bauzas | so that would be a bit hard to test it with tempest | |
| 16:44:22 | sean-k-mooney | i suspect you could reuse some fo the exsiting test with the right config if you needed too | |
| 16:44:24 | bauzas | anyway, I think we're done on this | |
| 16:44:44 | bauzas | about tempest, we could discuss this on the review time | |
| 16:44:50 | bauzas | thanks folks | |
| 16:44:51 | opendevreview | Artom Lifshitz proposed openstack/nova master: Save cell socket correctly when updating host NUMA topology https://review.opendev.org/c/openstack/nova/+/862964 | |
| 16:44:51 | opendevreview | Artom Lifshitz proposed openstack/nova master: Reproduce bug 1995153 https://review.opendev.org/c/openstack/nova/+/862967 | |
| 16:45:01 | bauzas | any other item to add before we end the meeting ? | |
| 16:45:22 | auniyal | small thing o/ | |
| 16:45:27 | auniyal | https://review.opendev.org/c/openstack/nova/+/839922 | |
| 16:45:27 | auniyal | CI on yoga: this one keep failing for different reasons, mostly | |
| 16:45:28 | bauzas | shot | |
| 16:45:42 | auniyal | mostly volume tests | |
| 16:46:23 | sean-k-mooney | ya that kind fo a pain im not sure there is anythin we can do beyond recheck | |
| 16:46:29 | sean-k-mooney | is it the volume detach tests | |
| 16:46:45 | sean-k-mooney | auniyal: gibi found some tests that are not waiting properly | |
| 16:46:47 | bauzas | I think this is also tracked on the stable CI failures etherpad | |
| 16:46:50 | auniyal | yes, attach and detach , but they are always different | |
| 16:47:04 | auniyal | sometime tomeout | |
| 16:47:15 | sean-k-mooney | yoga is not EM right so its still using tempest master? | |
| 16:47:20 | auniyal | no | |
| 16:47:46 | auniyal | tbc no, its not EM | |
| 16:47:50 | sean-k-mooney | ok | |
| 16:47:58 | sean-k-mooney | so it still can get tempest fixes if we fix those tests | |
| 16:48:09 | bauzas | yup | |
| 16:48:40 | bauzas | are we done ? | |
| 16:48:59 | auniyal | sorry I didn't get, any action on above | |
| 16:49:20 | auniyal | we need to fix tempest tests ? | |
| 16:49:47 | sean-k-mooney | i think just continue to reheck it. gibi found at least on test that is not waiting for sshable | |
| 16:49:53 | bauzas | no, we have some tempest patches up | |
| 16:49:57 | sean-k-mooney | and notice other dont appear to eb waiting but i dont have the context | |
| 16:50:01 | bauzas | and yoga would benefit from those | |
| 16:50:10 | bauzas | since tempest is branchless | |
| 16:50:14 | sean-k-mooney | oh do you have a link? | |
| 16:50:16 | auniyal | ack thanks | |
| 16:51:54 | bauzas | I was referring to gibi's recent discoveries of testing gap for ssh wait | |
| 16:52:13 | bauzas | (sorry was looking at the -tc meeting) | |
| 16:52:23 | bauzas | -tc chan* | |
| 16:52:35 | bauzas | can we close this meeting now ? | |
| 16:52:38 | sean-k-mooney | its fine we can wrap this here and chat after | |
| 16:53:06 | bauzas | cool | |
| 16:53:08 | bauzas | thanks all | |
| 16:53:12 | opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2023/nova.2023-04-25-16.00.log.html | |
| 16:53:12 | opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2023/nova.2023-04-25-16.00.txt | |
| 16:53:12 | opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2023/nova.2023-04-25-16.00.html | |
| 16:53:12 | opendevmeet | Meeting ended Tue Apr 25 16:53:12 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 16:53:12 | bauzas | #endmeeting | |
| 16:53:14 | sean-k-mooney | https://review.opendev.org/c/openstack/tempest/+/880891 | |
| 16:53:17 | sean-k-mooney | seams to be related | |
| 16:53:43 | elodilles | thanks o/ | |
| 17:01:21 | sean-k-mooney | so that test is wrong | |
| 17:01:40 | sean-k-mooney | we do not supprot attaching or detaching prots or volume from neuton or cinder | |
| 17:02:28 | frickler | so we run this test for 6 years, have issues with it time and again, and only now notice that it tests an unsupported scenario? cool | |
| 17:03:33 | sean-k-mooney | frickler: it has never been supported | |
| 17:03:49 | sean-k-mooney | i jsut notice this existed because gmann has a dnm patch up | |
| 17:04:23 | gmann | which one ? | |
| 17:04:28 | frickler | yes, saw the comment in the patch. also didn't want to blame anyone, just enjoying the wondrous world of openstack once again | |
| 17:04:32 | sean-k-mooney | https://github.com/openstack/tempest/blob/master/tempest/api/volume/test_volumes_actions.py#L39-L55 | |
| 17:04:34 | frickler | https://review.opendev.org/c/openstack/tempest/+/881132/3 | |
| 17:05:18 | sean-k-mooney | it kind of depend on what self.volumes_client.attach_volume actully does | |
| 17:05:22 | sean-k-mooney | if its calling nova its fine | |
| 17:05:22 | frickler | ah, no, the one below | |
| 17:05:37 | sean-k-mooney | if its using the cinder attachments api directly its not | |
| 17:07:16 | sean-k-mooney | that looks like its callining cinder https://github.com/openstack/tempest/blob/20e460dacfae6b4546903a9caaf9253330f27b5a/tempest/clients.py#L286 | |
| 17:10:02 | sean-k-mooney | frickler: this was actully added 11 years ago https://github.com/openstack/tempest/commit/a42fe441703084449107fabb15fe42938c02ba08 | |
| 17:10:15 | sean-k-mooney | that does not mean it has been correct or supported for all tha time | |
| 17:10:27 | frickler | ah, I was only looking at the current blame, which says 2017 | |
| 17:10:45 | frickler | you can see the actual API calls in https://4ae644854fb3bf106e9b-6877b85dbe482cd2daa62a6731b06023.ssl.cf1.rackcdn.com/881132/3/check/tempest-full-py3/37d3ce7/controller/logs/tempest_log.txt | |
| 17:12:11 | gmann | frickler: sean-k-mooney ohk that one. those tests are meant to be cinder standalone case and they are not valid scenario involving nova in half way | |
| 17:12:32 | sean-k-mooney | right they are fine fi you are using cinder standalone | |