| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-04-13 | |||
| 13:39:36 | opendevreview | sean mooney proposed openstack/nova master: add hypervisor version weigher https://review.opendev.org/c/openstack/nova/+/880231 | |
| 13:40:48 | opendevreview | sean mooney proposed openstack/nova master: add hypervisor version weigher https://review.opendev.org/c/openstack/nova/+/880231 | |
| 13:41:20 | sean-k-mooney | bauzas: fyi that should now be ready to go ^ | |
| 13:55:28 | bauzas | sean-k-mooney: yup, I saw the updates :) | |
| 13:56:15 | sean-k-mooney | the ping was more to say im done updatign it if you want to review | |
| 13:57:38 | sean-k-mooney | bauzas: once you are done with that i would also liek to land https://review.opendev.org/q/topic:sqlalchemy-20+project:openstack/nova+status:open if we can form stephenfin | |
| 13:58:03 | sean-k-mooney | gibi: ^ melwitt: ^ if either of ye can review those that would also be good | |
| 14:20:07 | stephenfin | sean-k-mooney: Speaking of, just replied on https://review.opendev.org/c/openstack/nova/+/860850 | |
| 14:22:29 | kashyap | gibi: bauzas: When you can, can you have a look at this from Sean: https://review.opendev.org/c/openstack/nova/+/880231 | |
| 14:23:23 | bauzas | kashyap: already know it :) | |
| 14:23:40 | kashyap | Thank you; I know, I'm slow in catching up :) | |
| 15:16:47 | opendevreview | Merged openstack/os-traits master: Update python testing as per zed cycle testing runtime https://review.opendev.org/c/openstack/os-traits/+/841682 | |
| 16:47:37 | dansmith | bauzas: AFAICT, we don't ever hit this trap in any of our CI jobs: https://review.opendev.org/c/openstack/nova/+/879687/5/nova/compute/resource_tracker.py | |
| 17:09:10 | sean-k-mooney | i think the only way we could try and create a claim on a disabled node is if there was a race | |
| 17:09:37 | sean-k-mooney | specificaly if between the time we selected the node in the schdluer and before the node reached the compute we updated the service to disabled | |
| 17:10:35 | sean-k-mooney | assuming self.diabled is the compute service disabled value? | |
| 17:24:04 | dansmith | sean-k-mooney: no | |
| 17:24:11 | dansmith | sean-k-mooney: we had a long conversation about it yesterday | |
| 17:27:33 | dansmith | I replied to your comments on the review | |
| 18:20:46 | sean-k-mooney | oh ok this is not related to the compute service state. reading | |
| 18:21:52 | sean-k-mooney | oh ok so for non-ironic | |
| 18:22:46 | sean-k-mooney | for use to get here we woudl need two compute-agents that the saem config.host value so that they both shared teh same queue in rabbit or somethign equaly bad/wrong | |
| 18:23:26 | sean-k-mooney | im jsut tryign to think how we would recive a request fo another compute node that this agent does not know about | |
| 18:25:35 | sean-k-mooney | im am wonderign if i can think of a way to repoduce this but mostly coming up blank | |
| 18:26:17 | sean-k-mooney | maybe if you set Conf.host=X and then changed /etc/hostname with preantelope | |
| 18:26:48 | sean-k-mooney | a pendign request in the queue for the old comptue node would end up here? | |
| 18:27:05 | sean-k-mooney | that cant happen now in either case since the agent wont start if you did this | |
| 18:27:47 | sean-k-mooney | so ya i agree this shold not jsut be ignored | |
| 18:28:05 | sean-k-mooney | i just dont knwo if its possibel to cause today | |
| 18:28:39 | sean-k-mooney | is this code path used in the ironic case with the hashring stuff? | |
| 18:29:31 | sean-k-mooney | i would expect it to be common | |
| 18:30:12 | sean-k-mooney | it was not a behvior i was aware of in any case | |
| 18:39:46 | opendevreview | sean mooney proposed openstack/nova master: add hypervisor version weigher https://review.opendev.org/c/openstack/nova/+/880231 | |
| 18:43:07 | opendevreview | sean mooney proposed openstack/nova master: add hypervisor version weigher https://review.opendev.org/c/openstack/nova/+/880231 | |
| #openstack-nova - 2023-04-14 | |||
| 00:02:01 | opendevreview | melanie witt proposed openstack/nova master: Call volume detach rollback API if detach fails https://review.opendev.org/c/openstack/nova/+/880399 | |
| 09:34:01 | opendevreview | Merged openstack/nova stable/zed: Fix rescue volume-based instance https://review.opendev.org/c/openstack/nova/+/872116 | |
| 11:41:16 | frickler | bauzas: I think this meeting is long obsolete and could be dropped from the calendar? https://meetings.opendev.org/#Placement_Team_Office_Hour | |
| 11:41:38 | bauzas | frickler : sure | |
| 11:41:47 | bauzas | Want me to janitor it? | |
| 11:43:19 | frickler | that'd be nice, then I can approve it | |
| 11:43:23 | frickler | likely https://meetings.opendev.org/#Nova_Monthly_Asia_Friendly_Team_Meeting too | |
| 11:51:48 | bauzas | cool, lemme do this this afternoon | |
| 12:22:56 | bauzas | frickler: https://meetings.opendev.org/meetings/placement/2019/ | |
| 12:23:00 | bauzas | shit, wrong paste | |
| 12:23:16 | bauzas | frickler: https://review.opendev.org/c/opendev/irc-meetings/+/880485 | |
| 14:13:12 | bauzas | gibi: sean-k-mooney: I have this long open doc change, can you round it again ? https://review.opendev.org/c/openstack/nova/+/875730 | |
| 14:19:00 | gibi | bauzas: +2 | |
| 14:21:13 | bauzas | thanks for the swing | |
| 14:23:15 | dansmith | bauzas: did you see my ping yesterday about that resize claim thing? | |
| 14:24:08 | dansmith | the more I think about it, the more I think I should just bite the bullet and add a raise there as part of that series | |
| 14:24:18 | dansmith | and call it a "tightening of the host->node relationship" if nothing else | |
| 14:25:52 | bauzas | dansmith: yeah I could be okay with an exception | |
| 14:26:02 | dansmith | alright | |
| 14:26:08 | bauzas | that's what we discussed on Wed | |
| 14:26:40 | bauzas | I was a bit afraid we could say 'hehe, sure' if we weren't providing now an exception, and without having a migration record | |
| 14:26:44 | dansmith | I know, and I said I didn't want to | |
| 14:26:50 | bauzas | ++ | |
| 14:27:06 | dansmith | again, I don't think the exception isn't required to keep it consistent, | |
| 14:27:15 | dansmith | it will just make any breakage obvious | |
| 15:45:07 | sean-k-mooney | bauzas: gibi i proably wont have the weigher updated today before ye finsih but ill try and get it done latere today so it will be avaiable for ye on monday | |
| 15:45:26 | gibi | sean-k-mooney: ack, no worriews | |
| 15:45:35 | bauzas | sorry folks, I'm done for today | |
| 15:55:00 | sean-k-mooney | bauzas: do you still need more eye on that ping | |
| 15:55:48 | sean-k-mooney | ill review it in a bit just finsihsing something locally | |
| 15:55:51 | bauzas | sean-k-mooney: sorry wdym? | |
| 15:55:58 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/875730/4/doc/source/contributor/ptl-guide.rst | |
| 15:56:00 | bauzas | Ack ok no worries | |
| 15:56:19 | bauzas | and no rush ;-) | |
| 15:56:34 | sean-k-mooney | assuming all is well ill hit that before i finish today | |
| 16:30:58 | noonedeadpunk | folks, do you have any idea, why metadata on config-drive won't contain fixed ip address, but will have `"type": "ipv4_dhcp"`? | |
| 16:34:10 | noonedeadpunk | probably worth postponing this question till Monday... | |
| 16:37:04 | sean-k-mooney | noonedeadpunk: we changed that in antelope | |
| 16:37:45 | sean-k-mooney | the logic being if hte network has dhcp enabeld it should not be set so that cloud init wont hardcode it | |
| 16:38:05 | sean-k-mooney | actully | |
| 16:38:15 | sean-k-mooney | maybe im mixing that up with something else | |
| 16:38:23 | sean-k-mooney | let me see if i can fidn the patch im thinking of | |
| 16:38:34 | sean-k-mooney | i dont recall if it was only the mtu that we stopped passing | |
| 16:38:38 | noonedeadpunk | Well, we've started seeing that right in antelope:) | |
| 16:39:12 | noonedeadpunk | I just had a chat with octavia folks, they still see ip for net with enabled dhcp... | |
| 16:39:42 | noonedeadpunk | But we can have slightly different versions | |
| 16:40:23 | sean-k-mooney | https://github.com/openstack/nova/commit/6bdc79af30151f683c0f462bc6c69da30ebcbcf9 | |
| 16:40:27 | sean-k-mooney | ok so that was just metadta | |
| 16:40:33 | sean-k-mooney | * mtu | |
| 16:41:06 | sean-k-mooney | it should not affect ips | |
| 16:41:48 | noonedeadpunk | well. test__get_link_mtu has none for IP ? | |
| 16:42:12 | sean-k-mooney | https://github.com/openstack/nova/commit/6bdc79af30151f683c0f462bc6c69da30ebcbcf9#diff-f04bc33149c06fd545308c204ae23cb7c83abd01443bdf8f85acce861b0547f4R266 | |
| 16:42:23 | sean-k-mooney | yes but this is all that functioanlly changed | |
| 16:43:33 | sean-k-mooney | noonedeadpunk: this was not chagned by that but is proably more of interest to youhttps://github.com/openstack/nova/blob/master/nova/virt/netutils.py#L279-L330 | |
| 16:44:34 | sean-k-mooney | wait you said fixed_ips | |
| 16:44:48 | noonedeadpunk | specifically https://github.com/openstack/nova/blob/master/nova/virt/netutils.py#L295 | |
| 16:45:05 | noonedeadpunk | johnsom: ^ | |
| 16:45:21 | noonedeadpunk | so, the thing is that johnsom have on their sandbox this in metadata https://www.irccloud.com/pastebin/fEVIIOCM/ | |
| 16:45:34 | sean-k-mooney | the only fixed_ip info is the ec2 compat stuff https://github.com/openstack/nova/blob/master/nova/virt/netutils.py#L227-L240 | |
| 16:45:43 | noonedeadpunk | and I have https://paste.openstack.org/show/bNGH0dceR991yU0OthqO/ | |
| 16:45:55 | noonedeadpunk | nah, forget about `fixed_ip`... | |
| 16:46:21 | noonedeadpunk | I was trying to express expectations rather then reffering any data | |
| 16:46:44 | sean-k-mooney | ok | |
| 16:46:50 | noonedeadpunk | At we both have dhcp enabled | |
| 16:47:27 | sean-k-mooney | ya so the irccloud linke has ip_address in the data | |
| 16:47:40 | sean-k-mooney | which is what i expect in the networks section | |