| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-03-30 | |||
| 14:46:04 | dansmith | sean-k-mooney: what is the qemu security issue that started causing detach issues that you mentioned on the list? | |
| 14:46:37 | sean-k-mooney | dansmith: the orgianl motivation for the change in qemu was related to a secuity issue i belvie | |
| 14:46:46 | sean-k-mooney | i dont actully know the details | |
| 14:46:52 | dansmith | sean-k-mooney: but what's the change? I wasn't aware anything changed (intentionally) | |
| 14:46:58 | bauzas | was in libvirt 8, right? | |
| 14:47:16 | sean-k-mooney | it was undefiend behaivor if you could retry detach while it was in progress | |
| 14:47:29 | sean-k-mooney | they intentionally made it an error and have it abort the inprogress detach | |
| 14:47:33 | bauzas | elodilles: I can raise the question to the nova team by email | |
| 14:47:52 | elodilles | bauzas: yepp, that is perfectly OK i think | |
| 14:47:55 | bauzas | elodilles: and we could conclude on the next weekly meeting | |
| 14:47:56 | sean-k-mooney | in old version fo qemu it would actully try detaching again | |
| 14:48:03 | elodilles | bauzas: ++ | |
| 14:48:07 | dansmith | sean-k-mooney: that's not actually causing us trouble though right? if we needed to retry the detach it probably wasn't working anyway, right? | |
| 14:48:16 | bauzas | elodilles: or the next one, I've seen the deadline for approving | |
| 14:48:31 | dansmith | sean-k-mooney: ah meaning we're never sending the acpi event anymore after the first one? | |
| 14:49:05 | sean-k-mooney | correct after the first one it never gets sent again but also our retry mechaium would stop the detach form proceeding | |
| 14:49:22 | sean-k-mooney | i.e. if was just slow detachign and we retried it would abort the detach | |
| 14:49:51 | elodilles | bauzas: though we should not postpone the release close to the transition, otherwise if we hurry and merge things and something will be broken then we cannot fix it anymore ;) | |
| 14:49:53 | dansmith | hmm, okay | |
| 14:49:58 | sean-k-mooney | dansmith: gibi swapped use form blind retryes on a timeout/interval oto trying to use qemu events | |
| 14:50:16 | sean-k-mooney | or maybe that was lee | |
| 14:50:29 | sean-k-mooney | in either case that was not enough to resolve this issue | |
| 14:50:46 | dansmith | okay, I guess I didn't know about this other detail | |
| 14:50:47 | sean-k-mooney | it just seam like we need to kick the vms several times to get the detach to work | |
| 14:51:06 | bauzas | elodilles: yeah that's understandable, we shall not be lazy | |
| 14:51:09 | dansmith | if it's a matter of the first event getting missed or something, that definitely *could* support the "use a real distro" argument I guess | |
| 14:51:32 | dansmith | if the first one fails, is there some way the "in progress"-ness gets reset such that allowing a retry *ever* works? | |
| 14:51:39 | bauzas | elodilles: despite (tbh), I'm like ~0% interested about the Xena branch :) | |
| 14:51:55 | bauzas | actually, EM is helping my work :) | |
| 14:52:02 | sean-k-mooney | dansmith: currently i belive there is no way to rest the state without restarting the vm | |
| 14:52:19 | sean-k-mooney | https://gitlab.com/libvirt/libvirt/-/issues/309 | |
| 14:52:46 | dansmith | does running the guest agent allow us to do it that way instead of just acpi? | |
| 14:53:01 | dansmith | thanks, I'll brush up on that bug | |
| 14:53:16 | sean-k-mooney | good question i do not think so but maybe | |
| 14:53:28 | sean-k-mooney | i have never really looke at what the guest agent can actully do | |
| 14:53:47 | sean-k-mooney | i knowit has some filesystem apis to freeze them | |
| 14:54:01 | sean-k-mooney | dansmith: the other thing to keep in mind is its not always acpi | |
| 14:54:21 | sean-k-mooney | qhen you change to q35 we started to use pcie natiave hotplug instead | |
| 14:54:38 | sean-k-mooney | the proved to be buggey so they went back to acpi | |
| 14:54:59 | sean-k-mooney | im not sure if they have changed back to native pcie hotplug or if it still uses acpi | |
| 14:54:59 | dansmith | for disks? but I'm using acpi as a stand-in.. I guess for disks I figured it was an eject request or something | |
| 14:55:36 | sean-k-mooney | there are 2 ways to signel it for the pc machine type it used ahci interupts becasue you only had a pci bus not pcie | |
| 14:55:55 | sean-k-mooney | pcie has its own hotplug mechanium and qemu tried to use that instead | |
| 14:55:56 | elodilles | bauzas: we had a xena release this year, so at least we are mostly good ;) | |
| 14:56:13 | sean-k-mooney | then then hit bugs and went back to ahci | |
| 14:56:21 | sean-k-mooney | for virtio-blk each disk is a pci device | |
| 14:56:35 | sean-k-mooney | for virtio-scsi then they are not | |
| 14:56:46 | sean-k-mooney | they are scsi device connected to the contoller | |
| 14:57:19 | bauzas | reminder : we restart in 3 mins, cinder room | |
| 14:57:26 | sean-k-mooney | speakign of we could try using virtio-scsi i guess | |
| 14:57:46 | sean-k-mooney | just set hw_disk_bus=scsi in devstack | |
| 14:58:09 | sean-k-mooney | i dont think htat helps as i think its the ahci path thats buggy but its an option to try | |
| 14:58:40 | sean-k-mooney | dansmith: sorry for the context dump :) | |
| 15:00:32 | whoami-rajat | https://redhat.bluejeans.com/556681290 | |
| 15:01:24 | sean-k-mooney | dansmith: ^ are you joining that by the way | |
| 15:01:42 | dansmith | sean-k-mooney: nope, tc now.. | |
| 15:01:47 | sean-k-mooney | ah ok | |
| 15:02:01 | sean-k-mooney | we can recap hte direct image location converstaion | |
| 15:46:05 | bauzas | senrique: oh you just joined, cool thanks | |
| 15:55:55 | bauzas | senrique: a few docs so :) | |
| 15:56:09 | bauzas | senrique: this is our overall process workflow https://docs.openstack.org/nova/latest/contributor/process.html#how-do-i-get-my-code-merged | |
| 15:56:12 | senrique | bauzas, hey :) | |
| 15:56:22 | bauzas | tl;dr: create a blueprint on https://blueprints.launchpad.net/nova/ | |
| 15:57:06 | bauzas | then, once you think you have time to attend a specific nova meeting, add your topic to the weekly meeting agenda https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting (in the open discussion last topic) | |
| 15:57:59 | bauzas | and then, we'll discuss it on the subsequent meeting, asking you a few details and if we agree, then we just approve your blueprint desing (from a procedural pov) | |
| 15:58:03 | bauzas | design* even | |
| 15:58:31 | bauzas | then, you're free to work on the implementation patches and ask for reviews | |
| 15:59:33 | bauzas | senrique: one example is https://meetings.opendev.org/meetings/nova/2023/nova.2023-01-17-16.00.log.html#l-287 | |
| 16:10:02 | bauzas | break until 1620UTC | |
| 16:10:33 | bauzas | and then, see you back on https://www.openstack.org/ptg/rooms/diablo | |
| 16:19:14 | senrique | thank you bauzas!! | |
| 18:41:46 | opendevreview | sean mooney proposed openstack/nova master: [DNM] testing enableind discard by default https://review.opendev.org/c/openstack/nova/+/879077 | |
| 19:04:56 | opendevreview | Merged openstack/nova stable/xena: Accept both 1 and Y as AMD SEV KVM kernel param value https://review.opendev.org/c/openstack/nova/+/843938 | |
| #openstack-nova - 2023-03-31 | |||
| 10:55:11 | opendevreview | Amit Uniyal proposed openstack/nova-specs master: Add cleanup flag to remove dangling volumes https://review.opendev.org/c/openstack/nova-specs/+/878757 | |
| 11:31:27 | sean-k-mooney | vmaccel: we can start using https://etherpad.opendev.org/p/track-sriov-nics-in-placement i have imported the template and will start copying the parts form the old spec | |
| 11:39:04 | opendevreview | Amit Uniyal proposed openstack/nova-specs master: Add cleanup flag to remove dangling volumes https://review.opendev.org/c/openstack/nova-specs/+/878757 | |
| 12:06:58 | sean-k-mooney | vmaccel: gibi i have copied in the basics info that is needed for the spec but left most of the template in place | |
| 12:07:37 | sean-k-mooney | vmaccel: ill leave the rest for you to clean up becasue if i do much more i really wont be in a position to review this any more | |
| 12:53:20 | opendevreview | yatin proposed openstack/nova master: [DNM] Test lower tb cache https://review.opendev.org/c/openstack/nova/+/868419 | |
| 13:01:22 | bauzas | vTPG day starting now | |
| 13:07:33 | bauzas | nobody ? :( | |
| 13:07:57 | bauzas | https://www.openstack.org/ptg/rooms/diablo | |
| 13:08:31 | opendevreview | Amit Uniyal proposed openstack/nova-specs master: Add cleanup flag to remove dangling volumes https://review.opendev.org/c/openstack/nova-specs/+/878757 | |
| 13:11:05 | vmaccel | sean-k-mooney: thanks - will work on it | |
| 13:44:52 | artom | dansmith, sean-k-mooney, good news, a new Australian marsupial has been discovered! https://i.imgur.com/YoSuLDB.png | |
| 13:45:06 | dansmith | works for me | |
| 13:54:12 | dansmith | noonedeadpunk: are you joining the nova room? | |
| 13:54:18 | dansmith | to discuss your discovery thing? | |
| 13:54:50 | bauzas | https://etherpad.opendev.org/p/nova-bobcat-ptg#L473 | |
| 13:55:01 | noonedeadpunk | Yep, sure | |
| 13:55:05 | noonedeadpunk | sec | |
| 14:10:30 | bauzas | sean-k-mooney: are you able to join the nova session ? | |
| 14:11:34 | bauzas | (we're on a break til 1415UTC) | |
| 14:47:22 | bauzas | break until 3pm utc | |
| 14:52:45 | bauzas | gmann: dansmith: fwiw, the gate gives me headaches back these days | |
| 14:53:14 | bauzas | I'll need to scrub all the rechecks I made and try to follow the most common patterns | |
| 14:54:00 | bauzas | things were quiet for 3 weeks, but now it becomes worst (I guess because we're back on a full dev cycle so more job runs at the same time) | |
| 14:56:24 | gmann | bauzas: are you seeing this volume state error or something else also https://12df9c834cfda7bed796-e5788b19bd89c28fd446f909c1b0ae99.ssl.cf5.rackcdn.com/875621/10/check/nova-ceph-multistore/91680b5/testr_results.html | |
| 15:30:35 | stephenfin | bauzas: Was this what you were looking for review of? https://review.opendev.org/c/openstack/python-openstackclient/+/851244 You need to rebase it if so then gtema can take a look | |
| 15:31:56 | bauzas | stephenfin: yup that's the one and yeah now I have work to do | |