Earlier  
Posted Nick Remark
#openstack-nova - 2023-03-14
08:58:20 bauzas so, IMHO, we should delete the share mapping in the instance delete call
08:58:35 bauzas as we can't use the delete cascade SQL support
08:58:49 Uggla bauzas, yep and add the semaphore to avoid any race.
08:59:09 bauzas + in init_instance(), recreating the share like I said
08:59:30 bauzas and maybe a periodic for making sure we don't leak any shares
09:00:31 bauzas Uggla: can you look at what happens to the foreign key ?
09:01:59 Uggla bauzas, yes I'll try to simulate it again.
09:03:45 bauzas cool
10:57:49 opendevreview Hiroki Narukawa proposed openstack/nova master: libvirt: retry libvirt connection on live_migration_monitor https://review.opendev.org/c/openstack/nova/+/867077
13:35:39 opendevreview Rajesh Tailor proposed openstack/nova master: Fix duplicate cell creation with same name https://review.opendev.org/c/openstack/nova/+/876940
14:17:15 bauzas gibi: sean-k-mooney: other cores, we need this https://review.opendev.org/c/openstack/nova-specs/+/876887 to be merged quick soon please
14:17:22 bauzas quite* soon
14:21:16 sean-k-mooney ah the redirects sure ill look now
14:21:38 gibi good for me
14:22:02 sean-k-mooney same looks fine
14:22:13 sean-k-mooney im happy the script worked with the new name format
14:30:49 opendevreview Merged openstack/nova-specs master: Move Antelope implemented specs https://review.opendev.org/c/openstack/nova-specs/+/876887
14:36:02 opendevreview Maxim Monin proposed openstack/nova master: Server Rescue leads to Server ERROR state if base image is deleted https://review.opendev.org/c/openstack/nova/+/872385
14:38:37 bauzas thanks folks
15:17:22 gibi bauzas: I'm happy that you are only asking me to review these realtively easy patches as otherwise I would have to say no :)
16:00:06 opendevmeet The meeting name has been set to 'nova'
16:00:06 opendevmeet Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:00:06 opendevmeet Meeting started Tue Mar 14 16:00:06 2023 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:00:06 bauzas #startmeeting nova
16:00:12 bauzas howdy folks
16:00:18 dansmith o/
16:00:21 bauzas #link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting
16:01:04 bauzas ok, let's start, people can join meanwhile
16:01:10 bauzas #topic Bugs (stuck/critical)
16:01:10 gibi o/
16:01:15 bauzas #info No Critical bug
16:01:19 bauzas #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 16 new untriaged bugs (+2 since the last meeting)
16:01:26 elodilles o/
16:01:30 auniyal o/
16:02:02 bauzas elodilles: I saw you did a bit of triage
16:02:07 elodilles yepp
16:02:08 bauzas I also looked at the new bugs todayt
16:02:16 elodilles thanks!
16:02:21 bauzas (to see whether we were regressing)
16:02:31 bauzas elodilles: nothing you want to discuss ?
16:02:43 auniyal bauzas, regarding this - https://bugs.launchpad.net/nova/+bug/2011567
16:02:52 auniyal The message right now is, "fill this in after the PTG", shall we update it to something else.
16:02:57 gmann o/
16:03:21 bauzas auniyal: as I said as a comment, we don't have cycle priorities
16:03:40 bauzas so, either we delete the Bobcat file, or meh
16:04:07 sean-k-mooney we have kept it for other release
16:04:17 sean-k-mooney its been blank for years at this point
16:04:18 bauzas yup, that's what I wrote
16:04:33 bauzas we can provide some upstream priorities if we want
16:04:40 auniyal okay, the msg seems like we missed to update after PTG
16:04:47 bauzas but, if we don't have anyone, should we delete the file ?
16:05:03 sean-k-mooney im ok either way
16:05:10 bauzas we could discuss this in the PTG if we want
16:05:14 sean-k-mooney sure
16:05:18 auniyal ack
16:05:18 bauzas kk
16:05:21 bauzas let's do this then
16:05:42 bauzas auniyal: I also closed your other bug report https://bugs.launchpad.net/nova/+bug/2011564
16:05:56 bauzas auniyal: as I said, those links are just examples
16:05:57 auniyal yes, that I missed the example
16:06:03 auniyal my bad
16:06:09 bauzas ok
16:06:15 bauzas moving on then
16:06:20 elodilles about your question bauzas : there was a serialproxy TR. serialproxy example client seems very old and not really functional (bug: https://bugs.launchpad.net/nova/+bug/2009956 )
16:07:07 elodilles i guess low prio is OK for that
16:07:16 elodilles but correct me if i was wrong
16:07:32 bauzas elodilles: mmm, good question
16:07:46 bauzas 'low' is good for me
16:07:57 sean-k-mooney we expect the serial proxy to be used with netcat in generalright
16:08:48 sean-k-mooney oh actully we expeort it as a websocket
16:08:59 sean-k-mooney so you need a websocket client
16:09:04 bauzas sean-k-mooney: netcat or any script like https://docs.openstack.org/nova/latest/contributor/testing/serial-console.html
16:09:07 elodilles yes, rather a websocket client
16:09:29 sean-k-mooney ya so i dont really consider the example in the docs to be maintained
16:09:38 sean-k-mooney if its not tested its broken by default
16:09:41 sean-k-mooney and we dont test that
16:09:56 elodilles ack
16:10:24 bauzas well, then should we deprecate this API ?
16:10:27 sean-k-mooney so we proably shoudl fix this and by either providing a new nova console script that we test or delete the current example and document using a diffent client
16:10:29 bauzas as a signal
16:10:32 sean-k-mooney no
16:10:36 sean-k-mooney it works fine in horizon
16:10:40 bauzas saying "sorry, we don't really test it"
16:10:42 sean-k-mooney or it did the last time i used it
16:10:56 sean-k-mooney we shoudl remove the example script
16:11:05 bauzas sean-k-mooney: looks to me elodilles tested this with master and it wasn't longer working
16:11:18 sean-k-mooney elodilles: did you test it with horizon
16:11:24 sean-k-mooney or that test script
16:11:55 bauzas I can try to test it with https://github.com/vi/websocat
16:11:56 elodilles sean-k-mooney: well, I don't know whether my devstack was properly configured, but it didn't work
16:12:13 elodilles neither with any old clients
16:12:46 elodilles so i don't know whether this is a problem in serial proxy or the clients
16:12:51 sean-k-mooney ack we shoudl look into this more i dont currently have a devstack but i can try and find time to deploy one and see
16:13:11 sean-k-mooney elodilles: if you can try configuring horizon to use it that would be the main way its used
16:13:16 bauzas me too
16:13:22 elodilles sean-k-mooney: ack
16:13:42 bauzas maybe let's put the importance to Medium, as this is an API
16:13:53 sean-k-mooney https://docs.openstack.org/nova/xena/admin/remote-console-access.html#serial
16:14:02 sean-k-mooney its not an api
16:14:18 sean-k-mooney but it is a fully supprot compenet

Earlier   Later