| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-03-13 | |||
| 09:52:21 | bauzas | the first patch is only getting a soft -1 because I'd want you to test some deletion behaviour | |
| 09:52:32 | bauzas | apart from this, I'm OK | |
| 09:52:51 | bauzas | now, I have more concerns for the objects patc | |
| 09:52:54 | bauzas | patch | |
| 09:53:15 | bauzas | it looks to me that we should discuss how to use this object between the services | |
| 09:53:18 | bauzas | and what it could do | |
| 10:27:26 | Uggla | bauzas, ok | |
| 10:28:40 | bauzas | Uggla: I need to get my daughter in 10 mins but we can discuss that in the afternoon if you want | |
| 10:28:55 | Uggla | ok sounds good | |
| 10:29:08 | bauzas | I'll ping you later around 2pm CET | |
| 10:47:07 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix duplicate cell creation with same name https://review.opendev.org/c/openstack/nova/+/876940 | |
| 12:05:15 | dvo-plv | @sean-k-mooney, are you here ? | |
| 12:10:28 | sean-k-mooney | o/ | |
| 12:11:59 | sean-k-mooney | dvo-plv: hi yes i am | |
| 12:15:02 | dvo-plv | I would like to discuss this blueprint https://review.opendev.org/c/openstack/neutron/+/869510 . Previously we implemented our separate linkvirt driver, but you prefer to move to the default openvswitch driver. We made our internal poc and published it to the opendev to simplify our discussion on how it would be better to be implemented | |
| 12:15:52 | dvo-plv | btw, I can not figure out, how to mention user here? | |
| 12:16:37 | sean-k-mooney | as in to ping people | |
| 12:16:41 | sean-k-mooney | on irc | |
| 12:16:44 | sean-k-mooney | or something else | |
| 12:19:19 | dvo-plv | yes, how to ping pople here. How do you do it with me? | |
| 12:19:39 | sean-k-mooney | just dvo-plv or dvo-plv: | |
| 12:19:47 | sean-k-mooney | dvo-plv: so like this | |
| 12:19:54 | sean-k-mooney | does that highlight for you | |
| 12:20:18 | sean-k-mooney | basicaly most client auto highlight on the nic you are connected with and you can configure others | |
| 12:20:20 | dvo-plv | i see, thank you | |
| 12:21:00 | sean-k-mooney | the : at the end generally gets added if you tab complete but it shoudl not be required | |
| 12:21:14 | dvo-plv | so ,if you have a time, I would like to discuss solution how to support our nic propperly | |
| 12:21:16 | sean-k-mooney | my client will match on my nic regardless or prefix or sufix | |
| 12:21:34 | sean-k-mooney | dvo-plv: so im in two minds | |
| 12:22:00 | sean-k-mooney | if you intend to someday upstream supprot for your nic to vanilla ovs then it should be in the generic openvswich/ovn drivers in tree | |
| 12:22:18 | sean-k-mooney | if you plan to maintain a fork then your orginal approch is fine | |
| 12:23:22 | sean-k-mooney | in general if the way you connect to a network backend it common acorrss vendors we like to have only one implemation of that | |
| 12:23:53 | sean-k-mooney | in your specific case i see there are some special requriements around the name of the vhost-user socket | |
| 12:24:20 | sean-k-mooney | i suspect that is specific to your vswith implmation | |
| 12:25:36 | dvo-plv | yes, we have our own dpdk driver what requires some specific moments | |
| 12:26:13 | sean-k-mooney | as currently written i think your patch might break the exiting virtio-forwarder code | |
| 12:26:44 | dvo-plv | when you are talking about original approach. You mean separate driver or implementation support with openvswitch | |
| 12:27:26 | sean-k-mooney | when i was suggesting using a singel ml2/driver for both i was suggesting ensuring your nic works with the dpdk_user supprot in vaniall ovs | |
| 12:27:40 | sean-k-mooney | and i was asking if that was what you were trying to enable | |
| 12:27:55 | sean-k-mooney | the answer to the second quetion is no | |
| 12:28:04 | sean-k-mooney | you are not trying to enabel to upstream ovs feature | |
| 12:28:15 | sean-k-mooney | your are trying to enable your vendor specific version | |
| 12:28:26 | sean-k-mooney | in which case usign an out of tree ml2 dirver is appropreiate | |
| 12:28:56 | sean-k-mooney | that way you do not need to worry about compatiablity with netonomes implamation of virtio forward | |
| 12:29:38 | sean-k-mooney | nova just uses the vhost-user path provided by neutron so as long as you set it to the correct value that should be transparent to nova | |
| 12:32:35 | sean-k-mooney | dvo-plv: have dpdk removed or raised the limit on dpdk type ports above 32 yet | |
| 12:37:19 | sean-k-mooney | dvo-plv: what i would suggest is adding a VIF_DETAILS_VHOSTUSER_NAPATECH_PLUG | |
| 12:37:49 | sean-k-mooney | so in the port binding details set a flag to indicate taht its napatech | |
| 12:38:34 | sean-k-mooney | continue to use vnic_type=vritio-forwarder | |
| 12:39:29 | justas_napa | Hi. To answer the question regarding ovs support - it really depends on the end user requirements | |
| 12:39:38 | sean-k-mooney | in nova check for both and in a new if in os_vif_util implement the logic you require | |
| 12:40:13 | justas_napa | we maintain our own OvS to support features like QinQ and some special QoS schemes | |
| 12:40:18 | sean-k-mooney | justas_napa: the in tree ml2/ovs and ml2/ovn dirver are only ment to supprot ovs form openvsiwtch.org | |
| 12:41:04 | sean-k-mooney | so if the basic virtio-forward fucntionality is not upstream to vanilla ovs it should be in a seperatem ml2 driver and os_vif driver | |
| 12:41:12 | justas_napa | I think we are OK to limit ourselves to vanilla ovs | |
| 12:41:53 | justas_napa | unless adding support for our own OVS is trivial | |
| 12:42:52 | sean-k-mooney | well vaniall ovs has two ways to enabel vhost-user but the proposal is not using either of them | |
| 12:42:59 | sean-k-mooney | https://docs.openvswitch.org/en/latest/topics/dpdk/vhost-user/ | |
| 12:43:17 | sean-k-mooney | instead you are created dpdk vdevs https://docs.openvswitch.org/en/latest/topics/dpdk/vdev/ | |
| 12:44:58 | sean-k-mooney | there is supprot for dpdk representor prots | |
| 12:45:27 | justas_napa | so then it's custom ml2 and os_vif driver | |
| 12:45:57 | sean-k-mooney | https://docs.openvswitch.org/en/latest/topics/dpdk/phy/#representors | |
| 12:46:02 | sean-k-mooney | am i think so. | |
| 12:46:26 | sean-k-mooney | if you go with the out of tree ml2/os-vif drivers then all that is requried in nova is a minor change to call them | |
| 12:46:26 | justas_napa | yes, we are heavy users of representors | |
| 12:46:46 | sean-k-mooney | so ok maybe we need to level set | |
| 12:47:07 | sean-k-mooney | justas_napa: the dpdk type port that you are creating for use with virio-forward | |
| 12:47:14 | sean-k-mooney | is that a vf representor | |
| 12:47:21 | sean-k-mooney | as descirbed here https://docs.openvswitch.org/en/latest/topics/dpdk/phy/#representors | |
| 12:47:32 | justas_napa | yes | |
| 12:47:50 | justas_napa | becuase all dataplane is offloaded to FPGA | |
| 12:48:01 | sean-k-mooney | ok so if that is what we are enableing and the supprot in upstream ovs also works with your nics we can enabel that in the intree support | |
| 12:48:54 | sean-k-mooney | so next question you require the vhost-user socket path to have a specific format to corralate teh vhost-user path to the dpdk representor correct | |
| 12:49:42 | justas_napa | I don't think we require specific path, just the socket name | |
| 12:49:53 | sean-k-mooney | the orginal requriements when vhsot-user was first added to ovs was the socket path's final segment and port name must be the same | |
| 12:50:20 | sean-k-mooney | right so for normal vhost-user when it was first added the socket-name and port name had to be the same | |
| 12:50:47 | sean-k-mooney | later we added a socket path to ovs to remove that limiation as part of supproting vhost-user-client mode where qemu is the server | |
| 12:51:22 | justas_napa | -chardev socket,id=char0,path=/usr/local/var/run/stdvio5,server | |
| 12:51:50 | justas_napa | so we are flexible on thje path, but the last part is stdvio<#VF> | |
| 12:52:00 | sean-k-mooney | ya so your dirver breaks the convention that the final segment of the name matches the name of the ovs port which is fine | |
| 12:52:07 | sean-k-mooney | ack | |
| 12:52:32 | sean-k-mooney | https://review.opendev.org/c/openstack/neutron/+/869510/2/neutron/plugins/ml2/drivers/openvswitch/mech_driver/mech_openvswitch.py#217 | |
| 12:52:37 | sean-k-mooney | so that is why you need this code | |
| 12:53:06 | justas_napa | yep | |
| 12:53:28 | sean-k-mooney | so the problem i see is the pci_slot is always going to be set for vnic_type virtio-forwarder | |
| 12:53:54 | sean-k-mooney | but we only want to take the else branch if its napatech | |
| 12:54:14 | sean-k-mooney | so ninstead of the current if we shoudl add a config value to the agent and check if that is set | |
| 12:54:25 | sean-k-mooney | so just like | |
| 12:54:27 | sean-k-mooney | sockdir = agent['configurations'].get('vhostuser_socket_dir', | |
| 12:54:29 | sean-k-mooney | ovs_const.VHOST_USER_SOCKET_DIR) | |
| 12:55:20 | sean-k-mooney | you shoudl add something like sockdir = agent['configurations'].get('vhostuser_socket_name_scheme','port_name') | |
| 12:55:50 | sean-k-mooney | and for napatech you woudl set vhostuser_socket_name_scheme to VF_index | |
| 12:55:54 | sean-k-mooney | or something liek that | |
| 12:55:56 | justas_napa | OK | |
| 12:56:22 | justas_napa | dvo-plv - does this work for us? | |
| 12:57:23 | sean-k-mooney | i need to think about the nova patch a bit but i think if you do that the nova patch is fine as is | |
| 12:57:54 | justas_napa | ack | |
| 12:57:55 | sean-k-mooney | well it needs test but the core functionality is proably correct | |
| 12:58:32 | dvo-plv | in our solution, socket name value is depends on the pci slot | |
| 12:58:55 | dvo-plv | This value vhostuser_socket_name_scheme will be located at the neutron conf file | |