| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-02-02 | |||
| 17:25:09 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (objects) https://review.opendev.org/c/openstack/nova/+/839401 | |
| 17:25:09 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (db) https://review.opendev.org/c/openstack/nova/+/831193 | |
| 17:25:10 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part) https://review.opendev.org/c/openstack/nova/+/833090 | |
| 17:25:10 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | |
| 17:25:11 | opendevreview | ribaudr proposed openstack/nova master: Check shares support https://review.opendev.org/c/openstack/nova/+/850499 | |
| 17:25:11 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (api) https://review.opendev.org/c/openstack/nova/+/836830 | |
| 17:25:12 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | |
| 17:25:12 | opendevreview | ribaudr proposed openstack/nova master: Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | |
| 17:25:13 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028 | |
| 17:25:14 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/852085 | |
| 17:25:14 | opendevreview | ribaudr proposed openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029 | |
| 17:25:16 | opendevreview | ribaudr proposed openstack/nova master: Add virt/libvirt error test cases https://review.opendev.org/c/openstack/nova/+/852087 | |
| 17:25:16 | opendevreview | ribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working. https://review.opendev.org/c/openstack/nova/+/852086 | |
| 17:25:18 | opendevreview | ribaudr proposed openstack/nova master: Support rebooting an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/854824 | |
| 17:25:18 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to reboot method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/854823 | |
| 17:25:20 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach_error notification https://review.opendev.org/c/openstack/nova/+/860283 | |
| 17:25:20 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach_error notification https://review.opendev.org/c/openstack/nova/+/860282 | |
| 17:25:22 | opendevreview | ribaudr proposed openstack/nova master: Support resuming an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/860285 | |
| 17:25:22 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to resume method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/860284 | |
| 17:25:24 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (driver part) https://review.opendev.org/c/openstack/nova/+/860287 | |
| 17:25:24 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to rescue/unrescue shares https://review.opendev.org/c/openstack/nova/+/860286 | |
| 17:25:26 | opendevreview | ribaudr proposed openstack/nova master: Documentation https://review.opendev.org/c/openstack/nova/+/871642 | |
| 17:25:26 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/860288 | |
| 20:41:14 | opendevreview | Sylvain Bauza proposed openstack/nova master: cpu: interfaces for managing state and governor https://review.opendev.org/c/openstack/nova/+/868236 | |
| 20:41:15 | opendevreview | Sylvain Bauza proposed openstack/nova master: WIP: enable cpus when an instance is spawning https://review.opendev.org/c/openstack/nova/+/868237 | |
| 20:41:15 | opendevreview | Sylvain Bauza proposed openstack/nova master: libvirt: let CPUs be power managed https://review.opendev.org/c/openstack/nova/+/821228 | |
| #openstack-nova - 2023-02-03 | |||
| 02:08:05 | opendevreview | Merged openstack/nova master: Check our nodes for hypervisor_hostname changes https://review.opendev.org/c/openstack/nova/+/872220 | |
| 09:47:39 | opendevreview | Amit Uniyal proposed openstack/nova master: Adds check if resized to swap zero https://review.opendev.org/c/openstack/nova/+/857339 | |
| 10:38:54 | opendevreview | Rajesh Tailor proposed openstack/nova master: Add functional regression tests for bug 1857306 https://review.opendev.org/c/openstack/nova/+/700456 | |
| 10:52:34 | opendevreview | Rajesh Tailor proposed openstack/nova master: Add functional regression tests for bug 1857306 https://review.opendev.org/c/openstack/nova/+/700456 | |
| 11:16:03 | zigo | My patch for rocky/stein/train probably has broke nova ... :( | |
| 11:17:00 | zigo | What's the current status of the Nova gate for these releases? | |
| 11:20:32 | bauzas | zigo: we're on hold with wallaby | |
| 11:20:54 | bauzas | and I think we won't have backports for Train | |
| 11:21:16 | bauzas | (and as a reminder, Stein and older branches are EOL'd in nova) | |
| 11:23:05 | sean-k-mooney | zigo: part of the problem with train and older is we cannot bump the minium requirements of oslo and the patach the provides the extra info was merged in ussuri | |
| 11:23:58 | sean-k-mooney | so the only way to backport this upstream in train and older would be to either vendor the oslo changes in nova or fallback to not fixign teh cve when oslo is not new enough | |
| 11:31:50 | bauzas | mmm, looks like a new gate problem \o/ | |
| 11:31:52 | bauzas | https://opensearch.logs.openstack.org/_dashboards/app/discover?security_tenant=global#/?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-7d,to:now))&_a=(columns:!(filename),filters:!(('$state':(store:appState),meta:(alias:!n,disabled:!f,index:'94869730-aea8-11ec-9e6a-83741af3fdcd',key:filename,negate:!f,params:(query:job-output.txt),type:phrase),query:(match_phrase:(filename:job-output.txt)))),index:'94869730-aea | |
| 11:31:54 | bauzas | 8-11ec-9e6a-83741af3fdcd',interval:auto,query:(language:kuery,query:test_replace_location),sort:!()) | |
| 11:32:17 | bauzas | huzzah | |
| 11:37:17 | bauzas | https://bugs.launchpad.net/nova/+bug/2004641 is created | |
| 11:40:34 | sean-k-mooney | ya we have seen that a few times | |
| 11:40:44 | sean-k-mooney | not that new but definetly intermitant | |
| 11:41:21 | sean-k-mooney | i did see b'400 Bad Request\n\nThe Store URI was malformed.\n\n ' last year but only like once or twice | |
| 11:43:28 | sean-k-mooney | i have no idea why that happens sometimes | |
| 11:50:26 | bauzas | sean-k-mooney: unrelated, I tried this morning to see how to use the SysFixture I created to be used for two different computes | |
| 11:50:56 | bauzas | sean-k-mooney: the problem is not on how to use two fixture instances | |
| 11:51:22 | sean-k-mooney | its the mock of the sys path | |
| 11:51:52 | sean-k-mooney | you need to activate that when teh compute is started with a With statement | |
| 11:52:03 | bauzas | sean-k-mooney: but the question I have is how to make sure if that we call, say, migrate_instance() how to use the right fixture instance | |
| 11:52:19 | bauzas | sean-k-mooney: you think it would work so ? | |
| 11:52:33 | bauzas | I was thinking of this | |
| 11:52:47 | sean-k-mooney | we have done similar things in the past. dansmith is doing somethign similar in the stable uuid series | |
| 11:52:49 | bauzas | but I was afraid that when we call migrate_instance() it wouldn't work | |
| 11:53:00 | sean-k-mooney | well there is one way to find out | |
| 11:53:32 | sean-k-mooney | try it and see | |
| 11:53:35 | bauzas | I could use a context manager | |
| 11:53:44 | bauzas | yeah, I'll try | |
| 11:54:25 | sean-k-mooney | if its a proably the we can do it sleightly differnt by doing mock.patch.object on the speficic compute instnaces | |
| 11:54:36 | sean-k-mooney | *compute objects | |
| 11:54:47 | sean-k-mooney | and ensure each one will use the correct one | |
| 11:56:26 | bauzas | I'll test it | |
| 11:56:36 | bauzas | I'm pretty done with my series | |
| 11:56:41 | bauzas | I'm just adding more tests | |
| 11:57:01 | sean-k-mooney | as in "ready to give up" or its good for re review | |
| 11:57:06 | sean-k-mooney | im hoping the latter :) | |
| 11:57:52 | sean-k-mooney | main feedback at a glance is you have no docs and no release note so in addtion to tests please think about those | |
| 11:58:21 | sean-k-mooney | ping me when you would like a full review and/or manual testing of this | |
| 11:58:53 | bauzas | sean-k-mooney: yup, you can manually test if you want | |
| 11:59:23 | bauzas | sean-k-mooney: the WIP is +W because of the tests and indeed the documents | |
| 11:59:32 | sean-k-mooney | you probaly have not tried using mixed cpus (a vm with pinned and unpined cores) and im not sure if you have check what happens when you use vcpu_pin_set vs cpu_dedicated_set | |
| 11:59:43 | bauzas | s/+W/-W of course | |
| 11:59:58 | bauzas | sean-k-mooney: good point, I can try | |
| 12:00:46 | sean-k-mooney | ill test those manully but when you have some basic test functional test to cover the commen cases pushed in an non wip it would be nice to have functional tests for those | |
| 12:02:15 | sean-k-mooney | we should also test the other funky numa cases i really dont expect it to matter but asymetic numa nodes and multiple numa. all of those advanced cases however can be added later | |
| 12:02:22 | sean-k-mooney | i dont belive your code will care | |
| 12:03:27 | sean-k-mooney | instance.numa_topology.cpu_pinning should be ever PCPU the vm is pinned too regardless of numa | |
| 12:04:20 | sean-k-mooney | including the extra one not used by vm cores when you use hw:emulator_thread_policy=isolate | |
| 12:06:04 | bauzas | not sure I fully understand your point, sorry | |
| 12:06:40 | sean-k-mooney | if you tried to parse the pinned cpus form the xml there are a bunch of edgecases that you would have had to handel | |
| 12:06:51 | sean-k-mooney | like also lookign at the emulator thread | |
| 12:07:19 | sean-k-mooney | but since your using instance.numa_topology.cpu_pinning you can mostly ignore that complexity | |
| 12:07:56 | bauzas | yup changed it based on your point | |
| 12:08:32 | sean-k-mooney | so while it would still be nice to test some fo the more complex numa toplogies and edgecases the code should not genrally have to care about them | |
| 12:08:54 | bauzas | yup, that's why I want to have migration tests + some numa ones | |
| 12:09:17 | sean-k-mooney | bauzas: we are expictly only supporting this when you use cpu_dedicated_set right and not vcpu_pin_set | |
| 12:09:29 | bauzas | correct | |
| 12:09:48 | bauzas | well, checking my code | |
| 12:10:01 | sean-k-mooney | do we want to raise a config error like dansmith is doing in the stable uuid series | |
| 12:10:15 | sean-k-mooney | i.e. if you enable this but also have vcpu_pin_set defiend | |
| 12:10:39 | sean-k-mooney | or dont have cpu_dedicated_set defiend | |
| 12:10:58 | bauzas | good question, I need to think about it | |
| 12:11:14 | sean-k-mooney | there are extra edgecases that only come into play if you use vcpu_pin_set | |
| 12:11:18 | sean-k-mooney | which is why im asking | |
| 12:11:34 | bauzas | https://review.opendev.org/c/openstack/nova/+/868237/6/nova/virt/libvirt/cpu/api.py | |
| 12:11:37 | sean-k-mooney | specificaly related to cpu_thread_policy=isolate on a host with hyperthreading | |
| 12:11:55 | bauzas | here, we only check get_decicated_set() | |
| 12:12:15 | bauzas | but we try to look the numa_topo blob from the instance | |
| 12:12:47 | sean-k-mooney | ok so that is not going to block it | |