| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-02-01 | |||
| 19:41:35 | sean-k-mooney | cool let us know when its ready to re review | |
| 19:43:16 | sean-k-mooney | i think you have adressed everything i found in my manual testing at this point i can quickly run true the list again tomorrow | |
| 19:48:29 | dansmith | sean-k-mooney: no, I can't really address the traceback (on startup) without a change to oslo.service AFAIK | |
| 19:48:39 | dansmith | but it will no longer be a trace if it happens during periodic | |
| 19:49:07 | sean-k-mooney | i was refering to https://review.opendev.org/c/openstack/nova/+/872432/1/nova/compute/manager.py | |
| 19:49:15 | sean-k-mooney | sorry not that | |
| 19:49:22 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/872432/1/nova/compute/resource_tracker.py | |
| 19:49:39 | dansmith | sean-k-mooney: if you could re-+W this before you go, that can still merge https://review.opendev.org/c/openstack/nova/+/872220/3 | |
| 19:49:44 | dansmith | and then we'll have less for tomorrow | |
| 19:50:01 | sean-k-mooney | sure | |
| 19:50:06 | dansmith | sean-k-mooney: yeah, but in order to get service startup to abort, we still have to raise and you'll get a trace in the logs | |
| 19:50:14 | dansmith | sean-k-mooney: that one was just hit by a rebase accidentally | |
| 19:50:15 | sean-k-mooney | i was just skiming the later two patches by the way | |
| 19:50:58 | sean-k-mooney | dansmith: ok and the agent will abort on start in that case? | |
| 19:51:11 | dansmith | yes, | |
| 19:51:14 | sean-k-mooney | ill test it to tomrrow either way just wondering what to expect | |
| 19:51:16 | sean-k-mooney | cool | |
| 19:51:36 | dansmith | the reason it wasn't before is we swallow and ignore Exception, except for specific ones, so now this makes InvalidConfiguration abort, if startup=True | |
| 19:51:56 | sean-k-mooney | presumably in a decorator | |
| 19:52:03 | dansmith | so that patch is mostly just to make sure we catch the duplicate error specifically, turn it into InvalidConfiguration, and then allow InvalidConfiguration on startup to abort us | |
| 19:52:06 | simondodsley | Question from a customer using Queens (I know EOL and unsupported), is there a way to migrate a boot volume to a new backend wit ha shutdown instance? | |
| 19:52:07 | dansmith | no | |
| 19:52:24 | dansmith | just in our own wrapper around update_available_resource() | |
| 19:52:32 | sean-k-mooney | ah ok | |
| 19:52:33 | dansmith | you'll see when you look closer.. it was fairly obvious, there are just lots of layers | |
| 19:53:01 | sean-k-mooney | ack | |
| 19:53:24 | sean-k-mooney | simondodsley: so ha shutdown isntance you mean isntancce ha is in use but the instance is stopped | |
| 19:53:48 | simondodsley | i beleive that is what they are asking | |
| 19:53:51 | sean-k-mooney | simondodsley: if its a boot form volume guest i would still expec a cinder volume retry or volume migration could be used | |
| 19:54:12 | sean-k-mooney | nova does not have any apis for this so you would have to ask the cinder folks i think | |
| 19:54:37 | simondodsley | they tried the cinder retype and it dodn't work. Nova got confused and attached the new volume with the wrong vd device | |
| 19:54:49 | simondodsley | or is that definatley a cinder/os-brick thing? | |
| 19:55:21 | sean-k-mooney | vd device? | |
| 19:55:35 | sean-k-mooney | as in /dev/vda /dev/vdb in the guest | |
| 19:56:17 | sean-k-mooney | if so the device path in the guest is not actully used when you are using libvirt | |
| 19:56:24 | sean-k-mooney | we cant actully contol that | |
| 19:56:54 | sean-k-mooney | but if you mean on the host that sound like a bug but im not sure if its a nova one of os-brick/cinder one | |
| 19:57:37 | sean-k-mooney | most of the host block device managemnt is done os-brick | |
| 20:01:23 | sean-k-mooney | dansmith: oh ya that was right in front of me https://review.opendev.org/c/openstack/nova/+/872432/1/nova/compute/manager.py#10491 | |
| 20:02:19 | dansmith | yep, that's it, and you can see earlier we raise on startup for reshape things | |
| 20:02:42 | sean-k-mooney | yep | |
| 20:02:48 | dansmith | I wasn't expecting us to have a "log and swallow" exception handler there, so it took me a while to realize why it *was* running at startup, but not stopping us | |
| 20:03:02 | sean-k-mooney | ya | |
| 20:03:30 | sean-k-mooney | ok actully going now o/ the first patch is on its way | |
| 20:04:44 | dansmith | thanks | |
| 22:51:21 | opendevreview | melanie witt proposed openstack/nova master: Reproducer for bug 2003991 unshelving offloaded instance https://review.opendev.org/c/openstack/nova/+/872470 | |
| 22:51:22 | opendevreview | melanie witt proposed openstack/nova master: Enforce quota usage from placement when unshelving https://review.opendev.org/c/openstack/nova/+/872471 | |
| #openstack-nova - 2023-02-02 | |||
| 03:57:29 | opendevreview | Ghanshyam proposed openstack/nova stable/wallaby: Remove broken sdk functional job from stable/wallaby https://review.opendev.org/c/openstack/nova/+/871798 | |
| 09:07:23 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/python-novaclient master: Bump microversion to 2.95 https://review.opendev.org/c/openstack/python-novaclient/+/872418 | |
| 09:08:46 | sahid | thank you artom for this ^ I've just fixed one point I hope you d'ont mind and the phrasing was right | |
| 09:09:34 | sahid | bauzas: just in case you have not noticed, I have fixed the comments that you wanted previously https://review.opendev.org/c/openstack/nova/+/872413 | |
| 09:26:41 | bauzas | sahid: ahem, I had some nit on the nits follow-up :D | |
| 09:26:57 | sahid | ahah let me fix that | |
| 10:04:56 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: fup: support evacuate target state https://review.opendev.org/c/openstack/nova/+/872413 | |
| 10:24:20 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (db) https://review.opendev.org/c/openstack/nova/+/831193 | |
| 10:24:21 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | |
| 10:24:21 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (objects) https://review.opendev.org/c/openstack/nova/+/839401 | |
| 10:24:22 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part) https://review.opendev.org/c/openstack/nova/+/833090 | |
| 10:24:23 | opendevreview | ribaudr proposed openstack/nova master: Check shares support https://review.opendev.org/c/openstack/nova/+/850499 | |
| 10:24:23 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (api) https://review.opendev.org/c/openstack/nova/+/836830 | |
| 10:24:24 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | |
| 10:24:24 | opendevreview | ribaudr proposed openstack/nova master: Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | |
| 10:24:25 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028 | |
| 10:24:26 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/852085 | |
| 10:24:26 | opendevreview | ribaudr proposed openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029 | |
| 10:24:28 | opendevreview | ribaudr proposed openstack/nova master: Add virt/libvirt error test cases https://review.opendev.org/c/openstack/nova/+/852087 | |
| 10:24:28 | opendevreview | ribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working. https://review.opendev.org/c/openstack/nova/+/852086 | |
| 10:24:30 | opendevreview | ribaudr proposed openstack/nova master: Support rebooting an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/854824 | |
| 10:24:30 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to reboot method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/854823 | |
| 10:24:32 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach_error notification https://review.opendev.org/c/openstack/nova/+/860283 | |
| 10:24:32 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach_error notification https://review.opendev.org/c/openstack/nova/+/860282 | |
| 10:24:34 | opendevreview | ribaudr proposed openstack/nova master: Support resuming an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/860285 | |
| 10:24:34 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to resume method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/860284 | |
| 10:24:36 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (driver part) https://review.opendev.org/c/openstack/nova/+/860287 | |
| 10:24:36 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to rescue/unrescue shares https://review.opendev.org/c/openstack/nova/+/860286 | |
| 10:24:38 | opendevreview | ribaudr proposed openstack/nova master: Documentation https://review.opendev.org/c/openstack/nova/+/871642 | |
| 10:24:38 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/860288 | |
| 13:36:53 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/python-novaclient master: Bump microversion to 2.95 https://review.opendev.org/c/openstack/python-novaclient/+/872418 | |
| 14:09:24 | opendevreview | Jorge San Emeterio proposed openstack/nova master: Dividing global privsep profile https://review.opendev.org/c/openstack/nova/+/871729 | |
| 14:10:10 | opendevreview | Jorge San Emeterio proposed openstack/nova master: WIP: Moving privsep profiles to nova/__init__.py https://review.opendev.org/c/openstack/nova/+/872010 | |
| 14:31:00 | opendevreview | Jorge San Emeterio proposed openstack/nova master: Moving privsep profiles to nova/__init__.py https://review.opendev.org/c/openstack/nova/+/872010 | |
| 17:25:09 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (objects) https://review.opendev.org/c/openstack/nova/+/839401 | |
| 17:25:09 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (db) https://review.opendev.org/c/openstack/nova/+/831193 | |
| 17:25:10 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part) https://review.opendev.org/c/openstack/nova/+/833090 | |
| 17:25:10 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | |
| 17:25:11 | opendevreview | ribaudr proposed openstack/nova master: Check shares support https://review.opendev.org/c/openstack/nova/+/850499 | |
| 17:25:11 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (api) https://review.opendev.org/c/openstack/nova/+/836830 | |
| 17:25:12 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | |
| 17:25:12 | opendevreview | ribaudr proposed openstack/nova master: Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | |
| 17:25:13 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028 | |
| 17:25:14 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/852085 | |
| 17:25:14 | opendevreview | ribaudr proposed openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029 | |
| 17:25:16 | opendevreview | ribaudr proposed openstack/nova master: Add virt/libvirt error test cases https://review.opendev.org/c/openstack/nova/+/852087 | |
| 17:25:16 | opendevreview | ribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working. https://review.opendev.org/c/openstack/nova/+/852086 | |
| 17:25:18 | opendevreview | ribaudr proposed openstack/nova master: Support rebooting an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/854824 | |
| 17:25:18 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to reboot method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/854823 | |
| 17:25:20 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach_error notification https://review.opendev.org/c/openstack/nova/+/860283 | |
| 17:25:20 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach_error notification https://review.opendev.org/c/openstack/nova/+/860282 | |
| 17:25:22 | opendevreview | ribaudr proposed openstack/nova master: Support resuming an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/860285 | |
| 17:25:22 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to resume method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/860284 | |