| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-01-30 | |||
| 18:55:18 | sean-k-mooney | ya gerrit agrees so gibis +2 is still there | |
| 19:00:45 | sean-k-mooney | i see thats not exactuly what i was expecting | |
| 19:00:54 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/872204/1/nova/compute/manager.py#1556 | |
| 19:01:38 | dansmith | well, sorry to disappoint you | |
| 19:02:32 | sean-k-mooney | i was expectign you to get teh compute node object and see if its hypervior hostname is the same as what the driver currently says it is | |
| 19:03:07 | sean-k-mooney | i think this covers the first two cases | |
| 19:03:20 | sean-k-mooney | on line 1563 | |
| 19:03:21 | dansmith | but that's not going to catch the case you were concerned about.. where we have a different (generated) uuid, so we think we should create a compute node, but we fail because of the UC on the hostname | |
| 19:03:55 | sean-k-mooney | i was concewrned about 2 thing | |
| 19:04:40 | sean-k-mooney | i think this covers test 3 and 4 https://etherpad.opendev.org/p/Stable-compute-uuid-manual-testing#L77 | |
| 19:04:58 | sean-k-mooney | im unsure about 9 and 10 | |
| 19:05:00 | sean-k-mooney | https://etherpad.opendev.org/p/Stable-compute-uuid-manual-testing#L216 | |
| 19:05:01 | dansmith | the third bullet will result in us looking up both our node and the conflicting host's node, but the uuids won't match what we expect | |
| 19:06:23 | sean-k-mooney | a change in the hostname does not maen Conf.host changes or our uuid does but i can check your code now and confirm if it resoulve all 4 test cases | |
| 19:07:27 | dansmith | I dunno what test 9 is supposed to be because there's no explanation other than "$old_hostname" so I'm not sure if this addresses that or not | |
| 19:07:37 | dansmith | I think it *does* address what I listed as things it should address, | |
| 19:07:56 | sean-k-mooney | that you change /etc/hostname form X to Y but Conf.host is hardcoded to X | |
| 19:07:57 | dansmith | the later of which is setting CONF.host to be the same for two separate compute services | |
| 19:08:22 | dansmith | that's the hypervisor_hostname thing right? this doesn't address that | |
| 19:08:36 | sean-k-mooney | thats the hypervior host name thing yes | |
| 19:08:41 | dansmith | I haven't even gotten there yet | |
| 19:08:44 | sean-k-mooney | so that what happend in old OOO | |
| 19:08:52 | sean-k-mooney | ack | |
| 19:09:34 | sean-k-mooney | tripleo started hardcodeing CONF.host before they hardcoded /etc/hostname to the same value | |
| 19:10:00 | sean-k-mooney | so 9 is basically testing that old case | |
| 19:10:21 | dansmith | that's cool, but that's not what I'm trying to address with this patch, nor what even the series was trying to address. that's more in the scope of some of the later things in the top-level spec | |
| 19:10:54 | dansmith | I think we can address it here, once we have a stable "who the fsck am I?" notion, but I haven't gotten there yet | |
| 19:11:08 | sean-k-mooney | ack | |
| 19:11:39 | sean-k-mooney | so ill retest and with your last patch i should epect it to handel 3 an 4 (file delete and file with wrong uuid) correct | |
| 19:11:55 | sean-k-mooney | and 9/10 should still be out of scope | |
| 19:12:09 | dansmith | probably, but since I haven't gotten the *existing* tests to pass I have no idea | |
| 19:12:19 | dansmith | I thought you said you wanted to look at the test failures, which is why I pushed it up | |
| 19:12:32 | sean-k-mooney | dansmith: i can do that too | |
| 19:13:01 | sean-k-mooney | but i have yoru code deployed so i can quickly test those edge cases first | |
| 20:00:28 | gmann | gibi: updated placement rbac change for your comment, please check (in case you missed my previous ping ) https://review.opendev.org/c/openstack/placement/+/865618 | |
| 20:08:02 | sean-k-mooney | there is a security team irc right? | |
| 20:08:29 | sean-k-mooney | im trying to calulate teh CVSSv3 score for the vmdk CVE | |
| 20:08:34 | sean-k-mooney | i come up with 8.2 | |
| 20:10:05 | dansmith | fungi: ^ | |
| 20:10:50 | fungi | #openstack-security yeah | |
| 20:11:20 | sean-k-mooney | ack i can ask there but you said this was not normaly done by the sectuiy team | |
| 20:11:22 | sean-k-mooney | https://nvd.nist.gov/vuln-metrics/cvss/v3-calculator?vector=AV:N/AC:H/PR:L/UI:N/S:C/C:H/I:N/A:H&version=3.1 | |
| 20:11:31 | sean-k-mooney | that is what i came up with | |
| 21:31:16 | opendevreview | Dan Smith proposed openstack/nova master: Detect host renames and abort startup https://review.opendev.org/c/openstack/nova/+/863920 | |
| 21:31:16 | opendevreview | Dan Smith proposed openstack/nova master: Fixup patch for stable-compute-uuid series https://review.opendev.org/c/openstack/nova/+/871848 | |
| 21:31:17 | opendevreview | Dan Smith proposed openstack/nova master: Check our nodes for hypervisor_hostname changes https://review.opendev.org/c/openstack/nova/+/872220 | |
| 21:40:57 | opendevreview | Rafael Weingartner proposed openstack/nova-specs master: spec: nova Dynamic scheduler system https://review.opendev.org/c/openstack/nova-specs/+/872225 | |
| #openstack-nova - 2023-01-31 | |||
| 00:02:20 | opendevreview | Merged openstack/nova master: Make resource tracker use UUIDs instead of names https://review.opendev.org/c/openstack/nova/+/863919 | |
| 07:54:26 | sahid | o/ | |
| 07:58:03 | sahid | ouch, merge conflicts on rpc version :/ | |
| 07:59:01 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: api: extend evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858384 | |
| 07:59:01 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: compute: enhance compute evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858383 | |
| 11:51:02 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: compute: enhance compute evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858383 | |
| 11:51:03 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: api: extend evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858384 | |
| 12:40:30 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix concurrent migration of vms with multiattach volume failure https://review.opendev.org/c/openstack/nova/+/872278 | |
| 13:17:48 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix concurrent migration of vms with multiattach volume failure https://review.opendev.org/c/openstack/nova/+/872278 | |
| 14:09:46 | sahid | bauzas, sean-k-mooney can I request reviews on the evacuate api feature, i'ts all green. I had to rebase and fix conflicts this morning du to a rpc change | |
| 14:10:02 | sahid | now i think we are good, i hope :-) | |
| 14:26:03 | sean-k-mooney | ya i was waiting for ci to report back before pining bauzas | |
| 14:26:26 | sean-k-mooney | im +2 on the first and +1.5 on the second pending bauzas's review | |
| 14:26:36 | sean-k-mooney | if they are happy then ill escalate to +2w | |
| 14:42:31 | opendevreview | Alexey Stupnikov proposed openstack/nova stable/ussuri: [stable-only] Disable nova-grenade-multinode voting https://review.opendev.org/c/openstack/nova/+/872281 | |
| 14:43:17 | opendevreview | Alexey Stupnikov proposed openstack/nova stable/ussuri: reenable greendns in nova. https://review.opendev.org/c/openstack/nova/+/833437 | |
| 14:53:56 | bauzas | sean-k-mooney: sahid: I'll look again when I have time today | |
| 14:58:05 | sahid | ack ++ thank you bauzas | |
| 15:23:34 | opendevreview | Dan Smith proposed openstack/nova master: Protect against a deleted node id file https://review.opendev.org/c/openstack/nova/+/872204 | |
| 15:37:40 | elodilles | bauzas: are you editing the Nova meeting page or may I edit it? | |
| 15:38:08 | bauzas | elodilles: do it | |
| 15:38:21 | bauzas | elodilles: I'm doing 4 things at the same time | |
| 15:38:41 | elodilles | bauzas: :-o | |
| 15:38:52 | bauzas | multi-tasking | |
| 15:38:56 | bauzas | but man, this is hard | |
| 15:39:38 | elodilles | bauzas: i can imagine :S i don't like context switching :/ | |
| 15:45:32 | elodilles | bauzas: done. you can also edit now (if you want to do a 5th thing :S) | |
| 15:50:18 | bauzas | elodilles: yup, will do indeed | |
| 16:00:27 | opendevmeet | The meeting name has been set to 'nova' | |
| 16:00:27 | opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | |
| 16:00:27 | opendevmeet | Meeting started Tue Jan 31 16:00:27 2023 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | |
| 16:00:27 | bauzas | #startmeeting nova | |
| 16:00:33 | bauzas | hey ho | |
| 16:00:44 | gmann | o/ | |
| 16:00:56 | elodilles | o/ | |
| 16:01:02 | Uggla | o/ | |
| 16:01:04 | dansmith | o/ | |
| 16:01:16 | gibi | o7 | |
| 16:01:40 | bauzas | okay let's start | |
| 16:01:49 | bauzas | #topic Bugs (stuck/critical) | |
| 16:01:56 | bauzas | #info No Critical bug | |
| 16:02:00 | bauzas | #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 27 new untriaged bugs (+1 since the last meeting) | |
| 16:02:04 | bauzas | #info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster | |
| 16:02:21 | bauzas | bug baton can be passed over to artom if he wants | |
| 16:02:30 | artom | Sure | |
| 16:02:38 | artom | I feel like I've skipped.... many weeks | |
| 16:02:43 | artom | (unintentionally) | |
| 16:03:24 | bauzas | thanks | |
| 16:03:36 | bauzas | #info bug baton is being passed to artom | |
| 16:03:46 | bauzas | artom: again, this is just a temptative | |
| 16:03:52 | bauzas | don't feel that much obliged | |
| 16:04:04 | artom | Well don't say that | |
| 16:04:30 | bauzas | ok, so, before we move on, do people want to discuss about some , per say, CVE bugfix or everything is OK since we're on track ? | |