Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2023-01-30
16:53:23 sean-k-mooney ya i suspect it disappeared too
18:29:25 opendevreview Merged openstack/nova master: Persist existing node uuids locally https://review.opendev.org/c/openstack/nova/+/863918
18:29:35 opendevreview Merged openstack/nova master: Fix huge-page doc https://review.opendev.org/c/openstack/nova/+/869689
18:41:02 dansmith sean-k-mooney: I thought on friday you said you were happy with my answer here: https://review.opendev.org/c/openstack/nova/+/863919/12
18:41:22 dansmith but I also thought you commented on it, which I don't see... do we need more on that?
18:41:51 sean-k-mooney i think that was in context of https://review.opendev.org/c/openstack/nova/+/863918/12
18:42:02 sean-k-mooney i have not looked at the rt one since then
18:42:20 sean-k-mooney as in i looked at it before we talked on irc/meet
18:42:36 sean-k-mooney ill try and loop back too it again shortly
18:43:14 dansmith okay just wanted to make sure I wasn't missing some response or action
18:44:08 sean-k-mooney no i think we can likely proceed with that for now
18:44:11 sean-k-mooney https://review.opendev.org/c/openstack/nova/+/863919/12/nova/tests/unit/compute/test_resource_tracker.py#1553
18:44:33 dansmith ack
18:44:44 sean-k-mooney i was expecting to be blocked becasue i was expecting use to block hypervior_hostname changes which we agreed should be done but is out of scope of the spec
18:45:20 sean-k-mooney im ok to defer that to after the current serise of patches as either a bug or something we do next cycle
18:48:47 dansmith I've been working all morning (and some on friday) trying to get the consistency check (i.e. "are there any nodes that claim to be mine that aren't in my list of uuids") to pass functional tests
18:49:19 dansmith but I'm about to slam a body part in a door so I have an excuse to stop working on it.. this stuff is such a tangled mess
18:49:20 sean-k-mooney i assume as a patch on the end of the seriese
18:49:47 sean-k-mooney i was hoping we could jsut tweak _ensure_existing_node_identity
18:49:59 sean-k-mooney but im guessing when we do that has test fallout
18:50:05 sean-k-mooney and you have been trying to resolve that
18:51:29 dansmith I don't want to put the logic in there specifically because that's the migration code, which we might remove one day once migrations are long out of our support envelope
18:51:42 dansmith but that has nothing to do with the difficulty
18:51:58 sean-k-mooney oh _ensure_existing_node_identity is only called there ok
18:52:00 dansmith I can push up what I have if you want and you can try to get things to pass
18:52:26 sean-k-mooney sure i can take a look at it
18:53:35 sean-k-mooney ill proceed with the RT change and the last two patch reviews now
18:53:54 opendevreview Dan Smith proposed openstack/nova master: Make resource tracker use UUIDs instead of names https://review.opendev.org/c/openstack/nova/+/863919
18:53:55 opendevreview Dan Smith proposed openstack/nova master: Detect host renames and abort startup https://review.opendev.org/c/openstack/nova/+/863920
18:53:55 opendevreview Dan Smith proposed openstack/nova master: Fixup patch for stable-compute-uuid series https://review.opendev.org/c/openstack/nova/+/871848
18:53:56 opendevreview Dan Smith proposed openstack/nova master: TURBOWIP: Add a host/node consistency check https://review.opendev.org/c/openstack/nova/+/872204
18:54:13 sean-k-mooney heh ok
18:54:22 sean-k-mooney i was oging to suggest not modifying the make RT one
18:54:39 dansmith I had to rebase to submit
18:54:58 dansmith it's otherwise unchanged
18:55:18 sean-k-mooney ya gerrit agrees so gibis +2 is still there
19:00:45 sean-k-mooney i see thats not exactuly what i was expecting
19:00:54 sean-k-mooney https://review.opendev.org/c/openstack/nova/+/872204/1/nova/compute/manager.py#1556
19:01:38 dansmith well, sorry to disappoint you
19:02:32 sean-k-mooney i was expectign you to get teh compute node object and see if its hypervior hostname is the same as what the driver currently says it is
19:03:07 sean-k-mooney i think this covers the first two cases
19:03:20 sean-k-mooney on line 1563
19:03:21 dansmith but that's not going to catch the case you were concerned about.. where we have a different (generated) uuid, so we think we should create a compute node, but we fail because of the UC on the hostname
19:03:55 sean-k-mooney i was concewrned about 2 thing
19:04:40 sean-k-mooney i think this covers test 3 and 4 https://etherpad.opendev.org/p/Stable-compute-uuid-manual-testing#L77
19:04:58 sean-k-mooney im unsure about 9 and 10
19:05:00 sean-k-mooney https://etherpad.opendev.org/p/Stable-compute-uuid-manual-testing#L216
19:05:01 dansmith the third bullet will result in us looking up both our node and the conflicting host's node, but the uuids won't match what we expect
19:06:23 sean-k-mooney a change in the hostname does not maen Conf.host changes or our uuid does but i can check your code now and confirm if it resoulve all 4 test cases
19:07:27 dansmith I dunno what test 9 is supposed to be because there's no explanation other than "$old_hostname" so I'm not sure if this addresses that or not
19:07:37 dansmith I think it *does* address what I listed as things it should address,
19:07:56 sean-k-mooney that you change /etc/hostname form X to Y but Conf.host is hardcoded to X
19:07:57 dansmith the later of which is setting CONF.host to be the same for two separate compute services
19:08:22 dansmith that's the hypervisor_hostname thing right? this doesn't address that
19:08:36 sean-k-mooney thats the hypervior host name thing yes
19:08:41 dansmith I haven't even gotten there yet
19:08:44 sean-k-mooney so that what happend in old OOO
19:08:52 sean-k-mooney ack
19:09:34 sean-k-mooney tripleo started hardcodeing CONF.host before they hardcoded /etc/hostname to the same value
19:10:00 sean-k-mooney so 9 is basically testing that old case
19:10:21 dansmith that's cool, but that's not what I'm trying to address with this patch, nor what even the series was trying to address. that's more in the scope of some of the later things in the top-level spec
19:10:54 dansmith I think we can address it here, once we have a stable "who the fsck am I?" notion, but I haven't gotten there yet
19:11:08 sean-k-mooney ack
19:11:39 sean-k-mooney so ill retest and with your last patch i should epect it to handel 3 an 4 (file delete and file with wrong uuid) correct
19:11:55 sean-k-mooney and 9/10 should still be out of scope
19:12:09 dansmith probably, but since I haven't gotten the *existing* tests to pass I have no idea
19:12:19 dansmith I thought you said you wanted to look at the test failures, which is why I pushed it up
19:12:32 sean-k-mooney dansmith: i can do that too
19:13:01 sean-k-mooney but i have yoru code deployed so i can quickly test those edge cases first
20:00:28 gmann gibi: updated placement rbac change for your comment, please check (in case you missed my previous ping ) https://review.opendev.org/c/openstack/placement/+/865618
20:08:02 sean-k-mooney there is a security team irc right?
20:08:29 sean-k-mooney im trying to calulate teh CVSSv3 score for the vmdk CVE
20:08:34 sean-k-mooney i come up with 8.2
20:10:05 dansmith fungi: ^
20:10:50 fungi #openstack-security yeah
20:11:20 sean-k-mooney ack i can ask there but you said this was not normaly done by the sectuiy team
20:11:22 sean-k-mooney https://nvd.nist.gov/vuln-metrics/cvss/v3-calculator?vector=AV:N/AC:H/PR:L/UI:N/S:C/C:H/I:N/A:H&version=3.1
20:11:31 sean-k-mooney that is what i came up with
21:31:16 opendevreview Dan Smith proposed openstack/nova master: Detect host renames and abort startup https://review.opendev.org/c/openstack/nova/+/863920
21:31:16 opendevreview Dan Smith proposed openstack/nova master: Fixup patch for stable-compute-uuid series https://review.opendev.org/c/openstack/nova/+/871848
21:31:17 opendevreview Dan Smith proposed openstack/nova master: Check our nodes for hypervisor_hostname changes https://review.opendev.org/c/openstack/nova/+/872220
21:40:57 opendevreview Rafael Weingartner proposed openstack/nova-specs master: spec: nova Dynamic scheduler system https://review.opendev.org/c/openstack/nova-specs/+/872225
#openstack-nova - 2023-01-31
00:02:20 opendevreview Merged openstack/nova master: Make resource tracker use UUIDs instead of names https://review.opendev.org/c/openstack/nova/+/863919
07:54:26 sahid o/
07:58:03 sahid ouch, merge conflicts on rpc version :/
07:59:01 opendevreview Sahid Orentino Ferdjaoui proposed openstack/nova master: api: extend evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858384
07:59:01 opendevreview Sahid Orentino Ferdjaoui proposed openstack/nova master: compute: enhance compute evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858383
11:51:02 opendevreview Sahid Orentino Ferdjaoui proposed openstack/nova master: compute: enhance compute evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858383
11:51:03 opendevreview Sahid Orentino Ferdjaoui proposed openstack/nova master: api: extend evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858384
12:40:30 opendevreview Rajesh Tailor proposed openstack/nova master: Fix concurrent migration of vms with multiattach volume failure https://review.opendev.org/c/openstack/nova/+/872278
13:17:48 opendevreview Rajesh Tailor proposed openstack/nova master: Fix concurrent migration of vms with multiattach volume failure https://review.opendev.org/c/openstack/nova/+/872278
14:09:46 sahid bauzas, sean-k-mooney can I request reviews on the evacuate api feature, i'ts all green. I had to rebase and fix conflicts this morning du to a rpc change
14:10:02 sahid now i think we are good, i hope :-)
14:26:03 sean-k-mooney ya i was waiting for ci to report back before pining bauzas
14:26:26 sean-k-mooney im +2 on the first and +1.5 on the second pending bauzas's review
14:26:36 sean-k-mooney if they are happy then ill escalate to +2w
14:42:31 opendevreview Alexey Stupnikov proposed openstack/nova stable/ussuri: [stable-only] Disable nova-grenade-multinode voting https://review.opendev.org/c/openstack/nova/+/872281
14:43:17 opendevreview Alexey Stupnikov proposed openstack/nova stable/ussuri: reenable greendns in nova. https://review.opendev.org/c/openstack/nova/+/833437
14:53:56 bauzas sean-k-mooney: sahid: I'll look again when I have time today
14:58:05 sahid ack ++ thank you bauzas

Earlier   Later