| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-01-26 | |||
| 14:55:28 | sean-k-mooney | we can see what elodilles thinks | |
| 14:55:42 | sean-k-mooney | or other stable cores when the first review is up | |
| 14:56:34 | sahid | sean-k-mooney, bauzas ok so i fixed the tests on compute and conductor, and changed the s/NovaException/... then i fixed REST API + tests with a HTTPConflict | |
| 15:00:08 | sean-k-mooney | sahid++ | |
| 15:00:23 | sean-k-mooney | i am just joinging a call but ill look when im free | |
| 15:01:11 | sahid | sean-k-mooney: cool thanks you, but let me ping you when CI is green, no need that you lost your time if something fails that i have not noticed ;) | |
| 15:03:03 | sean-k-mooney | sure im in calls for the hour or two | |
| 15:20:35 | opendevreview | Alexey Stupnikov proposed openstack/nova master: Log some InstanceNotFound exceptions from libvirt https://review.opendev.org/c/openstack/nova/+/863665 | |
| 15:20:35 | opendevreview | Alexey Stupnikov proposed openstack/nova master: Add functional tests to reproduce bug #1994983 https://review.opendev.org/c/openstack/nova/+/863416 | |
| 15:38:44 | opendevreview | Alexey Stupnikov proposed openstack/nova stable/victoria: Add functional tests to reproduce bug #1960412 https://review.opendev.org/c/openstack/nova/+/845753 | |
| 15:38:55 | opendevreview | Alexey Stupnikov proposed openstack/nova stable/victoria: Clean up when queued live migration aborted https://review.opendev.org/c/openstack/nova/+/845754 | |
| 16:45:50 | gmann | bauzas: gibi: for tempest pin on wallaby, skiptest exception is due to incompatible version of stestr in constraints. I am checking it with what tempest version work on wallaby stestr constraint. | |
| 16:46:16 | bauzas | gmann: ack thanks | |
| 16:46:34 | gmann | bauzas: for placement rbac system scope, in zed cycle direction of RBAC we have decided to drop the system scope from services that is why every policy is made to project scoped https://github.com/openstack/governance/commit/1909d4f7a0dc2920fc04ab5bfac112a671547cee | |
| 16:46:52 | gibi | gmann: thanks | |
| 16:46:54 | bauzas | gmann: yup, my brain dumped this | |
| 16:57:32 | bauzas | sahid: you made a wrong assumption when writing the conductor unittest https://review.opendev.org/c/openstack/nova/+/858383/26/nova/tests/unit/conductor/test_conductor.py#4775 | |
| 16:57:50 | bauzas | the test should pass with the call be accepted without this parameter | |
| 17:00:30 | sahid | bauzas: hum let me check | |
| 17:03:09 | sahid | hum right we should not raise an exception here, I have done that too fast and for some reason when i have executed them locally i did not noticed.. | |
| 17:03:56 | sahid | bauzas: have you noticed something else that I can fix in that same time> | |
| 17:03:59 | sahid | ? | |
| 17:11:45 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: compute: enhance compute evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858383 | |
| 17:11:46 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: api: extend evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858384 | |
| 17:30:56 | dansmith | sean-k-mooney: btw I think the stable compute series is ready for serious review and/or merging with two exceptions 1. some nits from gibi I will do as a FUP, and 2. working on trivial unit tests for the top rename patch | |
| 17:31:09 | dansmith | but it passes with the experimental ironic job and everything | |
| 17:31:30 | dansmith | I guess maybe a test patch against ironic to run all their jobs might be prudent, let me get that in the pipe | |
| 17:32:01 | opendevreview | Ghanshyam proposed openstack/placement master: Modify the placement API policies defaults and scope_type https://review.opendev.org/c/openstack/placement/+/865618 | |
| 17:50:30 | opendevreview | Merged openstack/nova master: libvirt: Replace usage of compareCPU() with compareHypervisorCPU() https://review.opendev.org/c/openstack/nova/+/869950 | |
| 18:27:31 | sean-k-mooney | dansmith: i saw gibis review earlier ya and was wondering about the rest of the sereise | |
| 18:27:53 | sean-k-mooney | gibis comment was about using a fixutre right | |
| 18:29:29 | gibi | yeah I had testing nits | |
| 18:29:33 | gibi | nothing serious | |
| 18:30:01 | sean-k-mooney | dansmith: ok ill review the seriese tomorrow. im planning to deploy devstack tomorrow anyway so ill try the stable uuid series after i get that deployed and do a full pass on it | |
| 18:30:21 | dansmith | sean-k-mooney: cool, sounds like a plan thanks | |
| 18:30:57 | dansmith | the ironic test job on top is about half done, all green so far | |
| 18:31:36 | sean-k-mooney | dansmith: oh you have a dnm patch for that already cool | |
| 18:34:06 | dansmith | yeah I'll paste a link in the last patch when it's done if it looks good | |
| 18:37:17 | sean-k-mooney | dansmith: one thing about the series. i dont see a release note and i dont think you have docs for this do you? | |
| 18:37:34 | dansmith | sean-k-mooney: no and no | |
| 18:37:49 | dansmith | sean-k-mooney: I'll get going on that, but let's not hold up on that, if possible :) | |
| 18:38:02 | sean-k-mooney | ok so maybe another patch on the end for that or put it in the WIP patch | |
| 18:38:37 | sean-k-mooney | i think we can proceed before that i do trust you to write those just something that jumped out at me when i skimmed over the seriese | |
| 18:38:42 | dansmith | I'll put the reno in the current last patch and then docs after yeah | |
| 18:38:53 | sean-k-mooney | cool works for me | |
| 18:39:07 | dansmith | I need to push up the unit tests I have, just waiting for ironic to finish, so reno can go in there and then I'll do the docs after | |
| 18:40:58 | sean-k-mooney | i dont think any of this code really does anything until "Persist existing node uuids locally" so we can proably merge the first three tomrrow gibi is already +2 on those | |
| 18:41:33 | sean-k-mooney | i need to go push something else but i might start on the first 3 this evening | |
| 18:42:03 | dansmith | sure, that sounds good | |
| 18:42:05 | sean-k-mooney | but im only around for another 30 mins or so today then i need to go eat something | |
| 18:42:15 | dansmith | the persist one is also not super impactful, but it does do stuff | |
| 18:42:25 | dansmith | the resource tracker one is where the rubber meets the road for the first time | |
| 19:14:25 | opendevreview | Dan Smith proposed openstack/nova master: Detect host renames and abort startup https://review.opendev.org/c/openstack/nova/+/863920 | |
| 19:47:56 | opendevreview | Dan Smith proposed openstack/nova master: Fixup patch for stable-compute-uuid series https://review.opendev.org/c/openstack/nova/+/871848 | |
| 19:47:56 | opendevreview | Dan Smith proposed openstack/nova master: Detect host renames and abort startup https://review.opendev.org/c/openstack/nova/+/863920 | |
| 21:50:38 | sean-k-mooney[m] | dansmith: i did a first pass i have one or two question later in the series the first 3 should be in the gate | |
| 21:51:02 | dansmith | sean-k-mooney: ack, thanks, I saw the first three, I'll look at the others in a bit or tomorrow | |
| 22:30:21 | gmann | gibi: updated the placement RBAC change https://review.opendev.org/c/openstack/placement/+/865618 | |
| 22:48:45 | opendevreview | Merged openstack/nova master: Add virt/node module for stable uuids https://review.opendev.org/c/openstack/nova/+/863915 | |
| 22:48:53 | opendevreview | Merged openstack/nova master: Pass service ref to init_host(), if exists https://review.opendev.org/c/openstack/nova/+/863916 | |
| #openstack-nova - 2023-01-27 | |||
| 04:41:25 | opendevreview | Ghanshyam proposed openstack/nova stable/xena: DNM: testing tempest pin for stable/wallaby https://review.opendev.org/c/openstack/nova/+/871800 | |
| 04:51:43 | gmann | gibi: bauzas: updates on stable/wallaby gate: I have updated the devstack patch (depends-on) and it fixes the gate - https://review.opendev.org/c/openstack/nova/+/871798 | |
| 04:52:38 | gmann | gibi: bauzas: but it unhide another bug in devstack/grenade side due to which stable/xena grenade job start failing (with devstack stable/wallaby tempest pin) - https://bugs.launchpad.net/grenade/+bug/2003993 | |
| 04:53:18 | gmann | I have proposed the fix https://review.opendev.org/q/I5e938139b47f443a4c358415d0d4dcf6549cd085 and testing it in https://review.opendev.org/c/openstack/nova/+/871800 | |
| 05:58:02 | opendevreview | Ghanshyam proposed openstack/nova stable/xena: DNM: testing tempest pin for stable/wallaby https://review.opendev.org/c/openstack/nova/+/871800 | |
| 07:10:56 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: compute: enhance compute evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858383 | |
| 07:10:57 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: api: extend evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858384 | |
| 07:11:09 | sahid | ^ fixed merge conflict | |
| 07:11:10 | sahid | o/ | |
| 09:01:38 | bauzas | sahid: I have a busy morning but I'll try to take a look | |
| 09:01:57 | bauzas | gmann: ack, thanks for the heads-up | |
| 09:02:26 | priteau | Would the nova team consider disabling the failing grenade job on stable/wallaby temporarily to be able to merge the VMDK patch? | |
| 09:02:45 | bauzas | priteau: that's one of the options in the table | |
| 09:03:45 | bauzas | but before doing it, I need to correctly understand the problem | |
| 09:40:54 | opendevreview | Kashyap Chamarthy proposed openstack/nova stable/zed: libvirt: At start-up rework compareCPU() usage with a workaround https://review.opendev.org/c/openstack/nova/+/871968 | |
| 09:45:14 | gibi | gmann: those fixes looks good to me. thanks for proposing them | |
| 09:46:11 | kashyap | Hm, /me lost track of these upstream backports from last July still :-( -- https://review.opendev.org/q/topic:bug%252F1982853 | |
| 09:54:35 | opendevreview | Kashyap Chamarthy proposed openstack/nova stable/yoga: Add a workaround to skip hypervisor version check on LM https://review.opendev.org/c/openstack/nova/+/851202 | |
| 09:56:15 | opendevreview | Kashyap Chamarthy proposed openstack/nova stable/yoga: libvirt: At start-up rework compareCPU() usage with a workaround https://review.opendev.org/c/openstack/nova/+/871969 | |
| 09:57:57 | kashyap | elodilles: bauzas: This backport has been waiting for a while, can this be put through? - https://review.opendev.org/c/openstack/nova/+/851205 | |
| 10:02:42 | bauzas | kashyap: done | |
| 10:02:49 | kashyap | Thx! | |
| 10:09:01 | elodilles | it won't merge, as the yoga patch has not been merged yet: https://review.opendev.org/c/openstack/nova/+/851202 | |
| 10:09:12 | elodilles | bauzas: ^^^ | |
| 10:09:48 | bauzas | voila why I didn't +W before | |
| 10:09:53 | sahid | bauzas: no worries thank you for your time! | |
| 10:09:57 | bauzas | -ETOOMANYREVIEWSONFLY | |
| 10:11:50 | elodilles | (as I see you +W'd it once, but the patch wasn't cherry picked from the latest, merged PS) | |
| 10:12:56 | kashyap | elodilles: Oh, yeah; the Yoga one is still waiting. And are you saying the Xena cherry-pick is not correct? | |
| 10:13:15 | kashyap | Ah, you were talking about the _past_ ("wasn't"). Now it should be fine | |
| 10:21:13 | elodilles | kashyap: the cherry-pick needs to be done again from yoga patch to stable/xena | |
| 10:21:30 | kashyap | Duh, I thought I just did it ... /me face-palms and looks | |
| 10:21:44 | elodilles | (and the current xena patch won't merge as it is not cherry picked from the latest yoga PS) | |
| 10:22:11 | elodilles | kashyap: thx for fixing it | |
| 10:23:51 | kashyap | elodilles: Gonna cherry-pick from this Yoga commit to Xena: c07495d9d64dd0635d72fc7ff67d73a656a40d13 | |
| 10:24:55 | elodilles | kashyap: yepp, that is the hash of the latest PS | |
| 10:29:04 | kashyap | elodilles: Hmm, I also need to backport another one before that (https://review.opendev.org/c/openstack/nova/+/845045) | |
| 10:29:14 | kashyap | For Xena, i.e.; /me goes to do it | |
| 10:31:09 | opendevreview | Kashyap Chamarthy proposed openstack/nova stable/xena: Add a workaround to skip hypervisor version check on LM https://review.opendev.org/c/openstack/nova/+/851205 | |
| 10:31:10 | opendevreview | Kashyap Chamarthy proposed openstack/nova stable/xena: libvirt: Add a workaround to skip compareCPU() on destination https://review.opendev.org/c/openstack/nova/+/871975 | |