| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-01-26 | |||
| 13:53:40 | kashyap | gibi: You're right though. I tend to be a bit of a drama queen sometimes; please ignore me :) | |
| 13:54:14 | kashyap | gibi: Thank you both for the help! Now hope the API replacement patch goes through soon | |
| 13:54:21 | bauzas | sean-k-mooney: any docs you could point me out on the new direction for system roles ? | |
| 13:54:25 | kashyap | (Thanks, sahid for rechecking it while I was away :)) | |
| 13:56:08 | sean-k-mooney | bauzas: gmann might have the links more redilaly but i think we updated the goal with it too | |
| 13:56:22 | sean-k-mooney | bauzas: like this was a very very big thing that we have talked about before | |
| 13:56:48 | sean-k-mooney | https://github.com/openstack/governance/commit/1909d4f7a0dc2920fc04ab5bfac112a671547cee | |
| 13:56:54 | bauzas | " In yoga cycle, we redefined this goal with the changes mentioned above so that allowing system administrators to access system level resources APIs only and allow project users to access project-level resource APIs. These changes have been done for nova and neutron. " | |
| 13:57:06 | bauzas | sean-k-mooney: problem is, sometimes my brain splits | |
| 13:57:14 | sean-k-mooney | it was actully in zed | |
| 13:57:43 | bauzas | so it looks to me I probably heard about it, but then it wasn't ringing the bell in my brain when I saw today's change | |
| 13:57:45 | sean-k-mooney | well it depnes but that commit has the relevent info in it | |
| 14:01:53 | sahid | kashyap: sure :-) | |
| 14:10:33 | sean-k-mooney | kashyap: now all you have to do is backport it all the way to train and then cerry pick it downstream :P | |
| 14:11:20 | sean-k-mooney | so for 2 patchs that only 20 ish commits to create and review | |
| 14:11:56 | sean-k-mooney | with that said im not sure we need to backport the second patch | |
| 14:12:09 | sean-k-mooney | the frist we should but using the new api is less imporant | |
| 14:18:50 | opendevreview | Alexey Stupnikov proposed openstack/nova stable/zed: Remove deleted projects from flavor access list https://review.opendev.org/c/openstack/nova/+/870053 | |
| 14:26:13 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: compute: enhance compute evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858383 | |
| 14:26:14 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: api: extend evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858384 | |
| 14:27:30 | sahid | ^ fixed compute part, and owrking on the API one | |
| 14:29:59 | sahid | for the API part, is a BadRequest returned sounds good? in case that the rpc is not right and user is using new version? | |
| 14:30:17 | sahid | or do you have in mind an other http status? | |
| 14:30:42 | sahid | sean-k-mooney, bauzas ^ if you have a sec | |
| 14:31:23 | bauzas | sahid: we agreed yesterday on returning a HTTP409 Conflict | |
| 14:31:29 | sahid | ack | |
| 14:31:45 | bauzas | I think we have existing exceptions that do those | |
| 14:46:12 | sean-k-mooney | we do | |
| 14:46:35 | sean-k-mooney | we use 409 conflict anythime we dont meet the required min compute service version and in a few other cases | |
| 14:46:55 | sean-k-mooney | we used to have a mix of code but we normalised on 409 about 3 cyles ago | |
| 14:47:19 | sean-k-mooney | it used to be diffent between pmem cyborg, numa/sriov migrations ectra | |
| 14:49:02 | kashyap | sean-k-mooney: Heh, on the backports ... I need a bit of a breather for a few hours first from it | |
| 14:49:40 | sean-k-mooney | no worries but please propose them upstream before the downstream ones so we get the ci coverage | |
| 14:50:28 | kashyap | Ah, definitely | |
| 14:50:33 | kashyap | How far back we wanna go upstream? | |
| 14:51:31 | sean-k-mooney | so 16 is train if you want to go to 16 downstream then please do it upstream to trian too | |
| 14:51:42 | sean-k-mooney | if this is just for 17/wallaby you can stop there | |
| 14:51:45 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: api: extend evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858384 | |
| 14:52:52 | sean-k-mooney | this change shoudl be pretty safe to backprot and i dont really expect confligt | |
| 14:52:58 | sean-k-mooney | so hopefully its simple to do | |
| 14:52:58 | kashyap | Yep | |
| 14:54:11 | kashyap | I only wonder about the small logical change of the switch to using _get_cpu_model_mapping() | |
| 14:55:09 | sean-k-mooney | not using that in my view was an existing bug that shoudl have been fixed anyway | |
| 14:55:19 | sean-k-mooney | so i think its ok | |
| 14:55:28 | sean-k-mooney | we can see what elodilles thinks | |
| 14:55:42 | sean-k-mooney | or other stable cores when the first review is up | |
| 14:56:34 | sahid | sean-k-mooney, bauzas ok so i fixed the tests on compute and conductor, and changed the s/NovaException/... then i fixed REST API + tests with a HTTPConflict | |
| 15:00:08 | sean-k-mooney | sahid++ | |
| 15:00:23 | sean-k-mooney | i am just joinging a call but ill look when im free | |
| 15:01:11 | sahid | sean-k-mooney: cool thanks you, but let me ping you when CI is green, no need that you lost your time if something fails that i have not noticed ;) | |
| 15:03:03 | sean-k-mooney | sure im in calls for the hour or two | |
| 15:20:35 | opendevreview | Alexey Stupnikov proposed openstack/nova master: Log some InstanceNotFound exceptions from libvirt https://review.opendev.org/c/openstack/nova/+/863665 | |
| 15:20:35 | opendevreview | Alexey Stupnikov proposed openstack/nova master: Add functional tests to reproduce bug #1994983 https://review.opendev.org/c/openstack/nova/+/863416 | |
| 15:38:44 | opendevreview | Alexey Stupnikov proposed openstack/nova stable/victoria: Add functional tests to reproduce bug #1960412 https://review.opendev.org/c/openstack/nova/+/845753 | |
| 15:38:55 | opendevreview | Alexey Stupnikov proposed openstack/nova stable/victoria: Clean up when queued live migration aborted https://review.opendev.org/c/openstack/nova/+/845754 | |
| 16:45:50 | gmann | bauzas: gibi: for tempest pin on wallaby, skiptest exception is due to incompatible version of stestr in constraints. I am checking it with what tempest version work on wallaby stestr constraint. | |
| 16:46:16 | bauzas | gmann: ack thanks | |
| 16:46:34 | gmann | bauzas: for placement rbac system scope, in zed cycle direction of RBAC we have decided to drop the system scope from services that is why every policy is made to project scoped https://github.com/openstack/governance/commit/1909d4f7a0dc2920fc04ab5bfac112a671547cee | |
| 16:46:52 | gibi | gmann: thanks | |
| 16:46:54 | bauzas | gmann: yup, my brain dumped this | |
| 16:57:32 | bauzas | sahid: you made a wrong assumption when writing the conductor unittest https://review.opendev.org/c/openstack/nova/+/858383/26/nova/tests/unit/conductor/test_conductor.py#4775 | |
| 16:57:50 | bauzas | the test should pass with the call be accepted without this parameter | |
| 17:00:30 | sahid | bauzas: hum let me check | |
| 17:03:09 | sahid | hum right we should not raise an exception here, I have done that too fast and for some reason when i have executed them locally i did not noticed.. | |
| 17:03:56 | sahid | bauzas: have you noticed something else that I can fix in that same time> | |
| 17:03:59 | sahid | ? | |
| 17:11:45 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: compute: enhance compute evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858383 | |
| 17:11:46 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: api: extend evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858384 | |
| 17:30:56 | dansmith | sean-k-mooney: btw I think the stable compute series is ready for serious review and/or merging with two exceptions 1. some nits from gibi I will do as a FUP, and 2. working on trivial unit tests for the top rename patch | |
| 17:31:09 | dansmith | but it passes with the experimental ironic job and everything | |
| 17:31:30 | dansmith | I guess maybe a test patch against ironic to run all their jobs might be prudent, let me get that in the pipe | |
| 17:32:01 | opendevreview | Ghanshyam proposed openstack/placement master: Modify the placement API policies defaults and scope_type https://review.opendev.org/c/openstack/placement/+/865618 | |
| 17:50:30 | opendevreview | Merged openstack/nova master: libvirt: Replace usage of compareCPU() with compareHypervisorCPU() https://review.opendev.org/c/openstack/nova/+/869950 | |
| 18:27:31 | sean-k-mooney | dansmith: i saw gibis review earlier ya and was wondering about the rest of the sereise | |
| 18:27:53 | sean-k-mooney | gibis comment was about using a fixutre right | |
| 18:29:29 | gibi | yeah I had testing nits | |
| 18:29:33 | gibi | nothing serious | |
| 18:30:01 | sean-k-mooney | dansmith: ok ill review the seriese tomorrow. im planning to deploy devstack tomorrow anyway so ill try the stable uuid series after i get that deployed and do a full pass on it | |
| 18:30:21 | dansmith | sean-k-mooney: cool, sounds like a plan thanks | |
| 18:30:57 | dansmith | the ironic test job on top is about half done, all green so far | |
| 18:31:36 | sean-k-mooney | dansmith: oh you have a dnm patch for that already cool | |
| 18:34:06 | dansmith | yeah I'll paste a link in the last patch when it's done if it looks good | |
| 18:37:17 | sean-k-mooney | dansmith: one thing about the series. i dont see a release note and i dont think you have docs for this do you? | |
| 18:37:34 | dansmith | sean-k-mooney: no and no | |
| 18:37:49 | dansmith | sean-k-mooney: I'll get going on that, but let's not hold up on that, if possible :) | |
| 18:38:02 | sean-k-mooney | ok so maybe another patch on the end for that or put it in the WIP patch | |
| 18:38:37 | sean-k-mooney | i think we can proceed before that i do trust you to write those just something that jumped out at me when i skimmed over the seriese | |
| 18:38:42 | dansmith | I'll put the reno in the current last patch and then docs after yeah | |
| 18:38:53 | sean-k-mooney | cool works for me | |
| 18:39:07 | dansmith | I need to push up the unit tests I have, just waiting for ironic to finish, so reno can go in there and then I'll do the docs after | |
| 18:40:58 | sean-k-mooney | i dont think any of this code really does anything until "Persist existing node uuids locally" so we can proably merge the first three tomrrow gibi is already +2 on those | |
| 18:41:33 | sean-k-mooney | i need to go push something else but i might start on the first 3 this evening | |
| 18:42:03 | dansmith | sure, that sounds good | |
| 18:42:05 | sean-k-mooney | but im only around for another 30 mins or so today then i need to go eat something | |
| 18:42:15 | dansmith | the persist one is also not super impactful, but it does do stuff | |
| 18:42:25 | dansmith | the resource tracker one is where the rubber meets the road for the first time | |
| 19:14:25 | opendevreview | Dan Smith proposed openstack/nova master: Detect host renames and abort startup https://review.opendev.org/c/openstack/nova/+/863920 | |
| 19:47:56 | opendevreview | Dan Smith proposed openstack/nova master: Fixup patch for stable-compute-uuid series https://review.opendev.org/c/openstack/nova/+/871848 | |
| 19:47:56 | opendevreview | Dan Smith proposed openstack/nova master: Detect host renames and abort startup https://review.opendev.org/c/openstack/nova/+/863920 | |
| 21:50:38 | sean-k-mooney[m] | dansmith: i did a first pass i have one or two question later in the series the first 3 should be in the gate | |