Earlier  
Posted Nick Remark
#openstack-nova - 2023-01-24
15:05:16 bauzas dansmith: kk, I've seen it before
15:06:08 bauzas sean-k-mooney: dansmith: I have a bit thoughts on upgrades for sahid's new API microversion https://review.opendev.org/c/openstack/nova/+/858384
15:06:26 bauzas dansmith: +2d the master one
15:12:33 sean-k-mooney evacuate will work but not with the latest microverion until you are fully upgraded
15:13:05 sean-k-mooney so the only way around that is a new paramater in the api
15:13:18 bauzas sean-k-mooney: I know, see my comments
15:13:34 dansmith wow, that patch
15:13:35 bauzas sean-k-mooney: my only comment is to say we should at least explain it more
15:13:39 sean-k-mooney but that kind of defeats the idea of always pwowering off unless the new parmater default to powering off if not set
15:14:49 sean-k-mooney bauzas: is the concern mainly for nova-client
15:14:52 bauzas sean-k-mooney: sure, and again, I'm not *against* the new behaviour
15:15:16 sean-k-mooney openstack client need explcit opt in
15:15:24 sean-k-mooney baiscally im wondiering are you ok with just docs
15:15:26 bauzas sean-k-mooney: my only concern is that IMHO we don't really explain it correctly, at least we need an upgrade section
15:15:28 sean-k-mooney or do you want a design change
15:15:51 sean-k-mooney ok so you would like better docs and beeter release note to call that out
15:16:04 bauzas sean-k-mooney: at least I can accept the new behaviour, but I want to make sure that people know it
15:16:37 bauzas as you said, by default OSC will return an exception if you evacuate an instance on Antelope without upgrading all computes
15:16:46 sean-k-mooney no
15:16:50 sean-k-mooney by default it will evacuate
15:16:57 sean-k-mooney because it does not use the latest microverions
15:17:12 sean-k-mooney its only an issue for nova client which woudl use the latest microversion automatically
15:17:15 bauzas I thought that now OSC defaults to the latest
15:17:18 sean-k-mooney nope
15:17:20 sean-k-mooney 2.1
15:17:50 bauzas sean-k-mooney: this is an issue for any client asking the latest
15:17:53 sean-k-mooney if you want anything else you have to choose it by env var, cli flag or in your clouds.yaml
15:17:54 bauzas point.
15:18:13 bauzas hence me saying I'm OK (again, see my comments)
15:18:14 sean-k-mooney bauzas: right which we tell them not to do to avoid this exact type of issue
15:18:20 bauzas but we correctly need to document it
15:18:23 sean-k-mooney sure
15:18:30 sean-k-mooney tottaly fine wiht adding more docs
15:18:44 bauzas and having a better returned exception
15:19:20 bauzas like "heh, we don't accept your parameters for the new feature" doesn't really explain *why* the exception was returned
15:19:20 sean-k-mooney we can explictly say use a microversion before X (2.95?) to evacuate until upgades are complete
15:19:34 bauzas sean-k-mooney: true, that's what I'm asking
15:19:53 sean-k-mooney this is also an adming only api so the impact is much less
15:20:12 bauzas again, I've said it : it's admin-only hence why I'm OK
15:20:16 sean-k-mooney but we still need to tell them about it so ya
15:20:34 bauzas if this was an enduser API, then definitely -1 and asking for another design
15:20:48 bauzas because endusers don't know the environment was upgraded
15:21:00 sean-k-mooney im not sure i would agree
15:21:02 bauzas and actually, even API admins couldn't be knowing itr
15:21:21 sean-k-mooney but i would say if that how you felt giving that feedback now instead of in the spec review is unfortunet
15:21:22 bauzas sometimes, environment operators and API admins are different people
15:21:47 bauzas sean-k-mooney: again, I'm not against the desing
15:21:51 bauzas we discussed it at the PTG
15:22:00 bauzas and the spec was there, agreed
15:22:07 sean-k-mooney we did and the spec had 4 +2s too
15:22:19 bauzas I'm just explaining that this could have been different if the API was enduser, that's it
15:22:43 bauzas and see "could"
15:22:49 bauzas not saying I would disagree
15:22:55 sean-k-mooney we have microversion to allow this so we could but i dont think we should even for an end user api
15:23:18 sean-k-mooney anyway lets work on the release note and excetion message so
15:23:19 bauzas anyway, I think we both agree : it needs a better explanation
15:23:22 sean-k-mooney thanks for taking a look
15:23:27 sean-k-mooney yep
15:25:18 dansmith no, it's already +2
15:25:21 dansmith https://review.opendev.org/c/openstack/nova/+/871612
15:25:34 dansmith whoops
15:25:51 sean-k-mooney differnt patch :)
15:26:04 dansmith wrong window, sorry
15:26:23 sean-k-mooney shall i send that through the gate given what it is
15:26:33 dansmith I would
15:27:07 sean-k-mooney on its way
15:28:04 sean-k-mooney brb
15:53:55 bauzas as a reminder, nova meeting in 7 mins
16:00:18 opendevmeet The meeting name has been set to 'nova'
16:00:18 opendevmeet Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:00:18 opendevmeet Meeting started Tue Jan 24 16:00:18 2023 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:00:18 bauzas #startmeeting nova
16:00:24 bauzas hey everyone
16:01:02 dansmith o/
16:01:35 gibi o/
16:01:58 bauzas I guess we can start, as we can make it quick
16:02:14 bauzas #topic Bugs (stuck/critical)
16:02:15 elodilles o/
16:02:24 bauzas #info One Critical bug
16:02:38 bauzas same than last week
16:02:47 bauzas #link https://bugs.launchpad.net/nova/+bug/2002951
16:03:05 bauzas AFAICT, gibi's skip patch is now merged, so we can put it to High
16:03:16 bauzas fine ?
16:03:28 bauzas dansmith's series is on the fly
16:03:36 gibi fine
16:03:58 bauzas #link https://review.opendev.org/c/openstack/tempest/+/870974 skipping now the failing test
16:04:32 bauzas #link https://review.opendev.org/c/openstack/tempest/+/871000 proposal for fixing the test issue
16:04:45 bauzas dansmith: can I review it ? looks so
16:05:12 dansmith bauzas: you can review whatever you want :)
16:05:17 bauzas excellenbt
16:05:20 dansmith but yeah need gmann and kopecmartin to hit that I think
16:05:31 bauzas yup, can't +2 tempest
16:05:38 dansmith oh,
16:05:46 dansmith I need to unskip so he can see, I'll do that after this
16:06:00 bauzas ok, I can hold then
16:06:06 bauzas moving on
16:07:25 bauzas #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 26 new untriaged bugs (-1 since the last meeting)
16:07:36 bauzas thanks gibi for the triage, any bug you wanted to raise ?
16:07:56 gibi bauzas: I triaged ~5 bugs, nothing serious popped up
16:08:00 bauzas cool

Earlier   Later