| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-01-17 | |||
| 13:59:48 | bauzas | hah | |
| 13:59:50 | bauzas | that | |
| 14:00:07 | zigo | :) | |
| 14:00:15 | bauzas | yeah, in generall the overall workflow is prescribed, like in https://docs.openstack.org/project-team-guide/index.html | |
| 14:00:48 | bauzas | but beyond this, this is the project's team responsbility to decide how to implement what they want | |
| 14:00:55 | bauzas | like, the WSGI framework they prefer | |
| 14:01:09 | bauzas | or even the WSGI server they'd run with devstack | |
| 14:03:06 | bauzas | zigo: but honestly, the keystonemiddleware plugin isn't that hard to use | |
| 14:03:44 | zigo | I don't think that's the hardest part indeed. I just don't know where to start! :) | |
| 14:03:56 | bauzas | I suppose you just way the regular 'do the auth thing' by keystonmiddleware like in https://docs.openstack.org/keystonemiddleware/latest/middlewarearchitecture.html#authentication-component | |
| 14:04:31 | bauzas | zigo: we have a couple of openstack cookiecutters, if those still exist and are updated | |
| 14:04:57 | bauzas | but yeah, before incepting any code, I'd recommend to formalize your repo structure the openstack way | |
| 14:05:12 | zigo | - api | |
| 14:05:12 | zigo | - oslo.config | |
| 14:05:12 | zigo | - alembic migrations | |
| 14:05:12 | zigo | Yeah, I used it. But it doesn't do: | |
| 14:05:13 | zigo | ... | |
| 14:05:36 | bauzas | :) | |
| 14:05:48 | zigo | Yeah, I'm navigating through many projects to see how they are organized, and I'm trying to pick the best ones. | |
| 14:06:05 | bauzas | if you're asking for a 'Project inception 101 class', I'll make you sad, it doesn't exist :) | |
| 14:06:20 | bauzas | but you can surely bug us if you want guidance | |
| 14:06:35 | bauzas | I guess you know the project team guide ? | |
| 14:06:44 | zigo | Thanks ! :) | |
| 14:06:51 | bauzas | https://docs.openstack.org/project-team-guide/index.html | |
| 14:07:33 | zigo | Well, I know how the community works, gerrit, release management, branches, etc. | |
| 14:07:56 | zigo | I don't think I even need to read this ! :) | |
| 14:07:58 | bauzas | yup, but there is a small but interesting section in that guide https://docs.openstack.org/project-team-guide/technical-guides/index.html | |
| 14:08:04 | opendevreview | Balazs Gibizer proposed openstack/nova master: Use new get_rpc_client API from oslo.messaging https://review.opendev.org/c/openstack/nova/+/869900 | |
| 14:08:33 | bauzas | you also have the API guidelines https://specs.openstack.org/openstack/api-wg/#guidelines | |
| 14:09:30 | bauzas | and then you're left with reading each of the oslo libs docs | |
| 14:09:45 | bauzas | assuming you want RPC | |
| 14:15:42 | zigo | Thanks for all of the links. | |
| 14:15:56 | zigo | I don't think I'll need RPC, but maybe along the way... | |
| 14:29:21 | bauzas | artom: sean-k-mooney: https://review.opendev.org/c/openstack/nova/+/869812 got a weak -1 because I think we need to add an upgrade section in reno | |
| 14:29:57 | bauzas | tl;dr: starting with 2023.1, users could request instance.example.com hostname for their instance, and it would fail | |
| 14:30:10 | bauzas | because of dhcp_domain | |
| 14:31:42 | sean-k-mooney | it wont fail but it will be modifed as currently don | |
| 14:31:52 | sean-k-mooney | but sure lets add that | |
| 14:32:29 | artom | bauzas, sure, OK | |
| 14:33:05 | bauzas | sean-k-mooney: yeah agreed "fail" is too broad | |
| 14:33:19 | bauzas | sean-k-mooney: I mean their instances won't get the hostname they expect | |
| 14:33:31 | bauzas | from the user pov | |
| 14:36:03 | kashyap | gibi: I think for my unit test question in the scroll, it's probably because I accidentally removed a mock. /me tries... | |
| 14:36:26 | gibi | kashyap: sorry, I haven't got back to that yet | |
| 14:36:36 | kashyap | Don't worry, I don't count on instant responses :-) | |
| 14:36:50 | kashyap | I know you're context-switching on several tihngs | |
| 14:39:38 | sean-k-mooney | bauzas: yep exactly so im fine with calling that out in the release note | |
| 14:41:29 | bauzas | sean-k-mooney: i wonder if operators will scream about it | |
| 14:41:59 | bauzas | of course we can't provide different input validation based on a config option | |
| 14:42:16 | bauzas | but still, they'll have to change something probably | |
| 14:42:43 | sahid | stephenfin: o/ | |
| 14:43:03 | sahid | I can see that you are involving on osprofiler | |
| 14:43:12 | sahid | I have question for you :-) | |
| 14:43:47 | sean-k-mooney | bauzas: we are not changing the exting behavior | |
| 14:44:07 | sean-k-mooney | so if they were not doing this before we blocked FQDNs they will get the same behavior | |
| 14:44:25 | sahid | ut's related to the driver Jaeger, we would like to add an option | |
| 14:44:27 | sahid | https://github.com/openstack/osprofiler/blob/master/osprofiler/drivers/jaeger.py#L56 | |
| 14:44:40 | sean-k-mooney | bauzas: that is why we orginally did not mention it in the sepc | |
| 14:44:47 | sean-k-mooney | we did dicuss this option in hte past | |
| 14:45:02 | sahid | basically the point will be to have a prefix for the service_name, so we can make a difference between for example services that are running on different region | |
| 14:45:38 | sahid | does that mae sense for you if I add an option like service_prefix | |
| 14:45:59 | sean-k-mooney | bauzas: so i dont think operators will be upset that we are mainting the behvior they expect | |
| 14:46:43 | sahid | from my understanding that one will be only useful for jaeger, so I'm considering adding a section [jaager] | |
| 14:46:45 | bauzas | sean-k-mooneytechnically I agree | |
| 14:46:52 | bauzas | sean-k-mooney: technically I agree | |
| 14:46:57 | bauzas | we never supported FQDNs | |
| 14:47:20 | sean-k-mooney | and those that used dispaly name with an fqdn hand it modifed by the config option | |
| 14:47:29 | bauzas | so when passing a hostname, cloud-init was getting a FQDN based on the hostname + the default domain name from the option | |
| 14:47:35 | sean-k-mooney | so if they wanted it to not be modifed they already had to set the config option to the empty string | |
| 14:47:37 | bauzas | which was consistent | |
| 14:47:41 | artom | bauzas, fixed | |
| 14:47:45 | kashyap | Unrelated: Is the "nova-tox-functional-py38" job passing reliably for everyone? - it's still failing with "TypeError: getresponse() got an unexpected keyword argument 'buffering' | |
| 14:47:49 | kashyap | " | |
| 14:48:28 | sean-k-mooney | bauzas: when stephen added --hostname we also added the dhcp_doamin to the dns name in neutron | |
| 14:48:37 | sean-k-mooney | we did nto modify what we put in the metadtaa | |
| 14:48:48 | sean-k-mooney | and we are not going to with artoms code because he is not changing that | |
| 14:48:59 | sean-k-mooney | it was only the value in the neutron port that was changed | |
| 14:49:43 | bauzas | you know what ? I'll play the ostrich about any kind of FQDN questions | |
| 14:50:01 | bauzas | once artom uploads his change, I'll review it and I'm done | |
| 14:50:04 | sean-k-mooney | bauzas: dont feel like you cant ask them | |
| 14:50:24 | sean-k-mooney | im just saying we are intentiolly not changing the behvior to not break anyone | |
| 14:50:37 | sean-k-mooney | and because we dont want cofnig dirven api behavior | |
| 14:50:43 | bauzas | the ship has sailed | |
| 14:50:47 | sean-k-mooney | so without removign the option entirly which would impact everyone | |
| 14:50:55 | sean-k-mooney | we cant really do much else | |
| 14:51:07 | bauzas | but honestly, I liked the fact that we were saying domain names was something unrelated to nova :) | |
| 14:51:26 | sean-k-mooney | yep so did i | |
| 14:51:38 | sean-k-mooney | this is the compromsie so that we dont have to care about them again once done | |
| 14:52:11 | sean-k-mooney | like all good compromises it does not make anyone happy but we can all live with it | |
| 14:52:26 | bauzas | the ostrich theory applied to me. | |
| 14:53:20 | sean-k-mooney | i prefer magpie psychology. distract people with other shiny things that matter | |
| 14:55:34 | bauzas | I need to learn the three-card monte | |
| 14:55:58 | bauzas | 'follow your card' | |
| 14:56:56 | kashyap | bauzas: sean-k-mooney: There's a thing called "Belgian compromise", which loosely means: | |
| 14:56:57 | sean-k-mooney | bauzas: added https://blueprints.launchpad.net/nova/+spec/default-ephemeral-format-unformated to meeting adjenda | |
| 14:57:00 | kashyap | (quote) | |
| 14:57:01 | kashyap | complex issues are settled by conceding something to every party concerned, through an agreement that is usually so complicated that nobody completely understands all its implications. | |
| 14:57:05 | kashyap | (/quote) | |
| 14:57:28 | sean-k-mooney | hehe ya sounds like a typical eu threaty | |
| 14:58:17 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: libvirt: At start-up skip compareCPU() with a workaround https://review.opendev.org/c/openstack/nova/+/870794 | |