| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-01-12 | |||
| 18:13:01 | sean-k-mooney | melwitt: i can i was more or less holding off for you to get your questions answered without interferring | |
| 18:13:24 | sean-k-mooney | i know the responce form the previous iteration but i was away i was filling in context that was not in the spec | |
| 18:13:29 | melwitt | sean-k-mooney: I know. wanted to let you know I'm good so you can go ahead | |
| 18:13:40 | sean-k-mooney | so wanted ot let you get happy with the spec content without that bias | |
| 18:13:59 | melwitt | I appreciate that :) | |
| 18:14:53 | melwitt | I knew you were +2 already but I didn't feel comfortable +2ing until I understood it better | |
| 18:17:30 | sean-k-mooney | hehe well i was almost -2 intilaly when it was storign password. with the pivot to addign the ironic vnc proxy that removed most of my concners and this just became a ironic dirver change to add partiy for an exisitn api | |
| 18:18:04 | sean-k-mooney | the double proxying is a little odd but i see use in the ironic vnc proxy for standalone ironic too | |
| 18:19:39 | melwitt | I was also pretty much -2 with the initial proposal. so I saw that was removed which was good but didn't quite understand where the second proxy fit into the flow | |
| 18:20:49 | melwitt | *saw that password storage was removed | |
| 18:20:58 | sean-k-mooney | ya so the current vnc proxy really just wraps the vnc tcp session provided by qemu in a web socket | |
| 18:21:30 | sean-k-mooney | in the ironic case its more or less the same it will take the tcp session form the ironic proxy and convert it to a websocket for horizon | |
| 18:22:44 | melwitt | yeah, I think it makes sense now but at first I was confused | |
| 18:26:28 | opendevreview | Merged openstack/nova-specs master: new spec: support of vnc console for ironic https://review.opendev.org/c/openstack/nova-specs/+/863773 | |
| 18:40:57 | gmann | sean-k-mooney: gibi: I know you might have this in your list but just a review reminder for placement RBAC change https://review.opendev.org/c/openstack/placement/+/865618 | |
| 18:41:31 | sean-k-mooney | it is on it but i can try and give it more priority :) | |
| 18:41:59 | sean-k-mooney | is this a depency for the nova patch to merge or was that something else | |
| 18:50:50 | opendevreview | Merged openstack/nova master: Remove deleted projects from flavor access list https://review.opendev.org/c/openstack/nova/+/849131 | |
| 18:52:02 | gmann | sean-k-mooney: that was something else. there is no deps. | |
| 18:52:24 | sean-k-mooney | ok that was changing the jobs to enable srbac right | |
| 18:52:37 | gmann | sean-k-mooney: yes | |
| 18:52:37 | sean-k-mooney | we needed to do that for placment then nova | |
| 18:53:00 | sean-k-mooney | ok and this is adding the service role | |
| 18:53:07 | sean-k-mooney | and the other changes for the srbac role | |
| 18:53:13 | sean-k-mooney | ok ill take a look shortly | |
| 18:53:25 | gmann | sean-k-mooney: for placement it was a change in fixture which is needed for nova to enable new defaults, this one https://review.opendev.org/c/openstack/placement/+/869525 | |
| 18:53:29 | gmann | sean-k-mooney: thanks | |
| 18:56:14 | sean-k-mooney | ill look at that after so | |
| 19:24:59 | opendevreview | Tobias Urdin proposed openstack/nova master: Use get_rpc_client helper from oslo.messaging https://review.opendev.org/c/openstack/nova/+/869900 | |
| 19:25:37 | opendevreview | Tobias Urdin proposed openstack/nova master: Use new get_rpc_client API from oslo.messaging https://review.opendev.org/c/openstack/nova/+/869900 | |
| 21:20:59 | opendevreview | Dan Smith proposed openstack/nova master: Make resource tracker use UUIDs instead of names https://review.opendev.org/c/openstack/nova/+/863919 | |
| 21:20:59 | opendevreview | Dan Smith proposed openstack/nova master: Persist existing node uuids locally https://review.opendev.org/c/openstack/nova/+/863918 | |
| 21:21:00 | opendevreview | Dan Smith proposed openstack/nova master: WIP: Detect host renames and abort startup https://review.opendev.org/c/openstack/nova/+/863920 | |
| 23:08:05 | opendevreview | Merged openstack/nova master: Allow enabling PCI scheduling in Placement https://review.opendev.org/c/openstack/nova/+/854924 | |
| #openstack-nova - 2023-01-13 | |||
| 02:58:43 | opendevreview | Merged openstack/nova-specs master: Add maxphysaddr support for Libvirt https://review.opendev.org/c/openstack/nova-specs/+/861033 | |
| 06:24:46 | opendevreview | Merged openstack/placement master: Avoid rbac defaults conflict in functional tests https://review.opendev.org/c/openstack/placement/+/869525 | |
| 08:50:30 | gibi | fyi there is a low frequency but seems to be new functional test failure on the nova gate https://bugs.launchpad.net/nova/+bug/2002782 | |
| 08:57:14 | gibi | also I see multiple failures in varios nova jobs with keystone not having admin role defined | |
| 08:57:17 | gibi | Jan 13 03:22:30.365429 np0032719500 devstack@keystone.service[52368]: ERROR keystone.server.flask.application [None req-a8fb798b-0274-4f56-8a07-13659cf7afe4 None admin] Could not find role: admin.: keystone.exception.RoleNotFound: Could not find role: admin. | |
| 08:57:28 | gibi | example: https://zuul.opendev.org/t/openstack/build/8cec516802404c0a8af6a2724ac2b78b/log/controller/logs/screen-keystone.txt#1142 | |
| 08:58:16 | gibi | but there are successful job runs there since so I'm not sure if it wasn't just a temporary gate block resolved since | |
| 09:08:54 | kashyap | gibi: Morning, 'grenade-skip-level' and 'nova-ceph-multistore' jobs are failing for me (looks unrelated): https://review.opendev.org/c/openstack/nova/+/869950/ | |
| 09:09:34 | kashyap | One is: | |
| 09:09:36 | kashyap | --- | |
| 09:09:37 | kashyap | dpkg: error processing package pcp (--configure): installed pcp package post-installation script subprocess returned error exit status 1 | |
| 09:09:41 | kashyap | --- | |
| 09:15:59 | gibi | yepp that is unrelated | |
| 09:16:46 | gibi | https://bugs.launchpad.net/devstack/+bug/1943184 | |
| 09:17:10 | kashyap | Ah, thanks for the link | |
| 09:17:27 | kashyap | And the 'nova-ceph-multistore' job seems to crash/segfault Python due to this test: | |
| 09:17:40 | kashyap | tempest.api.compute.admin.test_volume.AttachSCSIVolumeTestJSON.test_attach_scsi_disk_with_config_drive[id-777e468f-17ca-4da4-b93d-b7dbf56c0494] | |
| 09:18:30 | kashyap | gibi: Wow, if 'pcp' has eeb unreliable for that long, I wonder if there's an alternative or if it's necessary at all | |
| 09:19:27 | frickler | it is only for stat collection, so mostly not necessary at all. I was also thinking we had disabled it by default, do you enable dstat in those job(s)? | |
| 09:21:06 | kashyap | frickler: I don't know off-hand if those jobs enable 'dstat', but I assume they do | |
| 10:29:04 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: api: extend evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858384 | |
| 10:29:04 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: compute: enhance compute evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858383 | |
| 12:01:54 | opendevreview | Alexey Stupnikov proposed openstack/nova master: Add functional tests to reproduce bug #1994983 https://review.opendev.org/c/openstack/nova/+/863416 | |
| 12:02:08 | opendevreview | Alexey Stupnikov proposed openstack/nova master: Log some InstanceNotFound exceptions from libvirt https://review.opendev.org/c/openstack/nova/+/863665 | |
| 12:06:02 | lajoskatona | Hi nova team, shall I ask about the CLI of migrate? The question is: "is there a chance to change the --wait option to wait for the migrate status instead of the server status in case of openstack server migrate .... --wait?" | |
| 12:08:16 | lajoskatona | The logic is here: https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/compute/v2/server.py#L3016-L3022 and as I saw it was (the login I mean) copy-pasted from novaclient, but for that I can't find why it was decided to wait for the server status instead of the status of the migration | |
| 12:08:54 | lajoskatona | I see reason for both, as even if the migration failed the server can remain on the same host and we are happy as it is active. | |
| 12:09:49 | opendevreview | Alexey Stupnikov proposed openstack/nova stable/zed: Remove deleted projects from flavor access list https://review.opendev.org/c/openstack/nova/+/870053 | |
| 12:10:11 | lajoskatona | But from the other perspective the user would be happy to see in this case that hey your migration failed (without extra check for the status of migration), as it can be misleading that the --wait returns happily but the migration failed | |
| 12:13:18 | sean-k-mooney | lajoskatona: if i recall there is not a good way to find the miration object | |
| 12:14:27 | sean-k-mooney | the migrate and live migrate calls dont retrun the migration uuid if i recall so you would need ot have a hureistic to find it client side | |
| 12:15:25 | sean-k-mooney | something like list the migrations or server events for the instnace and get the last one and hope that is the correct one for the currnt command | |
| 12:16:22 | sean-k-mooney | https://docs.openstack.org/api-ref/compute/?expanded=migrate-server-migrate-action-detail#migrate-server-migrate-action | |
| 12:17:20 | sean-k-mooney | if we had an api change to retrun the migration uuid form that and the live migrate endpoint then it would be easy for the client to wait on the migration status instead | |
| 12:25:28 | lajoskatona | sean-k-mooney: thanks, sounds interesting and true as I start to remember the migration things. I check and play with it to understand fully. | |
| 13:20:38 | pslestang | Hy all, is that because the relation chain is not totally reviewed that I can not merge this patchset https://review.opendev.org/c/openstack/nova/+/867832 or do I miss something else? | |
| 13:36:01 | sean-k-mooney | yes | |
| 13:36:15 | sean-k-mooney | the repoducer is not approved so the fix won be merged | |
| 13:36:39 | sean-k-mooney | when the parent merges the top patch will be merged by zuul | |
| 13:39:56 | pslestang | ok understood, will some of you get some times to approve it? | |
| 13:46:08 | sean-k-mooney | ya we will review it as normal i might have time to take a look later today | |
| 13:46:44 | sean-k-mooney | this code is incldued more or less in the follow up patch so i have glance over it already | |
| 13:47:08 | sean-k-mooney | so likely there will be no feedback but im doing some email stuff right now so dont want to swtich context | |
| 13:47:33 | kashyap | Man, I'm in Gate-hell, these jobs are failing w/ unrelated errors :( - nova-live-migration, nova-multi-cell, nova-ovs-hybrid-plug, nova-grenade-multinode | |
| 13:48:04 | kashyap | I wonder how many of these jobs really deserve to be "voting" | |
| 13:51:24 | sean-k-mooney | all of them | |
| 13:51:49 | sean-k-mooney | they are pretty stabel if there is currently an issue its new and we shoudl investigate that | |
| 13:56:20 | kashyap | Well, that is the "ideal" scenario, assuming there's "unlimited bandwidth" from contributors. I can't possibly keep investigating CI issues all day and week long | |
| 13:56:51 | sean-k-mooney | https://zuul.openstack.org/builds?job_name=nova-live-migration&job_name=nova-ovs-hybrid-plug&job_name=nova-multi-cell&job_name=nova-grenade-multinode&project=openstack%2Fnova&branch=master&skip=0 | |
| 13:56:52 | kashyap | I don't know if all of them are deserving, we have to re-evaulate some jobs to see if they're still worth their salt. | |
| 13:57:16 | sean-k-mooney | i do look at those jobs and the ones that you listed are valuable | |
| 13:57:21 | kashyap | What's annoing is all of these jobs passed in the previous run :-( | |
| 13:59:37 | sean-k-mooney | the grenade job failed on test_volume_backed_live_migration | |
| 13:59:46 | bauzas | kashyap: lemme look then, change id ? | |
| 14:00:33 | sean-k-mooney | presumable https://review.opendev.org/c/openstack/nova/+/869587 | |
| 14:01:02 | kashyap | bauzas: Thanks for the offer, I have already opened all the failing 4 jobs and seeing what's up one-by-one | |
| 14:01:03 | sean-k-mooney | or https://review.opendev.org/c/openstack/nova/+/869950 | |
| 14:01:24 | bauzas | sean-k-mooney: ack, will look | |
| 14:01:33 | bauzas | TGIF | |
| 14:01:43 | kashyap | Previously 'nova-ceph-multistore' was failing due to 'pcp' package unreliability | |
| 14:01:55 | kashyap | bauzas: That's the patch: https://review.opendev.org/c/openstack/nova/+/869950/ | |
| 14:01:56 | sean-k-mooney | ya i saw that in one of the other failaure | |
| 14:02:00 | sean-k-mooney | that might be a mirror issue | |
| 14:02:12 | sean-k-mooney | so not related to the job but the cloud it ran on | |
| 14:02:32 | sean-k-mooney | i know that there was issues with one of the ci providers running out os log storage i think during the week | |
| 14:02:42 | kashyap | Hmm, it's a pity that we don't have a way to selectively run the failing jobs (while retaining the older one) - if nothing has changed in a patch | |