| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-01-10 | |||
| 18:56:32 | opendevreview | Dan Smith proposed openstack/nova master: WIP: Make resource tracker use UUIDs instead of names https://review.opendev.org/c/openstack/nova/+/863919 | |
| 19:00:10 | sean-k-mooney | Kirill_: i think so but im to tired to review a spec fully this evning. skiming its in teh correct directory and since almost all the implemation is on the ironic sid eand ther eis no api changes this is likely sufficent | |
| 19:01:26 | Kirill_ | got it. thanks for your efforts! | |
| 19:03:17 | sean-k-mooney | im not sure if melwitt is around today but she might be able to provide more feedback today. otherwise ill take another look tomorow. you still need a second core to review and approvhe it in either case. | |
| 19:07:52 | opendevreview | Ghanshyam proposed openstack/osc-placement stable/zed: [stable-only] Use stable branch version of placement in functional tests https://review.opendev.org/c/openstack/osc-placement/+/869753 | |
| 19:08:40 | opendevreview | Ghanshyam proposed openstack/osc-placement stable/yoga: [stable-only] Use stable branch version of placement in functional tests https://review.opendev.org/c/openstack/osc-placement/+/869754 | |
| 19:23:49 | opendevreview | Ghanshyam proposed openstack/osc-placement master: Use pypi released version of placement in functional tests https://review.opendev.org/c/openstack/osc-placement/+/869755 | |
| 19:24:51 | opendevreview | Ghanshyam proposed openstack/osc-placement stable/zed: Use pypi released version of placement in functional tests https://review.opendev.org/c/openstack/osc-placement/+/869753 | |
| 19:25:42 | opendevreview | Dan Smith proposed openstack/nova master: Add virt/node module for stable uuids https://review.opendev.org/c/openstack/nova/+/863915 | |
| 19:25:43 | opendevreview | Dan Smith proposed openstack/nova master: Add get_available_node_uuids() to virt driver https://review.opendev.org/c/openstack/nova/+/863917 | |
| 19:25:43 | opendevreview | Dan Smith proposed openstack/nova master: Pass service ref to init_host(), if exists https://review.opendev.org/c/openstack/nova/+/863916 | |
| 19:25:44 | opendevreview | Dan Smith proposed openstack/nova master: WIP: Make resource tracker use UUIDs instead of names https://review.opendev.org/c/openstack/nova/+/863919 | |
| 19:25:44 | opendevreview | Dan Smith proposed openstack/nova master: Persist existing node uuids locally https://review.opendev.org/c/openstack/nova/+/863918 | |
| 19:25:45 | opendevreview | Dan Smith proposed openstack/nova master: WIP: Detect host renames and abort startup https://review.opendev.org/c/openstack/nova/+/863920 | |
| 19:28:23 | opendevreview | Ghanshyam proposed openstack/osc-placement stable/yoga: Use pypi released version of placement in functional tests https://review.opendev.org/c/openstack/osc-placement/+/869754 | |
| 19:58:51 | opendevreview | Ghanshyam proposed openstack/osc-placement master: Use pypi released version of placement in functional tests https://review.opendev.org/c/openstack/osc-placement/+/869755 | |
| 20:23:15 | opendevreview | Ghanshyam proposed openstack/osc-placement stable/zed: Use pypi released version of placement in functional tests https://review.opendev.org/c/openstack/osc-placement/+/869753 | |
| 20:24:17 | opendevreview | Ghanshyam proposed openstack/osc-placement stable/yoga: Use pypi released version of placement in functional tests https://review.opendev.org/c/openstack/osc-placement/+/869754 | |
| 20:40:52 | opendevreview | Merged openstack/python-novaclient stable/zed: [stable-only] Pin tox <4 https://review.opendev.org/c/openstack/python-novaclient/+/869527 | |
| 20:56:04 | opendevreview | Ghanshyam proposed openstack/osc-placement master: Use pypi released version of placement in functional tests https://review.opendev.org/c/openstack/osc-placement/+/869755 | |
| 21:17:31 | opendevreview | Ghanshyam proposed openstack/osc-placement stable/xena: Use pypi released version of placement in functional tests https://review.opendev.org/c/openstack/osc-placement/+/869768 | |
| 21:17:49 | gmann | sean-k-mooney: bauzas: gibi : these are the osc-placement gate fixes https://review.opendev.org/q/I4e3e5732411639054baaa9211a29e2e2c8210ac0 | |
| 21:39:07 | opendevreview | Merged openstack/nova stable/victoria: Adapt websocketproxy tests for SimpleHTTPServer fix https://review.opendev.org/c/openstack/nova/+/866195 | |
| 22:14:05 | dansmith | gmann: still around? | |
| #openstack-nova - 2023-01-11 | |||
| 00:43:36 | opendevreview | Merged openstack/python-novaclient stable/yoga: [stable-only] Pin tox <4 https://review.opendev.org/c/openstack/python-novaclient/+/869597 | |
| 00:54:16 | gmann | dansmith: hi | |
| 02:47:12 | opendevreview | Merged openstack/python-novaclient stable/xena: [stable-only] Pin tox <4 https://review.opendev.org/c/openstack/python-novaclient/+/869598 | |
| 05:37:52 | opendevreview | Ghanshyam proposed openstack/nova master: Enable new defaults and scope checks by default https://review.opendev.org/c/openstack/nova/+/866218 | |
| 08:30:28 | opendevreview | Kirill proposed openstack/nova-specs master: new spec: support of vnc console for ironic https://review.opendev.org/c/openstack/nova-specs/+/863773 | |
| 09:10:20 | gibi | stephenfin: if you have time I fixed your comments in https://review.opendev.org/c/openstack/nova/+/854924 | |
| 09:17:54 | gibi | and also there are some other patches in the PCI series where I lost your +2 | |
| 09:30:37 | kashyap | Morning. Can anyone remind me again if this targetted 'recheck' works: "recheck tempest-integrated-compute" | |
| 09:42:46 | gibi | kashyap: npe | |
| 09:42:48 | gibi | nope | |
| 09:43:01 | gibi | there is now way to selectively recheck | |
| 09:43:06 | gibi | it is intentional | |
| 09:50:43 | kgube | gibi: Hi! Could you have another look at this: https://review.opendev.org/c/openstack/nova-specs/+/855490 | |
| 09:50:51 | kashyap | gibi: Aaah, I see. | |
| 09:51:28 | gibi | kgube: I will try | |
| 09:51:47 | kgube | thanks! | |
| 10:01:35 | gibi | kashyap: left feedback in https://review.opendev.org/c/openstack/nova/+/869587 | |
| 10:02:19 | gibi | kashyap, sean-k-mooney: I vaguely remember that you discussed removing the this check ^^ before. What was the outcome of that? | |
| 10:02:48 | auniyal | Hi gibi | |
| 10:02:55 | auniyal | can you please review these also | |
| 10:02:55 | gibi | auniyal: hi! | |
| 10:02:57 | auniyal | https://review.opendev.org/c/openstack/nova/+/864006 | |
| 10:02:59 | kashyap | gibi: Thanks! Will check in abit | |
| 10:03:04 | auniyal | https://review.opendev.org/c/openstack/nova/+/864006 | |
| 10:03:13 | auniyal | https://review.opendev.org/c/openinfra/openstack-map/+/866568 | |
| 10:09:25 | gibi | bauzas: do you want to check https://review.opendev.org/c/openstack/nova-specs/+/855490 (Use extend volume completion action) or I can +A it? | |
| 10:09:48 | gibi | you have review prio +1 on it | |
| 10:09:51 | gibi | hence my question | |
| 10:11:26 | opendevreview | Lukas Piwowarski proposed openstack/nova stable/zed: DNM: Test change in run-tempest role https://review.opendev.org/c/openstack/nova/+/869804 | |
| 10:14:00 | bauzas | gibi: sorry, discussing with Uggla but sure I can do it | |
| 10:15:59 | gibi | bauzas: it is more like do you want to? we have 2 +2s on it | |
| 10:16:36 | kashyap | gibi: Responded. Thanks for the review. I hope I have answered at least 60% of your questions :) | |
| 10:40:43 | pslestang | Hello all, dansmith will you have some time to review https://review.opendev.org/c/openstack/nova/+/867832, I pushed an other patchset after your +2 review | |
| 10:42:11 | gibi | kashyap: responeded | |
| 10:43:34 | opendevreview | Lukas Piwowarski proposed openstack/nova stable/zed: DNM: Test change in run-tempest role https://review.opendev.org/c/openstack/nova/+/869804 | |
| 10:52:34 | kashyap | gibi: Thank you. On the 2nd point, I'm wondering if there's a fairly uncomplicated way to return the flags | |
| 10:53:09 | kashyap | (And no your first point, will drop that dead variable) | |
| 11:05:58 | gibi | kashyap: my point is that the original function did not return that information, so that information was only use locally there, but the usage of it is removed by you | |
| 11:06:26 | gibi | so I think the generation of that information can be removed too | |
| 11:07:23 | kashyap | gibi: Okay, let me play a little more with it. I only want to make sure people can still specify extra flags and we propagate that | |
| 11:08:03 | kashyap | gibi: Ah, we still consider the extra flags in _get_guest_cpu_model_config() method | |
| 11:08:21 | kashyap | So we should be good | |
| 11:08:30 | gibi | I believe this was not the place where we actually handled the extra flags | |
| 11:09:04 | gibi | yepp _get_guest_cpu_model_config seem to be the real place | |
| 11:09:50 | kashyap | Yep, indeed we handle it _get_guest_cpu_model_config(). I myself added that ... seeing the note <emabarassed emoji> | |
| 11:11:00 | kashyap | gibi: Thanks! Respinning. | |
| 11:21:52 | opendevreview | Aaron S proposed openstack/nova master: Add further workaround features for qemu_monitor_announce_self https://review.opendev.org/c/openstack/nova/+/867324 | |
| 11:22:59 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: libvirt: Remove compareCPU() check in _check_cpu_compatibility() https://review.opendev.org/c/openstack/nova/+/869587 | |
| 11:24:42 | kashyap | gibi: (While you still have the context. Hope I got that right) --^ | |
| 11:26:35 | opendevreview | Aaron S proposed openstack/nova master: Add further workaround features for qemu_monitor_announce_self https://review.opendev.org/c/openstack/nova/+/867324 | |
| 11:30:51 | opendevreview | Merged openstack/nova stable/ussuri: Adds a repoducer for post live migration fail https://review.opendev.org/c/openstack/nova/+/864006 | |
| 11:31:35 | opendevreview | Merged openstack/nova stable/ussuri: Adapt websocketproxy tests for SimpleHTTPServer fix https://review.opendev.org/c/openstack/nova/+/866196 | |
| 11:32:17 | opendevreview | Artom Lifshitz proposed openstack/nova master: [Broken WIP] 2.94: FQDN in hostname https://review.opendev.org/c/openstack/nova/+/869812 | |
| 11:32:29 | sean-k-mooney | gibi: basically i thing its wrong for nova not to enfore the cpu compatiablity itself ideally at teh schduleing point and failures at the live migrate call to livert are too late. however apprently the libvirt folks are advising that we delegate this check to libvirt alone. so if we remove this i want us to add something to our backloag to go replace it in the future | |
| 11:33:19 | sean-k-mooney | currently we attempt to do that in pre-livemigrate using the old compareCPU api | |
| 11:34:28 | opendevreview | Balazs Gibizer proposed openstack/nova stable/yoga: Reproduce bug 1981813 in func env https://review.opendev.org/c/openstack/nova/+/859312 | |
| 11:34:29 | opendevreview | Balazs Gibizer proposed openstack/nova stable/yoga: Gracefully ERROR in _init_instance if vnic_type changed https://review.opendev.org/c/openstack/nova/+/859313 | |
| 11:35:13 | gibi | sean-k-mooney: the current patch is removing the compatibility check at the compute startup, it does not change the check at live migration | |
| 11:36:05 | sean-k-mooney | i have not looked at the current patch just the ones that were created before | |
| 11:36:13 | sean-k-mooney | why would we want to remove it at compute start up | |
| 11:36:17 | sean-k-mooney | looking at it now | |
| 11:38:16 | sean-k-mooney | as an unconditional change i think this is wrong | |
| 11:41:32 | gibi | sean-k-mooney: I think the renewed interest for this is coming from https://review.opendev.org/c/openstack/nova/+/869536/ | |
| 11:41:36 | kashyap | Please see the commit message. We have already talked about it in detail before, and the rationale explains it there | |
| 11:41:47 | sean-k-mooney | i objected to the live migraiton workaround as i think that was also wrong fundementaly at a nova level so if we want to disabel this is think we shoudl have it behaind a workaround | |
| 11:42:07 | sean-k-mooney | kashyap: yep but you never convicend me it was right before | |
| 11:42:31 | sean-k-mooney | kashyap: i just agree to not block it because it was guarded behind a workaround and we still did the check by default | |
| 11:43:10 | sean-k-mooney | kashyap: really what i would liek to see is for you or someone else to complete swaping to the new api | |
| 11:43:47 | opendevreview | Balazs Gibizer proposed openstack/nova stable/xena: Reproduce bug 1981813 in func env https://review.opendev.org/c/openstack/nova/+/859314 | |
| 11:43:48 | opendevreview | Balazs Gibizer proposed openstack/nova stable/xena: Gracefully ERROR in _init_instance if vnic_type changed https://review.opendev.org/c/openstack/nova/+/859315 | |
| 11:44:06 | sean-k-mooney | gibi: yep proably however this was fixed in libvirt upstream with the intoduction fo new cpu models | |
| 11:44:19 | gibi | we tried the new API work that but is complicated enough that is stalls out | |
| 11:44:20 | sean-k-mooney | and i think we just have not backported that fix downsstream | |
| 11:48:18 | opendevreview | Manuel Bentele proposed openstack/nova master: libvirt: Add configuration options to set SPICE compression settings https://review.opendev.org/c/openstack/nova/+/828675 | |
| 12:00:50 | gibi | so moving this under a WA flag; would that mean that people with certain hw should always set the WA flag, i.e. in case of mpx https://review.opendev.org/c/openstack/nova/+/869536/ | |
| 12:01:33 | gibi | and we can only remove the WA flag after we resurrect https://review.opendev.org/c/openstack/nova/+/762330 and finish it? | |