| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-01-10 | |||
| 16:03:51 | bauzas | Uggla: I'll take the baton for this week, but if you want, we can both look at bugs | |
| 16:04:07 | bauzas | #info bug baton is being passed to bauzas | |
| 16:04:29 | bauzas | any particular urgent bug to discuss ? | |
| 16:04:40 | bauzas | I guess we'll discuss the tox saga in the next chapter | |
| 16:04:59 | bauzas | if no, let's move on and go to the gate topic | |
| 16:05:06 | bauzas | #topic Gate status | |
| 16:05:12 | bauzas | #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs | |
| 16:05:16 | bauzas | #link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&pipeline=periodic-weekly Nova&Placement periodic jobs status | |
| 16:05:21 | bauzas | #link https://review.opendev.org/c/openstack/tempest/+/866049 proposal to add more delay for centos9s-fips job | |
| 16:05:26 | bauzas | #info Please look at the gate failures and file a bug report with the gate-failure tag. | |
| 16:05:30 | gibi | placement and nova gate is unblocked as far as I know. we merged the two tox4 patches | |
| 16:05:31 | bauzas | #info STOP DOING BLIND RECHECKS aka. 'recheck' https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures | |
| 16:05:51 | bauzas | I was about to tell it once I was done with the weekly items | |
| 16:05:52 | bauzas | so, | |
| 16:06:12 | gibi | I see nova patches progressing in the gate queue | |
| 16:06:17 | gibi | so I think we are OK | |
| 16:06:33 | gibi | I haven't chacked osc-placement and python-novaclient status | |
| 16:06:40 | gibi | os-vif should be unblocked too | |
| 16:06:46 | gmann | their master gate is good, I checked | |
| 16:06:54 | gmann | but for stable branch gate, python-novaclient patches need to merge #link https://review.opendev.org/q/I442568a5f5900e593feb2b5527109e0aa79e5aa7+status:open | |
| 16:07:12 | dansmith | nice | |
| 16:07:15 | gmann | and osc-placement is failing <= stable/yoga https://review.opendev.org/c/openstack/osc-placement/+/869451 | |
| 16:07:17 | bauzas | #info we had a funky week due to tox4 but now gate is better https://lists.openstack.org/pipermail/openstack-discuss/2023-January/031709.html | |
| 16:07:41 | gmann | it is failing on placement functionla job where we use master placement but stable branch constraints so mismatch | |
| 16:07:42 | bauzas | gmann: cool, I'll look at the novaclient patch | |
| 16:08:11 | gmann | I cannot remember why we do not use master constraints in that placement functional job? | |
| 16:08:12 | bauzas | oh, I did it already | |
| 16:08:13 | gibi | the there are follow up request for nova and placement too: i) remove the install_command usage ii) check if pdf doc build works or not | |
| 16:08:33 | gibi | gmann: we should I believe | |
| 16:08:43 | gmann | this one https://github.com/openstack/osc-placement/blob/master/tox.ini#L30 | |
| 16:09:26 | sean-k-mooney | we want it t o run against master i belvie | |
| 16:09:28 | gibi | gmann: hm, do we have placement in the upper-constraints? | |
| 16:09:43 | sean-k-mooney | perhaps although we shoudl not | |
| 16:09:54 | sean-k-mooney | only lib projects should eb in uc | |
| 16:09:57 | gmann | gibi: no because we use it from master source | |
| 16:10:12 | bauzas | sean-k-mooney: this is for testing placement itself | |
| 16:10:22 | gibi | this is testing osc-placement I believe | |
| 16:10:22 | bauzas | so we need the latest | |
| 16:10:32 | bauzas | correct | |
| 16:10:36 | gmann | yeah testing osc-placement with master placement | |
| 16:10:42 | sean-k-mooney | its the fucntional test for placement openstackclient plugin | |
| 16:10:45 | gibi | and constarints are inherited from https://github.com/openstack/osc-placement/blob/fdf10423bf29b7cfd5e88d9d06e1313ee881ab80/tox.ini#L17 | |
| 16:10:48 | bauzas | we're discussing of testing osc-placement | |
| 16:10:59 | bauzas | using placement master branch | |
| 16:11:07 | sean-k-mooney | yes and how the functional job forces the master branch of placment | |
| 16:11:14 | bauzas | yup | |
| 16:11:18 | gmann | gibi: it use stable/yoga for yoga testing #link https://github.com/openstack/osc-placement/blob/stable/yoga/tox.ini#L18 | |
| 16:11:18 | sean-k-mooney | i think this was because fo the placment fixture | |
| 16:11:23 | gmann | for master it is all good | |
| 16:11:28 | gmann | master gate | |
| 16:11:33 | bauzas | agreed with gmann | |
| 16:11:34 | sean-k-mooney | https://github.com/openstack/osc-placement/commit/da8cd4d68b06399c607776db2a704b4578146996 | |
| 16:11:45 | gibi | I don't see the issue sorry | |
| 16:11:54 | gmann | for stable/zed somehow constraints matches so we do not see failure | |
| 16:11:55 | sean-k-mooney | so the tox.ini is correct | |
| 16:11:55 | bauzas | if I have a osc client patch, I don't wanna hold my check on a placement release | |
| 16:12:25 | gmann | sean-k-mooney: stable/yoga constraints will not work with latest placement | |
| 16:12:39 | bauzas | anyway, tox4 upgrade was fun | |
| 16:12:45 | gmann | that is why it is failing on os-traits version mismatch | |
| 16:13:02 | sean-k-mooney | for stable branchs we likely need to pin yes | |
| 16:13:26 | gmann | yeah, either pin placement or use master constraints for this latest placement testing | |
| 16:13:27 | sean-k-mooney | bauzas: likely not because they handel constratits differnrlty | |
| 16:13:42 | gmann | anyways we can discuss it after meeting as it seems need more discussions | |
| 16:13:43 | gibi | gmann: so on stable/yoga this is an issue https://github.com/openstack/osc-placement/blob/stable/yoga/tox.ini#L31 | |
| 16:13:57 | gibi | as it install master placement on stable yoga | |
| 16:14:09 | gmann | gibi: yes. | |
| 16:14:11 | sean-k-mooney | ya so we just need to pin the branch in that line which is posible | |
| 16:14:14 | gibi | OK I got it | |
| 16:14:21 | elodilles | as i remember constraints from master also caused issues on stable branches (in placement) | |
| 16:14:30 | bauzas | sean-k-mooney: yeah, my point is that if the tox developers don't verify the behaviours of tox.ini and rather say they just verify the toml ones, then I'm a bit afraid | |
| 16:14:47 | sean-k-mooney | bauzas: its not related to that | |
| 16:15:14 | sean-k-mooney | bauzas: openstack is quite differnt form ontehr python project in how we use setuptools/pbr and the idea of a constratis file | |
| 16:15:23 | gmann | all other stable branches gate are good. I tested them after pin | |
| 16:15:32 | gibi | bauzas: tox4 was a rewrite, and they are not intending to keep all the tox3 behavior (I learned yesterday) | |
| 16:15:43 | bauzas | sean-k-mooney: sure I'm not saying we should create a pyproject.toml filze | |
| 16:15:50 | gibi | gmann: thanks! | |
| 16:16:06 | bauzas | sean-k-mooney: but I was wondering why nobody was finding the problem until we told them | |
| 16:16:08 | sean-k-mooney | bauzas: well that has been discussed and we might want to eventually but we should lop back to one topic | |
| 16:16:25 | sean-k-mooney | bauzas: because constrait files is baicaly an openstack thing | |
| 16:16:44 | bauzas | sean-k-mooney: we didn't had only problems with constraints | |
| 16:16:45 | clarkb | sean-k-mooney: openstack is the primary user in the wild probably but it is a normal pip functionality | |
| 16:16:53 | sean-k-mooney | we are the comunity that drove that in pip | |
| 16:17:10 | sean-k-mooney | but yes its is a pip capablity | |
| 16:17:11 | bauzas | gibi: ack, good to know | |
| 16:17:14 | clarkb | bauzas: fwiw I'm helping to move zuul and opendev projects to nox | |
| 16:17:33 | sean-k-mooney | isnit that a pti issue | |
| 16:17:41 | sean-k-mooney | dont we specify tox explictly | |
| 16:17:43 | clarkb | (because there are lots of little tox changes and when I file issues upstream the resposne is often "why would you do that?" and the answer is well because v3 supported it so ya...) | |
| 16:17:51 | clarkb | sean-k-mooney: yes for openstack. I personally think openstack should change too | |
| 16:17:56 | clarkb | but it is work | |
| 16:18:03 | sean-k-mooney | perhaps a good ptg topic | |
| 16:18:10 | gmann | +1 | |
| 16:18:12 | dansmith | I'm not super keen on the nox thing | |
| 16:18:13 | sean-k-mooney | how to evovle pti | |
| 16:18:14 | bauzas | not only for our project | |
| 16:18:21 | dansmith | so I'd like to have a real discussion about it | |
| 16:18:33 | bauzas | should be a cross-project discussion honestly | |
| 16:18:34 | dansmith | (I'm also not super keen on tox destroying the world for fun and profit) | |
| 16:18:37 | sean-k-mooney | right i was thinking comuity/cross project topic | |
| 16:18:45 | bauzas | dansmith: me too | |