| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-12-13 | |||
| 16:48:26 | bauzas | ok | |
| 16:48:27 | clarkb | but nova's actually looks really clean and if that test change passes then you are probably fine | |
| 17:04:14 | gmann | elodilles: gibi: clarkb: bauzas: on tox. we have pinned it in devstack side for tox based job also https://github.com/openstack/devstack/blob/master/playbooks/tox/pre.yaml#L14 | |
| 17:04:56 | gmann | so ensure-tox role unpinning on dev 21 should not impact devstack based tox job. but yes we need to move master to tox 4.0.0 soon | |
| 17:05:48 | clarkb | right I think the main concern at this point is developers aren't going to want to maintain different versions of tox for different projects. Generally keeping up with latest avoids this problem. We pinned to stop the bleeding and now we can take a controlled approach to adding compatibility | |
| 17:06:28 | gmann | yeah | |
| 17:33:36 | opendevreview | Merged openstack/nova master: Create RequestGroups from InstancePCIRequests https://review.opendev.org/c/openstack/nova/+/852771 | |
| 17:33:43 | opendevreview | Merged openstack/nova master: Support resource_class and traits in PCI alias https://review.opendev.org/c/openstack/nova/+/853316 | |
| 17:33:50 | opendevreview | Merged openstack/nova master: Split PCI pools per PF https://review.opendev.org/c/openstack/nova/+/854440 | |
| #openstack-nova - 2022-12-14 | |||
| 08:35:44 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: api: extend evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858384 | |
| 08:35:44 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: compute: enhance compute evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858383 | |
| 08:36:16 | bauzas | happy spec review day everyone | |
| 08:50:18 | sahid | o/ I will be around if needed | |
| 13:23:29 | opendevreview | Merged openstack/nova stable/wallaby: Fix the wrong exception used to retry detach API calls https://review.opendev.org/c/openstack/nova/+/866084 | |
| 13:23:35 | opendevreview | Merged openstack/nova stable/wallaby: Retry attachment delete API call for 504 Gateway Timeout https://review.opendev.org/c/openstack/nova/+/866085 | |
| 14:11:41 | opendevreview | Merged openstack/nova master: Ironic nodes with instance reserved in placement https://review.opendev.org/c/openstack/nova/+/864773 | |
| 14:33:10 | andry | Hi to all, on my openstack installation I have one kvm that has been emptied and rebooted, but when i launch openstack hypervisor show podto2-kvm06 I see running_vms 7 but if I see on kvm I don't see vm and if I list openstack server list --all --host kvm, nothing appear. How is it possible?Thank you. | |
| 14:39:02 | andry | now i'm seeing on nova of kvm Error updating resources for node podto2-kvm06.: ValueError: No JSON object could be decoded | |
| 14:41:18 | amorin | hey sean-k-mooney and other, I'd love having a review on this: https://review.opendev.org/c/openstack/nova/+/853682 | |
| 14:44:07 | amorin | and also: https://review.opendev.org/c/openstack/nova/+/863891 | |
| 14:46:03 | opendevreview | Manuel Bentele proposed openstack/nova-specs master: Add configuration options to set SPICE compression settings https://review.opendev.org/c/openstack/nova-specs/+/849488 | |
| 15:23:37 | sean-k-mooney | amorin:perhaps tomorrow. today is intented to be a spec review day | |
| 15:24:04 | sean-k-mooney | for reasons i have not been able to spend much time on reviews today but tomrrow is ment to be an unoffical implemantion reveiw day | |
| 15:24:15 | sean-k-mooney | ill see if i can take a look at it then | |
| 16:11:02 | amorin | ack, thanks | |
| 17:44:38 | opendevreview | Merged openstack/nova-specs master: add spec for fqdn in hostname https://review.opendev.org/c/openstack/nova-specs/+/862626 | |
| 17:57:16 | opendevreview | Merged openstack/nova-specs master: Add configuration options to set SPICE compression settings https://review.opendev.org/c/openstack/nova-specs/+/849488 | |
| 21:05:40 | opendevreview | Merged openstack/python-novaclient master: trivial: Remove use of kwargs https://review.opendev.org/c/openstack/python-novaclient/+/806918 | |
| #openstack-nova - 2022-12-15 | |||
| 05:26:10 | opendevreview | Ghanshyam proposed openstack/nova master: Enable new defaults and scope checks by default https://review.opendev.org/c/openstack/nova/+/866218 | |
| 07:56:15 | opendevreview | Nobuhiro MIKI proposed openstack/nova-specs master: Add maxphysaddr support for Libvirt https://review.opendev.org/c/openstack/nova-specs/+/861033 | |
| 08:00:21 | opendevreview | Hiroki Narukawa proposed openstack/nova master: libvirt: retry libvirt connection on live_migration_monitor https://review.opendev.org/c/openstack/nova/+/867077 | |
| 10:54:11 | sean-k-mooney | bauzas: hi i was wrogn yestereday johns ironic spec is not merged yet but im more or less happy with it https://review.opendev.org/c/openstack/nova-specs/+/862833 do you want to review or will i add +w | |
| 10:54:40 | sean-k-mooney | there are a few nits that i think can be adressed in a followup but i dont see anything that would prevent us merging it as is | |
| 11:31:01 | sean-k-mooney | gibi: i need to do one thing then grab coffee after that i will be staring to review the pci series | |
| 11:31:25 | gibi | sean-k-mooney: OK. I replied to your comments about the rp_uuid vs rp_uuids | |
| 11:32:31 | sean-k-mooney | ya i was just checkign that and going to ping you | |
| 11:32:38 | sean-k-mooney | so based on your answer | |
| 11:33:15 | sean-k-mooney | we are using that array for two different types | |
| 11:33:30 | gibi | nope | |
| 11:33:41 | sean-k-mooney | pool vs spec | |
| 11:34:06 | gibi | pool has a single rp uuid, spec has a list of rp uuids serialized as comma separates string | |
| 11:34:27 | sean-k-mooney | yes but ignored_tags is beign applied to both | |
| 11:35:14 | gibi | ahh, yes that is applied to both yes | |
| 11:35:26 | sean-k-mooney | ya so that is what was confusitng me | |
| 11:35:48 | sean-k-mooney | since each type only have one fo the two field but we have on array of ignored tags | |
| 11:36:12 | sean-k-mooney | anyway based on your comments and this converstaion i now understand the intent | |
| 11:36:53 | sean-k-mooney | we might want to consider doing this diffently but i think im ok with this for now. but we my want to split this in a followup | |
| 11:37:31 | gibi | I made a note and I will look into this | |
| 11:37:32 | sean-k-mooney | ill leave a comment to that effect and see what stephen thinks when he gets to it and upgrade to +2 | |
| 12:51:08 | opendevreview | Stephen Finucane proposed openstack/nova master: Use SDK for add/remove instance info from node https://review.opendev.org/c/openstack/nova/+/659691 | |
| 12:51:09 | opendevreview | Stephen Finucane proposed openstack/nova master: Remove use of removeprefix https://review.opendev.org/c/openstack/nova/+/867788 | |
| 12:51:09 | opendevreview | Stephen Finucane proposed openstack/nova master: Use SDK for getting network metadata from node https://review.opendev.org/c/openstack/nova/+/670213 | |
| 12:51:10 | opendevreview | Stephen Finucane proposed openstack/nova master: Use SDK for volume_target.* https://review.opendev.org/c/openstack/nova/+/867790 | |
| 12:51:10 | opendevreview | Stephen Finucane proposed openstack/nova master: Remove unused mocks https://review.opendev.org/c/openstack/nova/+/867789 | |
| 12:51:11 | opendevreview | Stephen Finucane proposed openstack/nova master: Use SDK for node.set_power_state https://review.opendev.org/c/openstack/nova/+/867792 | |
| 12:51:11 | opendevreview | Stephen Finucane proposed openstack/nova master: Use SDK for node.set_provision_state https://review.opendev.org/c/openstack/nova/+/867791 | |
| 12:51:12 | opendevreview | Stephen Finucane proposed openstack/nova master: Use SDK for remaining network operations https://review.opendev.org/c/openstack/nova/+/867794 | |
| 12:51:12 | opendevreview | Stephen Finucane proposed openstack/nova master: Use SDK for node.vif* https://review.opendev.org/c/openstack/nova/+/867793 | |
| 12:51:14 | opendevreview | Stephen Finucane proposed openstack/nova master: Use SDK for deprecated baremetal proxy API https://review.opendev.org/c/openstack/nova/+/867796 | |
| 12:51:14 | opendevreview | Stephen Finucane proposed openstack/nova master: Use SDK for remaining ironic driver calls https://review.opendev.org/c/openstack/nova/+/867795 | |
| 12:51:16 | opendevreview | Stephen Finucane proposed openstack/nova master: Remove unnecessary aliasing https://review.opendev.org/c/openstack/nova/+/867798 | |
| 12:51:16 | opendevreview | Stephen Finucane proposed openstack/nova master: Remove Ironic client wrapper https://review.opendev.org/c/openstack/nova/+/867797 | |
| 12:51:18 | opendevreview | Stephen Finucane proposed openstack/nova master: Use real SDK objects in tests https://review.opendev.org/c/openstack/nova/+/867799 | |
| 12:52:08 | stephenfin | now back to reviews | |
| 13:10:47 | opendevreview | Merged openstack/nova master: Map PCI pools to RP UUIDs https://review.opendev.org/c/openstack/nova/+/854118 | |
| 13:13:23 | sean-k-mooney | stephenfin: is that replaceing the ironic client usage with sdk | |
| 13:13:48 | sean-k-mooney | we have a RFE bug for that if you were not aware can you link to that in the toic/commtis | |
| 13:21:33 | sean-k-mooney | gibi: bauzas this is the glace spec by the way that i mentioned yesterday https://review.opendev.org/c/openstack/glance-specs/+/863209 | |
| 13:21:55 | bauzas | ok | |
| 13:22:38 | sean-k-mooney | bauzas: did you see my ping for the ironic spec | |
| 13:23:21 | sean-k-mooney | https://review.opendev.org/c/openstack/nova-specs/+/862833 | |
| 13:23:37 | bauzas | sean-k-mooney: yup, I'll review about it | |
| 14:06:25 | gibi | sean-k-mooney: I read through the glance spec above but I cannot really add much to it top of your and dansmith_s comments | |
| 14:11:34 | sean-k-mooney | ack do you have any idea how backup works today? | |
| 14:11:48 | sean-k-mooney | i always assumed we had glance details in our config | |
| 14:12:25 | sean-k-mooney | backup predates microversion so i never really looked at the details sicne it also predates specs in nova | |
| 14:12:49 | johnthetubaguy | bauzas: I am sort of around today if there are questions on the spec, in case that helps. | |
| 14:15:58 | gibi | sean-k-mooney: never tried backup | |
| 14:16:35 | johnthetubaguy | sean-k-mooney: I thought it was just a regular snapshot using the users token? Its not on a schedule, we just delete old ones after creating a new one... I thought. Been about 5 years since I tried it mind. Although those glance calls can also get a service token attached, to stop the user token expiry issues. | |
| 14:17:35 | johnthetubaguy | you could require a service token, a bit like how we discussed for using user tokens for port binding in neutron | |
| 14:42:24 | opendevreview | Merged openstack/python-novaclient master: tests: Fix Python 3.11 compatibility https://review.opendev.org/c/openstack/python-novaclient/+/867270 | |
| 14:43:28 | stephenfin | sean-k-mooney: yeah, exactly. What's the RFE/bug? | |
| 15:00:18 | opendevreview | Pierre-Samuel Le Stang proposed openstack/nova master: Reproducer test of bug #1999674 https://review.opendev.org/c/openstack/nova/+/867807 | |
| 15:11:44 | bauzas | johnthetubaguy: sean-k-mooney: fwiw, I'm on the spec since 30 mins | |
| 15:11:51 | bauzas | should be done in 10 mins | |
| 15:12:41 | sean-k-mooney | ack | |
| 15:23:12 | bauzas | johnthetubaguy: sean-k-mooney send to the gate with comments | |
| 15:23:16 | bauzas | nothing important | |
| 15:23:29 | bauzas | and as said, we can continue discussing about those during the implementation | |
| 15:23:36 | bauzas | but I don't wanna hold this spec for this cycle | |
| 15:35:11 | opendevreview | Merged openstack/nova-specs master: Ironic shard_key to replace peer_list https://review.opendev.org/c/openstack/nova-specs/+/862833 | |
| 16:02:28 | rloo | hi nova-folks. thanks johnthetubaguy for fixing https://bugs.launchpad.net/nova/+bug/1974070 because I need that fix in wallaby! Is this https://review.opendev.org/c/openstack/nova/+/864773 backportable, it added a new config option? | |
| 16:05:06 | johnthetubaguy | rloo: your very welcome! I think it is backportable, because its a workaround config option, at least I think that is what we agreed. I haven't had chance to propose it myself though. | |
| 16:06:22 | rloo | thx johnthetubaguy ! if i can recall how to, i'll try to propose them and see how that goes :) | |
| 16:07:28 | rloo | btw johnthetubaguy, this didn't get merged, is it still desired? https://review.opendev.org/c/openstack/nova/+/842478 | |
| 16:09:06 | opendevreview | Ruby Loo proposed openstack/nova stable/zed: Ironic nodes with instance reserved in placement https://review.opendev.org/c/openstack/nova/+/867642 | |
| 16:17:46 | opendevreview | Konrad Gube proposed openstack/nova-specs master: Use extend volume completion action https://review.opendev.org/c/openstack/nova-specs/+/855490 | |
| 16:24:57 | opendevreview | Konrad Gube proposed openstack/nova-specs master: Use extend volume completion action https://review.opendev.org/c/openstack/nova-specs/+/855490 | |
| 16:33:38 | johnthetubaguy | rloo: good point, that is still needed for cases like when you mark and available node as in-maintenance but it gets picked before nova updates placement. we shouldn't need it work around automatic cleaning anymore though, so its more of an edge case now | |
| 16:33:45 | opendevreview | John Garbutt proposed openstack/nova master: Ironic: retry when node not available https://review.opendev.org/c/openstack/nova/+/842478 | |