| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-12-05 | |||
| 15:15:23 | dansmith | sean-k-mooney: yes: https://review.opendev.org/q/topic:bp%252Fstable-compute-uuid | |
| 15:15:48 | dansmith | as I mentioned, there are two tests in there that are failing because they assert that we recreate compute nodes, which this makes us not do | |
| 15:15:50 | sean-k-mooney | oh ok i missed that then ill try and review it before i finish for the year | |
| 15:16:08 | dansmith | so I left them as failing so that you can see that, and will go back and update the tests (of course) | |
| 15:16:24 | sean-k-mooney | ya you mentioned that the current fixutre for restarting the compute service was problematic | |
| 15:16:35 | sean-k-mooney | ack | |
| 15:16:40 | dansmith | yes, but I think I've fixed that | |
| 15:17:10 | dansmith | the failing tests are just because the test confirms that we re-create a compute node, but with this code, we re-find the old one | |
| 15:17:46 | dansmith | it's been sitting a month at this point so I don't fully remember, and I'll be even more hazy in Jan, but will pick it up then :) | |
| 15:17:56 | sean-k-mooney | ack i think in the long run that is proably more correct anyway (refinding them) | |
| 15:18:37 | dansmith | that's the point of the work, yeah :) | |
| 15:18:50 | dansmith | (well one of the points) | |
| 15:19:05 | dansmith | it avoids the stale/broken placement allocations and such | |
| 15:19:40 | sean-k-mooney | well i think (would have to check) we were reusing the uuid or soemthign liek tha tso that the palcement side was correct | |
| 15:19:50 | bauzas | dansmith: sent to the gate | |
| 15:19:51 | sean-k-mooney | in the funtional tests | |
| 15:19:58 | sean-k-mooney | but thanks for the context | |
| 15:20:05 | bauzas | dansmith: thanks for having added some paragraphs | |
| 15:20:46 | dansmith | bauzas: thanks | |
| 15:21:09 | dansmith | sean-k-mooney: in the ironic case we are I think, not sure about the regular case | |
| 15:21:42 | dansmith | sean-k-mooney: in the case of a host rename, we don't find the old provider by name (because our name changed) so we re-create everything right? | |
| 15:21:55 | sean-k-mooney | i think the way the current recreate worked we were not actully creating a new compute node record in the db | |
| 15:22:20 | sean-k-mooney | * how it worked in teh functional tests | |
| 15:22:37 | dansmith | okay I'm talking about in real life | |
| 15:23:18 | sean-k-mooney | ya so in real life the lookup can fail in one of two ways | |
| 15:23:35 | sean-k-mooney | either the host value does not match adn we create a new compute service entry | |
| 15:23:55 | sean-k-mooney | or the hypervior_hostname does not match and we delete and recreate teh compute node record | |
| 15:24:27 | dansmith | neither will match on a libvirt host that has renamed right? | |
| 15:24:32 | sean-k-mooney | so if the host value changes the service entry gets recreated and if the hypervior_hostname mismatches its the compute node | |
| 15:24:53 | sean-k-mooney | dansmith: if you have notihgn set in the config then yes | |
| 15:25:12 | dansmith | ah, right | |
| 15:25:26 | sean-k-mooney | ooo at least hardcodes the host value | |
| 15:25:39 | sean-k-mooney | so if the hostname change and the config is not updated then it will find the service | |
| 15:25:48 | sean-k-mooney | then delete the compute node and recreate it | |
| 15:27:36 | dansmith | sean-k-mooney: yeah I guess we need to make sure we have those cases covered in the tests.. "host renamed, no config set" and "host renamed, config set to something" | |
| 15:28:34 | sean-k-mooney | i think we can emulate that by mocking the driver method to get the host name and config flags at least at a unit test level | |
| 15:28:52 | sean-k-mooney | for functional tests we could proably do it too but only with one compute node sicne the config is shared | |
| 15:29:24 | sean-k-mooney | but yes i agree i dont know if we need to test all 4 combination but proably woudl not hurt | |
| 15:30:06 | admin1 | is there a good rescue image (os ) for openstack .. that kind of boots directly without login/pass for rescue ? | |
| 15:32:39 | sean-k-mooney | well by default the same image the vm is booted with is used for rescue | |
| 15:33:00 | sean-k-mooney | but any of the images you woudl use on a phsyical host will be good | |
| 15:33:16 | sean-k-mooney | like KNOPPIX | |
| 15:33:17 | opendevreview | Merged openstack/nova-specs master: Add stable-compute-uuid spec https://review.opendev.org/c/openstack/nova-specs/+/863152 | |
| 15:34:37 | sean-k-mooney | it actully would proably have made sense to allow a keypair to be specifed for rescue | |
| 15:35:05 | sean-k-mooney | although the assumtion was the tenant would do rescue so that why we reuse the one the vm is booted with | |
| 15:36:13 | sean-k-mooney | admin1: if you are doing this on behalf of a tenatn what i would recommend is creating a iamge yourself and baking in a set of ssh keys and then usign that to rescue tenant vms | |
| 17:03:54 | opendevreview | Merged openstack/nova stable/xena: refactor: remove duplicated logic https://review.opendev.org/c/openstack/nova/+/864932 | |
| 17:04:00 | opendevreview | Merged openstack/nova stable/xena: Record SRIOV PF MAC in the binding profile https://review.opendev.org/c/openstack/nova/+/864933 | |
| 17:04:07 | opendevreview | Merged openstack/nova stable/xena: Remove double mocking https://review.opendev.org/c/openstack/nova/+/864934 | |
| 17:04:13 | opendevreview | Merged openstack/nova stable/xena: Remove double mocking... again https://review.opendev.org/c/openstack/nova/+/864935 | |
| 17:04:19 | opendevreview | Merged openstack/nova stable/xena: Add compute restart capability for libvirt func tests https://review.opendev.org/c/openstack/nova/+/864936 | |
| 17:04:24 | opendevreview | Merged openstack/nova stable/xena: enable blocked VDPA move operations https://review.opendev.org/c/openstack/nova/+/864937 | |
| 17:56:04 | sean-k-mooney | :) | |
| 17:56:14 | sean-k-mooney | ok ill update the wallaby ones now | |
| 18:02:38 | melwitt | sean-k-mooney: fyi this is the strange py27 failure on the stable/train backport that I could not figure out what is going on https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_80f/866090/1/check/openstack-tox-py27/80f58ef/testr_results.html | |
| 18:03:10 | sean-k-mooney | yep i have that open in a tab somewhere | |
| 18:03:26 | melwitt | ok cool :) | |
| 18:04:59 | sean-k-mooney | im wondering if this is related to a call to super or something like that | |
| 18:05:23 | sean-k-mooney | im not exactly sure where TypeError: __init__() takes at least 2 arguments (1 given) | |
| 18:05:32 | sean-k-mooney | is coming form or if this is a tully the issue | |
| 18:06:26 | melwitt | hmm, I will check | |
| 18:09:01 | sean-k-mooney | my guess is either this is related to the python 3 only verison fo super or we require an adtional positional arg in train for a class | |
| 18:09:18 | sean-k-mooney | the one arg that was given is presumabley self | |
| 18:10:05 | sean-k-mooney | althugh it could be the context | |
| 18:13:02 | melwitt | I feel like it has to be something to do with creation of the ClientException objects in the unit tests, there's really not much in the patch | |
| 18:14:00 | melwitt | *not much else | |
| 18:14:37 | sean-k-mooney | whats weired is it only fails on py27 | |
| 18:14:58 | sean-k-mooney | i expect most or all of that to not care | |
| 18:15:16 | melwitt | yeah, same. so weird | |
| 21:01:53 | zigo | Hi there! About https://bugs.debian.org/1025110 to me it feels like novaclient is calling suparser.addparser twice with the same subparser name, which now raises an error in Py 3.11. | |
| 21:02:07 | zigo | Though I'm having trouble finding the 2 places ... | |
| 21:02:25 | zigo | (I'm not familliar with novaclient...) | |
| 21:02:33 | zigo | Can someone have a look? | |
| 21:04:44 | zigo | In novaclient/tests/unit/test_shell.py, I can see shell._find_actions() called twice with fake_actions_module as argument ... | |
| 21:05:53 | zigo | That's both in test_load_versioned_actions() and test_load_actions_with_versioned_args(). | |
| 21:06:02 | zigo | So this looks like a test issue, not a novaclient issue. | |
| 21:10:19 | zigo | https://bugs.launchpad.net/python-novaclient/+bug/1998856 | |
| #openstack-nova - 2022-12-06 | |||
| 08:32:51 | opendevreview | Hiroki Narukawa proposed openstack/nova master: libvirt: add sftp driver https://review.opendev.org/c/openstack/nova/+/866672 | |
| 09:08:33 | sahid_ | o/ sorry to annoy guys any chance to get somes reviews regarding the impl of evacuate spec? https://review.opendev.org/c/openstack/nova/+/858383 there are lot of files updated but just small changes | |
| 09:12:37 | sean-k-mooney | sahid_: i dont know if i will get to them today but i will get to them before i go on pto for the year | |
| 09:12:52 | sean-k-mooney | im here until friday next week | |
| 09:13:03 | sean-k-mooney | i suspect we can likely get this merged before then | |
| 09:15:00 | bauzas | yup, I'll try too | |
| 09:15:16 | bauzas | I personnally need to rush on implementing the cpu offlining feature | |
| 09:15:22 | bauzas | before the xmas period | |
| 09:21:56 | sean-k-mooney | if its aviable next week ill have time to start reviewing | |
| 09:22:12 | zigo | sahid_: Hi there! Would you have the URL of the bp handy? | |
| 09:24:48 | zigo | It appears cinderclient has the same exact bug (the 2 broken tests are looking very similar if not completely identical) | |
| 09:24:48 | zigo | Back to the bug report from yesterday: https://bugs.launchpad.net/python-novaclient/+bug/1998856 | |
| 09:37:58 | sahid_ | Hey zigo, https://github.com/openstack/nova-specs/blob/master/specs/2023.1/approved/allowing-target-state-for-evacuate.rst | |
| 09:54:07 | sahid_ | sean-k-mooney: hey! no worries, just that more we can have it soon in the tree more we can fix any bugs it could have :-) (and also safe am I we have it merged for antelope :p) | |
| 10:52:25 | opendevreview | Sylvain Bauza proposed openstack/nova stable/wallaby: Reproducer for bug 1951656 https://review.opendev.org/c/openstack/nova/+/866157 | |
| 10:52:40 | opendevreview | Sylvain Bauza proposed openstack/nova stable/wallaby: Handle mdev devices in libvirt 7.7+ https://review.opendev.org/c/openstack/nova/+/866158 | |
| 10:59:25 | opendevreview | sean mooney proposed openstack/nova stable/wallaby: refactor: remove duplicated logic https://review.opendev.org/c/openstack/nova/+/865334 | |
| 10:59:26 | opendevreview | sean mooney proposed openstack/nova stable/wallaby: Record SRIOV PF MAC in the binding profile https://review.opendev.org/c/openstack/nova/+/865336 | |
| 10:59:27 | opendevreview | sean mooney proposed openstack/nova stable/wallaby: Add compute restart capability for libvirt func tests https://review.opendev.org/c/openstack/nova/+/865571 | |
| 10:59:28 | opendevreview | sean mooney proposed openstack/nova stable/wallaby: enable blocked VDPA move operations https://review.opendev.org/c/openstack/nova/+/865572 | |
| 10:59:29 | opendevreview | sean mooney proposed openstack/nova stable/wallaby: Reproducer for bug 1951656 https://review.opendev.org/c/openstack/nova/+/866157 | |
| 10:59:31 | opendevreview | sean mooney proposed openstack/nova stable/wallaby: Handle mdev devices in libvirt 7.7+ https://review.opendev.org/c/openstack/nova/+/866158 | |
| 11:11:01 | zigo | sahid_: If I understand correctly, the goal is to have a instance go from ACTIVE to SHUTOFF during the evacuate ? | |