| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-11-30 | |||
| 17:08:36 | sean-k-mooney | even if its just an interim step to reventually removing that in the db layer | |
| 17:08:50 | sean-k-mooney | ok so you would prefer we internally escalate to admin context | |
| 17:08:53 | dansmith | sean-k-mooney: not only because it would affect lots of other non-service role things, but also because it expands that check which we probably want to minimize | |
| 17:09:08 | sean-k-mooney | ya that fiar | |
| 17:09:10 | dansmith | I'd prefer we explicitly "elevate" to admin for service role things at the point of access | |
| 17:09:12 | gmann | yeah | |
| 17:09:26 | gmann | ok, let me go with approach 1. policy check for service role at start 2. fetch the things (server etc) with admin context | |
| 17:09:41 | dansmith | ++ | |
| 17:09:48 | sean-k-mooney | yep that works for me | |
| 17:10:01 | sean-k-mooney | the same shoudl apply to swap volume | |
| 17:10:10 | sean-k-mooney | its the same check that is failign right | |
| 17:10:14 | gmann | ok, thanks dansmith sean-k-mooney | |
| 17:10:16 | sean-k-mooney | the get_server | |
| 17:10:36 | gmann | dansmith: sean-k-mooney btw if you have time, placement policy updates are ready to review too https://review.opendev.org/c/openstack/placement/+/865618 | |
| 17:10:39 | gmann | gibi: ^^ | |
| 17:10:45 | gmann | sean-k-mooney: yes | |
| 17:14:59 | sean-k-mooney | gmann: realistically it will be next week before i have time to take a look but i set RP+1 and ill try to come back to itthen | |
| 17:15:33 | gmann | sean-k-mooney: sure, thanks | |
| 17:19:24 | opendevreview | melanie witt proposed openstack/nova stable/yoga: Adapt websocketproxy tests for SimpleHTTPServer fix https://review.opendev.org/c/openstack/nova/+/866192 | |
| 17:20:36 | opendevreview | melanie witt proposed openstack/nova stable/xena: Adapt websocketproxy tests for SimpleHTTPServer fix https://review.opendev.org/c/openstack/nova/+/866193 | |
| 17:21:41 | opendevreview | melanie witt proposed openstack/nova stable/wallaby: Adapt websocketproxy tests for SimpleHTTPServer fix https://review.opendev.org/c/openstack/nova/+/866194 | |
| 17:29:43 | opendevreview | melanie witt proposed openstack/nova stable/victoria: Adapt websocketproxy tests for SimpleHTTPServer fix https://review.opendev.org/c/openstack/nova/+/866195 | |
| 17:31:16 | opendevreview | melanie witt proposed openstack/nova stable/ussuri: Adapt websocketproxy tests for SimpleHTTPServer fix https://review.opendev.org/c/openstack/nova/+/866196 | |
| 18:05:07 | opendevreview | melanie witt proposed openstack/nova stable/train: Adapt websocketproxy tests for SimpleHTTPServer fix https://review.opendev.org/c/openstack/nova/+/866201 | |
| 18:07:24 | opendevreview | Merged openstack/nova-specs master: fixing: allowing target state for evacuate https://review.opendev.org/c/openstack/nova-specs/+/866108 | |
| 19:05:48 | opendevreview | Merged openstack/nova stable/yoga: refactor: remove duplicated logic https://review.opendev.org/c/openstack/nova/+/855022 | |
| 21:07:27 | opendevreview | Ghanshyam proposed openstack/nova master: Enable new defaults and scope checks by default https://review.opendev.org/c/openstack/nova/+/866218 | |
| 21:48:10 | atmark | need help modifying https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L4150-L4172 . I'd like to add to check VM property if it contains say a string 'NoRestart' in addition to ignored_states | |
| 21:54:37 | opendevreview | Ghanshyam proposed openstack/nova master: Enable new defaults and scope checks by default https://review.opendev.org/c/openstack/nova/+/866218 | |
| 22:33:37 | opendevreview | melanie witt proposed openstack/nova stable/train: Adapt websocketproxy tests for SimpleHTTPServer fix https://review.opendev.org/c/openstack/nova/+/866201 | |
| #openstack-nova - 2022-12-01 | |||
| 00:02:28 | opendevreview | melanie witt proposed openstack/nova stable/train: Adapt websocketproxy tests for SimpleHTTPServer fix https://review.opendev.org/c/openstack/nova/+/866201 | |
| 06:12:15 | opendevreview | Wenping Song proposed openstack/nova master: Get only resolved arqs instead of filter all arqs https://review.opendev.org/c/openstack/nova/+/866291 | |
| 08:44:47 | opendevreview | Manuel Bentele proposed openstack/nova master: libvirt: Add configuration options to set SPICE compression settings https://review.opendev.org/c/openstack/nova/+/828675 | |
| 08:45:53 | opendevreview | Merged openstack/nova master: Adds regression functional test for 1980720 https://review.opendev.org/c/openstack/nova/+/861357 | |
| 10:25:15 | opendevreview | Merged openstack/nova stable/train: add regression test case for bug 1978983 https://review.opendev.org/c/openstack/nova/+/864168 | |
| 10:54:05 | jsanemet | hello | |
| 10:54:23 | jsanemet | could i get a review for this spec? | |
| 10:54:25 | jsanemet | https://review.opendev.org/c/openstack/nova-specs/+/865432 | |
| 10:54:41 | jsanemet | thanks | |
| 11:37:42 | opendevreview | Merged openstack/nova stable/train: For evacuation, ignore if task_state is not None https://review.opendev.org/c/openstack/nova/+/864169 | |
| 11:49:23 | opendevreview | Rajat Dhasmana proposed openstack/nova stable/wallaby: [stable-only] Use os-brick from source in wallaby https://review.opendev.org/c/openstack/nova/+/866326 | |
| 13:55:49 | opendevreview | Manuel Bentele proposed openstack/nova master: libvirt: Add configuration options to set SPICE compression settings https://review.opendev.org/c/openstack/nova/+/828675 | |
| 14:08:27 | tobias-urdin | do we support live migration of instances with pinned pcpus? perhaps sean-k-mooney can shime in | |
| 14:11:19 | tobias-urdin | imo should be supported since train, but always better to ask i guess | |
| 14:11:51 | sean-k-mooney | tobias-urdin: yes but it depend on the release | |
| 14:12:05 | bauzas | we indeed do | |
| 14:12:24 | sean-k-mooney | https://specs.openstack.org/openstack/nova-specs/specs/train/implemented/numa-aware-live-migration.html | |
| 14:12:45 | sean-k-mooney | the numa aware live migration feature added the ablity to recaluate and update the xml for the destination host | |
| 14:13:19 | sean-k-mooney | tobias-urdin: before that you could only live migrate if the same cpus were free on the dest and that was kind of a hack | |
| 14:13:26 | sean-k-mooney | so before train really only cold migration | |
| 14:13:34 | sean-k-mooney | after train live migration should work properly | |
| 14:14:11 | sean-k-mooney | tobias-urdin: the same is true for hugepages. it was done in the same feautre | |
| 14:14:20 | sean-k-mooney | tobias-urdin: there is still one unfixed bug | |
| 14:14:52 | sean-k-mooney | live migrating between hosts with different vcpu_pin_sets or different cpu_shared_sets | |
| 14:15:04 | sean-k-mooney | for non numa instnace is still technically broken | |
| 14:15:15 | opendevreview | Merged openstack/nova stable/yoga: Record SRIOV PF MAC in the binding profile https://review.opendev.org/c/openstack/nova/+/855023 | |
| 14:15:21 | opendevreview | Merged openstack/nova stable/yoga: Remove double mocking https://review.opendev.org/c/openstack/nova/+/855024 | |
| 14:15:24 | tobias-urdin | ack, so if nodes are identical in terms of config (pin sets) it shouldn't be a problem | |
| 14:15:26 | opendevreview | Merged openstack/nova stable/yoga: Remove double mocking... again https://review.opendev.org/c/openstack/nova/+/855025 | |
| 14:15:32 | opendevreview | Merged openstack/nova stable/yoga: Add compute restart capability for libvirt func tests https://review.opendev.org/c/openstack/nova/+/855026 | |
| 14:15:32 | sean-k-mooney | we do not update the cpus for floating instnaces until you hard reboot the vm | |
| 14:15:42 | opendevreview | Merged openstack/nova stable/victoria: [compute] always set instance.host in post_livemigration https://review.opendev.org/c/openstack/nova/+/863903 | |
| 14:16:20 | sean-k-mooney | tobias-urdin: for pinend vms the pin sets can be differnt and it shoudl not be a problem | |
| 14:16:56 | sean-k-mooney | in trian+ | |
| 14:18:19 | tobias-urdin | ack, not sure I understand the bug tho | |
| 14:19:37 | sean-k-mooney | the but is if you are not using cpu pinning, and you have set cpu_share_set or vcpu_pin_set | |
| 14:20:01 | sean-k-mooney | if that is not the same on all hosts floating vms will float over the wrong cores after migrating | |
| 14:20:27 | sean-k-mooney | the numa aware migration feature only updates the cpus if the vm has a numa toplogy | |
| 14:20:43 | sean-k-mooney | if its a normal vm with no numa info it does not update the cpus | |
| 14:21:14 | sean-k-mooney | and if you have eiterh vcpu_pin_set defiend or cpu_shared_set then the floating vms will be soft pinned to float over those cores | |
| 14:21:40 | tobias-urdin | ah I see, thanks, that shouldn't be an issue on our part then. thanks as always! | |
| 14:21:48 | sean-k-mooney | so this bug has been there since like icehouse wehn vcpu_pin_set was added as a config option | |
| 14:22:33 | sean-k-mooney | we have just never fixed it as it need an rpc change to pass back the requried info | |
| 14:45:27 | tobias-urdin | ack | |
| 15:32:36 | atmark | hello, looking at resume_state_on_host_boot() in https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L4150-L4172, I like to add OR condition in https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L4164 such that it also ignores if the VM has property `NoRestart=True' e.g. `if state in ignored_states or instance_properties = | |
| 15:32:38 | atmark | 'NoRestart=True':`. Appreciate any pointers on how can I accomplish this. | |
| 15:54:51 | bauzas | sean-k-mooney: gibi found a good issue in your stable/xena series for VDPA https://review.opendev.org/c/openstack/nova/+/864932 | |
| 16:00:03 | bauzas | sean-k-mooney: just update the commit msg and we're all cool | |
| 16:01:30 | sean-k-mooney | bauzas: yes i think i have seen that | |
| 16:01:36 | sean-k-mooney | and i think its adressed in the train version | |
| 16:01:44 | sean-k-mooney | but ill need to look at it again | |
| 16:01:58 | sean-k-mooney | i know i have to respine it for something and redo the train oen as a result | |
| 18:14:36 | opendevreview | sean mooney proposed openstack/nova stable/xena: refactor: remove duplicated logic https://review.opendev.org/c/openstack/nova/+/864932 | |
| 18:14:37 | opendevreview | sean mooney proposed openstack/nova stable/xena: Record SRIOV PF MAC in the binding profile https://review.opendev.org/c/openstack/nova/+/864933 | |
| 18:14:38 | opendevreview | sean mooney proposed openstack/nova stable/xena: Remove double mocking https://review.opendev.org/c/openstack/nova/+/864934 | |
| 18:14:39 | opendevreview | sean mooney proposed openstack/nova stable/xena: Remove double mocking... again https://review.opendev.org/c/openstack/nova/+/864935 | |
| 18:14:40 | opendevreview | sean mooney proposed openstack/nova stable/xena: Add compute restart capability for libvirt func tests https://review.opendev.org/c/openstack/nova/+/864936 | |
| 18:14:41 | opendevreview | sean mooney proposed openstack/nova stable/xena: enable blocked VDPA move operations https://review.opendev.org/c/openstack/nova/+/864937 | |
| 18:15:53 | sean-k-mooney | bauzas: once ^ are merged ill redo the wallaby ones to update teh cherry-picked lines | |
| 18:16:15 | sean-k-mooney | i just updated the commit messages in the first two patches the rest are the same just rebased | |
| 19:25:46 | opendevreview | Merged openstack/nova stable/yoga: enable blocked VDPA move operations https://review.opendev.org/c/openstack/nova/+/855035 | |
| #openstack-nova - 2022-12-02 | |||
| 09:30:09 | whoami-rajat | hey #openstack-nova , nova-ceph-multistore is failing on wallaby gate, can anyone take a look at this patch fixing it? https://review.opendev.org/c/openstack/nova/+/866326 | |
| 09:51:50 | bauzas | whoami-rajat: haha, I saw the problem | |
| 09:52:19 | bauzas | whoami-rajat: thanks for your change, but I have a question | |
| 09:53:17 | bauzas | why couldn't we have a new os-brick version ? | |
| 09:53:46 | bauzas | because Wallaby is on EM ? | |
| 10:07:11 | whoami-rajat | bauzas, yes, the only way (I know of) is to take os-brick from source, I talked to the release team and not possible to release another os-brick for wallaby | |
| 10:10:22 | bauzas | whoami-rajat: which release model do you have for os-brick ? | |
| 10:10:32 | bauzas | lemme check actually | |
| 10:16:03 | bauzas | https://releases.openstack.org/teams/cinder.html#os-brick hah, you're not using the independent model | |