| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-11-29 | |||
| 15:06:15 | bauzas | gibi: I had the same concern, but eventually I said yes because it's an operator question | |
| 15:07:13 | bauzas | gibi: here, that means that we won't provide the MTU in the metadata service if the subnet from the instance is using a dhcp server | |
| 15:08:18 | gibi | "subnet from the instance is using a dhcp server" <- but if the network has two subnets one with dhcp and one without dhcp then we need to check the actualy subnet the port uses, not every subnet in the network | |
| 15:08:37 | gibi | or do I miss something | |
| 15:08:38 | gibi | ? | |
| 15:09:05 | gibi | I'm OK to not set MTU if the subnet the port uses has DHCP. But the patch does not implement that | |
| 15:09:22 | gibi | that patch does not set MTU if _any_ of the subnets of the network has DHCP | |
| 15:09:38 | gibi | no just the one the port uses | |
| 15:10:30 | frickler | I need to double-check but I think for v6 the MTU is signaled by RAs, not dhcp? | |
| 15:11:10 | sean-k-mooney | gibi: good catch gibi | |
| 15:11:13 | gibi | (I assume that as the dhcp_server is defined per subnet it can be differently configured per subnet of the same network) | |
| 15:11:47 | sean-k-mooney | frickler: for ipv6 mtu is discoverd via the neibour discovery protocol | |
| 15:12:08 | sean-k-mooney | and it shoudl be automaticaly negociated regardelss of using RA or DHCP6 | |
| 15:12:26 | opendevreview | Sylvain Bauza proposed openstack/nova master: Don't provide MTU value in metadata service if DHCP is enabled https://review.opendev.org/c/openstack/nova/+/855664 | |
| 15:12:56 | sean-k-mooney | RA and DHCPv6 could provide an inital value. | |
| 15:12:57 | bauzas | slaweq: gibi: sean-k-mooney: in order to stop the check pipeline, I created a new revision ^ | |
| 15:13:08 | sean-k-mooney | gibi: yes the dhcp option is per subnet not per network | |
| 15:13:17 | sean-k-mooney | bauzas: ack | |
| 15:13:28 | sean-k-mooney | well you could have just removed the +w | |
| 15:14:48 | sean-k-mooney | gibi: actully | |
| 15:15:45 | sean-k-mooney | gibi: is the set of subnets that it is lopping over the subnets the port is attach to via the fixed ipes it has or just the one on the network | |
| 15:15:54 | sean-k-mooney | i woudl assume we have not prefiltered them | |
| 15:16:13 | gibi | I don't think we prefilter them | |
| 15:16:18 | gibi | but I haven't checked explicitly | |
| 15:16:35 | gibi | I assumed it is all the subnets of the network as it is under [networ][subnets] | |
| 15:16:41 | sean-k-mooney | so we need to do an intersection between the subnets of the fixed ips and the subnets of the network and then check only those | |
| 15:16:54 | sean-k-mooney | gibi: ya that is what i woudl assume too | |
| 15:18:47 | bauzas | sean-k-mooney: no, you can't just remove the +W if it was running to the gate | |
| 15:19:17 | bauzas | even in check pipeline | |
| 15:20:26 | bauzas | gibi: we prefilter only if we opt in for routed networks | |
| 15:20:40 | sean-k-mooney | bauzas: if it was in check you can if it was in gate then no | |
| 15:21:01 | bauzas | sean-k-mooney: anyway, this is done but I'm pretty sure of the other way | |
| 15:21:06 | bauzas | meh | |
| 15:21:23 | sean-k-mooney | so this is not related to routed networks | |
| 15:21:32 | bauzas | so, here, we have a list of subnets that's given from a network | |
| 15:21:38 | sean-k-mooney | you can have as may subnetes on a network as you liek to add more ips to the network | |
| 15:22:23 | sean-k-mooney | its pretty common ot jsut add addtional subnets to a network if you run out of ips for ports on that network | |
| 15:22:34 | bauzas | if the instance has an IP address for a subnet that doesn't have a DHCP server running, but other subnets do have DHCP server, then we won't set the MTU | |
| 15:22:42 | bauzas | if we merge this one | |
| 15:22:55 | sean-k-mooney | yes which woudl be incorrect | |
| 15:22:55 | bauzas | sean-k-mooney: I know, I'm clarifying the situation | |
| 15:23:14 | bauzas | so yeah, agreed, we need to check the fixed IP address subnet, that's it | |
| 15:23:24 | bauzas | we even don't need an intersection | |
| 15:23:38 | sean-k-mooney | oh | |
| 15:23:45 | sean-k-mooney | ya good point | |
| 15:23:50 | sean-k-mooney | we dont need the intersaction | |
| 15:23:52 | bauzas | and I think my prefilter already does this somewhere | |
| 15:23:58 | sean-k-mooney | just loop over the subnets of the fixed ips | |
| 15:24:05 | bauzas | not saying we should run the prefilter | |
| 15:24:18 | bauzas | but the check is the same | |
| 15:24:25 | bauzas | I mean the pattern | |
| 15:24:30 | sean-k-mooney | right just that there might be exsiting code that can be copeid or shared | |
| 15:25:24 | sean-k-mooney | this https://github.com/openstack/nova/blob/master/nova/scheduler/request_filter.py#L317-L331 | |
| 15:26:14 | sean-k-mooney | you are calling neutron there since the info is not in the network info cache at this point | |
| 15:26:22 | sean-k-mooney | so that wont actrully help | |
| 15:27:32 | sean-k-mooney | but the vif object can give you the fixed ips | |
| 15:27:35 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/network/model.py#L445-L450 | |
| 15:28:25 | sean-k-mooney | looking at that code it might be already filtering | |
| 15:30:31 | sean-k-mooney | so the subnets are constucted here | |
| 15:30:33 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/network/neutron.py#L3330-L3332 | |
| 15:31:19 | sean-k-mooney | which internally uses https://github.com/openstack/nova/blob/master/nova/network/neutron.py#L3568-L3637 | |
| 15:31:26 | sean-k-mooney | _get_subnets_from_port | |
| 15:32:19 | sean-k-mooney | so we only store the subnets for the current port in the info cache | |
| 15:54:26 | bauzas | reminder : nova meeting in 5 mins | |
| 15:54:31 | bauzas | -ish | |
| 16:00:07 | opendevmeet | The meeting name has been set to 'nova' | |
| 16:00:07 | opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | |
| 16:00:07 | opendevmeet | Meeting started Tue Nov 29 16:00:07 2022 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | |
| 16:00:07 | bauzas | #startmeeting nova | |
| 16:00:12 | bauzas | hey folks | |
| 16:00:16 | auniyal | O/ | |
| 16:00:22 | gibi | o/ | |
| 16:00:48 | Uggla | o/ | |
| 16:01:16 | elodilles | o/ | |
| 16:01:36 | bauzas | let me grab a coffee and we start | |
| 16:02:50 | bauzas | ok let's start and welcome | |
| 16:03:00 | bauzas | #topic Bugs (stuck/critical) | |
| 16:03:03 | dansmith | o/ | |
| 16:03:05 | bauzas | #info No Critical bug | |
| 16:03:07 | sean-k-mooney | o/ | |
| 16:03:09 | bauzas | #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 16 new untriaged bugs (+5 since the last meeting) | |
| 16:03:15 | bauzas | #info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster | |
| 16:03:31 | bauzas | I know this was a busy week | |
| 16:03:40 | bauzas | any bug to discuss ? | |
| 16:03:49 | bauzas | (apart from the gate ones) | |
| 16:04:12 | bauzas | looks not | |
| 16:04:20 | bauzas | elodilles: can you use the baton for the next bugs ? | |
| 16:04:26 | elodilles | yepp | |
| 16:04:29 | bauzas | cool thanks ! | |
| 16:04:35 | bauzas | #info bug baton is being passed to elodilles | |
| 16:04:41 | bauzas | #topic Gate status | |
| 16:04:45 | bauzas | #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs | |
| 16:04:55 | bauzas | it was a busy week | |
| 16:05:17 | bauzas | #info ML thread about the gate blocking issues we had https://lists.openstack.org/pipermail/openstack-discuss/2022-November/031357.html | |
| 16:05:30 | bauzas | kudos to the team for the hard work | |
| 16:05:34 | bauzas | it looks now the gate is back | |
| 16:05:49 | bauzas | unfortunately, we had to skip some tests :( | |
| 16:06:23 | bauzas | but actually maybe they were not necessary :) | |
| 16:06:33 | bauzas | anyway | |
| 16:06:40 | bauzas | #link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&pipeline=periodic-weekly Nova&Placement periodic jobs status | |