| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-10-03 | |||
| 09:45:29 | auniyal | I have a doubt in this comment, can you please confirm, the changes | |
| 09:46:13 | auniyal | last comment in this patch | |
| 09:55:19 | gibi | auniyal: what I ment there is that you have to restore the state of the instance object to point to the source host. And that needs not just the instance.host but also the instnace.node to be set properly. You can copy the instance current node at the start of the post_live_migration_at_destination call in a local variabla and then use that to restore instance.node in the finally block | |
| 10:10:28 | sean-k-mooney | gibi: no | |
| 10:10:48 | sean-k-mooney | gibi: post live migration is after we are allowed to rollback | |
| 10:10:54 | gibi | sorry | |
| 10:10:57 | gibi | I mixed source det | |
| 10:10:58 | gibi | dest | |
| 10:11:03 | sean-k-mooney | oh ok | |
| 10:11:21 | gibi | so it is not enough to set the instance.host but need to set the instance.node | |
| 10:11:24 | gibi | to the dest | |
| 10:11:27 | sean-k-mooney | yes | |
| 10:11:38 | gibi | but then auniyal you have to look up the dest node | |
| 10:12:21 | sean-k-mooney | well your running on the test at this point | |
| 10:12:26 | auniyal | isn't dest node is same as dest host ? or dest | |
| 10:12:31 | sean-k-mooney | so you just need to set it im not sure you need to look it up | |
| 10:12:41 | sean-k-mooney | auniyal: for libvirt yes | |
| 10:12:44 | sean-k-mooney | in general no | |
| 10:12:52 | sean-k-mooney | actully no | |
| 10:13:01 | sean-k-mooney | even for libvirt they can be different | |
| 10:13:19 | sean-k-mooney | although i think that owuld be an error | |
| 10:15:02 | sean-k-mooney | node_name = compute_node.hypervisor_hostname | |
| 10:15:28 | sean-k-mooney | where as instance.host = CONF.host | |
| 10:16:01 | auniyal | queston, what is diff between host and node, till now, I thought the instance.host is where compute service is running, (node is as general we say in any network tree/mapping (machine)) | |
| 10:16:02 | sean-k-mooney | by default those shoudl be the same but if you manually set [DEFAULT]/host | |
| 10:16:09 | sean-k-mooney | then they can be differnt | |
| 10:16:26 | sean-k-mooney | node is the name of the comptue node | |
| 10:16:33 | sean-k-mooney | host is the name of the compute service | |
| 10:16:58 | sean-k-mooney | for non clustered drivers like libvirt they are normally the same | |
| 10:17:52 | sean-k-mooney | for clustered dirvers like ironic where 1 compute service manages many baremetal servers | |
| 10:17:55 | sean-k-mooney | they are differnet | |
| 10:18:31 | sean-k-mooney | you can look up the name like this | |
| 10:18:33 | sean-k-mooney | https://github.com/openstack/nova/blob/1025c9879341d44db33c4cc501435364dd185a9e/nova/compute/manager.py#L9263-L9267 | |
| 10:19:58 | auniyal | ack | |
| 11:48:15 | opendevreview | Andre Aranha proposed openstack/nova master: Replace Centos 8 jobs for Centos 9 https://review.opendev.org/c/openstack/nova/+/858272 | |
| 11:49:47 | opendevreview | Andre Aranha proposed openstack/nova master: Remove the periodic Centos 8 job https://review.opendev.org/c/openstack/nova/+/858272 | |
| 12:02:36 | opendevreview | Andre Aranha proposed openstack/nova stable/yoga: Test setting the nova job to centos-9-stream https://review.opendev.org/c/openstack/nova/+/860087 | |
| 12:39:35 | opendevreview | Maksim Malchuk proposed openstack/nova stable/xena: Fix to implement 'pack' or 'spread' VM's NUMA cells https://review.opendev.org/c/openstack/nova/+/829804 | |
| 14:48:13 | atmark | Hello. Getting this error when trying to temporarily increase allocation_ratio in placement via CLI | |
| 14:48:23 | atmark | JSON does not validate: 'total' is a required property Failed validating 'required' in schema['properties']['inventories']['patternProperties']['^[A-Z0-9_]+$']: | |
| 14:48:53 | atmark | ./openstack resource provider inventory set c80259e6-67fb-47a0-b04f-364b2f2b2969 --resource MEMORY_MB:allocation_ratio=1.0 | |
| 16:14:10 | gibi | atmark: either define the total value in --resource too, or use --amend to instruct the client to only change the allocation_ratio | |
| 17:19:49 | atmark | gibi: --amend works, thanks | |
| 17:44:03 | gibi | atmark: :) | |
| #openstack-nova - 2022-10-04 | |||
| 08:15:39 | bauzas | gibi: your help is needed for a janitory change https://review.opendev.org/c/openstack/nova-specs/+/856173 | |
| 08:20:33 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova-specs master: spec: allowing target state for evacuate https://review.opendev.org/c/openstack/nova-specs/+/857838 | |
| 08:36:51 | gibi | bauzas: done | |
| 08:37:01 | bauzas | thanks | |
| 08:45:41 | opendevreview | Merged openstack/nova-specs master: Move specs to implemented https://review.opendev.org/c/openstack/nova-specs/+/856173 | |
| 08:56:00 | auniyal__ | Hi sean-k-mooney, gibi | |
| 08:56:25 | auniyal__ | in post live migration unit test https://review.opendev.org/c/openstack/nova/+/791135/7/nova/tests/unit/compute/test_compute_mgr.py#10212 | |
| 08:57:17 | auniyal__ | while testing this test, when controls comes here - https://review.opendev.org/c/openstack/nova/+/791135/7/nova/compute/manager.py#9045 | |
| 08:57:35 | auniyal__ | context ctxt is set to None, | |
| 08:58:51 | auniyal__ | we need this to be nova.context.RequestContext, so we can get node_name | |
| 08:59:29 | auniyal__ | what changes I should make in unit test so context get set | |
| 09:00:07 | auniyal__ | this unit test is failing right now with this error - *** AttributeError: 'NoneType' object has no attribute '_enginefacade_context' | |
| 10:13:07 | opendevreview | Amit Uniyal proposed openstack/nova master: [compute] always set instnace.host in post_livemigration https://review.opendev.org/c/openstack/nova/+/791135 | |
| 10:51:06 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: compute: enhance compute evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858383 | |
| 10:51:06 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: api: extend evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858384 | |
| 11:19:01 | sean-k-mooney | bauzas: im just double checking the shas now but im going to approve the final release patch for nova/placment ectra if you have no objections | |
| 11:19:16 | sean-k-mooney | to my knoladage we do not have any issues that would require another RC correct | |
| 11:20:17 | sean-k-mooney | https://etherpad.opendev.org/p/nova-zed-rc-potential looks clean to me | |
| 11:22:23 | sean-k-mooney | oh just noticed you did it this morning i was going to ping you about it yesterday but it was too late when i tought of it | |
| 11:35:15 | gibi | auniyal__: you are passing None as ctx from the unit test right now https://review.opendev.org/c/openstack/nova/+/791135/7/nova/tests/unit/compute/test_compute_mgr.py#10223 so if you need a real context then pass one in. if you look at the tests around your test case you will see that there is self.context available to pass | |
| 11:38:35 | auniyal__ | ack gibi | |
| 11:39:27 | auniyal__ | I missed this, so I moved the retriving node_name, before calling this function and it passed | |
| 11:40:42 | auniyal__ | also regarding error, while retriving node name I changed the exception. I have added a comment in new change | |
| 12:55:52 | opendevreview | Amit Uniyal proposed openstack/nova master: [compute] always set instnace.host in post_livemigration https://review.opendev.org/c/openstack/nova/+/791135 | |
| 14:15:35 | auniyal__ | Hi sean-k-mooney | |
| 14:15:44 | auniyal__ | regarding adding functional test for VM snapshot | |
| 14:15:51 | auniyal__ | in continuation of older discussion | |
| 14:16:04 | auniyal__ | <sean-k-mooney> which makes me thing that the libvirt fixture is not currently in use | |
| 14:16:04 | auniyal__ | ||
| 14:16:04 | auniyal__ | <sean-k-mooney> the libvirt fixture shoudl be mockign this out | |
| 14:16:18 | auniyal__ | I was not sure, how to proceed further, so added fake_get_absolute_limit in fixtures.cinder | |
| 14:16:28 | auniyal__ | and then it failed at https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L3239 | |
| 14:16:28 | auniyal__ | here - https://github.com/openstack/nova/blob/master/nova/tests/fixtures/cinder.py | |
| 14:16:28 | auniyal__ | this - https://paste.opendev.org/show/bEV0xVXGyuWohgRHE9Vm/ | |
| 14:16:40 | auniyal__ | as the properties are not set with VOLUME which is used via fixture - | |
| 14:16:41 | auniyal__ | now this went further, but then again it failed at - https://github.com/openstack/nova/blob/master/nova/compute/api.py#L3511 | |
| 14:16:41 | auniyal__ | this - https://paste.opendev.org/show/bJgH2kLDa65iRCz9HuIt/ | |
| 14:16:41 | auniyal__ | So I added one more constant IMAGE_BACKED_VOL_QUIESCE | |
| 14:16:41 | auniyal__ | https://github.com/openstack/nova/blob/aad31e6ba489f720f5bdc765c132fd0f059a0329/nova/tests/fixtures/cinder.py#L154 | |
| 14:16:45 | auniyal__ | with same error which I was getting earlier | |
| 14:16:57 | auniyal__ | ===> keystoneauth1.exceptions.catalog.EmptyCatalog: The service catalog is empty. | |
| 14:36:18 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: api: extend evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858384 | |
| 14:36:18 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: compute: enhance compute evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858383 | |
| 14:55:37 | artom | sahid, ohhai, long time no see | |
| 15:06:58 | bauzas | reminder: nova meeting in 54 mins | |
| 15:51:23 | bauzas | last reminder : nova meeting in 9 mins (and I have to update the agenda, oh man) | |
| 16:00:15 | opendevmeet | The meeting name has been set to 'nova' | |
| 16:00:15 | bauzas | #startmeeting nova | |
| 16:00:15 | opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | |
| 16:00:15 | opendevmeet | Meeting started Tue Oct 4 16:00:15 2022 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | |
| 16:00:21 | bauzas | hey stackers | |
| 16:00:29 | gibi | o/ | |
| 16:00:33 | bauzas | #link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | |
| 16:01:04 | elodilles | o/ | |
| 16:02:05 | bauzas | okay, let's start, hopefully people will join later | |
| 16:02:28 | bauzas | #topic Bugs (stuck/critical) | |