| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-09-22 | |||
| 17:49:36 | melwitt | that's part of why it confuses me bc it's attached to the volume but then the xml points at the delta | |
| 17:54:01 | sean-k-mooney | yep so that is why we probly need to change the forma on the volume | |
| 17:54:19 | sean-k-mooney | and keep the format of the snapshot at the current romat of the disk | |
| 17:54:41 | sean-k-mooney | a second snapshot will result in the qcow the vm is now using being the snapshot disk | |
| 17:54:52 | sean-k-mooney | so the second snabp shot format will be qcow | |
| 17:54:58 | sean-k-mooney | but that ok | |
| 17:55:10 | sean-k-mooney | the rule is | |
| 17:55:19 | sean-k-mooney | the format of the snapshot is the current volume format | |
| 17:55:33 | sean-k-mooney | and the volmue format after snapstho is always qcow | |
| 17:57:19 | melwitt | sean-k-mooney: ok. so PS1 of my cinder patch was likely the right approach. and the volume extend failure is expected and should be skipped if nfs is being used, until that spec you linked earlier is implemented (?) | |
| 18:00:12 | sean-k-mooney | i belive so | |
| 18:00:33 | sean-k-mooney | the patch you linked me would also proably work as a workaround | |
| 18:00:51 | sean-k-mooney | but i dont belive it would be the right long term solution | |
| 18:00:59 | melwitt | gotcha | |
| 18:11:40 | sean-k-mooney | o/ | |
| 22:23:58 | opendevreview | Merged openstack/placement master: update bindep for ubuntu 22.04 https://review.opendev.org/c/openstack/placement/+/858927 | |
| 22:24:00 | opendevreview | Merged openstack/placement master: Switch to 2023.1 Python3 unit tests and generic template name https://review.opendev.org/c/openstack/placement/+/857901 | |
| 23:07:30 | opendevreview | melanie witt proposed openstack/nova stable/yoga: Unify placement client singleton implementations https://review.opendev.org/c/openstack/nova/+/858997 | |
| 23:07:31 | opendevreview | melanie witt proposed openstack/nova stable/yoga: Avoid n-cond startup abort for keystone failures https://review.opendev.org/c/openstack/nova/+/858998 | |
| 23:12:18 | opendevreview | melanie witt proposed openstack/nova stable/xena: Unify placement client singleton implementations https://review.opendev.org/c/openstack/nova/+/858999 | |
| 23:12:19 | opendevreview | melanie witt proposed openstack/nova stable/xena: Avoid n-cond startup abort for keystone failures https://review.opendev.org/c/openstack/nova/+/859000 | |
| 23:23:41 | opendevreview | melanie witt proposed openstack/nova stable/wallaby: Unify placement client singleton implementations https://review.opendev.org/c/openstack/nova/+/859001 | |
| 23:23:42 | opendevreview | melanie witt proposed openstack/nova stable/wallaby: Avoid n-cond startup abort for keystone failures https://review.opendev.org/c/openstack/nova/+/859002 | |
| #openstack-nova - 2022-09-23 | |||
| 02:46:44 | opendevreview | Brian Rosmaita proposed openstack/nova master: Correct reST markup in config help string https://review.opendev.org/c/openstack/nova/+/859010 | |
| 02:54:59 | opendevreview | Junbo Jiang proposed openstack/nova master: Test overcommit status when choose numa nodes https://review.opendev.org/c/openstack/nova/+/858495 | |
| 03:37:14 | opendevreview | Rajesh Tailor proposed openstack/nova master: Update Availability zone doc page https://review.opendev.org/c/openstack/nova/+/846463 | |
| 03:39:52 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix typos in nova docs https://review.opendev.org/c/openstack/nova/+/858673 | |
| 03:41:01 | opendevreview | Merged openstack/nova master: Update nova-manage doc page https://review.opendev.org/c/openstack/nova/+/856894 | |
| 10:31:02 | auniyal_ | Hi #openstack-nova | |
| 10:31:14 | auniyal_ | regarding error: service catalog is empty | |
| 10:31:26 | auniyal_ | It has 2 WAY's | |
| 10:31:26 | auniyal_ | I have this functional test - https://paste.opendev.org/show/bY6ZjvBzDO4QXbzrpQ70/ | |
| 10:31:26 | auniyal_ | https://opendev.org/openstack/nova/src/branch/master/nova/virt/libvirt/driver.py#L3238 | |
| 10:31:26 | auniyal_ | so while creating snapshot I can test _set_quiesced functionality. | |
| 10:31:26 | auniyal_ | I am writing a functional test, to create a snapshot of instance whose image has property "os_require_quiesce" and should boot-from-volume. | |
| 10:31:30 | auniyal_ | WAY 1: boot from volume as I want to write, but its failing and giving error: https://paste.opendev.org/show/bMRo6x3aDgKmgDbQbadr/ | |
| 10:31:33 | auniyal_ | WAY 2: use CINDER fixture to get volume, Error: https://paste.opendev.org/show/bj553NIDlVAw7sKkVZfF/ | |
| 10:32:51 | sean-k-mooney | you shoudl be using the cinder fixture yes | |
| 10:33:27 | sean-k-mooney | your not actully usin gthe cidner fixture in this test | |
| 10:33:31 | sean-k-mooney | https://paste.opendev.org/show/bY6ZjvBzDO4QXbzrpQ70/ | |
| 10:33:36 | sean-k-mooney | yoru using a uuid from it | |
| 10:33:53 | sean-k-mooney | but you have not actully used the cinder fixture to provide a fake sinder | |
| 10:33:58 | sean-k-mooney | *cinder | |
| 10:34:06 | auniyal_ | in WAY 2, line 52 | |
| 10:34:07 | sean-k-mooney | right now your test is trying to actully call keystone | |
| 10:34:15 | sean-k-mooney | thats not using the fixture | |
| 10:34:22 | sean-k-mooney | on line 52 | |
| 10:34:32 | sean-k-mooney | its just geting a constnat that is defiend in it | |
| 10:35:33 | auniyal_ | okay, but shouldn't it be treated as volume while instance creation, (fake volume) | |
| 10:36:30 | auniyal_ | or I should add some other property as well | |
| 10:36:56 | sean-k-mooney | add self.useFixture(nova_fixtures.CinderFixture(self)) to the setUp | |
| 10:37:12 | sean-k-mooney | on line 20 | |
| 10:37:36 | sean-k-mooney | and from nova.tests import fixtures as nova_fixtures | |
| 10:38:01 | sean-k-mooney | ah you have that on line 4 | |
| 10:38:32 | sean-k-mooney | to enable a fixture you actullly need to do self.useFixture | |
| 10:39:28 | sean-k-mooney | also why did you comment out base.ServersTestBase, and integrated_helpers.InstanceHelperMixin | |
| 10:40:09 | auniyal_ | actually, CinderFixture is already added in inherited class | |
| 10:40:13 | auniyal_ | in here - https://opendev.org/openstack/nova/src/commit/aad31e6ba489f720f5bdc765c132fd0f059a0329/nova/tests/functional/integrated_helpers.py#L1208 | |
| 10:41:14 | sean-k-mooney | right but your not ment to be inheriting form that | |
| 10:42:02 | auniyal_ | okay, so I should inherit base.ServersTestBase, and integrated_helpers.InstanceHelperMixin | |
| 10:42:08 | auniyal_ | and add CinderFixtute | |
| 10:42:52 | sean-k-mooney | yes as i said a few time in the past integrated_helpers._IntegratedTestBase does not use the fake libvirt implemeattion | |
| 10:43:03 | sean-k-mooney | the bug your working on only happens in the libvirt driver | |
| 10:43:08 | sean-k-mooney | so you cant use that | |
| 10:43:28 | sean-k-mooney | which is why i perviouly told you to use base.ServersTestBase, and integrated_helpers.InstanceHelperMixin | |
| 10:45:08 | auniyal_ | actually, I tried that as well, so thats why, only commented and not removed from test | |
| 10:46:17 | auniyal_ | it failes with - https://paste.opendev.org/show/bL7nGtDSyTzc11Utb0AA/ | |
| 11:02:12 | sean-k-mooney | yes that is a diffent issue | |
| 11:02:33 | sean-k-mooney | we need to mock out the calls to check for secure boot | |
| 11:03:09 | sean-k-mooney | that is at least using the libvirt driver which is good | |
| 11:08:10 | auniyal_ | secure boot, by adding 'os_secure_boot': 'required', in image properties | |
| 11:08:34 | sean-k-mooney | no | |
| 11:08:55 | sean-k-mooney | if you read the traceback you will see it failing in the driver code | |
| 11:09:24 | sean-k-mooney | specificaly its trying to parse supprot for secure boot | |
| 11:09:44 | sean-k-mooney | the fake libvirt fixture is likely not faking that properly | |
| 11:10:09 | sean-k-mooney | so either you need to moack out the supports_secure_boot function or update the data the fixture is provideing | |
| 11:11:38 | sean-k-mooney | the libvirt fixture shoudl be mockign this out | |
| 11:11:40 | sean-k-mooney | https://github.com/openstack/nova/blob/f8c91eb75fc5504a37fc3b4be1d65d33dbc9b511/nova/tests/fixtures/libvirt.py#L1993-L2045 | |
| 11:12:29 | sean-k-mooney | which makes me thing that the libvirt fixture is not currently in use | |
| 22:59:17 | clarkb | Does anyone here know why the Nodepool CI job that tests against openstack using devstack is suddenly tripping over the check at https://opendev.org/openstack/nova/src/branch/master/nova/network/neutron.py#L603-L613 when this code doesn't appear to have changed recently? | |
| 22:59:26 | clarkb | https://zuul.opendev.org/t/zuul/build/74fab5fdddee4c3d88e71e40ad6795a7/log/docker/nodepool_nodepool-launcher_1.txt#1345 is the nodepool side of things reporting the error | |
| 22:59:51 | clarkb | Since the code hasn't chagned as far as I can tell I'm thinking the policy may have? But I'm not seeing where the policy might be set | |
| 23:04:31 | clarkb | hrm 909b0b02470dc795fd3d2775ee33864b055dd678 changed the default check_str from project admin to admin | |
| 23:05:07 | clarkb | But I think we've been able to do this successfully more recently than when that change landed | |
| 23:10:06 | clarkb | Sorry here is where we log that error message https://zuul.opendev.org/t/zuul/build/74fab5fdddee4c3d88e71e40ad6795a7/log/syslog#40077 which then maps back to that nodepool error (which is far more terse as that is what the sdk gives us) | |
| 23:22:14 | clarkb | It seem that both the recent failures and the most recent successful devstack installs for these jobs installed the same version of nova: aad31e6ba4 Merge "Update nova-manage doc page" | |
| 23:31:06 | clarkb | gmann: you've been pushing the rbac stuff along do you know if anything changed for that in the last day ? | |
| 23:34:39 | gmann | clarkb: policy is changed to admin from project admin means any admin can access it, so it is made more broader access than restrictive. also we have the old policy supported so it should work as it is | |
| 23:35:16 | gmann | may be we need to check if any change in token accessing it? | |
| 23:36:08 | clarkb | gmann: I don't think anything changed in how we access it unless openstacksdk just made a release /me checks | |
| 23:36:24 | clarkb | no the sdk updated a month ago | |
| 23:36:59 | gmann | clarkb: here, non admin is trying to access it https://zuul.opendev.org/t/zuul/build/74fab5fdddee4c3d88e71e40ad6795a7/log/syslog#40066 | |
| 23:37:19 | gmann | 'is_admin': False, | |
| 23:37:36 | clarkb | gmann: yes, but that was working yesterday | |
| 23:38:05 | clarkb | is it possible to be a project admin but not an admin? | |
| 23:39:35 | gmann | no, project admin is nothing but admin with project_id matching | |
| 23:40:18 | gmann | admin is just role 'admin' match so any project _id so every project admin is admin | |
| 23:41:06 | gmann | I think 'is_admin':False is changed somewhere in sdk or so | |
| 23:41:07 | clarkb | got it | |
| 23:41:23 | gmann | it should be true | |