| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-09-09 | |||
| 11:27:54 | kashyap | Okay, I need to think a bit more about this; now /me really steps out :) | |
| 11:28:07 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/663614/1/nova/conf/libvirt.py | |
| 11:28:29 | sean-k-mooney | thats the comment that makes me thing we woudl be better allowing -1 to mean nova chooes the larges value that will work for the arch | |
| 11:28:56 | sean-k-mooney | so 32 on x86 and 24 on aarch64 | |
| 11:29:21 | sean-k-mooney | and delegate to libvirt for anythign we dont have a known good value for | |
| 11:29:27 | sean-k-mooney | same as 0 today | |
| 11:30:07 | sean-k-mooney | if we did something like that i can proably be sold on updating the value | |
| 12:01:30 | opendevreview | Christian Rohmann proposed openstack/nova master: db: Drop redundant unique constraint for instances uuid https://review.opendev.org/c/openstack/nova/+/856757 | |
| 12:02:59 | opendevreview | Christian Rohmann proposed openstack/nova master: db: Drop redundant unique constraint for instances uuid https://review.opendev.org/c/openstack/nova/+/856757 | |
| 12:43:49 | kashyap | sean-k-mooney: Yeah, arch-specific setting makes sense | |
| 12:47:04 | Uggla | question, I have this signature: def _hard_reboot(self, context, instance, network_info, block_device_info=None, accel_info=None, share_info=None): I would like share_info to be an ShareMappingList object either empty or with items (not None). Shoud I change to share_info=ShareMappingList(), an empty list by default. I noticed the file is also under mypy so I could define a type. What is your preference ? | |
| 12:49:24 | sean-k-mooney | Uggla: no never | |
| 12:49:33 | opendevreview | Christian Rohmann proposed openstack/nova master: db: Drop redundant indeces on instances and console_auth_tokens tables https://review.opendev.org/c/openstack/nova/+/856757 | |
| 12:49:55 | sean-k-mooney | Uggla: you shoudl never us a collection as the default for a keyward arg | |
| 12:50:34 | sean-k-mooney | Uggla: the way python works is that the vlaue of the keyword args are initalised once one the fucntion is first parsed and then rused across all function calls | |
| 12:50:54 | sean-k-mooney | so fi you default to a list or object that object will be shared across all fucntion calls | |
| 12:51:23 | sean-k-mooney | so kwargs shoudl only be litral values like Ture 42 None | |
| 12:51:30 | opendevreview | Christian Rohmann proposed openstack/nova master: db: Drop redundant indexes on instances and console_auth_tokens tables https://review.opendev.org/c/openstack/nova/+/856757 | |
| 12:51:32 | sean-k-mooney | "a sting litral" | |
| 12:51:49 | sean-k-mooney | so share_info=ShareMappingList() is not correct to use | |
| 12:52:51 | Uggla | ok, but what is the good way to be sure share_info will have the proper type and safely call its methods ? | |
| 12:53:08 | sean-k-mooney | we can add the type annotations | |
| 12:53:23 | sean-k-mooney | but its if you want ti to be a requried arge then it should not be a kwarg | |
| 12:53:30 | sean-k-mooney | if its optional you should do | |
| 12:53:48 | sean-k-mooney | if share_info is None: | |
| 12:53:53 | sean-k-mooney | share_info=ShareMappingList() | |
| 12:54:08 | sean-k-mooney | in the hard reboot funtion if you need too | |
| 12:55:05 | sean-k-mooney | in most cases we woudl expect this to be None as most vms wont have shares | |
| 12:56:31 | Uggla | ok thx sean-k-mooney. | |
| 14:02:05 | opendevreview | Christian Rohmann proposed openstack/nova master: db: Drop redundant indeces on instances and console_auth_tokens tables https://review.opendev.org/c/openstack/nova/+/856757 | |
| 14:25:56 | opendevreview | Christian Rohmann proposed openstack/placement master: Db: Drop redundant indexes for columns already having unique constraint https://review.opendev.org/c/openstack/placement/+/856770 | |
| 14:59:03 | opendevreview | Christian Rohmann proposed openstack/nova master: db: Drop redundant indeces on instances and console_auth_tokens tables https://review.opendev.org/c/openstack/nova/+/856757 | |
| 15:03:53 | opendevreview | OpenStack Release Bot proposed openstack/os-vif stable/zed: Update .gitreview for stable/zed https://review.opendev.org/c/openstack/os-vif/+/856780 | |
| 15:03:54 | opendevreview | OpenStack Release Bot proposed openstack/os-vif stable/zed: Update TOX_CONSTRAINTS_FILE for stable/zed https://review.opendev.org/c/openstack/os-vif/+/856781 | |
| 15:03:56 | opendevreview | OpenStack Release Bot proposed openstack/os-vif master: Update master for stable/zed https://review.opendev.org/c/openstack/os-vif/+/856782 | |
| 15:03:57 | opendevreview | OpenStack Release Bot proposed openstack/os-vif master: Add Python3 antelope unit tests https://review.opendev.org/c/openstack/os-vif/+/856783 | |
| 15:04:03 | opendevreview | OpenStack Release Bot proposed openstack/osc-placement stable/zed: Update .gitreview for stable/zed https://review.opendev.org/c/openstack/osc-placement/+/856784 | |
| 15:04:04 | opendevreview | OpenStack Release Bot proposed openstack/osc-placement stable/zed: Update TOX_CONSTRAINTS_FILE for stable/zed https://review.opendev.org/c/openstack/osc-placement/+/856785 | |
| 15:04:06 | opendevreview | OpenStack Release Bot proposed openstack/osc-placement master: Update master for stable/zed https://review.opendev.org/c/openstack/osc-placement/+/856786 | |
| 15:04:07 | opendevreview | OpenStack Release Bot proposed openstack/osc-placement master: Add Python3 antelope unit tests https://review.opendev.org/c/openstack/osc-placement/+/856787 | |
| 15:04:18 | opendevreview | OpenStack Release Bot proposed openstack/python-novaclient stable/zed: Update .gitreview for stable/zed https://review.opendev.org/c/openstack/python-novaclient/+/856788 | |
| 15:04:20 | opendevreview | OpenStack Release Bot proposed openstack/python-novaclient stable/zed: Update TOX_CONSTRAINTS_FILE for stable/zed https://review.opendev.org/c/openstack/python-novaclient/+/856789 | |
| 15:04:21 | opendevreview | OpenStack Release Bot proposed openstack/python-novaclient master: Update master for stable/zed https://review.opendev.org/c/openstack/python-novaclient/+/856790 | |
| 15:04:22 | opendevreview | OpenStack Release Bot proposed openstack/python-novaclient master: Add Python3 antelope unit tests https://review.opendev.org/c/openstack/python-novaclient/+/856791 | |
| 22:48:32 | opendevreview | Christian Rohmann proposed openstack/nova master: db: Drop redundant indeces on instances and console_auth_tokens tables https://review.opendev.org/c/openstack/nova/+/856757 | |
| 22:56:55 | opendevreview | Christian Rohmann proposed openstack/placement master: Db: Drop redundant indexes for columns already having unique constraint https://review.opendev.org/c/openstack/placement/+/856770 | |
| #openstack-nova - 2022-09-10 | |||
| 09:48:19 | opendevreview | Rajesh Tailor proposed openstack/nova master: Update nova-manage doc page https://review.opendev.org/c/openstack/nova/+/856894 | |
| 09:49:10 | opendevreview | Rajesh Tailor proposed openstack/nova master: Update Availability zone doc page https://review.opendev.org/c/openstack/nova/+/846463 | |
| 10:53:37 | opendevreview | Takashi Natsume proposed openstack/nova master: Update min supported service version for 2023.1 https://review.opendev.org/c/openstack/nova/+/856895 | |
| 18:25:02 | opendevreview | Merged openstack/nova master: Gracefully ERROR in _init_instance if vnic_type changed https://review.opendev.org/c/openstack/nova/+/850003 | |
| #openstack-nova - 2022-09-12 | |||
| 07:11:06 | opendevreview | Christian Rohmann proposed openstack/nova master: db: Drop redundant indeces on instances and console_auth_tokens tables https://review.opendev.org/c/openstack/nova/+/856757 | |
| 07:46:14 | Uggla | Good morning Nova. | |
| 07:51:51 | bauzas | good morning | |
| 07:52:00 | gibi | o/ | |
| 07:52:20 | gibi | Uggla: do you still have a question on my comment on the manila series ? | |
| 07:53:11 | Uggla | hi gibi , no that's ok for the moment. :) | |
| 07:53:30 | gibi | Uggla: cool. Sorry for not responding last week I was deep in some k8s discussions | |
| 07:54:03 | Uggla | gibi, no worries that's fine. | |
| 08:43:05 | sahid | o/ I have specific use-case regarding nova host-evacuate, we would like evacuate host to run but that, all instances scheduled to be forced as shutdown | |
| 08:43:18 | sahid | is there a way to have this happening? | |
| 08:48:13 | sean-k-mooney | no | |
| 08:48:38 | sean-k-mooney | evacuate at the api level result in the vm being evacuated to the same state its in in the db currently | |
| 08:48:46 | sean-k-mooney | so you would need an api change for that. | |
| 08:49:06 | sean-k-mooney | novaclient's shell is deprecated so we are not adding or alterign any commands | |
| 08:49:22 | sean-k-mooney | and nova host-evacuate is intentionally not supported in osc | |
| 08:49:36 | sean-k-mooney | so at this point we should not alter/extend its behavior | |
| 08:50:03 | gibi | I'm wondering what happens if you try to first stop the VM then evacuate it | |
| 08:53:27 | sahid | gibi if the host is down, nothing is happening | |
| 08:53:51 | sahid | the other idea was to extend resetState | |
| 08:54:43 | gibi | I feel like this might be a new microversion to the evacuate action, adding a flag to instruct nova to evacuate but not start the VM on the dest | |
| 08:56:22 | sahid | it's what I was thinking as-well but for host-evacuate it seems that you don't want we make any changes | |
| 08:56:56 | gibi | host-evacuate is a client side concept. You can replace that with a shell script calling the openstack client | |
| 08:57:37 | sahid | side question, why host-evacuate is not supported in openstack client? | |
| 08:57:48 | gibi | what you cannot do is to make a active VM evacuated as stopped via the nova REST API today, hence my microversion thinking | |
| 08:57:51 | sean-k-mooney | sahid: because of what gibi said | |
| 08:58:02 | sean-k-mooney | you its a client side implemation and we did not want to support it any more | |
| 08:58:08 | sean-k-mooney | the error handeling is terrible | |
| 08:58:12 | gibi | sahid: because it is considered orcestration | |
| 08:58:20 | sean-k-mooney | well that too | |
| 08:58:22 | sahid | yes that makes sense, i understand now | |
| 08:58:38 | sean-k-mooney | but more because if one of the evacuation fails its kind of undefiend what the end result of the commnd is | |
| 08:59:01 | sahid | so back to the original use-case, does that would make sense to have evacuate with a flag to force the state? | |
| 08:59:12 | sean-k-mooney | it wont be one of (all evacuated or all still on orginal host) it will be a mix | |
| 08:59:29 | sean-k-mooney | sahid: i would say target state | |
| 08:59:33 | sean-k-mooney | rahter then force | |
| 08:59:46 | sean-k-mooney | that has been requested before at the last inperson ptg i think | |
| 09:00:02 | sean-k-mooney | i would not be apposed to a eveacuate to stopped option | |
| 09:00:12 | sean-k-mooney | im not sure that shelved makes sense | |
| 09:00:21 | sean-k-mooney | but started/stopped i can see | |
| 09:00:26 | gibi | I think target_state enum (AsBefore,Stopped) | |
| 09:00:28 | gibi | make sense | |
| 09:00:44 | gibi | AsBefore=NoChange | |
| 09:01:16 | gibi | can we evacuate a shelved instance? | |
| 09:01:26 | sean-k-mooney | on reset-sate while i would like to expand what it can do so that you can specify somehting other then aviable/error im not sure this is the right way to do this | |
| 09:01:31 | sean-k-mooney | gibi: no | |
| 09:01:38 | sean-k-mooney | gibi: because its not on a host | |
| 09:01:43 | gibi | OK, cool then :D | |
| 09:01:48 | gibi | I started worrying :) | |
| 09:02:01 | sean-k-mooney | im ment it would not make sense to evacuate to shelve_offloaded | |
| 09:02:21 | sean-k-mooney | we could allow shelve_offloading when its down instead | |