| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-08-31 | |||
| 20:18:00 | opendevreview | Rico Lin proposed openstack/nova master: Add traits for viommu model https://review.opendev.org/c/openstack/nova/+/844507 | |
| 20:18:00 | opendevreview | Rico Lin proposed openstack/nova master: libvirt: Add vIOMMU device to guest https://review.opendev.org/c/openstack/nova/+/830646 | |
| 20:18:34 | ricolin | sean-k-mooney: can you check if I do make it right this time, thanks ^^^ | |
| 20:50:40 | opendevreview | Rico Lin proposed openstack/nova master: libvirt: Add vIOMMU device to guest https://review.opendev.org/c/openstack/nova/+/830646 | |
| 20:50:41 | opendevreview | Rico Lin proposed openstack/nova master: Add traits for viommu model https://review.opendev.org/c/openstack/nova/+/844507 | |
| 23:27:37 | opendevreview | Merged openstack/nova master: Add documentation and releasenotes for RBAC change https://review.opendev.org/c/openstack/nova/+/854882 | |
| #openstack-nova - 2022-09-01 | |||
| 05:10:33 | whoami-rajat | sean-k-mooney, it is already being tested in tempest-full but the problem is the image is same before/after rebuild so it's not testing the actual feature i.e. to reimage to a new image hence the new job, not sure if there is a better way to do it | |
| 07:44:40 | opendevreview | Merged openstack/nova master: Add support for volume backed server rebuild https://review.opendev.org/c/openstack/nova/+/820368 | |
| 07:47:15 | gibi | good morning | |
| 07:51:31 | opendevreview | Merged openstack/nova master: Add conductor RPC interface for rebuild https://review.opendev.org/c/openstack/nova/+/831219 | |
| 07:53:15 | opendevreview | Merged openstack/nova master: Add API support for rebuilding BFV instances https://review.opendev.org/c/openstack/nova/+/830883 | |
| 07:58:53 | bauzas | good morning | |
| 08:16:52 | Uggla | gibi, bauzas good morning | |
| 08:17:18 | bauzas | Uggla: how was this morning ? :) | |
| 08:17:28 | bauzas | was Rose happy to see her friends ? | |
| 08:18:48 | Uggla | Yes, she's ok and happy because she has the teacher she wanted. | |
| 08:19:05 | gibi | :) | |
| 08:21:11 | Uggla | One little girl in her group was crying, and Rose gave her hand to go to the classroom. | |
| 08:21:47 | gibi | so nice | |
| 08:24:48 | bauzas | nice and bravo Rose | |
| 08:25:22 | bauzas | my oldest is still on vacations, she'll start tomorrow | |
| 08:25:37 | Uggla | in short no pb so far. I'll see this afternoon. | |
| 08:26:12 | bauzas | if you see me disappearing quickly, that's because I forgot about the time :p | |
| 08:32:06 | Uggla | 1st day on a Friday ? This is a warmup day for teachers ? :) | |
| 08:33:02 | bauzas | Uggla: no, for the "6e" chidren (10-11yo) they started today | |
| 08:33:20 | bauzas | for the older (12-14yo), they start tomorrow | |
| 08:33:55 | Uggla | yep strange to start on a Friday. (for your older one) | |
| 08:35:10 | bauzas | for the "6eme" folks, they only work today and not tomorrow | |
| 08:36:20 | bauzas | ("6eme" is first year of middle school) | |
| 08:46:43 | Uggla | ok so only 1 day the first week. Soft start. | |
| 09:19:26 | sean-k-mooney | its pretty common here | |
| 09:19:53 | sean-k-mooney | they give the students who are new to the school 1 day before the rest come back | |
| 09:20:06 | sean-k-mooney | so they can be shown around without all the other people | |
| 09:20:52 | sean-k-mooney | so normally they start on a wednesday here youngets class group, then first half then rest | |
| 09:21:13 | opendevreview | Konrad Gube proposed openstack/nova-specs master: Add API for assisted volume extend https://review.opendev.org/c/openstack/nova-specs/+/855490 | |
| 09:21:24 | sean-k-mooney | melwitt: ^ | |
| 09:36:16 | sean-k-mooney | whoami-rajat: tempest has an alternitive image so we can have two test one that reimages to the same image and one the reimages to the alt image https://github.com/openstack/tempest/blob/master/tempest/config.py#L294-L297 | |
| 09:36:31 | sean-k-mooney | whoami-rajat: so you would boot with image_ref and rebuild to image_ref_alt | |
| 09:37:13 | sean-k-mooney | whoami-rajat: we really only care that the images are idfferent in glance they can both be cirros and its fine | |
| 09:38:03 | sean-k-mooney | with the old microversion you can jsut the requried alt image to assert its not allowed | |
| 09:38:03 | sean-k-mooney | the mecanics are the same if its the same image or differnt with the new microverion | |
| 09:38:09 | sean-k-mooney | and the same image to assert it preserved data | |
| 09:56:19 | whoami-rajat | sean-k-mooney, those parameters point to the same image in default tempest job, like see this tempest.conf from tempest-full run, both image_ref and image_ref_alt points to same image https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_83f/831018/24/check/tempest-full-py3/83f6b4a/controller/logs/tempest_conf.txt | |
| 09:56:37 | whoami-rajat | sean-k-mooney, I'm configuring different images for those parameters in my job, see tempest.conf for my new job https://a59fb54e72bca9b30065-6505ce46ad1aa88851df8d527471f9dc.ssl.cf1.rackcdn.com/831018/24/check/tempest-rebuild-volume-backed/c4755d7/controller/logs/tempest_conf.txt | |
| 09:57:13 | whoami-rajat | IMAGE_URLS parameter in devstack enables setting different images for those parameters | |
| 09:57:27 | whoami-rajat | by default only one image is created and set as both image_ref and image_ref_alt | |
| 09:58:31 | whoami-rajat | that's why i configured a new job with this parameter, wasn't sure if modifying existing jobs for my test run is a valid thing so created a new job | |
| 10:00:55 | gibi | stephenfin: hi! how do you feel, will you have time to review the PCI series up until https://review.opendev.org/c/openstack/nova/+/850468/20 before the FF deadline? | |
| 10:09:07 | sean-k-mooney | whoami-rajat: yes but it would be better to configure devstack to upload the cirrios image twich with differnt names and then use that | |
| 10:09:38 | sean-k-mooney | so i think yes modifying the exisitng josb is totally valid | |
| 10:10:06 | sean-k-mooney | and would get more coverage of the feature. that can be done in the futrue | |
| 10:10:20 | sean-k-mooney | whoami-rajat: also congrats its merged in nova this morning | |
| 10:10:26 | whoami-rajat | hmm, ack, will try that | |
| 10:10:29 | sean-k-mooney | whoami-rajat: sorry it took so long | |
| 10:10:54 | whoami-rajat | sean-k-mooney, thanks and thank you to all the nova team bauzas gibi dansmith for helping with that! | |
| 10:11:02 | whoami-rajat | no problem :) | |
| 10:11:14 | sean-k-mooney | did you see my comments on teh osc patch | |
| 10:11:22 | whoami-rajat | nope, looking | |
| 10:11:38 | sean-k-mooney | ack you duplicated a test but forgot to rename it in the copy paste | |
| 10:11:48 | sean-k-mooney | trivial fix | |
| 10:11:55 | gibi | whoami-rajat: you are welcome | |
| 10:12:06 | whoami-rajat | sean-k-mooney, oh i addressed that yesterday only, i thought there was a new comment | |
| 10:12:23 | sean-k-mooney | ack, no i have not reviewd since you updated it | |
| 10:12:26 | sean-k-mooney | ill go do that now | |
| 10:12:39 | whoami-rajat | thanks | |
| 10:12:58 | whoami-rajat | https://review.opendev.org/c/openstack/python-openstackclient/+/831014 -- for quick reference | |
| 10:13:42 | sean-k-mooney | alredy reviewed | |
| 10:14:02 | sean-k-mooney | it looks good to me stephenfin ^ your an osc core care to take a look | |
| 10:17:58 | opendevreview | Amit Uniyal proposed openstack/nova master: Adds a repoducer for post live migration fail https://review.opendev.org/c/openstack/nova/+/854499 | |
| 10:17:59 | opendevreview | Amit Uniyal proposed openstack/nova master: [compute] always set instnace.host in post_livemigration https://review.opendev.org/c/openstack/nova/+/791135 | |
| 11:14:55 | sean-k-mooney | ricolin: can you update https://review.opendev.org/c/openstack/nova/+/844507/18/nova/virt/libvirt/driver.py#12202 | |
| 11:15:10 | sean-k-mooney | if you can make that change im +2 on both patches | |
| 11:15:14 | sean-k-mooney | bauzas: ^ | |
| 11:15:45 | sean-k-mooney | ill see if i can quickly test your changes in devstack too | |
| 11:15:56 | sean-k-mooney | to confirm this work as intended | |
| 12:46:21 | bauzas | sean-k-mooney: I can review the traits change once ricolin updates it | |
| 12:46:45 | ricolin | Thanks sean-k-mooney: bauzas will do it ASAP | |
| 12:46:51 | bauzas | cool | |
| 12:46:52 | sean-k-mooney | in its current form its not wrong its just over complciated | |
| 12:47:09 | sean-k-mooney | ricolin: i think if you adress that everything else looks ok | |
| 12:47:14 | sean-k-mooney | and it can land before FF | |
| 12:47:37 | ricolin | sean-k-mooney: sounds great | |
| 12:47:39 | sean-k-mooney | i have not had a change to test it locally yet but i expect it to work | |
| 12:47:48 | opendevreview | Amit Uniyal proposed openstack/nova master: [compute] always set instnace.host in post_livemigration https://review.opendev.org/c/openstack/nova/+/791135 | |
| 12:47:48 | opendevreview | Amit Uniyal proposed openstack/nova master: Adds a repoducer for post live migration fail https://review.opendev.org/c/openstack/nova/+/854499 | |
| 12:48:03 | sean-k-mooney | ricolin: i assume you ahve booted a vm with this code and validated the iommu is present | |
| 12:55:49 | opendevreview | Rico Lin proposed openstack/nova master: Add traits for viommu model https://review.opendev.org/c/openstack/nova/+/844507 | |
| 12:56:32 | ricolin | sean-k-mooney: done | |
| 12:58:00 | ricolin | and yes, I'm sure IOMMU is there. Just not sure I test Traits in the right way | |
| 13:01:56 | bauzas | ricolin: sean-k-mooney: reviewing | |
| 13:02:06 | ricolin | thanks bauzas | |
| 13:23:51 | sean-k-mooney | bauzas: gibi if ye want to proceed with ^ im more or less happy with it. the release note shoudl be in the seond patch | |
| 13:24:12 | sean-k-mooney | but as long as we land both of them its not an issue | |
| 13:24:26 | bauzas | sean-k-mooney: I just said +1 for an upgrade question | |
| 13:24:36 | sean-k-mooney | i replied | |
| 13:24:43 | sean-k-mooney | thats intentional | |
| 13:25:26 | sean-k-mooney | altough dansmith might point out we could have also added a min compute service check for this instead of using the traits | |
| 13:26:11 | sean-k-mooney | we normally did not dod that in the past however | |
| 13:26:21 | sean-k-mooney | so i think this is all good to go | |
| 13:26:31 | gibi | the trait based capability scheduling looks OK to me | |